From unknown Mon Aug 18 02:37:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17271: 24.4.50; mouse-yank-primary can insert read-only attributes Resent-From: Jorgen Schaefer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Apr 2014 18:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17271 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 17271@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.139758686831144 (code B ref -1); Tue, 15 Apr 2014 18:35:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Apr 2014 18:34:28 +0000 Received: from localhost ([127.0.0.1]:49127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wa8Bf-00086G-NM for submit@debbugs.gnu.org; Tue, 15 Apr 2014 14:34:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44180) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wa8Bc-00085s-To for submit@debbugs.gnu.org; Tue, 15 Apr 2014 14:34:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wa8BO-0007eD-Ah for submit@debbugs.gnu.org; Tue, 15 Apr 2014 14:34:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58035) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wa8BO-0007e8-7o for submit@debbugs.gnu.org; Tue, 15 Apr 2014 14:34:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wa8BI-0008DY-1i for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2014 14:34:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wa8BB-0007bM-Tg for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2014 14:34:03 -0400 Received: from loki.jorgenschaefer.de ([87.230.15.51]:38146) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wa8BB-0007b4-NI for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2014 14:33:57 -0400 Received: by loki.jorgenschaefer.de (Postfix, from userid 1000) id 4D0832020E0; Tue, 15 Apr 2014 20:33:25 +0200 (CEST) From: Jorgen Schaefer Date: Tue, 15 Apr 2014 20:33:25 +0200 Message-ID: <87wqeql9xm.fsf@loki.jorgenschaefer.de> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi! We have witnessed some strange behavior when users of the IRC client Circe copied text from a channel buffer elsewhere. The copied text remained read-only, as the channel buffer is, but only when copied using the mouse, not when copied using the keyboard. Reproduction: (setq select-active-regions t) (insert (propertize "foo" 'read-only t)) Then select the "foo" and immediately yank it somewhere using the middle mouse button. The inserted text retains the read-only property. It probably would be a good idea for `mouse-yank-primary' to use `insert-for-yank' instead of `insert'. From unknown Mon Aug 18 02:37:33 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jorgen Schaefer Subject: bug#17271: closed (Re: bug#17271: 24.4.50; mouse-yank-primary can insert read-only attributes) Message-ID: References: <87wqeql9xm.fsf@loki.jorgenschaefer.de> X-Gnu-PR-Message: they-closed 17271 X-Gnu-PR-Package: emacs Reply-To: 17271@debbugs.gnu.org Date: Wed, 02 Jul 2014 14:45:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1404312304-17685-1" This is a multi-part message in MIME format... ------------=_1404312304-17685-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #17271: 24.4.50; mouse-yank-primary can insert read-only attributes which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 17271@debbugs.gnu.org. --=20 17271: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D17271 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1404312304-17685-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 17271-done) by debbugs.gnu.org; 2 Jul 2014 14:44:04 +0000 Received: from localhost ([127.0.0.1]:40556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X2LlP-0004YW-9T for submit@debbugs.gnu.org; Wed, 02 Jul 2014 10:44:04 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:36237) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X2LlI-0004Y4-Ot for 17271-done@debbugs.gnu.org; Wed, 02 Jul 2014 10:43:57 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCw4mEhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IPAS-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCw4mEhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="75729377" Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 02 Jul 2014 10:43:46 -0400 Received: by pastel.home (Postfix, from userid 20848) id 769B762F8B; Wed, 2 Jul 2014 10:43:46 -0400 (EDT) From: Stefan Monnier To: Jorgen Schaefer Subject: Re: bug#17271: 24.4.50; mouse-yank-primary can insert read-only attributes Message-ID: References: <87wqeql9xm.fsf@loki.jorgenschaefer.de> Date: Wed, 02 Jul 2014 10:43:46 -0400 In-Reply-To: <87wqeql9xm.fsf@loki.jorgenschaefer.de> (Jorgen Schaefer's message of "Tue, 15 Apr 2014 20:33:25 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 17271-done Cc: 17271-done@debbugs.gnu.org, xani666@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Version:24.4 > Then select the "foo" and immediately yank it somewhere using the middle > mouse button. The inserted text retains the read-only property. > > It probably would be a good idea for `mouse-yank-primary' to use > `insert-for-yank' instead of `insert'. Indeed, thanks. I installed the patch below into the `emacs-24' branch. Stefan === modified file 'lisp/mouse.el' --- lisp/mouse.el 2014-06-20 18:35:04 +0000 +++ lisp/mouse.el 2014-07-02 14:37:36 +0000 @@ -1101,7 +1101,7 @@ (unless primary (error "No selection is available")) (push-mark (point)) - (insert primary))) + (insert-for-yank primary))) (defun mouse-kill-ring-save (click) "Copy the region between point and the mouse click in the kill ring. @@ -1383,7 +1383,7 @@ (or mouse-yank-at-point (mouse-set-point click)) (let ((secondary (x-get-selection 'SECONDARY))) (if secondary - (insert secondary) + (insert-for-yank secondary) (error "No secondary selection")))) (defun mouse-kill-secondary () ------------=_1404312304-17685-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Apr 2014 18:34:28 +0000 Received: from localhost ([127.0.0.1]:49127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wa8Bf-00086G-NM for submit@debbugs.gnu.org; Tue, 15 Apr 2014 14:34:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44180) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wa8Bc-00085s-To for submit@debbugs.gnu.org; Tue, 15 Apr 2014 14:34:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wa8BO-0007eD-Ah for submit@debbugs.gnu.org; Tue, 15 Apr 2014 14:34:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58035) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wa8BO-0007e8-7o for submit@debbugs.gnu.org; Tue, 15 Apr 2014 14:34:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wa8BI-0008DY-1i for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2014 14:34:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wa8BB-0007bM-Tg for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2014 14:34:03 -0400 Received: from loki.jorgenschaefer.de ([87.230.15.51]:38146) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wa8BB-0007b4-NI for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2014 14:33:57 -0400 Received: by loki.jorgenschaefer.de (Postfix, from userid 1000) id 4D0832020E0; Tue, 15 Apr 2014 20:33:25 +0200 (CEST) From: Jorgen Schaefer To: bug-gnu-emacs@gnu.org Subject: 24.4.50; mouse-yank-primary can insert read-only attributes Date: Tue, 15 Apr 2014 20:33:25 +0200 Message-ID: <87wqeql9xm.fsf@loki.jorgenschaefer.de> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi! We have witnessed some strange behavior when users of the IRC client Circe copied text from a channel buffer elsewhere. The copied text remained read-only, as the channel buffer is, but only when copied using the mouse, not when copied using the keyboard. Reproduction: (setq select-active-regions t) (insert (propertize "foo" 'read-only t)) Then select the "foo" and immediately yank it somewhere using the middle mouse button. The inserted text retains the read-only property. It probably would be a good idea for `mouse-yank-primary' to use `insert-for-yank' instead of `insert'. ------------=_1404312304-17685-1--