From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 15 14:34:28 2014 Received: (at submit) by debbugs.gnu.org; 15 Apr 2014 18:34:28 +0000 Received: from localhost ([127.0.0.1]:49127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wa8Bf-00086G-NM for submit@debbugs.gnu.org; Tue, 15 Apr 2014 14:34:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44180) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wa8Bc-00085s-To for submit@debbugs.gnu.org; Tue, 15 Apr 2014 14:34:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wa8BO-0007eD-Ah for submit@debbugs.gnu.org; Tue, 15 Apr 2014 14:34:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58035) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wa8BO-0007e8-7o for submit@debbugs.gnu.org; Tue, 15 Apr 2014 14:34:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wa8BI-0008DY-1i for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2014 14:34:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wa8BB-0007bM-Tg for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2014 14:34:03 -0400 Received: from loki.jorgenschaefer.de ([87.230.15.51]:38146) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wa8BB-0007b4-NI for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2014 14:33:57 -0400 Received: by loki.jorgenschaefer.de (Postfix, from userid 1000) id 4D0832020E0; Tue, 15 Apr 2014 20:33:25 +0200 (CEST) From: Jorgen Schaefer To: bug-gnu-emacs@gnu.org Subject: 24.4.50; mouse-yank-primary can insert read-only attributes Date: Tue, 15 Apr 2014 20:33:25 +0200 Message-ID: <87wqeql9xm.fsf@loki.jorgenschaefer.de> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi! We have witnessed some strange behavior when users of the IRC client Circe copied text from a channel buffer elsewhere. The copied text remained read-only, as the channel buffer is, but only when copied using the mouse, not when copied using the keyboard. Reproduction: (setq select-active-regions t) (insert (propertize "foo" 'read-only t)) Then select the "foo" and immediately yank it somewhere using the middle mouse button. The inserted text retains the read-only property. It probably would be a good idea for `mouse-yank-primary' to use `insert-for-yank' instead of `insert'. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 02 10:44:04 2014 Received: (at 17271-done) by debbugs.gnu.org; 2 Jul 2014 14:44:04 +0000 Received: from localhost ([127.0.0.1]:40556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X2LlP-0004YW-9T for submit@debbugs.gnu.org; Wed, 02 Jul 2014 10:44:04 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:36237) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X2LlI-0004Y4-Ot for 17271-done@debbugs.gnu.org; Wed, 02 Jul 2014 10:43:57 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCw4mEhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IPAS-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCw4mEhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="75729377" Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 02 Jul 2014 10:43:46 -0400 Received: by pastel.home (Postfix, from userid 20848) id 769B762F8B; Wed, 2 Jul 2014 10:43:46 -0400 (EDT) From: Stefan Monnier To: Jorgen Schaefer Subject: Re: bug#17271: 24.4.50; mouse-yank-primary can insert read-only attributes Message-ID: References: <87wqeql9xm.fsf@loki.jorgenschaefer.de> Date: Wed, 02 Jul 2014 10:43:46 -0400 In-Reply-To: <87wqeql9xm.fsf@loki.jorgenschaefer.de> (Jorgen Schaefer's message of "Tue, 15 Apr 2014 20:33:25 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 17271-done Cc: 17271-done@debbugs.gnu.org, xani666@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Version:24.4 > Then select the "foo" and immediately yank it somewhere using the middle > mouse button. The inserted text retains the read-only property. > > It probably would be a good idea for `mouse-yank-primary' to use > `insert-for-yank' instead of `insert'. Indeed, thanks. I installed the patch below into the `emacs-24' branch. Stefan === modified file 'lisp/mouse.el' --- lisp/mouse.el 2014-06-20 18:35:04 +0000 +++ lisp/mouse.el 2014-07-02 14:37:36 +0000 @@ -1101,7 +1101,7 @@ (unless primary (error "No selection is available")) (push-mark (point)) - (insert primary))) + (insert-for-yank primary))) (defun mouse-kill-ring-save (click) "Copy the region between point and the mouse click in the kill ring. @@ -1383,7 +1383,7 @@ (or mouse-yank-at-point (mouse-set-point click)) (let ((secondary (x-get-selection 'SECONDARY))) (if secondary - (insert secondary) + (insert-for-yank secondary) (error "No secondary selection")))) (defun mouse-kill-secondary () From unknown Sun Aug 17 00:57:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 31 Jul 2014 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator