GNU bug report logs - #17260
24.4.50; pulse.el: pulse-momentarily-highlight-one-line ignores point argument

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17260 in the body.
You can then email your comments to 17260 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Matt Curtis <matt.r.curtis <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4.50;
 pulse.el: pulse-momentarily-highlight-one-line ignores point argument
Date: Sun, 13 Apr 2014 15:44:08 +1000

[Message part 1 (text/plain, inline)]

The function "pulse-momentarily-highlight-one-line" (in pulse.el)
ignores the point argument and uses the current point instead.

To reproduce this issue, call the function with a location on
a line other than where the point currently is. The line with
point will be pulsed, not the line containing the supplied
location.

(pulse-momentary-highlight-one-line 259)


The following patch fixes the issue with (goto-char point)

-----

diff --git a/lisp/cedet/pulse.el b/lisp/cedet/pulse.el
index e2a48a4..10ede62 100644
--- a/lisp/cedet/pulse.el
+++ b/lisp/cedet/pulse.el
@@ -227,13 +227,15 @@ (defun pulse-momentary-unhighlight ()
 (defun pulse-momentary-highlight-one-line (point &optional face)
   "Highlight the line around POINT, unhighlighting before next command.
 Optional argument FACE specifies the face to do the highlighting."
-  (let ((start (point-at-bol))
-       (end (save-excursion
-              (end-of-line)
-              (when (not (eobp))
-                (forward-char 1))
-              (point))))
-    (pulse-momentary-highlight-region start end face)))
+  (save-excursion
+    (goto-char point)
+    (let ((start (point-at-bol))
+          (end (save-excursion
+                 (end-of-line)
+                 (when (not (eobp))
+                   (forward-char 1))
+                 (point))))
+      (pulse-momentary-highlight-region start end face))))

 (defun pulse-momentary-highlight-region (start end &optional face)
   "Highlight between START and END, unhighlighting before next command.

-----

In GNU Emacs 24.4.50.1 (x86_64-apple-darwin13.1.0, NS apple-appkit-1265.19)
 of 2014-04-13 on gonagall.local
Windowing system distributor `Apple', version 10.3.1265
Configured using:
 `configure --prefix=/usr/local/Cellar/emacs/HEAD --without-dbus
 --enable-locallisppath=/usr/local/share/emacs/site-lisp
 --infodir=/usr/local/Cellar/emacs/HEAD/share/info/emacs --with-gnutls
 --with-ns --disable-ns-self-contained'

Configured features:
ACL GNUTLS LIBXML2 ZLIB

Important settings:
  value of $LC_CTYPE: en_US.UTF-8
  locale-coding-system: utf-8-unix

[Message part 2 (text/html, inline)]

Message #8 received at 17260 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Matt Curtis <matt.r.curtis <at> gmail.com>
Cc: 17260 <at> debbugs.gnu.org
Subject: Re: bug#17260: 24.4.50;
 pulse.el: pulse-momentarily-highlight-one-line ignores point argument
Date: Tue, 09 Dec 2014 00:57:45 +0100

Matt Curtis <matt.r.curtis <at> gmail.com> writes:

> The following patch fixes the issue with (goto-char point)

Thanks; applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.