GNU bug report logs - #17250
24.3; find-variable gives search-failed error message

Previous Next

Package: emacs;

Reported by: Johan Claesson <johanclaesson <at> bredband.net>

Date: Sat, 12 Apr 2014 12:39:02 UTC

Severity: minor

Tags: confirmed, fixed, patch

Found in version 24.3

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 17250 <at> debbugs.gnu.org, johanclaesson <at> bredband.net
Subject: bug#17250: 24.3; find-variable gives search-failed error message
Date: Wed, 18 Apr 2018 09:23:40 +0300
> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Wed, 18 Apr 2018 00:58:39 +0200
> Cc: 17250 <at> debbugs.gnu.org
> 
> But there are several places that use this function without checking the
> return value.  Are they relying on this function to bug out with a
> cryptic error, or are they all confident that the file name can be
> found?
> 
> So I haven't applied it yet.  Perhaps somebody else will weigh in...

I'm not weighing in ;-)

>  (defun help-C-file-name (subr-or-var kind)
>    "Return the name of the C file where SUBR-OR-VAR is defined.
> -KIND should be `var' for a variable or `subr' for a subroutine."
> +KIND should be `var' for a variable or `subr' for a subroutine.
> +If we can't find the file name, nil is returned."
                                   ^^^^^^^^^^^^^^^
"return nil".  We try to avoid passive tense.




This bug report was last modified 5 years and 335 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.