From unknown Mon Jun 23 07:53:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17250: 24.3; find-variable gives search-failed error message Resent-From: Johan Claesson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Apr 2014 12:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17250 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 17250@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.139730631815688 (code B ref -1); Sat, 12 Apr 2014 12:39:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Apr 2014 12:38:38 +0000 Received: from localhost ([127.0.0.1]:46084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYxCe-00044w-Iz for submit@debbugs.gnu.org; Sat, 12 Apr 2014 08:38:38 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51427) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYxCY-000448-73 for submit@debbugs.gnu.org; Sat, 12 Apr 2014 08:38:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WYxCM-0002rW-Al for submit@debbugs.gnu.org; Sat, 12 Apr 2014 08:38:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYxCM-0002rS-7N for submit@debbugs.gnu.org; Sat, 12 Apr 2014 08:38:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYxCF-0001fO-Vo for bug-gnu-emacs@gnu.org; Sat, 12 Apr 2014 08:38:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WYxC8-0002of-J6 for bug-gnu-emacs@gnu.org; Sat, 12 Apr 2014 08:38:11 -0400 Received: from smtprelay-b22.telenor.se ([195.54.99.213]:41777) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYxC7-0002oT-TH for bug-gnu-emacs@gnu.org; Sat, 12 Apr 2014 08:38:04 -0400 Received: from ipb4.telenor.se (ipb4.telenor.se [195.54.127.167]) by smtprelay-b22.telenor.se (Postfix) with ESMTP id 4D45DE8128 for ; Sat, 12 Apr 2014 14:38:00 +0200 (CEST) X-SMTPAUTH-B2: [b157288] X-SENDER-IP: [85.224.213.128] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlbLAIsySVNV4NWAPGdsb2JhbABZgwUBATqDFYULtCaHNgICgRkXAwEBAQE4NYJGPBMBJyQPJQEEJQpLh2IBmWGyBRaOAQYBASlFhCAEjl+LOJRAO4EtCBc X-IronPort-AV: E=Sophos;i="4.97,848,1389740400"; d="scan'208";a="559817973" Received: from c-80d5e055.1542-1-64736c20.cust.bredbandsbolaget.se (HELO goblin) ([85.224.213.128]) by ipb4.telenor.se with ESMTP; 12 Apr 2014 14:37:58 +0200 From: Johan Claesson User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) Date: Sat, 12 Apr 2014 14:38:04 +0200 Message-ID: <87y4zaiuz7.fsf@bredband.net> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Hi, emacs -Q (defvar foo nil) C-M-x M-x find-variable RET foo RET This gives the following error: Search failed: "Vfoo " Since foo is defined interactively in the *scratch* buffer emacs does not know what file it belongs to. That is expected. I just think it should say something like "Don't know where foo is defined" instead of the above error message. Same thing on todays bzr trunk (GNU Emacs 24.4.50.1 (i686-pc-linux-gnu, GTK+ Version 3.8.6) of 2014-04-12 on goblin). Regards, /Johan In GNU Emacs 24.3.6 (i686-pc-linux-gnu, GTK+ Version 3.8.6) of 2014-04-06 on goblin Windowing system distributor `The X.Org Foundation', version 11.0.11405000 System Description: Ubuntu 13.10 Configured using: `configure '--prefix=/home/jcl/usr' '--without-toolkit-scroll-bars' '-C' '--without-compress-info'' Important settings: value of $LC_COLLATE: C value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Term Minor modes in effect: magit-auto-revert-mode: t diff-auto-refine-mode: t shell-dirtrack-mode: t display-time-mode: t minibuffer-depth-indicate-mode: t which-function-mode: t minibuffer-electric-default-mode: t winner-mode: t icomplete-mode: t ido-everywhere: t electric-layout-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t temp-buffer-resize-mode: t line-number-mode: t transient-mark-mode: t Recent input: e m SPC - Q C-h n q q C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n / o C-s f i n d - v a r C-s s e a r c h C-s C-s C-s SPC N P q C-h i d m e m a C-g m e l i i r e p o C-g d , e d m e n a m a i r e p o r t i n g C-h C-p C-s s e a r c h - f M-x l i s t y - - p a c C-s d e b b i U x SPC C-h i M-x d e b b u g g n u - e s e r a a r s e a r c h - f a i l e d M-1 C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n SPC n n q C-h m M-x f i n d - v a r i a b l e q q C-h i l l C-1 C-1 e m a c s SPC - Q M-x r e p o r t - e m b Recent messages: Preparing diary...done No event to add Making completion list... Contacting host: debbugs.gnu.org:80 [3 times] Wrote /tmp/gnus-temp-group-20992fgk Opening nndoc server on /tmp/gnus-temp-group-20992fgk-ephemeral...done Type C-x 1 to delete the help window, C-M-v to scroll help. Contacting host: debbugs.gnu.org:80 scroll-up: End of buffer Mark set [5 times] Load-path shadows: /home/jcl/share/elisp/.dir-locals hides /home/jcl/share/elisp/external/.dir-locals /home/jcl/share/elisp/.dir-locals hides /home/jcl/elpa/gnugo-2.3.1/.dir-locals /home/jcl/elpa/python-20130227.2146/python hides /home/jcl/usr/share/emacs/24.3/lisp/progmodes/python /home/jcl/elpa/flymake-0.4.16/flymake hides /home/jcl/usr/share/emacs/24.3/lisp/progmodes/flymake /home/jcl/elpa/org-20140331/org-faces hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-faces /home/jcl/elpa/org-20140331/ob-mscgen hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-mscgen /home/jcl/elpa/org-20140331/ob-lob hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-lob /home/jcl/elpa/org-20140331/ob-js hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-js /home/jcl/elpa/org-20140331/org-entities hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-entities /home/jcl/elpa/org-20140331/ob-css hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-css /home/jcl/elpa/org-20140331/ob-perl hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-perl /home/jcl/elpa/org-20140331/ob-ref hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-ref /home/jcl/elpa/org-20140331/org-clock hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-clock /home/jcl/elpa/org-20140331/org-mouse hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-mouse /home/jcl/elpa/org-20140331/org-capture hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-capture /home/jcl/elpa/org-20140331/ob-shen hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-shen /home/jcl/elpa/org-20140331/ob-emacs-lisp hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-emacs-lisp /home/jcl/elpa/org-20140331/org-colview hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-colview /home/jcl/elpa/org-20140331/org-bbdb hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-bbdb /home/jcl/elpa/org-20140331/ob-screen hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-screen /home/jcl/elpa/org-20140331/ob-table hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-table /home/jcl/elpa/org-20140331/org-habit hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-habit /home/jcl/elpa/org-20140331/org-compat hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-compat /home/jcl/elpa/org-20140331/org-archive hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-archive /home/jcl/elpa/org-20140331/org-irc hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-irc /home/jcl/elpa/org-20140331/org-macs hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-macs /home/jcl/elpa/org-20140331/org-version hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-version /home/jcl/elpa/org-20140331/ob-sql hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-sql /home/jcl/elpa/org-20140331/ob-octave hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-octave /home/jcl/elpa/org-20140331/ob-haskell hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-haskell /home/jcl/elpa/org-20140331/ob-awk hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-awk /home/jcl/elpa/org-20140331/org-table hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-table /home/jcl/elpa/org-20140331/org-pcomplete hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-pcomplete /home/jcl/elpa/org-20140331/ob-matlab hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-matlab /home/jcl/elpa/org-20140331/ob-latex hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-latex /home/jcl/elpa/org-20140331/org-feed hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-feed /home/jcl/elpa/org-20140331/ob-scala hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-scala /home/jcl/elpa/org-20140331/ob-asymptote hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-asymptote /home/jcl/elpa/org-20140331/org-gnus hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-gnus /home/jcl/elpa/org-20140331/ob-picolisp hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-picolisp /home/jcl/elpa/org-20140331/org hides /home/jcl/usr/share/emacs/24.3/lisp/org/org /home/jcl/elpa/org-20140331/ob-exp hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-exp /home/jcl/elpa/org-20140331/org-indent hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-indent /home/jcl/elpa/org-20140331/org-w3m hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-w3m /home/jcl/elpa/org-20140331/org-footnote hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-footnote /home/jcl/elpa/org-20140331/ob-sqlite hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-sqlite /home/jcl/elpa/org-20140331/org-attach hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-attach /home/jcl/elpa/org-20140331/org-id hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-id /home/jcl/elpa/org-20140331/ob-ruby hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-ruby /home/jcl/elpa/org-20140331/ob-sass hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-sass /home/jcl/elpa/org-20140331/ob-C hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-C /home/jcl/elpa/org-20140331/ob-org hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-org /home/jcl/elpa/org-20140331/ob-eval hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-eval /home/jcl/elpa/org-20140331/ob-lilypond hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-lilypond /home/jcl/elpa/org-20140331/org-loaddefs hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-loaddefs /home/jcl/elpa/org-20140331/org-element hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-element /home/jcl/elpa/org-20140331/ob-clojure hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-clojure /home/jcl/elpa/org-20140331/ob-sh hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-sh /home/jcl/elpa/org-20140331/ob-ledger hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-ledger /home/jcl/elpa/org-20140331/ob-io hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-io /home/jcl/elpa/org-20140331/org-inlinetask hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-inlinetask /home/jcl/elpa/org-20140331/org-info hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-info /home/jcl/elpa/org-20140331/org-crypt hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-crypt /home/jcl/elpa/org-20140331/ob-ocaml hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-ocaml /home/jcl/elpa/org-20140331/org-mobile hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-mobile /home/jcl/elpa/org-20140331/org-src hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-src /home/jcl/elpa/org-20140331/org-list hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-list /home/jcl/elpa/org-20140331/org-rmail hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-rmail /home/jcl/elpa/org-20140331/ob-comint hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-comint /home/jcl/elpa/org-20140331/ob-maxima hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-maxima /home/jcl/elpa/org-20140331/org-ctags hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-ctags /home/jcl/elpa/org-20140331/org-protocol hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-protocol /home/jcl/elpa/org-20140331/org-datetree hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-datetree /home/jcl/elpa/org-20140331/ob-scheme hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-scheme /home/jcl/elpa/org-20140331/org-plot hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-plot /home/jcl/elpa/org-20140331/ob-python hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-python /home/jcl/elpa/org-20140331/org-docview hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-docview /home/jcl/elpa/org-20140331/ob-gnuplot hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-gnuplot /home/jcl/elpa/org-20140331/ob-ditaa hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-ditaa /home/jcl/elpa/org-20140331/ob-plantuml hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-plantuml /home/jcl/elpa/org-20140331/ob-lisp hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-lisp /home/jcl/elpa/org-20140331/org-install hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-install /home/jcl/elpa/org-20140331/ob-tangle hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-tangle /home/jcl/elpa/org-20140331/org-agenda hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-agenda /home/jcl/elpa/org-20140331/ob-dot hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-dot /home/jcl/elpa/org-20140331/ob-keys hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-keys /home/jcl/elpa/org-20140331/ob-calc hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-calc /home/jcl/elpa/org-20140331/org-mhe hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-mhe /home/jcl/elpa/org-20140331/ob-java hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-java /home/jcl/elpa/org-20140331/ob-fortran hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-fortran /home/jcl/elpa/org-20140331/org-eshell hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-eshell /home/jcl/elpa/org-20140331/org-bibtex hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-bibtex /home/jcl/elpa/org-20140331/ob hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob /home/jcl/elpa/org-20140331/org-timer hides /home/jcl/usr/share/emacs/24.3/lisp/org/org-timer /home/jcl/elpa/org-20140331/ob-R hides /home/jcl/usr/share/emacs/24.3/lisp/org/ob-R /home/jcl/share/elisp/.dir-locals hides /home/jcl/usr/share/emacs/24.3/lisp/gnus/.dir-locals /home/jcl/elpa/emms-20140401.1157/tq hides /home/jcl/usr/share/emacs/24.3/lisp/emacs-lisp/tq Features: (shadow emacsbug nndoc url-handlers pcase texinfo toolbar-x prv-emacs desktop context plain-tex latex tex-style tex-buf tex dbus auto-complete popup butler-util butler-servers deferred json debbugs-gnu debbugs soap-client debbugs-autoloads locate emms-librefm-stream emms-playlist-limit emms-volume emms-volume-amixer emms-i18n emms-history emms-score emms-stream-info emms-metaplaylist-mode emms-bookmarks emms-cue emms-mode-line-icon emms-browser emms-player-xine emms-player-mpd emms-lyrics emms-streams emms-tag-editor emms-info-metaflac emms-mark emms-url emms-librefm-scrobbler xml emms-playlist-sort emms-last-played tempo haskell-show haskell-process haskell-navigate-imports haskell-presentation-mode haskell-str haskell-compat haskell-session haskell-font-lock magit-key-mode magit iswitchb epa epg git-rebase-mode git-commit-mode log-edit pcvs-util rng-loc rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util org-table esh-var esh-io esh-cmd esh-opt esh-ext esh-proc esh-arg esh-groups eshell esh-module esh-mode esh-util org-id ob-octave slime-repl-tests slime-mdot-fu slime-indentation slime-tests tree-widget elp inferior-slime slime-banner slime-enclosing-context slime-cl-indent cl-indent gud autoload tar-mode url-http url-gw url-cache url-auth url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util sort gnus-cite mm-archive mail-extr gnus-bcklg gnus-async add-log apropos vc-git w3m-cookie smiley jcl-replace jcl-ruby jcl-games-init jcl-text-translator-init text-translator text-translator-window text-translator-vars text-translator-sites jcl-muse-init htmlize-hack htmlize sgml-mode muse-latex muse-html muse-xml-common muse-colors cus-edit cus-start cus-load muse-publish muse-project muse-protocols muse-regexps derived muse muse-nested-tags muse-mode jcl-dictem-init dictem misearch multi-isearch mule-util image-file org-indent org-rmail org-mhe org-irc org-info org-gnus org-docview org-bibtex bibtex org-bbdb org-w3m jcl-renegade-goblin jcl-home-boot network-stream tls qp parse-time gnus-ml gnus-topic nndraft nnmh nnfolder nnml gnus-agent gnus-srvr gnus-score score-mode nnvirtual nntp gnus-cache jcl-torrent jcl-goblin fuzzy-match jcl-load jcl-boot text-translator-load jcl-stumpwm jcl-slime slime-fancy slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree slime-scratch slime-presentations bridge slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl slime-parse slime hyperspec jcl-sty jcl-org-init org-feed org-latex org-export-latex org-beamer org-exp org-exp-blocks footnote poporg vc-dir vc vc-dispatcher jcl-epresent epresent ox-latex ox-icalendar ox-html ox-ascii ox-publish ox org-element diet jcl-midnite-init midnight jcl-picpocket-init picpocket-test jcl-erc-init erc-goodies erc erc-backend erc-compat jcl-file-cache-init jcl-file-cache filecache jcl-grep-sbg sbg jcl-ido-init jcl-dired-init jcl-dired jcl-dired-lexical picpocket dired-details wdired dired-aux jcl-register-init jcl-command-subset-init jcl-generic-init generic-x jcl-erlang-init jcl-sbg jcl-erlang-log bookmark pp jcl-sbg-ssit erlang-eunit jcl-erlang distel-ie edb distel jcl-eel bindat patmatch erl-service derl epmd net-fsm erl erlext jcl-safe-init jcl-abbrev-init jcl-ediff-init ediff-merg ediff-diff ediff-wind ediff-help ediff-util ediff-mult ediff-init ediff jcl-term-init jcl-face-init hl-line jcl-elisp-init profiler edebug lib-requires loadhist hi-lock jcl-template-init jcl-template cperl-mode tagbag-init erlang jcl-register jcl-grep-init jcl-grep jcl-motion jcl-modes-init jcl-advice calc calc-loaddefs calc-macs jcl-rfc rfcview goto-addr proced table picture python rx inf-ruby ruby-mode inf-haskell haskell-cabal haskell-utils haskell-decl-scan haskell-mode haskell-string haskell-sort-imports haskell-align-imports flymake dabbrev cc-langs cwarn cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs grep jcl-command-subset nrepl nrepl-macroexpansion nrepl-interaction-mode nrepl-selector nrepl-repl-mode nrepl-repl nrepl-version pkg-info lisp-mnt epl nrepl-client compile eldoc arc-mode archive-mode etags dash clojure-mode inf-lisp view jcl-calendar-init jcl-emms-init emms-playing-time emms-mode-line emms-cache emms-info-ogginfo emms-info-mp3info emms-info later-do emms-playlist-mode emms-player-vlc emms-player-mplayer emms-player-simple emms-source-playlist emms-source-file emms-setup emms emms-compat jcl-gnus-init jcl-gnus jcl-w3m-init w3m-search jcl-term time-stamp ange-ftp w3m-bookmark w3m-antenna w3m-rss jcl-org-import-icalendar jcl-status org-agenda org org-macro org-footnote org-pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob ob-tangle org-src ob-ref ob-lob ob-table ob-keys ob-exp ob-comint ob-core ob-eval org-compat org-macs org-loaddefs autorevert appt jcl-calendar jcl-swedish-postfix quail help-mode holidays hol-loaddefs icalendar diary-lib diary-loaddefs cal-menu calendar cal-loaddefs dired-x gnus-msg gnus-art mm-uu mml2015 epg-config mm-view mml-smime smime dig gnus-sum nnoo gnus-group gnus-undo nnmail mail-source gnus-start gnus-spec gnus-int gnus-range gnus-win mailcap starttls smtpmail sendmail message rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader gnus gnus-ems nnheader mail-utils jcl-keys-init diff-mode easy-mmode tagbag tramp tramp-compat tramp-loaddefs cl-macs gv shell pcomplete format-spec windmove jcl-keys jcl-global-init wc-mode time paren mic-paren printing ps-print ps-def lpr uniquify mb-depth whitespace ffap url-parse auth-source eieio gnus-util mm-util mail-prsvr password-cache url-vars byte-opt warnings bytecomp byte-compile cconv saveplace jcl-imenu which-func imenu jcl-copyright jcl-duff clearcase tq reporter cl minibuf-eldef winner icomplete jcl-sl-init w3m browse-url doc-view jka-compr image-mode timezone w3m-hist w3m-fb bookmark-w3m w3m-ems wid-edit w3m-ccl ccl w3m-favicon w3m-image w3m-proc w3m-util jcl-misc jcl-ert ispell thingatpt find-lisp comint ansi-color dired jcl-misc-lexical jcl-windows ido ert find-func ewoc debug jcl-compile jcl-site-start jpt-mode erlang-start jcl-elpa-init num3-mode jcl-compat-init term disp-table ehelp electric ring sh-script smie executable jcl-times-init advice help-fns advice-preload jcl-util jcl-times cl-lib server jcl-load-path adjust-parens-autoloads ascii-art-to-unicode-autoloads async-autoloads auctex-autoloads tex-site auto-complete-autoloads butler-autoloads deferred-autoloads dired-details-autoloads eimp-autoloads el-mock-autoloads emms-autoloads epresent-autoloads erlang-autoloads etags-select-autoloads flymake-autoloads fuzzy-match-autoloads gitconfig-mode-autoloads gitignore-mode-autoloads gnugo-autoloads gnuplot-autoloads gnuplot-mode-autoloads haskell-mode-autoloads edmacro kmacro htmlize-autoloads inf-ruby-autoloads ipython-autoloads key-chord-autoloads keywiz-autoloads lib-requires-autoloads lua-mode-autoloads macrostep-autoloads magit-autoloads git-rebase-mode-autoloads git-commit-mode-autoloads markdown-mode-autoloads mic-paren-autoloads mo-git-blame-autoloads muse-autoloads nrepl-autoloads dash-autoloads clojure-mode-autoloads num3-mode-autoloads org-present-autoloads org-autoloads outorg-autoloads pkg-info-autoloads epl-autoloads popup-autoloads pysmell-autoloads python-autoloads s-autoloads slime-autoloads finder-inf tabbar-autoloads w3m-autoloads info easymenu web-autoloads yaoddmuse-autoloads package time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) From unknown Mon Jun 23 07:53:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17250: 24.3; find-variable gives search-failed error message Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Apr 2018 23:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17250 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Johan Claesson Cc: 17250@debbugs.gnu.org Received: via spool by 17250-submit@debbugs.gnu.org id=B17250.152400597230512 (code B ref 17250); Tue, 17 Apr 2018 23:00:02 +0000 Received: (at 17250) by debbugs.gnu.org; 17 Apr 2018 22:59:32 +0000 Received: from localhost ([127.0.0.1]:58182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8ZZT-0007vz-S0 for submit@debbugs.gnu.org; Tue, 17 Apr 2018 18:59:32 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:40066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8ZZR-0007vX-FH for 17250@debbugs.gnu.org; Tue, 17 Apr 2018 18:59:30 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f8ZYj-0001HA-LB; Wed, 18 Apr 2018 00:59:28 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f8ZYd-0003Eo-R6; Wed, 18 Apr 2018 00:58:39 +0200 From: Lars Ingebrigtsen References: <87y4zaiuz7.fsf@bredband.net> Date: Wed, 18 Apr 2018 00:58:39 +0200 In-Reply-To: <87y4zaiuz7.fsf@bredband.net> (Johan Claesson's message of "Sat, 12 Apr 2014 14:38:04 +0200") Message-ID: <87zi21e8yo.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Johan Claesson writes: > emacs -Q > (defvar foo nil) C-M-x > M-x find-variable RET foo RET > > This gives the following error: > > Search failed: "Vfoo > " > > Since foo is defined interactively in the *scratch* buffer emacs does > not know what file it belongs to. That is expected. I just think it > should say something like "Don't know where foo is defined" instead of > the above error message. The following patch fixes the problem. Simplest test case: (help-C-file-name 'foo 'var) But there are several places that use this function without checking the return value. Are they relying on this function to bug out with a cryptic error, or are they all confident that the file name can be found? So I haven't applied it yet. Perhaps somebody else will weigh in... diff --git a/lisp/help-fns.el b/lisp/help-fns.el index ec46a479ed..ab3fe3a732 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -169,7 +169,8 @@ describe-function ;;;###autoload (defun help-C-file-name (subr-or-var kind) "Return the name of the C file where SUBR-OR-VAR is defined. -KIND should be `var' for a variable or `subr' for a subroutine." +KIND should be `var' for a variable or `subr' for a subroutine. +If we can't find the file name, nil is returned." (let ((docbuf (get-buffer-create " *DOC*")) (name (if (eq 'var kind) (concat "V" (symbol-name subr-or-var)) @@ -181,19 +182,23 @@ help-C-file-name (expand-file-name internal-doc-file-name doc-directory))) (let ((file (catch 'loop (while t - (let ((pnt (search-forward (concat "\^_" name "\n")))) - (re-search-backward "\^_S\\(.*\\)") - (let ((file (match-string 1))) - (if (member file build-files) - (throw 'loop file) - (goto-char pnt)))))))) - (if (string-match "^ns.*\\(\\.o\\|obj\\)\\'" file) - (setq file (replace-match ".m" t t file 1)) - (if (string-match "\\.\\(o\\|obj\\)\\'" file) - (setq file (replace-match ".c" t t file)))) - (if (string-match "\\.\\(c\\|m\\)\\'" file) - (concat "src/" file) - file))))) + (let ((pnt (search-forward (concat "\^_" name "\n") nil t))) + (if (not pnt) + (throw 'loop nil) + (re-search-backward "\^_S\\(.*\\)") + (let ((file (match-string 1))) + (if (member file build-files) + (throw 'loop file) + (goto-char pnt))))))))) + (if (not file) + nil + (if (string-match "^ns.*\\(\\.o\\|obj\\)\\'" file) + (setq file (replace-match ".m" t t file 1)) + (if (string-match "\\.\\(o\\|obj\\)\\'" file) + (setq file (replace-match ".c" t t file)))) + (if (string-match "\\.\\(c\\|m\\)\\'" file) + (concat "src/" file) + file)))))) (defcustom help-downcase-arguments nil "If non-nil, argument names in *Help* buffers are downcased." -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 17 18:59:31 2018 Received: (at control) by debbugs.gnu.org; 17 Apr 2018 22:59:31 +0000 Received: from localhost ([127.0.0.1]:58178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8ZZT-0007vp-DM for submit@debbugs.gnu.org; Tue, 17 Apr 2018 18:59:31 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:40062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8ZZQ-0007vU-Vu for control@debbugs.gnu.org; Tue, 17 Apr 2018 18:59:29 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f8ZYp-0001OU-6z for control@debbugs.gnu.org; Wed, 18 Apr 2018 00:59:28 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f8ZYj-0003Eu-5M for control@debbugs.gnu.org; Wed, 18 Apr 2018 00:58:45 +0200 To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #17250 Message-Id: Date: Wed, 18 Apr 2018 00:58:45 +0200 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 17250 confirmed From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 17 18:59:31 2018 Received: (at control) by debbugs.gnu.org; 17 Apr 2018 22:59:31 +0000 Received: from localhost ([127.0.0.1]:58180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8ZZT-0007vu-Kl for submit@debbugs.gnu.org; Tue, 17 Apr 2018 18:59:31 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:40063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8ZZQ-0007vV-W7 for control@debbugs.gnu.org; Tue, 17 Apr 2018 18:59:29 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f8ZYn-0001Mq-NR for control@debbugs.gnu.org; Wed, 18 Apr 2018 00:59:27 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f8ZYh-0003Er-Dr for control@debbugs.gnu.org; Wed, 18 Apr 2018 00:58:43 +0200 To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #17250 Message-Id: Date: Wed, 18 Apr 2018 00:58:43 +0200 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 17250 patch From unknown Mon Jun 23 07:53:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17250: 24.3; find-variable gives search-failed error message Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Apr 2018 06:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17250 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch To: Lars Ingebrigtsen Cc: 17250@debbugs.gnu.org, johanclaesson@bredband.net Reply-To: Eli Zaretskii Received: via spool by 17250-submit@debbugs.gnu.org id=B17250.152403262926604 (code B ref 17250); Wed, 18 Apr 2018 06:24:01 +0000 Received: (at 17250) by debbugs.gnu.org; 18 Apr 2018 06:23:49 +0000 Received: from localhost ([127.0.0.1]:58381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8gVN-0006uz-DN for submit@debbugs.gnu.org; Wed, 18 Apr 2018 02:23:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8gVI-0006uh-Qm for 17250@debbugs.gnu.org; Wed, 18 Apr 2018 02:23:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8gV9-0007QN-P0 for 17250@debbugs.gnu.org; Wed, 18 Apr 2018 02:23:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8gV9-0007QI-K4; Wed, 18 Apr 2018 02:23:31 -0400 Received: from [176.228.60.248] (port=3366 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f8gV8-0003hJ-OG; Wed, 18 Apr 2018 02:23:31 -0400 Date: Wed, 18 Apr 2018 09:23:40 +0300 Message-Id: <83y3hl118z.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87zi21e8yo.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Wed, 18 Apr 2018 00:58:39 +0200) References: <87y4zaiuz7.fsf@bredband.net> <87zi21e8yo.fsf@mouse.gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Lars Ingebrigtsen > Date: Wed, 18 Apr 2018 00:58:39 +0200 > Cc: 17250@debbugs.gnu.org > > But there are several places that use this function without checking the > return value. Are they relying on this function to bug out with a > cryptic error, or are they all confident that the file name can be > found? > > So I haven't applied it yet. Perhaps somebody else will weigh in... I'm not weighing in ;-) > (defun help-C-file-name (subr-or-var kind) > "Return the name of the C file where SUBR-OR-VAR is defined. > -KIND should be `var' for a variable or `subr' for a subroutine." > +KIND should be `var' for a variable or `subr' for a subroutine. > +If we can't find the file name, nil is returned." ^^^^^^^^^^^^^^^ "return nil". We try to avoid passive tense. From unknown Mon Jun 23 07:53:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17250: 24.3; find-variable gives search-failed error message Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Apr 2018 02:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17250 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch To: Lars Ingebrigtsen Cc: 17250@debbugs.gnu.org, Johan Claesson Received: via spool by 17250-submit@debbugs.gnu.org id=B17250.152488246216660 (code B ref 17250); Sat, 28 Apr 2018 02:28:01 +0000 Received: (at 17250) by debbugs.gnu.org; 28 Apr 2018 02:27:42 +0000 Received: from localhost ([127.0.0.1]:41491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fCFaM-0004Kb-LY for submit@debbugs.gnu.org; Fri, 27 Apr 2018 22:27:42 -0400 Received: from mail-it0-f49.google.com ([209.85.214.49]:36434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fCFaI-0004KK-1e for 17250@debbugs.gnu.org; Fri, 27 Apr 2018 22:27:38 -0400 Received: by mail-it0-f49.google.com with SMTP id e20-v6so4022262itc.1 for <17250@debbugs.gnu.org>; Fri, 27 Apr 2018 19:27:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=UDHsArYGfxeyyiG1Za+i5EHvLAlBlteg5TCKSpjNvNc=; b=DAwCYwtZKEnQGPoPpPXlOela3t82Uw4lN+feyJb5lJNi1zMDB9FhrsO5WAPi9kmMsa BGs/XQiM/fNprcjlZoMri4Tbab/xEg/H2grWfQXsFKs871kupw1uU0OYLadoqYonPMbY YwqwX3kbG04w+3Fvwag/oyTpw4xh6IAmrKaaQ0JRFf4WLqNJ6tyoHHU8QEsA0ybXixmT 15OaRmHdvMRM/g0czfhQ/jleLLaxapL+G+kzXNNhkNjT+Cp1B7Osu2TB8V9VKsbxn4Yt 6YznzV3/YFU2L3rhElI5yAW3ddx5wh/LRxoR9omzKLVkpGYpLe5AhNwS/FuWSGnv3MLS Rp0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=UDHsArYGfxeyyiG1Za+i5EHvLAlBlteg5TCKSpjNvNc=; b=Hpy7tbsKGR9K5fa+xPAih2DcS+FZgJLd7/5PpJvBsrdVVunGyI+icKveKVfpo1puWl qkrd8jEkuv1NLSbAzMPuizc4WtcczwqYku+3rUm16QxNFSPmkU3LSKdGf8Ebh2i4AERv Pj3JMxpxEkMQuMR5zFGvbx1ryWLuV+v0HrLLE+C9aBmhhwxLhY9g5OA0+Q8sAjDc/mj/ uBeVFy58NJON05bOVRtvvUNoqFckuG8lsZM4V0FRDQMbGyJkSGU2E33HZW5deXRx6mMc wi+VbK50WM1bzI4yoUJcR/2CC0fw+kIfrrtbEmOSmwxPsJZM/sjSc6t+WGtAgB/kAZF1 UfaA== X-Gm-Message-State: ALQs6tBVqUhc0vbVTdNr6/3bdIYe2pJRp+IyMgLbXgkfA2rBBeOfhHz9 psuuwzy0aX6tBFp54yiMisYZIw== X-Google-Smtp-Source: AB8JxZpFkG+uz1q/+9i4/qXqppz/9Xx8X5rs6Kp8kWiewPyvFZm+fucUM0/54zuz1VQ0U9OesnM0MA== X-Received: by 2002:a24:4f14:: with SMTP id c20-v6mr4069881itb.59.1524882448446; Fri, 27 Apr 2018 19:27:28 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e19-v6sm1292816iob.31.2018.04.27.19.27.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Apr 2018 19:27:27 -0700 (PDT) From: Noam Postavsky References: <87y4zaiuz7.fsf@bredband.net> <87zi21e8yo.fsf@mouse.gnus.org> Date: Fri, 27 Apr 2018 22:27:25 -0400 In-Reply-To: <87zi21e8yo.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Wed, 18 Apr 2018 00:58:39 +0200") Message-ID: <8736zgqd4i.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > But there are several places that use this function without checking the > return value. Are they relying on this function to bug out with a > cryptic error, or are they all confident that the file name can be > found? > > So I haven't applied it yet. Perhaps somebody else will weigh in... I think it's okay. Here's my analysis of the call-sites found by M-x rgrep: ./help-fns.el:163:;; (defun help-C-file-name (subr-or-var kind) ./help-fns.el:170:(defun help-C-file-name (subr-or-var kind) ./help-fns.el:319: (help-C-file-name type 'subr) ./help-fns.el:325: (help-C-file-name object 'var) These 2 are in the return value position of `find-lisp-object-file-name', whose docstring says "If no suitable file is found, return nil". ./emacs-lisp/find-func.el:436: (help-C-file-name def 'subr)) This one is only called if `def' satisfies `subrp', so I think failing to find it can't happen anyway.=20=20 ./emacs-lisp/find-func.el:555: (help-C-file-name vari= able 'var)))) This one is in find-variable-noselect. Before your change, it would throw (search-failed "\037Vfoo\n"), with your change it throws (error "Don=E2=80=99t know where =E2=80=98foo=E2=80=99 is defined") which seems be= tter. ./progmodes/elisp-mode.el:693: (push (elisp--xref-make-xref ni= l symbol (help-C-file-name (symbol-function symbol) 'subr)) xrefs)) ./progmodes/elisp-mode.el:770: ;; yet; help-C-file-name does t= hat. Second call will ./progmodes/elisp-mode.el:772: (push (elisp--xref-make-xref 'd= efvar symbol (help-C-file-name symbol 'var)) xrefs)) ./ldefs-boot.el:15592:(autoload 'help-C-file-name "help-fns" "\ ./help-mode.el:203: (help-C-file-name (indirect= -function fun) 'fun))) ./help-mode.el:243: (setq file (help-C-file-name var 'var))) As far as I can tell, all of these calls only happen if the symbol has already been found by `find-lisp-object-file-name', so they won't trigger the failure case. From unknown Mon Jun 23 07:53:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17250: 24.3; find-variable gives search-failed error message Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jun 2019 14:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17250 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch To: Noam Postavsky Cc: 17250@debbugs.gnu.org, Johan Claesson Received: via spool by 17250-submit@debbugs.gnu.org id=B17250.15615579958016 (code B ref 17250); Wed, 26 Jun 2019 14:07:01 +0000 Received: (at 17250) by debbugs.gnu.org; 26 Jun 2019 14:06:35 +0000 Received: from localhost ([127.0.0.1]:36626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg8ZH-00025E-9X for submit@debbugs.gnu.org; Wed, 26 Jun 2019 10:06:35 -0400 Received: from quimby.gnus.org ([80.91.231.51]:49448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg8ZG-00024y-13 for 17250@debbugs.gnu.org; Wed, 26 Jun 2019 10:06:34 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hg8Z4-0000Vi-90; Wed, 26 Jun 2019 16:06:28 +0200 From: Lars Ingebrigtsen References: <87y4zaiuz7.fsf@bredband.net> <87zi21e8yo.fsf@mouse.gnus.org> <8736zgqd4i.fsf@gmail.com> Date: Wed, 26 Jun 2019 16:06:22 +0200 In-Reply-To: <8736zgqd4i.fsf@gmail.com> (Noam Postavsky's message of "Fri, 27 Apr 2018 22:27:25 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Noam Postavsky writes: >> So I haven't applied it yet. Perhaps somebody else will weigh in... > > I think it's okay. Here's my analysis of the call-sites found by M-x > rgrep: Thanks for checking this; I've now applied the patch to the Emacs trunk. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Noam Postavsky writes: >> So I haven't applied it yet. Perhaps somebody else will weigh in... > > I think it's okay. Here's my analysis of the call-sites found by M-x > rgrep: Thanks for checking this; I've now applied the patch to the Emacs trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 26 10:06:38 2019 Received: (at control) by debbugs.gnu.org; 26 Jun 2019 14:06:38 +0000 Received: from localhost ([127.0.0.1]:36628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg8ZK-00025P-H0 for submit@debbugs.gnu.org; Wed, 26 Jun 2019 10:06:38 -0400 Received: from quimby.gnus.org ([80.91.231.51]:49456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg8ZG-000251-N5 for control@debbugs.gnu.org; Wed, 26 Jun 2019 10:06:34 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hg8ZE-0000Vn-7K for control@debbugs.gnu.org; Wed, 26 Jun 2019 16:06:34 +0200 Date: Wed, 26 Jun 2019 16:06:32 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #17250 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 17250 fixed close 17250 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 17250 fixed close 17250 27.1 quit