GNU bug report logs - #17248
[PATCH] grep: waste of a lot of memory for a large pattern in dfamust

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17248 in the body.
You can then email your comments to 17248 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: bug-grep <at> gnu.org
Subject: [PATCH] grep: waste of a lot of memory for a large pattern in dfamust
Date: Sat, 12 Apr 2014 15:10:02 +0900

[Message part 1 (text/plain, inline)]

dfamust() uses a log of memory for long pattern.

  $ echo abc | grep -f /usr/share/dict/words

/usr/share/dict/words is about 5MB.  However, dfamust() will require
memory over 100MB.

Norihiro

[patch.txt (text/plain, attachment)]

Message #8 received at 17248 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: 17248 <at> debbugs.gnu.org
Subject: bug#17248: [PATCH] grep: waste of a lot of memory for a large pattern
 in dfamust
Date: Sat, 19 Apr 2014 00:04:30 +0900

[Message part 1 (text/plain, inline)]

I rebased this patch because of confliction.

[patch.txt (text/plain, attachment)]

Message #11 received at 17248 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: 17248 <at> debbugs.gnu.org
Subject: bug#17248: [PATCH] grep: waste of a lot of memory for a large pattern
 in dfamust
Date: Sun, 20 Apr 2014 09:59:24 +0900

[Message part 1 (text/plain, inline)]

Norihiro Tanaka wrote:
> I rebased this patch because of confliction.

I fixed the degration in rebase.

[patch.txt (text/plain, attachment)]

Message #14 received at 17248 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: 17248 <at> debbugs.gnu.org
Subject: bug#17248: [PATCH] grep: waste of a lot of memory for a large pattern
 in dfamust
Date: Tue, 22 Apr 2014 08:08:57 +0900

[Message part 1 (text/plain, inline)]

I rebased this patch because of confliction again.

[patch.txt (text/plain, attachment)]

Message #19 received at 17248-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>, 17248-done <at> debbugs.gnu.org
Subject: Re: bug#17248: [PATCH] grep: waste of a lot of memory for a large
 pattern in dfamust
Date: Thu, 24 Apr 2014 09:46:48 -0700

[Message part 1 (text/plain, inline)]

Thanks, I installed that, and followed it up with the attached minor 
cleanup patch.

[0001-dfa-minor-tuneup-of-dfamust-memory-savings-patch.patch (text/x-patch, attachment)]

Message #22 received at 17248-done <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 17248-done <at> debbugs.gnu.org
Subject: Re: bug#17248: [PATCH] grep: waste of a lot of memory for a large
 pattern in dfamust
Date: Sat, 10 May 2014 10:05:30 +0900

[Message part 1 (text/plain, inline)]

I have added a /* fallthrough */ comment, Jim works so in bug#17350.

[0001-maint-mark-a-breakless-case-with-fallthrough-comment.patch (text/plain, attachment)]

Message #25 received at 17248-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 17248-done <at> debbugs.gnu.org
Subject: Re: bug#17248: [PATCH] grep: waste of a lot of memory for a large
 pattern in dfamust
Date: Fri, 09 May 2014 18:46:38 -0700

Norihiro Tanaka wrote:
>             assert (!"neither LPAREN nor RPAREN may appear here");
> +          /* fallthrough */

That doesn't fall through, as the 'assert' never returns.

Message #28 received at 17248-done <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 17248-done <at> debbugs.gnu.org
Subject: Re: bug#17248: [PATCH] grep: waste of a lot of memory for a large
 pattern in dfamust
Date: Sat, 10 May 2014 12:03:46 +0900

Paul Eggert wrote:
> That doesn't fall through, as the 'assert' never returns.

Oh!  Thanks, I understood it.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.