From unknown Wed Sep 10 10:11:26 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#17234 <17234@debbugs.gnu.org> To: bug#17234 <17234@debbugs.gnu.org> Subject: Status: 24.3.50; overlay priority : cons cells make an error in ediff Reply-To: bug#17234 <17234@debbugs.gnu.org> Date: Wed, 10 Sep 2025 17:11:26 +0000 retitle 17234 24.3.50; overlay priority : cons cells make an error in ediff= =20 reassign 17234 emacs submitter 17234 Nicolas Richard severity 17234 important thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 10 05:37:06 2014 Received: (at submit) by debbugs.gnu.org; 10 Apr 2014 09:37:06 +0000 Received: from localhost ([127.0.0.1]:39586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYBPt-0004Qb-Hj for submit@debbugs.gnu.org; Thu, 10 Apr 2014 05:37:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57359) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYBPr-0004Q4-89 for submit@debbugs.gnu.org; Thu, 10 Apr 2014 05:37:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WYBPg-00028w-Vl for submit@debbugs.gnu.org; Thu, 10 Apr 2014 05:36:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYBPg-00028p-RP for submit@debbugs.gnu.org; Thu, 10 Apr 2014 05:36:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYBPb-0006QO-Rm for bug-gnu-emacs@gnu.org; Thu, 10 Apr 2014 05:36:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WYBPV-00025i-SF for bug-gnu-emacs@gnu.org; Thu, 10 Apr 2014 05:36:47 -0400 Received: from mxin.ulb.ac.be ([164.15.128.112]:42961) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYBPV-00025M-My for bug-gnu-emacs@gnu.org; Thu, 10 Apr 2014 05:36:41 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AnwGAJxlRlOkD3Xv/2dsb2JhbABZrxiCWgGYBXSDPRcNNAFgh2cBAxGaJI9ummABh2AXh2eEbII2hCIElnaBaIY8hjeFT4MyOw Received: from wifi-nat239.ulb.ac.be (HELO LDLC-portable) ([164.15.117.239]) by smtp.ulb.ac.be with ESMTP; 10 Apr 2014 11:36:39 +0200 From: Nicolas Richard To: bug-gnu-emacs@gnu.org Subject: 24.3.50; overlay priority : cons cells make an error in ediff Message-ID: <878urdmvr0.fsf@yahoo.fr> Date: Thu, 10 Apr 2014 11:36:38 +0200 MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Steps to reproduce from -Q : M-x ediff-regions-wordwise RET RET ; selects scratch buf RET ; ditto C-SPC C-n C-M-c ; select first line of scratch buffer C-n C-SPC C-n C-M-c ; select second line of scratch buffer n ; go to next difference That makes an error > Wrong type argument: number-or-marker-p, (nil . 100) in function ediff-highest-priority, which comes from commit > cdb3fff3f588caeed50cbb5b64c09bce0a0b31e3 > Author: Stefan Monnier > Date: Sun Mar 23 18:30:47 2014 -0400 > * lisp/simple.el (redisplay-highlight-region-function): Increase priority of > overlay to make sure boundaries are visible. > * src/buffer.c (struct sortvec): Add field `spriority'. > (compare_overlays): Use it. > (sort_overlays): Set it. where the notion of the "priority" of an overlay was changed : it can now be a cons cell (which holds a priority and a secondary priority). The changelog mentions bug#15899 but I saw nothing in that (very long) thread mentionning the fix. At (info "(elisp) Overlay Properties") however it is said that the priority "should be a non-negative integer". Also, and that's where the error comes from, ediff-init.el relies on the priority being either nil or an integer, in function ediff-highest-priority. For this I can suggest a fix (see patch below) but I don't know what lispref should say about the change. In GNU Emacs 24.3.50.6 (i686-pc-linux-gnu, GTK+ Version 2.24.20) of 2014-04-09 on LDLC-portable Modified lisp/ChangeLog diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 54ac144..3ed0195 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2014-04-10 Nicolas Richard + + * vc/ediff-init.el (ediff-highest-priority): Don't make an error + if overlay priority is a cons. + 2014-04-09 Dmitry Gutov * progmodes/ruby-mode.el (ruby-font-lock-keywords): Highlight more Modified lisp/vc/ediff-init.el diff --git a/lisp/vc/ediff-init.el b/lisp/vc/ediff-init.el index 000fdb9..110dc63 100644 --- a/lisp/vc/ediff-init.el +++ b/lisp/vc/ediff-init.el @@ -1352,7 +1352,12 @@ this variable represents.") (null (ediff-overlay-get ovr 'ediff)) (null (ediff-overlay-get ovr 'ediff-diff-num))) ;; use the overlay priority or 0 - (or (ediff-overlay-get ovr 'priority) 0) + (let ((priority (ediff-overlay-get ovr 'priority))) + (cond ((integerp priority) + priority) + ((consp priority) + (or (car priority) (cdr priority))) + (t 0))) 0)) ovr-list)))))))) -- Nico. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 10 15:17:59 2014 Received: (at 17234) by debbugs.gnu.org; 10 Apr 2014 19:17:59 +0000 Received: from localhost ([127.0.0.1]:44831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYKU2-0004zF-Gu for submit@debbugs.gnu.org; Thu, 10 Apr 2014 15:17:58 -0400 Received: from mercure.iro.umontreal.ca ([132.204.24.67]:34478) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYKU0-0004z4-Cg for 17234@debbugs.gnu.org; Thu, 10 Apr 2014 15:17:57 -0400 Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id A22DF84CCA; Thu, 10 Apr 2014 15:17:55 -0400 (EDT) Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 94CB81E5B7C; Thu, 10 Apr 2014 15:17:31 -0400 (EDT) Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 6F275B4180; Thu, 10 Apr 2014 15:17:31 -0400 (EDT) From: Stefan Monnier To: Nicolas Richard Subject: Re: bug#17234: 24.3.50; overlay priority : cons cells make an error in ediff Message-ID: References: <878urdmvr0.fsf@yahoo.fr> Date: Thu, 10 Apr 2014 15:17:31 -0400 In-Reply-To: <878urdmvr0.fsf@yahoo.fr> (Nicolas Richard's message of "Thu, 10 Apr 2014 11:36:38 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-Spam-Status: No X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 17234 Cc: 17234@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) > That makes an error >> Wrong type argument: number-or-marker-p, (nil . 100) > in function ediff-highest-priority, which comes from commit Indeed, thanks. Ediff's handling of overlay priorities is a good example of what's wrong with overlay priorities, adding code to make sure its overlays are "on top", then adding yet more code to ensure its other overlays are "even more on top". And then yet more code to try and defeat the other packages which might be taking part in this race to the highest priority. So, I just threw it out, which should solve those problem. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 10 16:28:04 2014 Received: (at control) by debbugs.gnu.org; 10 Apr 2014 20:28:04 +0000 Received: from localhost ([127.0.0.1]:44857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYLZs-00070c-23 for submit@debbugs.gnu.org; Thu, 10 Apr 2014 16:28:04 -0400 Received: from mercure.iro.umontreal.ca ([132.204.24.67]:43262) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYLZp-000707-Bp for control@debbugs.gnu.org; Thu, 10 Apr 2014 16:28:02 -0400 Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 9BAF184DAE for ; Thu, 10 Apr 2014 16:28:00 -0400 (EDT) Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 22F941E5874 for ; Thu, 10 Apr 2014 16:27:37 -0400 (EDT) Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 00B78B4180; Thu, 10 Apr 2014 16:27:36 -0400 (EDT) From: Stefan Monnier To: control@debbugs.gnu.org Subject: Re: bug#17234: 24.3.50; overlay priority : cons cells make an error in ediff Message-ID: References: <878urdmvr0.fsf@yahoo.fr> Date: Thu, 10 Apr 2014 16:27:36 -0400 In-Reply-To: <878urdmvr0.fsf@yahoo.fr> (Nicolas Richard's message of "Thu, 10 Apr 2014 11:36:38 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-Spam-Status: No X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) close 17234 thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 10 20:56:41 2014 Received: (at 17234) by debbugs.gnu.org; 11 Apr 2014 00:56:42 +0000 Received: from localhost ([127.0.0.1]:44988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYPlp-0007wN-En for submit@debbugs.gnu.org; Thu, 10 Apr 2014 20:56:41 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:53862 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYPlm-0007wC-VB for 17234@debbugs.gnu.org; Thu, 10 Apr 2014 20:56:39 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WYPll-0002oi-UO; Thu, 10 Apr 2014 20:56:37 -0400 From: Glenn Morris To: Stefan Monnier Subject: Re: bug#17234: 24.3.50; overlay priority : cons cells make an error in ediff References: <878urdmvr0.fsf@yahoo.fr> X-Spook: Capricorn New World Order Islam Abduganievich Karimov X-Ran: \c>E User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: 17234 Cc: 17234@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.6 (-----) Nicolas Richard wrote: > [...] the notion of the "priority" of an overlay was changed : it can > now be a cons cell (which holds a priority and a secondary priority). [...] > At (info "(elisp) Overlay Properties") however it is said that the > priority "should be a non-negative integer". What about the documentation/NEWS aspect? From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 11 08:30:44 2014 Received: (at 17234) by debbugs.gnu.org; 11 Apr 2014 12:30:44 +0000 Received: from localhost ([127.0.0.1]:45247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYabR-00028J-3N for submit@debbugs.gnu.org; Fri, 11 Apr 2014 08:30:42 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:59655) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYabM-00027z-3N for 17234@debbugs.gnu.org; Fri, 11 Apr 2014 08:30:37 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s3BCUYOW021718; Fri, 11 Apr 2014 08:30:34 -0400 Received: by pastel.home (Postfix, from userid 20848) id 07AF860212; Fri, 11 Apr 2014 08:30:34 -0400 (EDT) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#17234: 24.3.50; overlay priority : cons cells make an error in ediff Message-ID: References: <878urdmvr0.fsf@yahoo.fr> Date: Fri, 11 Apr 2014 08:30:33 -0400 In-Reply-To: (Glenn Morris's message of "Thu, 10 Apr 2014 20:56:37 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4908=0 X-NAI-Spam-Version: 2.3.0.9378 : core <4908> : inlines <724> : streams <1156666> : uri <1726400> X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 17234 Cc: 17234@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> [...] the notion of the "priority" of an overlay was changed : it can >> now be a cons cell (which holds a priority and a secondary priority). > [...] >> At (info "(elisp) Overlay Properties") however it is said that the >> priority "should be a non-negative integer". > What about the documentation/NEWS aspect? The new feature was introduced specifically for the region handling, and I'm not yet convinced I'm satisfied with it, so I'd rather not document it for now. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 11 09:08:40 2014 Received: (at 17234) by debbugs.gnu.org; 11 Apr 2014 13:08:40 +0000 Received: from localhost ([127.0.0.1]:45274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYbCA-0003qG-DZ for submit@debbugs.gnu.org; Fri, 11 Apr 2014 09:08:40 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]:58006) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYbC7-0003ps-WD for 17234@debbugs.gnu.org; Fri, 11 Apr 2014 09:08:37 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0N3V00400AWFP000@a-mtaout21.012.net.il> for 17234@debbugs.gnu.org; Fri, 11 Apr 2014 16:08:29 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N3V0037IB65ZD80@a-mtaout21.012.net.il>; Fri, 11 Apr 2014 16:08:29 +0300 (IDT) Date: Fri, 11 Apr 2014 16:08:30 +0300 From: Eli Zaretskii Subject: Re: bug#17234: 24.3.50; overlay priority : cons cells make an error in ediff In-reply-to: X-012-Sender: halo1@inter.net.il To: Stefan Monnier Message-id: <83ppkot3n5.fsf@gnu.org> References: <878urdmvr0.fsf@yahoo.fr> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17234 Cc: 17234@debbugs.gnu.org, rgm@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stefan Monnier > Date: Fri, 11 Apr 2014 08:30:33 -0400 > Cc: 17234@debbugs.gnu.org > > >> [...] the notion of the "priority" of an overlay was changed : it can > >> now be a cons cell (which holds a priority and a secondary priority). > > [...] > >> At (info "(elisp) Overlay Properties") however it is said that the > >> priority "should be a non-negative integer". > > What about the documentation/NEWS aspect? > > The new feature was introduced specifically for the region handling, and > I'm not yet convinced I'm satisfied with it, so I'd rather not > document it for now. Then how can we expect authors of other Lisp packages to be able to fix their code so it works with Emacs 24.4 and later? We must say _something_ in NEWS. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 11 11:56:52 2014 Received: (at 17234) by debbugs.gnu.org; 11 Apr 2014 15:56:52 +0000 Received: from localhost ([127.0.0.1]:45567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYdoy-0003kJ-21 for submit@debbugs.gnu.org; Fri, 11 Apr 2014 11:56:52 -0400 Received: from mercure.iro.umontreal.ca ([132.204.24.67]:51220) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYdov-0003k6-GT for 17234@debbugs.gnu.org; Fri, 11 Apr 2014 11:56:50 -0400 Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 960D884D22; Fri, 11 Apr 2014 11:56:48 -0400 (EDT) Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 4223C1E5B74; Fri, 11 Apr 2014 11:56:24 -0400 (EDT) Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 1D689B4180; Fri, 11 Apr 2014 11:56:24 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#17234: 24.3.50; overlay priority : cons cells make an error in ediff Message-ID: References: <878urdmvr0.fsf@yahoo.fr> <83ppkot3n5.fsf@gnu.org> Date: Fri, 11 Apr 2014 11:56:24 -0400 In-Reply-To: <83ppkot3n5.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Apr 2014 16:08:30 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 17234 Cc: 17234@debbugs.gnu.org, rgm@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) > Then how can we expect authors of other Lisp packages to be able to > fix their code so it works with Emacs 24.4 and later? We must say > _something_ in NEWS. It has always been the case that `priority' could be any value. Any non-number value was treated as nil by the display engine, whereas now some cons values are treated as something else. But ediff's bug could already be triggered in Emacs<24.4 by a package installing an overlay with a `priority' that's a cons cell. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 11 12:31:55 2014 Received: (at 17234) by debbugs.gnu.org; 11 Apr 2014 16:31:55 +0000 Received: from localhost ([127.0.0.1]:45579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYeMr-0005L6-P7 for submit@debbugs.gnu.org; Fri, 11 Apr 2014 12:31:54 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:56630 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYeMn-0005Ks-OO for 17234@debbugs.gnu.org; Fri, 11 Apr 2014 12:31:50 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WYeMm-0001bI-K5; Fri, 11 Apr 2014 12:31:48 -0400 From: Glenn Morris To: Stefan Monnier Subject: Re: bug#17234: 24.3.50; overlay priority : cons cells make an error in ediff References: <878urdmvr0.fsf@yahoo.fr> <83ppkot3n5.fsf@gnu.org> X-Spook: Islam Abduganievich Karimov Bruxelles NATO Montenegro X-Ran: ^1umQ>I'+CaRAQ=80:b!N!r%1s52-_kF@#h9C0A5\DNG9&}"-C(.uaQh}~b)N![l&^kX+w X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 11 Apr 2014 12:31:48 -0400 In-Reply-To: (Stefan Monnier's message of "Fri, 11 Apr 2014 11:56:24 -0400") Message-ID: <7oioqf4ykr.fsf_-_@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: 17234 Cc: 17234@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.4 (-----) Stefan Monnier wrote: > It has always been the case that `priority' could be any value. But the only documented values were and are nil and positive integers. I really doubt anyone was intentionally using anything else to mean "nil". > Any non-number value was treated as nil by the display engine, whereas > now some cons values are treated as something else. So even if your previous point was correct, it's still an incompatible change. A cons cell can no longer be used to mean "no explicit priority". > But ediff's bug could already be triggered in Emacs<24.4 by a package > installing an overlay with a `priority' that's a cons cell. Since we never (?) had any such reports, I conclude nobody did that. But I imagine ediff was not the only package trying to get the priority of an overlay and do something with the answer (however misguided you think that might be). From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 11 13:12:59 2014 Received: (at 17234) by debbugs.gnu.org; 11 Apr 2014 17:12:59 +0000 Received: from localhost ([127.0.0.1]:45599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYf0d-0008Ji-14 for submit@debbugs.gnu.org; Fri, 11 Apr 2014 13:12:59 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]:57921) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYf0a-0008J9-IW for 17234@debbugs.gnu.org; Fri, 11 Apr 2014 13:12:58 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0N3V00G00MDDAO00@a-mtaout20.012.net.il> for 17234@debbugs.gnu.org; Fri, 11 Apr 2014 20:12:50 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N3V00GCUMHA9H20@a-mtaout20.012.net.il>; Fri, 11 Apr 2014 20:12:47 +0300 (IDT) Date: Fri, 11 Apr 2014 20:12:48 +0300 From: Eli Zaretskii Subject: Re: bug#17234: 24.3.50; overlay priority : cons cells make an error in ediff In-reply-to: X-012-Sender: halo1@inter.net.il To: Stefan Monnier Message-id: <83ioqfu6wf.fsf@gnu.org> References: <878urdmvr0.fsf@yahoo.fr> <83ppkot3n5.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17234 Cc: 17234@debbugs.gnu.org, rgm@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stefan Monnier > Cc: rgm@gnu.org, 17234@debbugs.gnu.org > Date: Fri, 11 Apr 2014 11:56:24 -0400 > > > Then how can we expect authors of other Lisp packages to be able to > > fix their code so it works with Emacs 24.4 and later? We must say > > _something_ in NEWS. > > It has always been the case that `priority' could be any value. > > Any non-number value was treated as nil by the display engine, whereas > now some cons values are treated as something else. > > But ediff's bug could already be triggered in Emacs<24.4 by a package > installing an overlay with a `priority' that's a cons cell. Sorry, I don't see how all this removes the need to inform Lisp programmers of the change of a long-time traditional behavior. I don't understand the reason(s) for hiding this information. If you don't want to divulge some internal details, the information can be conveyed in a purely functional manner ("don't do XXX; instead, do YYY" or "don't assume that overlay priority is either an integer or nil) that doesn't require to describe implementation details. But I don't see how can we say nothing about this incompatible change. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 11 16:06:39 2014 Received: (at 17234) by debbugs.gnu.org; 11 Apr 2014 20:06:40 +0000 Received: from localhost ([127.0.0.1]:45674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYhig-00076d-RW for submit@debbugs.gnu.org; Fri, 11 Apr 2014 16:06:39 -0400 Received: from mercure.iro.umontreal.ca ([132.204.24.67]:43570) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYhia-00076M-Fv for 17234@debbugs.gnu.org; Fri, 11 Apr 2014 16:06:37 -0400 Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id D327384D8C; Fri, 11 Apr 2014 16:06:31 -0400 (EDT) Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id EA3E01E5874; Fri, 11 Apr 2014 16:06:08 -0400 (EDT) Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id CE52BB4180; Fri, 11 Apr 2014 16:06:08 -0400 (EDT) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#17234: 24.3.50; overlay priority : cons cells make an error in ediff Message-ID: References: <878urdmvr0.fsf@yahoo.fr> <83ppkot3n5.fsf@gnu.org> <7oioqf4ykr.fsf_-_@fencepost.gnu.org> Date: Fri, 11 Apr 2014 16:06:08 -0400 In-Reply-To: <7oioqf4ykr.fsf_-_@fencepost.gnu.org> (Glenn Morris's message of "Fri, 11 Apr 2014 12:31:48 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 17234 Cc: 17234@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) >> Any non-number value was treated as nil by the display engine, whereas >> now some cons values are treated as something else. > So even if your previous point was correct, it's still an incompatible > change. A cons cell can no longer be used to mean "no explicit priority". Indeed. Tho as you said: I really doubt anyone was intentionally using anything else to mean "nil". So I think we're safe on this side of the backward incompatibility. > But I imagine ediff was not the only package trying to get the priority > of an overlay and do something with the answer (however misguided you > think that might be). Hard to tell. Not sure what we can do about it, tho. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 11 16:08:20 2014 Received: (at 17234) by debbugs.gnu.org; 11 Apr 2014 20:08:21 +0000 Received: from localhost ([127.0.0.1]:45679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYhkK-0007A0-20 for submit@debbugs.gnu.org; Fri, 11 Apr 2014 16:08:20 -0400 Received: from mercure.iro.umontreal.ca ([132.204.24.67]:43595) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYhkA-00079h-S5 for 17234@debbugs.gnu.org; Fri, 11 Apr 2014 16:08:18 -0400 Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 9EC5B84D2D; Fri, 11 Apr 2014 16:08:10 -0400 (EDT) Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 8DB681E5874; Fri, 11 Apr 2014 16:07:47 -0400 (EDT) Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 7D6B5B4180; Fri, 11 Apr 2014 16:07:47 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#17234: 24.3.50; overlay priority : cons cells make an error in ediff Message-ID: References: <878urdmvr0.fsf@yahoo.fr> <83ppkot3n5.fsf@gnu.org> <83ioqfu6wf.fsf@gnu.org> Date: Fri, 11 Apr 2014 16:07:47 -0400 In-Reply-To: <83ioqfu6wf.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Apr 2014 20:12:48 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 17234 Cc: 17234@debbugs.gnu.org, rgm@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) > "don't assume that overlay priority is either an integer or nil" Feel free to put that in. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 11 16:22:14 2014 Received: (at 17234) by debbugs.gnu.org; 11 Apr 2014 20:22:14 +0000 Received: from localhost ([127.0.0.1]:45699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYhxm-0007Z4-7R for submit@debbugs.gnu.org; Fri, 11 Apr 2014 16:22:14 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:35040 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYhxj-0007Yv-Km for 17234@debbugs.gnu.org; Fri, 11 Apr 2014 16:22:12 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WYhxi-0006Ee-Ou; Fri, 11 Apr 2014 16:22:10 -0400 From: Glenn Morris To: Stefan Monnier Subject: Re: bug#17234: 24.3.50; overlay priority : cons cells make an error in ediff References: <878urdmvr0.fsf@yahoo.fr> <83ppkot3n5.fsf@gnu.org> <7oioqf4ykr.fsf_-_@fencepost.gnu.org> X-Spook: fraud afsatcom TELINT dictionary Zachawi infowar UOP PET X-Ran: 9%Mz](|Up%6`%I1w<"~Z2f1|UF"4i6#E*)DfFdiYc+'k{k/>XB*SV)yaaD,Y1(WXk.$Fx{ X-Hue: white X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 11 Apr 2014 16:22:10 -0400 In-Reply-To: (Stefan Monnier's message of "Fri, 11 Apr 2014 16:06:08 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: 17234 Cc: 17234@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.4 (-----) Stefan Monnier wrote: >> But I imagine ediff was not the only package trying to get the priority >> of an overlay and do something with the answer (however misguided you >> think that might be). > > Hard to tell. One minute of searching suggests that: extent-at in lucid.el ps-generate-postscript-with-faces1 in ps-def.el will have problems now. It would seem suprising if there are three files in Emacs that this causes problems for, and nothing external. > Not sure what we can do about it, tho. The least you can do is make an "incompatible change" NEWS entry. Ideally it would it explain what do if you still want to get the priority of an overlay as a number. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 15 12:56:11 2014 Received: (at 17234) by debbugs.gnu.org; 15 Apr 2014 16:56:11 +0000 Received: from localhost ([127.0.0.1]:49076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wa6eY-0004yp-PF for submit@debbugs.gnu.org; Tue, 15 Apr 2014 12:56:11 -0400 Received: from mercure.iro.umontreal.ca ([132.204.24.67]:38366) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wa6eW-0004ye-Ce for 17234@debbugs.gnu.org; Tue, 15 Apr 2014 12:56:08 -0400 Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id F3FE284DDE; Tue, 15 Apr 2014 12:56:05 -0400 (EDT) Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id C0E251E5B74; Tue, 15 Apr 2014 12:55:37 -0400 (EDT) Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id A0B15B4180; Tue, 15 Apr 2014 12:55:37 -0400 (EDT) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#17234: 24.3.50; overlay priority : cons cells make an error in ediff Message-ID: References: <878urdmvr0.fsf@yahoo.fr> <83ppkot3n5.fsf@gnu.org> <7oioqf4ykr.fsf_-_@fencepost.gnu.org> Date: Tue, 15 Apr 2014 12:55:37 -0400 In-Reply-To: (Glenn Morris's message of "Fri, 11 Apr 2014 16:22:10 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-Spam-Status: No X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 17234 Cc: 17234@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) > extent-at in lucid.el > ps-generate-postscript-with-faces1 in ps-def.el Indeed. And htmlize also. > The least you can do is make an "incompatible change" NEWS entry. Not sure which part is incompatible. > Ideally it would it explain what to do if you still want to get the > priority of an overlay as a number. You don't, really. But I've added an argument `sorted' to overlays-at which seems to provide the information that was really needed in the above cases. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 21 09:47:19 2014 Received: (at 17234) by debbugs.gnu.org; 21 Apr 2014 13:47:19 +0000 Received: from localhost ([127.0.0.1]:53898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WcEZ4-0003E3-VA for submit@debbugs.gnu.org; Mon, 21 Apr 2014 09:47:19 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:64807) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WcEZ1-0003Dp-1D for 17234@debbugs.gnu.org; Mon, 21 Apr 2014 09:47:16 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0N4D00F00VLVBO00@a-mtaout22.012.net.il> for 17234@debbugs.gnu.org; Mon, 21 Apr 2014 16:47:13 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N4D00EELVMOYD80@a-mtaout22.012.net.il>; Mon, 21 Apr 2014 16:47:13 +0300 (IDT) Date: Mon, 21 Apr 2014 16:47:03 +0300 From: Eli Zaretskii Subject: Re: bug#17234: 24.3.50; overlay priority : cons cells make an error in ediff In-reply-to: X-012-Sender: halo1@inter.net.il To: Stefan Monnier Message-id: <83ioq2dcbs.fsf@gnu.org> References: <878urdmvr0.fsf@yahoo.fr> <83ppkot3n5.fsf@gnu.org> <83ioqfu6wf.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17234 Cc: 17234@debbugs.gnu.org, rgm@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stefan Monnier > Cc: rgm@gnu.org, 17234@debbugs.gnu.org > Date: Fri, 11 Apr 2014 16:07:47 -0400 > > > "don't assume that overlay priority is either an integer or nil" > > Feel free to put that in. Done. From unknown Wed Sep 10 10:11:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 20 May 2014 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator