GNU bug report logs - #17230
[PATCH 1/2] grep: may also use Boyer-Moore algorithm for case-insensitive matching

Previous Next

Full log

Message #13 received at 17230-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>, 17230-done <at> debbugs.gnu.org
Subject: Re: bug#17230: [PATCH 1/2] grep: may also use Boyer-Moore algorithm
 for case-insensitive matching
Date: Tue, 22 Apr 2014 21:20:59 -0700

[Message part 1 (text/plain, inline)]

Thanks much for this performance improvement.  I puzzled for a while to 
figure out what was going on, and was confused by that tricky macro 
expansion.  Nowadays functions are typically not significantly slower 
than macros, so unless there's a major performance difference I'd prefer 
to use functions.  I installed the performance improvement patch and 
followed up with the attached patch, which uses C functions instead of 
macros and which coalesces some of the near-duplicate code.  The 
followup patch also includes some comments to try to explain the new 
functions.

[0001-kwset-simplify-Boyer-Moore-with-unibyte-i.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.