GNU bug report logs - #17230
[PATCH 1/2] grep: may also use Boyer-Moore algorithm for case-insensitive matching

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Subject: bug#17230: closed (Re: bug#17230: [PATCH 1/2] grep: may also use
 Boyer-Moore algorithm for case-insensitive matching)
Date: Wed, 23 Apr 2014 04:22:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#17230: [PATCH 1/2] grep: may also use Boyer-Moore algorithm for case-insensitive matching

which was filed against the grep package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 17230 <at> debbugs.gnu.org.

-- 
17230: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17230
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>, 17230-done <at> debbugs.gnu.org
Subject: Re: bug#17230: [PATCH 1/2] grep: may also use Boyer-Moore algorithm
 for case-insensitive matching
Date: Tue, 22 Apr 2014 21:20:59 -0700

[Message part 3 (text/plain, inline)]

Thanks much for this performance improvement.  I puzzled for a while to 
figure out what was going on, and was confused by that tricky macro 
expansion.  Nowadays functions are typically not significantly slower 
than macros, so unless there's a major performance difference I'd prefer 
to use functions.  I installed the performance improvement patch and 
followed up with the attached patch, which uses C functions instead of 
macros and which coalesces some of the near-duplicate code.  The 
followup patch also includes some comments to try to explain the new 
functions.

[0001-kwset-simplify-Boyer-Moore-with-unibyte-i.patch (text/plain, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: bug-grep <at> gnu.org
Subject: [PATCH 1/2] grep: may also use Boyer-Moore algorithm for
 case-insensitive matching
Date: Wed, 09 Apr 2014 22:54:42 +0900

[Message part 6 (text/plain, inline)]

Boyer-Moore algorithm is faster than Beate Commentz-Walter, in especially
worst case, because Galil rule is applicable only for Boyer-Moore
algorithm.

This patch enables to use Boyer-Moore algorithm for case-insensitive
matching.

Norihiro

[patch.txt (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.