GNU bug report logs - #17229
[PATCH 2/2] grep: speed-up by using memchr() in Boyer-Moore searching

Previous Next

Package: grep;

Reported by: Norihiro Tanaka <noritnk <at> kcn.ne.jp>

Date: Wed, 9 Apr 2014 13:56:02 UTC

Severity: normal

Tags: moreinfo, patch

Done: Norihiro Tanaka <noritnk <at> kcn.ne.jp>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 17229 <at> debbugs.gnu.org
Subject: bug#17229: [PATCH 2/2] grep: speed-up by using memchr() in Boyer-Moore searching
Date: Tue, 29 Apr 2014 18:38:05 -0700
> Subject: [PATCH] kwset: improve the performance by inlining tr

Thanks.  Normally we don't add 'inline' to functions, under the theory 
that compilers inline well-enough nowadays that we'd rather trust their 
judgment, but I suppose CentOS 5 is still relevant-enough and the 
performance effects great enough that we can make an exception here. 
Plus, we're already using 'inline' elsewhere in this module for 
performance reasons, and it's unlikely that a non-inlined 'tr' would 
perform better on any current platform.  So, I installed that patch.




This bug report was last modified 11 years and 105 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.