GNU bug report logs - #17228
24.4.50; Dired with -R switch and hiding details: Missing chars etc.

Previous Next

Full log

View this message in rfc822 format

From: Christopher Schmidt <ch <at> ristopher.com>
To: 17228 <at> debbugs.gnu.org
Cc: Michael Heerdegen <michael_heerdegen <at> web.de>, Eli Zaretskii <eliz <at> gnu.org>
Subject: bug#17228: 24.4.50; Dired with -R switch and hiding details: Missing chars etc.
Date: Mon, 21 Apr 2014 13:58:44 -0400 (EDT)

[Message part 1 (text/plain, inline)]

Michael Heerdegen <michael_heerdegen <at> web.de> writes:
> I don't think it's that hard to fix.  `dired-insert-set-properties'
> just doesn't check whether any non file line is an information line to
> hide or something else (empty line or subdir header line).  So,
> something like this should do:
[...]
> WDYT?  We should test it well, however, to be sure it does the same
> for different `ls-lisp-use-insert-directory-program' values and such.

Great!  I can confirm that your change fixes the bug with and without ls
emulation on my GNU/Linux system.  Thank you very much.

If there is no objection, I will commit the following patch to the
emacs-24 branch tomorrow.

[Message part 2 (text/x-diff, inline)]

+--- lisp/ChangeLog
+++ lisp/ChangeLog
@@ -1,3 +1,9 @@
+2014-04-21  Michael Heerdegen  <michael_heerdegen <at> web.de>
+
+	* dired.el (dired-insert-set-properties): Do not consider
+	subdirectory headings and empty lines to be information that
+	`dired-hide-details-mode' should hide.	(Bug#17228)
+
 2014-04-20  Michael Albinus  <michael.albinus <at> gmx.de>
 
 	* net/tramp-sh.el (tramp-get-ls-command): Use "-b" argument if
--- lisp/dired.el
+++ lisp/dired.el
@@ -1250,9 +1250,11 @@
     (while (< (point) end)
       (ignore-errors
 	(if (not (dired-move-to-filename))
-	    (put-text-property (line-beginning-position)
-			       (1+ (line-end-position))
-			       'invisible 'dired-hide-details-information)
+	    (unless (or (looking-at-p "^$")
+			(looking-at-p dired-subdir-regexp))
+	      (put-text-property (line-beginning-position)
+				 (1+ (line-end-position))
+				 'invisible 'dired-hide-details-information))
 	  (put-text-property (+ (line-beginning-position) 1) (1- (point))
 			     'invisible 'dired-hide-details-detail)
 	  (add-text-properties

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.