From unknown Mon Sep 08 01:50:45 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#17228 <17228@debbugs.gnu.org> To: bug#17228 <17228@debbugs.gnu.org> Subject: Status: 24.4.50; Dired with -R switch and hiding details: Missing chars etc. Reply-To: bug#17228 <17228@debbugs.gnu.org> Date: Mon, 08 Sep 2025 08:50:45 +0000 retitle 17228 24.4.50; Dired with -R switch and hiding details: Missing cha= rs etc. reassign 17228 emacs submitter 17228 Drew Adams severity 17228 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 08 18:36:04 2014 Received: (at submit) by debbugs.gnu.org; 8 Apr 2014 22:36:05 +0000 Received: from localhost ([127.0.0.1]:38274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WXece-0001yC-3D for submit@debbugs.gnu.org; Tue, 08 Apr 2014 18:36:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39993) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WXecc-0001xc-2z for submit@debbugs.gnu.org; Tue, 08 Apr 2014 18:36:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXecM-0006ru-DT for submit@debbugs.gnu.org; Tue, 08 Apr 2014 18:35:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXecM-0006rq-9w for submit@debbugs.gnu.org; Tue, 08 Apr 2014 18:35:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41681) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXecD-0007Og-HV for bug-gnu-emacs@gnu.org; Tue, 08 Apr 2014 18:35:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXec4-0006pG-QZ for bug-gnu-emacs@gnu.org; Tue, 08 Apr 2014 18:35:37 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:18859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXec4-0006p7-HF for bug-gnu-emacs@gnu.org; Tue, 08 Apr 2014 18:35:28 -0400 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s38MZQkh008842 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 8 Apr 2014 22:35:27 GMT Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s38MZPpr001372 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Tue, 8 Apr 2014 22:35:26 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s38MZPBK001361 for ; Tue, 8 Apr 2014 22:35:25 GMT MIME-Version: 1.0 Message-ID: Date: Tue, 8 Apr 2014 15:35:24 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 24.4.50; Dired with -R switch and hiding details: Missing chars etc. X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) emacs -Q C-u C-x d -alR SOME-DIR The descendent dirs are inserted. OK. Now hide details (`('). The `.' entries appear at the end of the subdir header lines. The newlines separating the inserted subdirs from the preceding listing are missing. The colons at the end of the subdir header lines are missing. The subdir header lines are not indented. (The top-level dir listing is OK.) Example - this is what you see before hiding details: d:/foo/test: total used in directory 1024 available 115348376 drwxrwxrwx 1 myuser Domain Users 0 2013-05-31 . drwxrwxrwx 1 myuser Domain Users 1048576 04-08 15:19 .. drwxrwxrwx 1 myuser Domain Users 0 2013-05-31 sample-one drwxrwxrwx 1 myuser Domain Users 0 2013-05-31 sample-two d:/foo/test/sample-one: total 0 drwxrwxrwx 1 myuser Domain Users 0 2013-05-31 . drwxrwxrwx 1 myuser Domain Users 0 2013-05-31 .. drwxrwxrwx 1 myuser Domain Users 0 2013-05-18 example1 d:/foo/test/sample-one/example: total 0 drwxrwxrwx 1 myuser Domain Users 0 2013-05-18 . drwxrwxrwx 1 myuser Domain Users 0 2013-05-31 .. d:/foo/test/sample-two: total 0 drwxrwxrwx 1 myuser Domain Users 0 2013-05-31 . drwxrwxrwx 1 myuser Domain Users 0 2013-05-31 .. drwxrwxrwx 1 myuser Domain Users 0 2013-05-18 example2 d:/foo/test/sample-two/example: total 0 drwxrwxrwx 1 myuser Domain Users 0 2013-05-18 . drwxrwxrwx 1 myuser Domain Users 0 2013-05-31 .. And this is what you see after hiding details: d:/foo/test: . .. sample-one sample-two d:/foo/test/sample-one . .. example d:/foo/test/sample-one/example1 . .. d:/foo/test/sample-two . .. example d:/foo/test/sample-two/example2 . .. In GNU Emacs 24.4.50.1 (i686-pc-mingw32) of 2014-04-08 on ODIEONE Bzr revision: 116956 dancol@dancol.org-20140408123940-knoyutxt4l8ws7qm Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/Devel/emacs/snapshot/trunk --enable-checking=3Dyes,glyphs 'CFLAGS=3D-O0 -g3' LDFLAGS=3D-Lc:/Devel/emacs/lib 'CPPFLAGS=3D-DGC_MCHECK=3D1 -Ic:/Devel/emacs/include'' From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 09 11:27:34 2014 Received: (at 17228) by debbugs.gnu.org; 9 Apr 2014 15:27:34 +0000 Received: from localhost ([127.0.0.1]:39182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WXuPR-00056M-UC for submit@debbugs.gnu.org; Wed, 09 Apr 2014 11:27:33 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:52473) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WXuPM-000565-Ic for 17228@debbugs.gnu.org; Wed, 09 Apr 2014 11:27:28 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0N3R00900S0CEJ00@a-mtaout22.012.net.il> for 17228@debbugs.gnu.org; Wed, 09 Apr 2014 18:26:48 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N3R009DLS8NBS30@a-mtaout22.012.net.il>; Wed, 09 Apr 2014 18:26:48 +0300 (IDT) Date: Wed, 09 Apr 2014 18:26:43 +0300 From: Eli Zaretskii Subject: Re: bug#17228: 24.4.50; Dired with -R switch and hiding details: Missing chars etc. In-reply-to: X-012-Sender: halo1@inter.net.il To: Drew Adams Message-id: <83eh165xsc.fsf@gnu.org> References: X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17228 Cc: 17228@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Tue, 8 Apr 2014 15:35:24 -0700 (PDT) > From: Drew Adams > > In GNU Emacs 24.4.50.1 (i686-pc-mingw32) > of 2014-04-08 on ODIEONE > Bzr revision: 116956 dancol@dancol.org-20140408123940-knoyutxt4l8ws7qm FWIW, I see the same problems on GNU/Linux. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 21 13:59:11 2014 Received: (at submit) by debbugs.gnu.org; 21 Apr 2014 17:59:11 +0000 Received: from localhost ([127.0.0.1]:54327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WcIUn-00059W-VX for submit@debbugs.gnu.org; Mon, 21 Apr 2014 13:59:10 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45480) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WcIUk-00059N-BZ for submit@debbugs.gnu.org; Mon, 21 Apr 2014 13:59:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WcIUe-0005NI-2N for submit@debbugs.gnu.org; Mon, 21 Apr 2014 13:59:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WcIUd-0005NA-W5 for submit@debbugs.gnu.org; Mon, 21 Apr 2014 13:59:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WcIUZ-0003Rd-4d for bug-gnu-emacs@gnu.org; Mon, 21 Apr 2014 13:58:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WcIUS-0005Lk-St for bug-gnu-emacs@gnu.org; Mon, 21 Apr 2014 13:58:55 -0400 Received: from ristopher.com ([81.4.108.209]:50849) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WcIUS-0005LA-Mv; Mon, 21 Apr 2014 13:58:48 -0400 Received: by ristopher.com (Postfix, from userid 0) id 623B620A83; Mon, 21 Apr 2014 13:58:45 -0400 (EDT) From: Christopher Schmidt To: bug-gnu-emacs@gnu.org Subject: Re: bug#17228: 24.4.50; Dired with -R switch and hiding details: Missing chars etc. In-Reply-To: <87eh0rttbw.fsf@web.de> (Michael Heerdegen's message of "Mon, 21 Apr 2014 02:33:07 +0200") Message-ID: <87eh0q5zui@ristopher.com> References: <837g6kf4xu.fsf@gnu.org> <87eh0rttbw.fsf@web.de> Mail-Followup-To: bug-gnu-emacs@gnu.org, Eli Zaretskii , Michael Heerdegen MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Date: Mon, 21 Apr 2014 13:58:44 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: Michael Heerdegen , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain Michael Heerdegen writes: > I don't think it's that hard to fix. `dired-insert-set-properties' > just doesn't check whether any non file line is an information line to > hide or something else (empty line or subdir header line). So, > something like this should do: [...] > WDYT? We should test it well, however, to be sure it does the same > for different `ls-lisp-use-insert-directory-program' values and such. Great! I can confirm that your change fixes the bug with and without ls emulation on my GNU/Linux system. Thank you very much. If there is no objection, I will commit the following patch to the emacs-24 branch tomorrow. --=-=-= Content-Type: text/x-diff Content-Disposition: inline +--- lisp/ChangeLog +++ lisp/ChangeLog @@ -1,3 +1,9 @@ +2014-04-21 Michael Heerdegen + + * dired.el (dired-insert-set-properties): Do not consider + subdirectory headings and empty lines to be information that + `dired-hide-details-mode' should hide. (Bug#17228) + 2014-04-20 Michael Albinus * net/tramp-sh.el (tramp-get-ls-command): Use "-b" argument if --- lisp/dired.el +++ lisp/dired.el @@ -1250,9 +1250,11 @@ (while (< (point) end) (ignore-errors (if (not (dired-move-to-filename)) - (put-text-property (line-beginning-position) - (1+ (line-end-position)) - 'invisible 'dired-hide-details-information) + (unless (or (looking-at-p "^$") + (looking-at-p dired-subdir-regexp)) + (put-text-property (line-beginning-position) + (1+ (line-end-position)) + 'invisible 'dired-hide-details-information)) (put-text-property (+ (line-beginning-position) 1) (1- (point)) 'invisible 'dired-hide-details-detail) (add-text-properties --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 22 16:49:08 2014 Received: (at control) by debbugs.gnu.org; 22 Apr 2014 20:49:08 +0000 Received: from localhost ([127.0.0.1]:55438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wchcq-0008Bb-DL for submit@debbugs.gnu.org; Tue, 22 Apr 2014 16:49:08 -0400 Received: from ristopher.com ([81.4.108.209]:57058) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wchcm-0008BQ-E1 for control@debbugs.gnu.org; Tue, 22 Apr 2014 16:49:05 -0400 Received: by ristopher.com (Postfix, from userid 0) id 21D3F20A82; Tue, 22 Apr 2014 16:49:02 -0400 (EDT) From: Christopher Schmidt To: control@debbugs.gnu.org Subject: none Message-ID: <878uqxqedt@ristopher.com> MIME-Version: 1.0 Content-Type: text/plain Date: Tue, 22 Apr 2014 16:49:01 -0400 (EDT) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) close 17228 From unknown Mon Sep 08 01:50:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 21 May 2014 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator