GNU bug report logs - #17219
24.3.50; wrong alignment when a list is given to dired

Previous Next

Full log

View this message in rfc822 format

From: Jakub Ječmínek <kuba <at> kubajecminek.cz>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Nicolas Richard <theonewiththeevillook <at> yahoo.fr>, 17219 <at> debbugs.gnu.org
Subject: bug#17219: 24.3.50; wrong alignment when a list is given to dired
Date: Thu, 16 Jan 2025 21:35:14 +0000

What do you think, should this be merged or should we rework the patch?

"Charalampos Mitrodimas" <charmitro <at> posteo.net> writes:

> Thanks Jakub!
>
> On 12/23/24 19:52, Jakub Ječmínek via Bug reports for GNU Emacs, the
> Swiss army knife of text editors wrote:
>> Hello,
>>
>> "Charalampos Mitrodimas" <charmitro <at> posteo.net> writes:
>>
>>> What about performance? Depending on the size of the directory,
>>> recalculating alignment could have a minor performance impact.
>> There is. The largest directory I have on my machine has around 18k
>> files (~5GB) and the penalty is around 20ms. I've run the tests for both
>> functions in standalone Emacs session started using 'emacs -Q'. Below
>> are the profiling results:
>>
>> Function Name     Call Count  Elapsed Time  Average Time
>> --------------------------------------------------------
>> dired-revert-new  10          5.2096629750  0.5209662975
>> dired-revert-old  10          5.051716523   0.5051716522
>>
>> dired-revert-new  25          11.843308944  0.4737323577
>> dired-revert-old  25          11.391448779  0.4556579511
>>
>>
>> Please let me know if that's too high so we can find another way.
> If my math doesn't deceive me, the performance penalty ranges
> between 3.13% (10 calls) and 3.97% (25 calls) based on the profiling
> results, which I find acceptable.
>
>
> --
> C. Mitrodimas
>

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.