GNU bug report logs - #17217
24.4.50; eww/shr and relative links

Previous Next

Full log

View this message in rfc822 format

From: joaotavora <at> gmail.com (João Távora)
To: 17217 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: bug#17217: 24.4.50; eww/shr and relative links
Date: Fri, 11 Apr 2014 16:08:52 +0100

Hello Lars,

I though I had CC'ed on this bug report, but apparently I didn't. Any
change you can have a look at this before the pretest? I have commit
rights and can perform the fix, but I didn't test thoroughly.

João

>> Hi maintainers, Lars,
>>
>>     emacs -Q
>>     M-x eww RET\
>>         http://franz.com/support/documentation/current/doc/classes/excl/compiler-inconsistent-name-usage-warning.htm\
>>         RET
>>
>> Click on any link in the webpage, *eww* always reports 404, because it
>> couldn't follow a relative link with href="../../release-notes.htm". A
>
> This patch seems to fix it,
>
> === modified file 'lisp/net/shr.el'
> *** lisp/net/shr.el	2014-03-05 18:44:58 +0000
> --- lisp/net/shr.el	2014-04-07 20:59:33 +0000
> ***************
> *** 610,616 ****
>   	 (concat (nth 3 base) url))
>   	(t
>   	 ;; Totally relative.
> ! 	 (concat (car base) (cadr base) url))))
>   
>   (defun shr-ensure-newline ()
>     (unless (zerop (current-column))
> --- 610,616 ----
>   	 (concat (nth 3 base) url))
>   	(t
>   	 ;; Totally relative.
> ! 	 (concat (car base) (expand-file-name url (cadr base))))))
>   
>   (defun shr-ensure-newline ()
>     (unless (zerop (current-column))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.