GNU bug report logs - #17213
24.3.50; ruby-mode: misindented continuation method calls inside parens

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#17213: closed (24.3.50; ruby-mode: misindented continuation
 method calls inside parens)
Date: Sun, 13 Mar 2016 23:51:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 14 Mar 2016 01:50:21 +0200
with message-id <3ba46e7d-b0d2-7f2d-a787-f620e9059e4e <at> yandex.ru>
and subject line Re: bug#17213: Acknowledgement (24.3.50; ruby-mode: misindented continuation method calls inside parens)
has caused the debbugs.gnu.org bug report #17213,
regarding 24.3.50; ruby-mode: misindented continuation method calls inside parens
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
17213: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17213
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50;
 ruby-mode: misindented continuation method calls inside parens
Date: Mon, 07 Apr 2014 05:45:27 +0300

Example:

abc(foo
     .bar,
    tee
     .qux)

The lines with dots should be indented one column more.

Same if I move either dot to the end of the previous line, but keep the
called methods where they are.

I can fix that for the second method call with the patch at the bottom,
but the first one is unaffected. Not sure what would be the best fix for
it.

On a related note, it's worrisome that indentation of the these two
similar pieces of code in fairly similar positions is governed by
different logic.


=== modified file 'lisp/progmodes/ruby-mode.el'
--- lisp/progmodes/ruby-mode.el	2014-03-27 08:21:15 +0000
+++ lisp/progmodes/ruby-mode.el	2014-04-04 03:28:12 +0000
@@ -658,7 +658,7 @@
     (`(:before . ".")
      (if (smie-rule-sibling-p)
          (and ruby-align-chained-calls 0)
-       ruby-indent-level))
+       (smie-rule-parent ruby-indent-level)))
     (`(:before . ,(or `"else" `"then" `"elsif" `"rescue" `"ensure"))
      (smie-rule-parent))
     (`(:before . "when")

[Message part 3 (message/rfc822, inline)]

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: 17213-done <at> debbugs.gnu.org
Subject: Re: bug#17213: Acknowledgement (24.3.50; ruby-mode: misindented
 continuation method calls inside parens)
Date: Mon, 14 Mar 2016 01:50:21 +0200

Pushed a workaround in 5b705bc97d3928e6550d271c415c54e00e020011 to emacs-25.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.