GNU bug report logs - #17190
24.4.50; fill-flow checks quoted lines after deleting leading space

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17190 in the body.
You can then email your comments to 17190 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4.50; fill-flow checks quoted lines after deleting leading space
Date: Sat, 05 Apr 2014 16:12:40 +0900

When I evaluate the below code, I receive unexpected result.

(with-temp-buffer
  (require 'flow-fill)
  (insert " > ABC \nDEF\n")
  (fill-flowed)
  ;; (mime-display-text/plain-flowed)
  (buffer-string))

->
"> ABC 
DEF
"
But I expect the below result.

"> ABC DEF
"

-- 
Kazuhiro Ito

Message #8 received at 17190 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
Cc: 17190 <at> debbugs.gnu.org
Subject: Re: bug#17190: 24.4.50; fill-flow checks quoted lines after
 deleting leading space
Date: Wed, 14 Aug 2019 17:20:08 -0700

Kazuhiro Ito <kzhr <at> d1.dion.ne.jp> writes:

> When I evaluate the below code, I receive unexpected result.
>
> (with-temp-buffer
>   (require 'flow-fill)
>   (insert " > ABC \nDEF\n")
>   (fill-flowed)
>   ;; (mime-display-text/plain-flowed)
>   (buffer-string))
>
> ->
> "> ABC 
> DEF
> "
> But I expect the below result.
>
> "> ABC DEF
> "

If I'm reading

https://tools.ietf.org/html/rfc2646

right, that's not how this is supposed to work, and `fill-flowed' does
it correctly -- it's supposed to flow together lines that have the same
quotation level, like this:

(with-temp-buffer
  (require 'flow-fill)
  (insert " > ABC \n> DEF\n")
  (fill-flowed)
  (buffer-string))


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #15 received at 17190 <at> debbugs.gnu.org (full text, mbox):

From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 17190 <at> debbugs.gnu.org
Subject: Re: bug#17190: 24.4.50;
 fill-flow checks quoted lines after deleting leading space
Date: Thu, 15 Aug 2019 18:59:55 +0900

> > When I evaluate the below code, I receive unexpected result.
> >
> > (with-temp-buffer
> >   (require 'flow-fill)
> >   (insert " > ABC \nDEF\n")
> >   (fill-flowed)
> >   ;; (mime-display-text/plain-flowed)
> >   (buffer-string))
> >
> > ->
> > "> ABC 
> > DEF
> > "
> > But I expect the below result.
> >
> > "> ABC DEF
> > "
> 
> If I'm reading
> 
> https://tools.ietf.org/html/rfc2646
> 
> right, that's not how this is supposed to work, and `fill-flowed' does
> it correctly -- it's supposed to flow together lines that have the same
> quotation level, like this:

Please beware Space-Stuffing at the first line.  The first line is not
quoted one.  " > ABC " and "DEF" have the same quotation level.

-- 
Kazuhiro Ito

Message #18 received at 17190 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
Cc: 17190 <at> debbugs.gnu.org
Subject: Re: bug#17190: 24.4.50; fill-flow checks quoted lines after
 deleting leading space
Date: Thu, 15 Aug 2019 16:59:34 -0700

Kazuhiro Ito <kzhr <at> d1.dion.ne.jp> writes:

> Please beware Space-Stuffing at the first line.  The first line is not
> quoted one.  " > ABC " and "DEF" have the same quotation level.

Ah, I missed that bit.  And:

4.4.  Space-Stuffing

   In order to allow for unquoted lines which start with ">", and to
   protect against systems which "From-munge" in-transit messages
   (modifying any line which starts with "From " to ">From "),
   Format=Flowed provides for space-stuffing.

   Space-stuffing adds a single space to the start of any line which
   needs protection when the message is generated.  On reception, if the
   first character of a line is a space, it is logically deleted.  This
   occurs after the test for a quoted line, and before the test for a
   flowed line.

So `fill-flowed' is definitely doing this wrong -- it just deletes the
space stuffing before it does any of the processing, which is the
opposite of what it should do, really.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #23 received at 17190 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
Cc: 17190 <at> debbugs.gnu.org
Subject: Re: bug#17190: 24.4.50; fill-flow checks quoted lines after
 deleting leading space
Date: Thu, 15 Aug 2019 18:00:51 -0700

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> So `fill-flowed' is definitely doing this wrong -- it just deletes the
> space stuffing before it does any of the processing, which is the
> opposite of what it should do, really.

I've now reimplemented the function to follow the algorithm proposed by
the RFC more closely in Emacs 27.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #30 received at 17190 <at> debbugs.gnu.org (full text, mbox):

From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 17190 <at> debbugs.gnu.org
Subject: Re: bug#17190: 24.4.50;
 fill-flow checks quoted lines after deleting leading space
Date: Fri, 16 Aug 2019 23:31:10 +0900

> > So `fill-flowed' is definitely doing this wrong -- it just deletes the
> > space stuffing before it does any of the processing, which is the
> > opposite of what it should do, really.
> 
> I've now reimplemented the function to follow the algorithm proposed by
> the RFC more closely in Emacs 27.

I confirmed the problem was fixed.
Thank you!

-- 
Kazuhiro Ito

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.