GNU bug report logs - #17157
[PATCH 1/5] Partially revert "dfa: improve port to freestanding DJGPP"

Previous Next

Full log

Message #29 received at 17157 <at> debbugs.gnu.org (full text, mbox):

From: Paolo Bonzini <bonzini <at> gnu.org>
To: arnold <at> skeeve.com, eggert <at> cs.ucla.edu, 17157 <at> debbugs.gnu.org
Cc: meyering <at> fb.com
Subject: Re: bug#17157: [PATCH 1/5] Partially revert "dfa: improve port to
 freestanding DJGPP"
Date: Wed, 02 Apr 2014 09:10:42 +0200

Il 01/04/2014 20:36, arnold <at> skeeve.com ha scritto:
> Not really such a good idea. mbsupport.h is used in multiple places
> in gawk to define if MBS support is availble. It needs to stay
> that way. Since we're discussing keeping dfa simple in both its
> environments, then it needs to be in a header that only dfa uses.
>
> At the moment, the best candidate is xalloc.h, which differs somewhat
> grep vs. gawk.
>
> But here too, in reality that file is mainly for allocation stuff
> and dfa portability doesn't really belong there.
>
> I respectfully suggest dfaconfig.h (or dfacustom.h) with
>
> 	#ifdef GAWK
> 	#ifndef HAVE_SETLOCALE
> 	#define selocale(x, y)	NULL
> 	#endif
> 	#define static_assert(cond) ...
> 	#endif
>
> as the initial contents.

Couldn't gawk's dfaconfig.h include gawk's mbsupport.h?

Paolo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.