GNU bug report logs - #17157
[PATCH 1/5] Partially revert "dfa: improve port to freestanding DJGPP"

Previous Next

Package: grep;

Reported by: Paolo Bonzini <bonzini <at> gnu.org>

Date: Tue, 1 Apr 2014 09:19:03 UTC

Severity: normal

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Paolo Bonzini <bonzini <at> gnu.org>
To: 17157 <at> debbugs.gnu.org
Cc: meyering <at> fb.com
Subject: bug#17157: [PATCH 1/5] Partially revert "dfa: improve port to freestanding DJGPP"
Date: Tue,  1 Apr 2014 11:18:42 +0200
This partially reverts the following commits:
- df6da5d40a47abbc6e3451cb9fab7a8c9ede12cc.
- c40e7f7158109985b901ae67e5faa06160547471.
- 0995fc11214ebbb1c99a4b6d675fe615b0ed8539.

As far as grep is concerned, the #define *does* belong in gnulib.  gawk
can apply the fix in a common header file like grep's src/system.h.
---
 src/dfa.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/dfa.c b/src/dfa.c
index b22fe97..a7f0056 100644
--- a/src/dfa.c
+++ b/src/dfa.c
@@ -34,11 +34,7 @@
 #include <locale.h>
 #include <stdbool.h>
 
-/* Gawk doesn't use Gnulib, so don't assume that setlocale and
-   static_assert are present.  */
-#ifndef LC_ALL
-# define setlocale(category, locale) NULL
-#endif
+/* Gawk doesn't use Gnulib, so don't assume static_assert is present.  */
 #ifndef static_assert
 # define static_assert(cond, diagnostic) \
     extern int (*foo (void)) [!!sizeof (struct { int foo: (cond) ? 8 : -1; })]
-- 
1.9.0






This bug report was last modified 11 years and 76 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.