GNU bug report logs - #17157
[PATCH 1/5] Partially revert "dfa: improve port to freestanding DJGPP"

Previous Next

Package: grep;

Reported by: Paolo Bonzini <bonzini <at> gnu.org>

Date: Tue, 1 Apr 2014 09:19:03 UTC

Severity: normal

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: arnold <at> skeeve.com
To: bonzini <at> gnu.org, arnold <at> skeeve.com, 17157 <at> debbugs.gnu.org
Cc: meyering <at> fb.com
Subject: bug#17157: [PATCH 1/5] Partially revert "dfa: improve port to freestanding DJGPP"
Date: Tue, 01 Apr 2014 06:00:51 -0600

Hi.

> > One thing is serving more than one master and having the occasional 
> > #ifndef GREP, another thing is doing things twice in grep (via gnulib 
> > and explicitly in dfa.c).
> >
> > setlocale, static_assert etc. should be in a dfacompat.h file that is 
> > not shared between grep and gawk and could also include the #define for 
> > GREP and GAWK symbols.
>
> I could live with that.  It's a good idea.

I should point out that defining GAWK in dfacompat.h is not the right
thing - I define it globally since there are a few gawk-specific bits in
the regex code too.

Thanks,

Arnold
This bug report was last modified 11 years and 75 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.