GNU bug report logs - #17149
shred - tape data

Previous Next

Package: coreutils;

Reported by: Rupert Russell <Rupert.Russell <at> ilmor.co.uk>

Date: Mon, 31 Mar 2014 15:45:04 UTC

Severity: normal

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Pádraig Brady <P <at> draigBrady.com>
Cc: "17149 <at> debbugs.gnu.org" <17149 <at> debbugs.gnu.org>
Subject: bug#17149: shred - tape data
Date: Thu, 03 Apr 2014 21:53:03 -0700

Pádraig Brady wrote:
>                     if (! INT_ADD_OVERFLOW (size, size_incr))
>                       size += size_incr;
> +                  else
> +                    size = OFF_T_MAX;

A clearer way to write that would be:

   size += MIN (size_incr, OFF_T_MAX - size);

Otherwise it looks good.
This bug report was last modified 11 years and 44 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.