GNU bug report logs - #17149
shred - tape data

Previous Next

Package: coreutils;

Reported by: Rupert Russell <Rupert.Russell <at> ilmor.co.uk>

Date: Mon, 31 Mar 2014 15:45:04 UTC

Severity: normal

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Pádraig Brady <P <at> draigBrady.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: Rupert Russell <Rupert.Russell <at> ilmor.co.uk>, "17149 <at> debbugs.gnu.org" <17149 <at> debbugs.gnu.org>
Subject: bug#17149: shred - tape data
Date: Wed, 02 Apr 2014 19:24:23 +0100

On 04/02/2014 06:59 PM, Paul Eggert wrote:
> On 04/02/2014 09:31 AM, Paul Eggert wrote:
>> Does the attached patch work for you? 
> Oops. that had an incorrect integer overflow check.  Attached is an improved version, which uses INT_ADD_OVERFLOW instead of attempting to do it by hand.

I was thinking initially the MTIOCTOP code would be too specific
to add to shred, but searching a bit more it seems generic
enough to be useful. The code looks good.

thanks!
Pádraig.
This bug report was last modified 11 years and 44 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.