Subject: bug#17141: closed (Re: bug#17141: [PATCH] tests: fix t2310-dos-extended-2-sector-min-offset.sh)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 18 Apr 2014 17:39:02 +0000

Your bug report

#17141: [PATCH] tests: fix t2310-dos-extended-2-sector-min-offset.sh

which was filed against the parted package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
17141: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17141
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#17141: [PATCH] tests: fix t2310-dos-extended-2-sector-min-offset.sh
From: Phillip Susi <[email-masked]>
To: "Brian C. Lane" <[email-masked]>
Cc: [email-masked]
Date: Fri, 18 Apr 2014 13:38:03 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

On 04/17/2014 06:14 PM, Brian C. Lane wrote:
> On Sat, Mar 29, 2014 at 04:31:39PM -0400, Phillip Susi wrote:
>> This test was ignoring the requested sector size and always
>> using 512 bytes per sector.  Fix it to use the requested sector
>> size. --- tests/t2310-dos-extended-2-sector-min-offset.sh | 9
>> +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
> 
> Ack

pushed.

Subject: [PATCH] tests: fix t2310-dos-extended-2-sector-min-offset.sh
From: Phillip Susi <[email-masked]>
To: [email-masked]
Date: Sat, 29 Mar 2014 16:31:39 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

This test was ignoring the requested sector size and always using
512 bytes per sector.  Fix it to use the requested sector size.
---
 tests/t2310-dos-extended-2-sector-min-offset.sh | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/tests/t2310-dos-extended-2-sector-min-offset.sh b/tests/t2310-dos-extended-2-sector-min-offset.sh
index f74cba5..53843ab 100644
--- a/tests/t2310-dos-extended-2-sector-min-offset.sh
+++ b/tests/t2310-dos-extended-2-sector-min-offset.sh
@@ -23,7 +23,8 @@ require_root_
 require_scsi_debug_module_
 
 # create memory-backed device
-scsi_debug_setup_ dev_size_mb=1 > dev-name ||
+ss=$sector_size_
+scsi_debug_setup_ sector_size=$ss dev_size_mb=1 > dev-name ||
   skip_ 'failed to create scsi_debug device'
 scsi_dev=$(cat dev-name)
 p1=${scsi_dev}1
@@ -31,15 +32,11 @@ p5=${scsi_dev}5
 
 cat <<EOF > exp || framework_failure
 BYT;
-$scsi_dev:2048s:scsi:512:512:msdos:Linux scsi_debug:;
+$scsi_dev:$((2048*512/$ss))s:scsi:$ss:$ss:msdos:Linux scsi_debug:;
 1:64s:128s:65s:::lba;
 5:65s:128s:64s:::;
 EOF
 
-cat <<EOF > err.exp || framework_failure
-Error: Partition(s) 5 on $scsi_dev have been written, but we have been unable to inform the kernel of the change, probably because it/they are in use.  As a result, the old partition(s) will remain in use.  You should reboot now before making further changes.
-EOF
-
 # Create a DOS label with an extended partition starting at sector 64.
 parted -s $scsi_dev mklabel msdos || fail=1
 parted --align=min -s $scsi_dev mkpart extended 64s 128s> out 2>&1 || fail=1
-- 
1.8.3.2