From unknown Sat Jun 14 19:45:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17141: [PATCH] tests: fix t2310-dos-extended-2-sector-min-offset.sh Resent-From: Phillip Susi Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Sat, 29 Mar 2014 20:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17141 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: 17141@debbugs.gnu.org X-Debbugs-Original-To: bug-parted@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.139612512924188 (code B ref -1); Sat, 29 Mar 2014 20:33:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 Mar 2014 20:32:09 +0000 Received: from localhost ([127.0.0.1]:56468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WTzvE-0006I3-Vu for submit@debbugs.gnu.org; Sat, 29 Mar 2014 16:32:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58919) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WTzvB-0006Ht-Gx for submit@debbugs.gnu.org; Sat, 29 Mar 2014 16:32:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTzv2-00047h-WA for submit@debbugs.gnu.org; Sat, 29 Mar 2014 16:32:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59854) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTzv2-00047d-TJ for submit@debbugs.gnu.org; Sat, 29 Mar 2014 16:31:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTzuw-0005oT-5n for bug-parted@gnu.org; Sat, 29 Mar 2014 16:31:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTzun-00043L-B0 for bug-parted@gnu.org; Sat, 29 Mar 2014 16:31:50 -0400 Received: from cdptpa-omtalb.mail.rr.com ([75.180.132.120]:61662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTzun-00042v-71 for bug-parted@gnu.org; Sat, 29 Mar 2014 16:31:41 -0400 X-Authority-Analysis: v=2.0 cv=H69ZMpki c=1 sm=0 a=S/gQ7PeTrZbCJAhh99lbaw==:17 a=O3OjK-w2qkwA:10 a=S1A5HrydsesA:10 a=ossw24rp0ecA:10 a=fxJcL_dCAAAA:8 a=KGjhK52YXX0A:10 a=9yqjtvvEwimE6CDegYQA:9 a=S/gQ7PeTrZbCJAhh99lbaw==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 72.238.67.160 Received: from [72.238.67.160] ([72.238.67.160:47772] helo=faldara.cfl.rr.com) by cdptpa-oedge04.mail.rr.com (envelope-from ) (ecelerity 2.2.3.46 r()) with ESMTP id 43/4A-11872-9AD27335; Sat, 29 Mar 2014 20:31:37 +0000 From: Phillip Susi Date: Sat, 29 Mar 2014 16:31:39 -0400 Message-Id: <1396125099-25101-1-git-send-email-psusi@ubuntu.com> X-Mailer: git-send-email 1.8.3.2 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This test was ignoring the requested sector size and always using 512 bytes per sector. Fix it to use the requested sector size. --- tests/t2310-dos-extended-2-sector-min-offset.sh | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tests/t2310-dos-extended-2-sector-min-offset.sh b/tests/t2310-dos-extended-2-sector-min-offset.sh index f74cba5..53843ab 100644 --- a/tests/t2310-dos-extended-2-sector-min-offset.sh +++ b/tests/t2310-dos-extended-2-sector-min-offset.sh @@ -23,7 +23,8 @@ require_root_ require_scsi_debug_module_ # create memory-backed device -scsi_debug_setup_ dev_size_mb=1 > dev-name || +ss=$sector_size_ +scsi_debug_setup_ sector_size=$ss dev_size_mb=1 > dev-name || skip_ 'failed to create scsi_debug device' scsi_dev=$(cat dev-name) p1=${scsi_dev}1 @@ -31,15 +32,11 @@ p5=${scsi_dev}5 cat < exp || framework_failure BYT; -$scsi_dev:2048s:scsi:512:512:msdos:Linux scsi_debug:; +$scsi_dev:$((2048*512/$ss))s:scsi:$ss:$ss:msdos:Linux scsi_debug:; 1:64s:128s:65s:::lba; 5:65s:128s:64s:::; EOF -cat < err.exp || framework_failure -Error: Partition(s) 5 on $scsi_dev have been written, but we have been unable to inform the kernel of the change, probably because it/they are in use. As a result, the old partition(s) will remain in use. You should reboot now before making further changes. -EOF - # Create a DOS label with an extended partition starting at sector 64. parted -s $scsi_dev mklabel msdos || fail=1 parted --align=min -s $scsi_dev mkpart extended 64s 128s> out 2>&1 || fail=1 -- 1.8.3.2 From unknown Sat Jun 14 19:45:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17141: [PATCH] tests: fix t2310-dos-extended-2-sector-min-offset.sh Resent-From: "Brian C. Lane" Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Thu, 17 Apr 2014 22:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17141 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: Phillip Susi Cc: 17141@debbugs.gnu.org Received: via spool by 17141-submit@debbugs.gnu.org id=B17141.139777286714545 (code B ref 17141); Thu, 17 Apr 2014 22:15:03 +0000 Received: (at 17141) by debbugs.gnu.org; 17 Apr 2014 22:14:27 +0000 Received: from localhost ([127.0.0.1]:51371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WauZe-0003mX-J8 for submit@debbugs.gnu.org; Thu, 17 Apr 2014 18:14:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7837) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WauZc-0003mM-1h for 17141@debbugs.gnu.org; Thu, 17 Apr 2014 18:14:24 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3HMENxR015230 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 17 Apr 2014 18:14:23 -0400 Received: from lister.brianlane.com (ovpn-113-59.phx2.redhat.com [10.3.113.59]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s3HMELkO018206 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Thu, 17 Apr 2014 18:14:23 -0400 Date: Thu, 17 Apr 2014 15:14:21 -0700 From: "Brian C. Lane" Message-ID: <20140417221421.GY10077@lister.brianlane.com> References: <1396125099-25101-1-git-send-email-psusi@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1396125099-25101-1-git-send-email-psusi@ubuntu.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-Spam-Score: -5.7 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) On Sat, Mar 29, 2014 at 04:31:39PM -0400, Phillip Susi wrote: > This test was ignoring the requested sector size and always using > 512 bytes per sector. Fix it to use the requested sector size. > --- > tests/t2310-dos-extended-2-sector-min-offset.sh | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) Ack -- Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT) From unknown Sat Jun 14 19:45:07 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Phillip Susi Subject: bug#17141: closed (Re: bug#17141: [PATCH] tests: fix t2310-dos-extended-2-sector-min-offset.sh) Message-ID: References: <535162FB.1010109@ubuntu.com> <1396125099-25101-1-git-send-email-psusi@ubuntu.com> X-Gnu-PR-Message: they-closed 17141 X-Gnu-PR-Package: parted X-Gnu-PR-Keywords: patch Reply-To: 17141@debbugs.gnu.org Date: Fri, 18 Apr 2014 17:39:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1397842742-27298-1" This is a multi-part message in MIME format... ------------=_1397842742-27298-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #17141: [PATCH] tests: fix t2310-dos-extended-2-sector-min-offset.sh which was filed against the parted package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 17141@debbugs.gnu.org. --=20 17141: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D17141 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1397842742-27298-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 17141-done) by debbugs.gnu.org; 18 Apr 2014 17:38:11 +0000 Received: from localhost ([127.0.0.1]:52134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WbCjr-000755-An for submit@debbugs.gnu.org; Fri, 18 Apr 2014 13:38:11 -0400 Received: from cdptpa-omtalb.mail.rr.com ([75.180.132.120]:62810) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WbCjp-00074h-8A for 17141-done@debbugs.gnu.org; Fri, 18 Apr 2014 13:38:09 -0400 X-Authority-Analysis: v=2.0 cv=GbyVbHrL c=1 sm=0 a=S/gQ7PeTrZbCJAhh99lbaw==:17 a=3C7RHhrQF8gA:10 a=bsFVFVl7vPwA:10 a=S1A5HrydsesA:10 a=ossw24rp0ecA:10 a=8nJEP1OIZ-IA:10 a=fxJcL_dCAAAA:8 a=KGjhK52YXX0A:10 a=QfKxxUxMAAAA:8 a=PF8MMxsYAAAA:8 a=-teQe7WM6XagimxDlKIA:9 a=wPNLvfGTeEIA:10 a=EqEPdlMN9GIA:10 a=S/gQ7PeTrZbCJAhh99lbaw==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 72.238.67.160 Received: from [72.238.67.160] ([72.238.67.160:48498] helo=[192.168.1.101]) by cdptpa-oedge02.mail.rr.com (envelope-from ) (ecelerity 2.2.3.46 r()) with ESMTP id F2/EA-00765-8F261535; Fri, 18 Apr 2014 17:38:01 +0000 Message-ID: <535162FB.1010109@ubuntu.com> Date: Fri, 18 Apr 2014 13:38:03 -0400 From: Phillip Susi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: "Brian C. Lane" Subject: Re: bug#17141: [PATCH] tests: fix t2310-dos-extended-2-sector-min-offset.sh References: <1396125099-25101-1-git-send-email-psusi@ubuntu.com> <20140417221421.GY10077@lister.brianlane.com> In-Reply-To: <20140417221421.GY10077@lister.brianlane.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17141-done Cc: 17141-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 04/17/2014 06:14 PM, Brian C. Lane wrote: > On Sat, Mar 29, 2014 at 04:31:39PM -0400, Phillip Susi wrote: >> This test was ignoring the requested sector size and always >> using 512 bytes per sector. Fix it to use the requested sector >> size. --- tests/t2310-dos-extended-2-sector-min-offset.sh | 9 >> +++------ 1 file changed, 3 insertions(+), 6 deletions(-) > > Ack pushed. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCgAGBQJTUWL7AAoJEI5FoCIzSKrwFXUH/3qLC0qO8/3g2yvyCzw1w+5x q79lHFg+XwwTYEHj3erbMFbuk0ofiu/w1o7R/qN16yjRZMe3NM9qw0AoGLlJ2e2H pSmyCST1dLgslRneQCb7/WlF0SWR0K64GmEyjeUsfnx5/TKO/GUdIbBdkFl5A7gs Y2hqkCwTru9l4nJPvHPRpW6lm0ixnRTla6LwPHyewM7v1KJqCTSwzF9VZNFWMSud YzuvYmTKhPIyE6JSfbsxyWXsFHzmT1mmIE6+mXpTaK1BFZLRFrZnjZ5a4zjpkIcm Mf3NCKDtJSxQaI2cCNtbkPaUw2CUYstvrvDo+zoMdbNKd+iJMmmoZ8lbNClO6Ms= =09gT -----END PGP SIGNATURE----- ------------=_1397842742-27298-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 29 Mar 2014 20:32:09 +0000 Received: from localhost ([127.0.0.1]:56468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WTzvE-0006I3-Vu for submit@debbugs.gnu.org; Sat, 29 Mar 2014 16:32:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58919) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WTzvB-0006Ht-Gx for submit@debbugs.gnu.org; Sat, 29 Mar 2014 16:32:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTzv2-00047h-WA for submit@debbugs.gnu.org; Sat, 29 Mar 2014 16:32:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59854) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTzv2-00047d-TJ for submit@debbugs.gnu.org; Sat, 29 Mar 2014 16:31:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTzuw-0005oT-5n for bug-parted@gnu.org; Sat, 29 Mar 2014 16:31:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTzun-00043L-B0 for bug-parted@gnu.org; Sat, 29 Mar 2014 16:31:50 -0400 Received: from cdptpa-omtalb.mail.rr.com ([75.180.132.120]:61662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTzun-00042v-71 for bug-parted@gnu.org; Sat, 29 Mar 2014 16:31:41 -0400 X-Authority-Analysis: v=2.0 cv=H69ZMpki c=1 sm=0 a=S/gQ7PeTrZbCJAhh99lbaw==:17 a=O3OjK-w2qkwA:10 a=S1A5HrydsesA:10 a=ossw24rp0ecA:10 a=fxJcL_dCAAAA:8 a=KGjhK52YXX0A:10 a=9yqjtvvEwimE6CDegYQA:9 a=S/gQ7PeTrZbCJAhh99lbaw==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 72.238.67.160 Received: from [72.238.67.160] ([72.238.67.160:47772] helo=faldara.cfl.rr.com) by cdptpa-oedge04.mail.rr.com (envelope-from ) (ecelerity 2.2.3.46 r()) with ESMTP id 43/4A-11872-9AD27335; Sat, 29 Mar 2014 20:31:37 +0000 From: Phillip Susi To: bug-parted@gnu.org Subject: [PATCH] tests: fix t2310-dos-extended-2-sector-min-offset.sh Date: Sat, 29 Mar 2014 16:31:39 -0400 Message-Id: <1396125099-25101-1-git-send-email-psusi@ubuntu.com> X-Mailer: git-send-email 1.8.3.2 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This test was ignoring the requested sector size and always using 512 bytes per sector. Fix it to use the requested sector size. --- tests/t2310-dos-extended-2-sector-min-offset.sh | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tests/t2310-dos-extended-2-sector-min-offset.sh b/tests/t2310-dos-extended-2-sector-min-offset.sh index f74cba5..53843ab 100644 --- a/tests/t2310-dos-extended-2-sector-min-offset.sh +++ b/tests/t2310-dos-extended-2-sector-min-offset.sh @@ -23,7 +23,8 @@ require_root_ require_scsi_debug_module_ # create memory-backed device -scsi_debug_setup_ dev_size_mb=1 > dev-name || +ss=$sector_size_ +scsi_debug_setup_ sector_size=$ss dev_size_mb=1 > dev-name || skip_ 'failed to create scsi_debug device' scsi_dev=$(cat dev-name) p1=${scsi_dev}1 @@ -31,15 +32,11 @@ p5=${scsi_dev}5 cat < exp || framework_failure BYT; -$scsi_dev:2048s:scsi:512:512:msdos:Linux scsi_debug:; +$scsi_dev:$((2048*512/$ss))s:scsi:$ss:$ss:msdos:Linux scsi_debug:; 1:64s:128s:65s:::lba; 5:65s:128s:64s:::; EOF -cat < err.exp || framework_failure -Error: Partition(s) 5 on $scsi_dev have been written, but we have been unable to inform the kernel of the change, probably because it/they are in use. As a result, the old partition(s) will remain in use. You should reboot now before making further changes. -EOF - # Create a DOS label with an extended partition starting at sector 64. parted -s $scsi_dev mklabel msdos || fail=1 parted --align=min -s $scsi_dev mkpart extended 64s 128s> out 2>&1 || fail=1 -- 1.8.3.2 ------------=_1397842742-27298-1--