GNU bug report logs - #17136
[PATCH] dfa: speed up memory allocation, port to IRIX

Previous Next

Full log

Message #43 received at 17136 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: 17136 <17136 <at> debbugs.gnu.org>, Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 17136-done <17136-done <at> debbugs.gnu.org>
Subject: Re: bug#17136: [PATCH] dfa: speed up memory allocation, port to IRIX
Date: Thu, 24 Apr 2014 09:22:38 -0700

[Message part 1 (text/plain, inline)]

On Thu, Apr 17, 2014 at 10:59 PM, Paul Eggert <eggert <at> cs.ucla.edu> wrote:
> I merged that patch into the grep trunk and am closing this bug report.
> While merging, I removed one part of the patch that had a small but
> measurable performance degradation, namely, the introduction of struct
> dfatab.  I found some other minor simplifications and threw them in. There
> seems to be no significant change in CPU performance.  The patch's causes
> the dfa module's text size to shrink by 8% on my platform (x86-64 Fedora
> 20), which I suppose is a small win, but the main point of the patch is
> simplifying the source.  I'm attaching what I installed, broken into 12
> little patches to ease review.

Running the tests with ASAN-enabled grep exposed a buffer overrun
that was introduced by the "simplify range char allocation" one.
I've fixed it with the attached patch:

[k.txt (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.