GNU bug report logs - #17136
[PATCH] dfa: speed up memory allocation, port to IRIX

Previous Next

Package: grep;

Reported by: Paul Eggert <eggert <at> cs.ucla.edu>

Date: Sat, 29 Mar 2014 01:30:03 UTC

Severity: normal

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Jim Meyering <jim <at> meyering.net>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: Norihiro Tanaka <noritnk <at> kcn.ne.jp>, 17136 <at> debbugs.gnu.org
Subject: bug#17136: [PATCH] dfa: speed up memory allocation, port to IRIX
Date: Sat, 19 Apr 2014 14:21:45 -0700
[Message part 1 (text/plain, inline)]
On Fri, Apr 18, 2014 at 11:22 PM, Paul Eggert <eggert <at> cs.ucla.edu> wrote:
> Norihiro Tanaka wrote:
>>
>> Perhaps, I may run accross it in order to use old GCC (4.1.2 on CentOS
>> 5.10).
>
>
> Thanks, it's lucky you did, so that we won't be inundated by other people
> reporting similar problems.  I see now that we were passing
> -Wno-pointer-sign to GCC, and that this suppressed useful diagnostics on
> newer GCC instances (but not on your older one).  I installed the attached
> patch to fix both the signedness problem, and the diagnostic-suppression
> problem.

This has encouraged me to revisit grep's list of disabled gcc warnings.
It turns out that we've been disabling many unnecessarily.
The attached patch reenables those that do not elicit a warning
from gcc-4.9.
[k.txt (text/plain, attachment)]

This bug report was last modified 11 years and 30 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.