GNU bug report logs - #17127
`call-process' circumvents password concealment w/ `read-passwd'

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Nathan Trapuzzano <nbtrap <at> nbtrap.com>, 17127 <at> debbugs.gnu.org
Subject: bug#17127: `call-process' circumvents password concealment w/ `read-passwd'
Date: Thu, 24 Oct 2019 13:49:21 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> The following patch fixes this, I think, by using post-command-hook
>> instead of after-change-functions.
>
> Actually, in theory after-change-functions should catch all cases
> whereas post-command-hook might miss some (i.e. chars inserted not
> while running a command, e.g. from a process filter).
>
> So while your new code probably works fine in practice (and is a good
> workaround for now) , I think the original code is "more correct" and we
> should try and figure out why it didn't work: how come
> after-change-functions is not run (or not correctly) by call-process?

Yeah, that's a good point.  Data inserted by call-process definitely
changes the buffer, so after-change-functions should be run.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.