GNU bug report logs - #17127
`call-process' circumvents password concealment w/ `read-passwd'

Previous Next

Package: emacs;

Reported by: Nathan Trapuzzano <nbtrap <at> nbtrap.com>

Date: Fri, 28 Mar 2014 00:34:01 UTC

Severity: normal

Tags: fixed

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Nathan Trapuzzano <nbtrap <at> nbtrap.com>, 17127 <at> debbugs.gnu.org
Subject: bug#17127: `call-process' circumvents password concealment w/ `read-passwd'
Date: Wed, 23 Oct 2019 18:01:45 -0400

> The following patch fixes this, I think, by using post-command-hook
> instead of after-change-functions.

Actually, in theory after-change-functions should catch all cases
whereas post-command-hook might miss some (i.e. chars inserted not
while running a command, e.g. from a process filter).

So while your new code probably works fine in practice (and is a good
workaround for now) , I think the original code is "more correct" and we
should try and figure out why it didn't work: how come
after-change-functions is not run (or not correctly) by call-process?


        Stefan
This bug report was last modified 5 years and 216 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.