GNU bug report logs - #17107
[PATCH 2/4] tests: Fix the t0281 test to respond to the backup GPT location question

Previous Next

To reply to this bug, email your comments to 17107 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Brian C. Lane" <bcl <at> redhat.com>
To: bug-parted <at> gnu.org
Subject: [PATCH 2/4] tests: Fix the t0281 test to respond to the backup GPT
 location question
Date: Wed, 26 Mar 2014 10:56:20 -0700

This fixes the test so that it will fix the backup GPT location as well
as expand move the LastUsableLBA to cover the larger disk.

* tests/t0281-gpt-grow.sh: Add backup GPT prompt
---
 tests/t0281-gpt-grow.sh | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/t0281-gpt-grow.sh b/tests/t0281-gpt-grow.sh
index e373578..44a743b 100644
--- a/tests/t0281-gpt-grow.sh
+++ b/tests/t0281-gpt-grow.sh
@@ -53,6 +53,7 @@ mv out o2 && sed -e "s,/.*/$dev,DEVICE,;s,
   *
,,g;s, $,," \
 
 # check for expected diagnostic
 cat <<EOF > exp || fail=1
+Error: The backup GPT table is not at the end of the disk, as it should be.  Fix, by moving the backup to the end (and removing the old backup)?
 Warning: Not all of the space available to DEVICE appears to be used, you can fix the GPT to use all of the space (an extra 500 blocks) or continue with the current setting?
 Model:  (file)
 Disk DEVICE: 2816kB
@@ -66,7 +67,7 @@ EOF
 compare exp out || fail=1
 
 # now we fix
-printf 'f\n' | parted ---pretend-input-tty $dev print > out 2>&1 || fail=1
+printf 'f\nf\n' | parted ---pretend-input-tty $dev print > out 2>&1 || fail=1
 
 # Transform the actual output, to avoid spurious differences when
 # $PWD contains a symlink-to-dir.  Also, remove the ^M      ...^M bogosity.
@@ -76,6 +77,8 @@ mv out o2 && sed -e "s,/.*/$dev,DEVICE,;s,
   *
,,g;s, $,," \
 
 # check for expected diagnostic
 cat <<EOF > exp || fail=1
+Error: The backup GPT table is not at the end of the disk, as it should be.  Fix, by moving the backup to the end (and removing the old backup)?
+Fix/Ignore? f
 Warning: Not all of the space available to DEVICE appears to be used, you can fix the GPT to use all of the space (an extra 500 blocks) or continue with the current setting?
 Fix/Ignore? f
 Model:  (file)
-- 
1.8.5.3

Message #8 received at 17107 <at> debbugs.gnu.org (full text, mbox):

From: Phillip Susi <psusi <at> ubuntu.com>
To: "Brian C. Lane" <bcl <at> redhat.com>, 17107 <at> debbugs.gnu.org
Subject: Re: bug#17107: [PATCH 2/4] tests: Fix the t0281 test to respond to
 the backup GPT location question
Date: Wed, 26 Mar 2014 22:28:00 -0400

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 03/26/2014 01:56 PM, Brian C. Lane wrote:
> This fixes the test so that it will fix the backup GPT location as
> well as expand move the LastUsableLBA to cover the larger disk.
> 
> * tests/t0281-gpt-grow.sh: Add backup GPT prompt

This test doesn't currently fail for me.  Perhaps this is a regression
resulting from your first patch in this series?


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCgAGBQJTM4ywAAoJEI5FoCIzSKrw90AH/0WICnLNxsa5qQRfaFdBXHnE
z3Wutv32O9FzDa1YqkgbiwbOvR6Kgf5FXu777glQVKgxUtIpi7ewwpzwzAIZtykR
98F18/PMcMcv07aelb6d9O+nXDM/0/jujopx4vaWtiQlUbs6cmghhZAevryMWN/m
8uKmc/DR7KA7Osk5/6239xGdCV9iei/CtANT45//NH+DU8lxyCTgrYoSyeIzi208
IdSrwSKLa3qilIEhQNE1lQdr0VbwuYGLp1G1BLN4LXHz6bofTpOPU5e46VBvOA3w
8r5EM56+6SOMRQMehe7qA1+hhE5mOYnFXglrz75eYq2RwyZDBm2cuauRNu9KxkI=
=nhpx
-----END PGP SIGNATURE-----

Message #11 received at 17107 <at> debbugs.gnu.org (full text, mbox):

From: "Brian C. Lane" <bcl <at> redhat.com>
To: Phillip Susi <psusi <at> ubuntu.com>
Cc: 17107 <at> debbugs.gnu.org
Subject: Re: bug#17107: [PATCH 2/4] tests: Fix the t0281 test to respond to
 the backup GPT location question
Date: Thu, 27 Mar 2014 08:02:43 -0700

On Wed, Mar 26, 2014 at 10:28:00PM -0400, Phillip Susi wrote:
> On 03/26/2014 01:56 PM, Brian C. Lane wrote:
> > This fixes the test so that it will fix the backup GPT location as
> > well as expand move the LastUsableLBA to cover the larger disk.
> > 
> > * tests/t0281-gpt-grow.sh: Add backup GPT prompt
> 
> This test doesn't currently fail for me.  Perhaps this is a regression
> resulting from your first patch in this series?

It is a side-effect of fixing the first thing. You are prompted to fix
the backup and then prompted to expand the amount of disk covered by
First/LastUsableLBA

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.