GNU bug report logs - #17104
[PATCH 3/4] tests: Add emit_superuser_warning for gpt tests

Previous Next

To reply to this bug, email your comments to 17104 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Brian C. Lane" <bcl <at> redhat.com>
To: bug-parted <at> gnu.org
Subject: [PATCH 3/4] tests: Add emit_superuser_warning for gpt tests
Date: Wed, 26 Mar 2014 10:56:21 -0700

---
 tests/t0281-gpt-grow.sh           | 3 ++-
 tests/t0282-gpt-move-backup.sh    | 3 ++-
 tests/t0283-overlap-partitions.sh | 6 ++++--
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/tests/t0281-gpt-grow.sh b/tests/t0281-gpt-grow.sh
index 44a743b..ff36b79 100644
--- a/tests/t0281-gpt-grow.sh
+++ b/tests/t0281-gpt-grow.sh
@@ -76,7 +76,8 @@ mv out o2 && sed -e "s,/.*/$dev,DEVICE,;s,
   *
,,g;s, $,," \
                       -e "s,^.*/lt-parted: ,parted: ," o2 > out
 
 # check for expected diagnostic
-cat <<EOF > exp || fail=1
+emit_superuser_warning > exp || fail=1
+cat <<EOF >> exp || fail=1
 Error: The backup GPT table is not at the end of the disk, as it should be.  Fix, by moving the backup to the end (and removing the old backup)?
 Fix/Ignore? f
 Warning: Not all of the space available to DEVICE appears to be used, you can fix the GPT to use all of the space (an extra 500 blocks) or continue with the current setting?
diff --git a/tests/t0282-gpt-move-backup.sh b/tests/t0282-gpt-move-backup.sh
index 9750ed7..1a296ad 100644
--- a/tests/t0282-gpt-move-backup.sh
+++ b/tests/t0282-gpt-move-backup.sh
@@ -75,7 +75,8 @@ mv out o2 && sed -e "s,/.*/$dev,DEVICE,;s,
   *
,,g;s, $,," \
                       -e "s,^.*/lt-parted: ,parted: ," o2 > out
 
 # check for expected diagnostic
-cat <<EOF > exp || fail=1
+emit_superuser_warning > exp || fail=1
+cat <<EOF >> exp || fail=1
 Error: The backup GPT table is not at the end of the disk, as it should be.  Fix, by moving the backup to the end (and removing the old backup)?
 Fix/Ignore? f
 Model:  (file)
diff --git a/tests/t0283-overlap-partitions.sh b/tests/t0283-overlap-partitions.sh
index 2a53407..c7ae52a 100644
--- a/tests/t0283-overlap-partitions.sh
+++ b/tests/t0283-overlap-partitions.sh
@@ -74,7 +74,8 @@ mv out o2 && sed -e "s,/.*/$dev,DEVICE,;s,
   *
,,g;s, $,," \
                       -e "s,^.*/lt-parted: ,parted: ," -e "s/^GNU Parted .*$/GNU Parted VERSION/" o2 > out
 
 # check for expected output
-cat <<EOF > exp || fail=1
+emit_superuser_warning > exp || fail=1
+cat <<EOF >> exp || fail=1
 GNU Parted VERSION
 Using DEVICE
 Welcome to GNU Parted! Type 'help' to view a list of commands.
@@ -116,7 +117,8 @@ mv out o2 && sed -e "s,/.*/$dev,DEVICE,;s,
   *
,,g;s, $,," \
                       -e "s,^.*/lt-parted: ,parted: ," -e "s/^GNU Parted .*$/GNU Parted VERSION/" o2 > out
 
 # check for expected output
-cat <<EOF > exp || fail=1
+emit_superuser_warning > exp || fail=1
+cat <<EOF >> exp || fail=1
 GNU Parted VERSION
 Using DEVICE
 Welcome to GNU Parted! Type 'help' to view a list of commands.
-- 
1.8.5.3

Message #8 received at 17104 <at> debbugs.gnu.org (full text, mbox):

From: Phillip Susi <psusi <at> ubuntu.com>
To: "Brian C. Lane" <bcl <at> redhat.com>, 17104 <at> debbugs.gnu.org
Subject: Re: bug#17104: [PATCH 3/4] tests: Add emit_superuser_warning for
 gpt tests
Date: Wed, 26 Mar 2014 22:29:38 -0400

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 03/26/2014 01:56 PM, Brian C. Lane wrote:
> --- tests/t0281-gpt-grow.sh           | 3 ++- 
> tests/t0282-gpt-move-backup.sh    | 3 ++- 
> tests/t0283-overlap-partitions.sh | 6 ++++-- 3 files changed, 8
> insertions(+), 4 deletions(-)

There is no log entry for this change, so I don't understand it at all.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCgAGBQJTM40SAAoJEI5FoCIzSKrwsc4IAI6971pgCo8FWQz0gilJR84i
NWRVsED02xje424pCT/a9mzxFsUyWyn/Up1dRj/OfFWF2DfeVmxoOZPZeeCI6tMC
gOnh396tU9Y5uO4LjNz/+XjIGCjoi/COZ4OxUomDrFtl/eOO5+PldXaNYn+3k9nU
X0Q9qIh8OLJzv9DGT6fBd3iP2O62dHWvuomx+mJntqSNNob4mZuF8v3PIcuBTy2c
lUkrkmwpUaZLHbvvt0isQ3u+JMOgbyeWQRPyirxxxr+CliE5hdyZQOnMcsG6lld5
qz/LkejMlZEk7eZm05U5g9PJJnUWN5CDvUwZA2UJ1y+zhkIZ7+CS1ZY1jn1PHHQ=
=TRgk
-----END PGP SIGNATURE-----

Message #11 received at 17104 <at> debbugs.gnu.org (full text, mbox):

From: "Brian C. Lane" <bcl <at> redhat.com>
To: Phillip Susi <psusi <at> ubuntu.com>
Cc: 17104 <at> debbugs.gnu.org
Subject: Re: bug#17104: [PATCH 3/4] tests: Add emit_superuser_warning for gpt
 tests
Date: Thu, 27 Mar 2014 08:03:50 -0700

On Wed, Mar 26, 2014 at 10:29:38PM -0400, Phillip Susi wrote:
> On 03/26/2014 01:56 PM, Brian C. Lane wrote:
> > --- tests/t0281-gpt-grow.sh           | 3 ++- 
> > tests/t0282-gpt-move-backup.sh    | 3 ++- 
> > tests/t0283-overlap-partitions.sh | 6 ++++-- 3 files changed, 8
> > insertions(+), 4 deletions(-)
> 
> There is no log entry for this change, so I don't understand it at all.

When running parted without -s it will emit a warning that you are not
superuser. In Fedora we run tests at buildtime as non-root so we need to
call this whenever not using -s

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

Message #14 received at 17104 <at> debbugs.gnu.org (full text, mbox):

From: Phillip Susi <psusi <at> ubuntu.com>
To: "Brian C. Lane" <bcl <at> redhat.com>
Cc: 17104 <at> debbugs.gnu.org
Subject: Re: bug#17104: [PATCH 3/4] tests: Add emit_superuser_warning for
 gpt tests
Date: Thu, 27 Mar 2014 13:09:52 -0400

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 3/27/2014 11:03 AM, Brian C. Lane wrote:
>> There is no log entry for this change, so I don't understand it
>> at all.
> 
> When running parted without -s it will emit a warning that you are
> not superuser. In Fedora we run tests at buildtime as non-root so
> we need to call this whenever not using -s

Ahh, I see now.  Could you add a log entry and repost?


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTNFtgAAoJEI5FoCIzSKrwiisH/1bJqLyzSH4i8EJNHuRYlucK
yXqxeanTV4h3mg69OZy+4DzlgAIDFbh7KjglMygTEKCJJkeY+ewh43KqMHTnjgv0
TbY1tdFXCSuASSrD/5NJ6aZi6Zl+GfvWfV56/xsZRtcKirutphoFJKnCWV7k+t9y
JlS6MFbr674U6Etvo/wibNU2rL6RFvhGHoSbe6NNUq2HIRAL5vWXdfLJModtaw12
5zQEKA9q8iVWk3HNO/z5SwAdM2FHQeqPjoeaNsTIEbJg7oD10/0b8vdBnwjdejao
2nSlWe9lzqdpsKC0+sJE8yueURm0UMGQEPe2TACk4dQQp9r4EXNs5xsD4xor3Kc=
=h20T
-----END PGP SIGNATURE-----

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.