GNU bug report logs - #17095
[PATCH] grep: proceed the `beg' pointer after exact matched in KWSet

Previous Next

Full log

View this message in rfc822 format

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: Eric Blake <eblake <at> redhat.com>, 17095 <17095 <at> debbugs.gnu.org>
Subject: bug#17095: [PATCH] grep: proceed the `beg' pointer after exact matched in KWSet
Date: Thu, 27 Mar 2014 12:06:36 -0700

[Message part 1 (text/plain, inline)]

On Thu, Mar 27, 2014 at 12:05 PM, Jim Meyering <jim <at> meyering.net> wrote:
> On Thu, Mar 27, 2014 at 5:54 AM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
>> Jim,
>>
>> Thanks, I have added the comments to the patch and have slightly
>> modified the comment you wrote.
>
> Norihiro,
>
> I see you also added a test case.  Thanks for that.  I've amended that
> commit log message with a corresponding ChangeLog entry.
>
> You're right that "beg" must not be advanced, so I have adjusted the
> patch to factor out the call to dfaexec without changing "beg".  I've also
> augmented the first test to require an exact match of the sole input line,
> and changed the other test to require not just a nonzero exit, but $? = 1.

And here's the patch:

[k.txt (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.