GNU bug report logs - #17095
[PATCH] grep: proceed the `beg' pointer after exact matched in KWSet

Previous Next

Package: grep;

Reported by: Norihiro Tanaka <noritnk <at> kcn.ne.jp>

Date: Tue, 25 Mar 2014 22:40:04 UTC

Severity: normal

Tags: patch

Done: Jim Meyering <jim <at> meyering.net>

Bug is archived. No further changes may be made.

Full log

Message #23 received at 17095 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: Eric Blake <eblake <at> redhat.com>, 17095 <at> debbugs.gnu.org
Subject: Re: bug#17095: [PATCH] grep: proceed the `beg' pointer after exact
 matched in KWSet
Date: Wed, 26 Mar 2014 09:05:52 -0700

[Message part 1 (text/plain, inline)]
Norihiro,

Thank you for the patch.  It looks correct, but induces what looks like
unnecessary duplication.  Did you consider the attached variant?

Also, the affected code path seems not to be covered by any test.
Can you construct a test case that exercises this change?

[k.txt (text/plain, attachment)]
This bug report was last modified 11 years and 116 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.