From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 24 12:17:59 2014 Received: (at submit) by debbugs.gnu.org; 24 Mar 2014 16:18:00 +0000 Received: from localhost ([127.0.0.1]:47822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WS7ZX-0006z4-FQ for submit@debbugs.gnu.org; Mon, 24 Mar 2014 12:17:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37481) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WS7ZU-0006yv-Mp for submit@debbugs.gnu.org; Mon, 24 Mar 2014 12:17:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WS7ZL-0007gg-NC for submit@debbugs.gnu.org; Mon, 24 Mar 2014 12:17:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WS7ZL-0007gU-K0 for submit@debbugs.gnu.org; Mon, 24 Mar 2014 12:17:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WS7ZF-0004gs-AM for bug-coreutils@gnu.org; Mon, 24 Mar 2014 12:17:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WS7Z9-0007Uf-Bx for bug-coreutils@gnu.org; Mon, 24 Mar 2014 12:17:41 -0400 Received: from frenzy.freefriends.org ([66.54.153.139]:50562 helo=freefriends.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WS7Z9-0007UK-6d for bug-coreutils@gnu.org; Mon, 24 Mar 2014 12:17:35 -0400 X-Envelope-From: karl@freefriends.org X-Envelope-To: Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.14.8/8.14.8) with ESMTP id s2OGHYRb014385 for ; Mon, 24 Mar 2014 10:17:34 -0600 Received: (from nobody@localhost) by freefriends.org (8.14.8/8.14.8/submit) id s2OGHXDG014380; Mon, 24 Mar 2014 16:17:33 GMT Date: Mon, 24 Mar 2014 16:17:33 GMT Message-Id: <201403241617.s2OGHXDG014380@freefriends.org> X-Authentication-Warning: frenzy.freefriends.org: nobody set sender to karl@freefriends.org using -f From: karl@freefriends.org (Karl Berry) To: bug-coreutils@gnu.org Subject: cp -i/yes gets ignored X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I find it annoying that explicitly answering "y" to an interactive prompt in cp can get ignored: $ touch foo $ chmod 444 foo $ cp -i /etc/issue foo cp: try to overwrite 'foo', overriding mode 0444 (r--r--r--)? y cp: cannot create regular file 'foo': Permission denied It seems to me, in terms of UI, that this is clearly at least as "forceful" (I would say more so) than -f, which does do the overwrite. Also, both mv -i and rm -i already perform their action on a readonly file when told "y"es. So simple consistency is another argument that cp should do the same. Jim told me once that this behavior is specified by POSIX. Hardly surprising. Can we DTRT here by default and reserve the stupid behavior for POSIXLY_CORRECT? Curmudgeonly, Karl From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 24 19:55:14 2014 Received: (at 17087) by debbugs.gnu.org; 24 Mar 2014 23:55:14 +0000 Received: from localhost ([127.0.0.1]:48204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSEi1-0007Zq-J8 for submit@debbugs.gnu.org; Mon, 24 Mar 2014 19:55:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28526) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSEhx-0007ZY-Uz for 17087@debbugs.gnu.org; Mon, 24 Mar 2014 19:55:11 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2ONt5mG018593 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 24 Mar 2014 19:55:05 -0400 Received: from [10.36.116.106] (ovpn-116-106.ams2.redhat.com [10.36.116.106]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s2ONt2BH004199 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 24 Mar 2014 19:55:04 -0400 Message-ID: <5330C5D5.5080805@draigBrady.com> Date: Mon, 24 Mar 2014 23:55:01 +0000 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Karl Berry Subject: Re: bug#17087: cp -i/yes gets ignored References: <201403241617.s2OGHXDG014380@freefriends.org> In-Reply-To: <201403241617.s2OGHXDG014380@freefriends.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 17087 Cc: 17087@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On 03/24/2014 04:17 PM, Karl Berry wrote: > I find it annoying that explicitly answering "y" to an interactive > prompt in cp can get ignored: > > $ touch foo > $ chmod 444 foo > $ cp -i /etc/issue foo > cp: try to overwrite 'foo', overriding mode 0444 (r--r--r--)? y > cp: cannot create regular file 'foo': Permission denied > > It seems to me, in terms of UI, that this is clearly at least as > "forceful" (I would say more so) than -f, which does do the overwrite. > > Also, both mv -i and rm -i already perform their action on a readonly > file when told "y"es. So simple consistency is another argument that cp > should do the same. > > Jim told me once that this behavior is specified by POSIX. Hardly > surprising. Can we DTRT here by default and reserve the stupid behavior > for POSIXLY_CORRECT? > > Curmudgeonly, > Karl I see the apparent redundancy here, though I think it is required. -i prompts whether to overwrite any destination no matter what the mode. Now one might be wondering of the futility of distinguishing the non writeable case, prompting whether to "try to overwrite" the non writeable file. That code has been there "from the beginning" and I'm guessing it's to prompt users to allow them to chmod the file in a separate terminal? Are there other cases where open(O_WRONLY,...) might succeed? If so then it would be incorrect to conflate a 'y' answer here with -f. Even if open(O_WRONLY) would not on the current system if could be dangerous to do generally. thanks, P�draig. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 25 02:26:01 2014 Received: (at 17087) by debbugs.gnu.org; 25 Mar 2014 06:26:01 +0000 Received: from localhost ([127.0.0.1]:48391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSKo9-0002g0-Rm for submit@debbugs.gnu.org; Tue, 25 Mar 2014 02:25:59 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:49388) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSKo3-0002fk-Ko for 17087@debbugs.gnu.org; Tue, 25 Mar 2014 02:25:53 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id BB7A4A60002; Mon, 24 Mar 2014 23:25:50 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6ehuPrAgP5i1; Mon, 24 Mar 2014 23:25:49 -0700 (PDT) Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 4E9FA39E8013; Mon, 24 Mar 2014 23:25:49 -0700 (PDT) Message-ID: <5331216C.5090404@cs.ucla.edu> Date: Mon, 24 Mar 2014 23:25:48 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= , Karl Berry Subject: Re: bug#17087: cp -i/yes gets ignored References: <201403241617.s2OGHXDG014380@freefriends.org> <5330C5D5.5080805@draigBrady.com> In-Reply-To: <5330C5D5.5080805@draigBrady.com> Content-Type: multipart/mixed; boundary="------------050806020306020405000303" X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 17087 Cc: 17087@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) This is a multi-part message in MIME format. --------------050806020306020405000303 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Pádraig Brady wrote: > That code has been there "from the beginning" and I'm guessing it's > to prompt users to allow them to chmod the file in a separate terminal? If we go back far enough (i.e., before commit 6bf3479 dated 2000-08-27), this message was output only if -f was also given. More recently we've seen similar complaints, e.g.: http://lists.gnu.org/archive/html/bug-coreutils/2007-03/msg00130.html At least the diagnostic wording could be improved so that users who are prompted don't get the false impression that the copy will succeed; POSIX clearly allows this. I installed the attached patches (the second is just a code cleanup). Perhaps that's enough. --------------050806020306020405000303 Content-Type: text/plain; charset=UTF-8; name="0001-cp-improve-quality-of-overwrite-prompt.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-cp-improve-quality-of-overwrite-prompt.patch" RnJvbSAxZTBkYjI0Y2ZiNjdhODU0MTYxNjJiZjQ4MjgwMWIyZWFkN2E4ZThmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBNb24sIDI0IE1hciAyMDE0IDIzOjE0OjQzIC0wNzAwClN1YmplY3Q6IFtQQVRD SCAxLzJdIGNwOiBpbXByb3ZlIHF1YWxpdHkgb2Ygb3ZlcndyaXRlIHByb21wdAoKKiBzcmMv Y29weS5jIChvdmVyd3JpdGVfcHJvbXB0KTogTmV3IGFyZyBYLiAgQWxsIGNhbGxlcnMgY2hh bmdlZC4KVXNlIFggdG8gaW1wcm92ZSB0aGUgcXVhbGl0eSBvZiB0aGUgcHJvbXB0IChCdWcj MTcwODcpLgoqIHRlc3RzL212L2ktMi5zaCwgdGVzdHMvbXYvaS0zLnNoOiBDaGFuZ2UgdGVz dCB0byBtYXRjaCBuZXcgcHJvbXB0LgotLS0KIHNyYy9jb3B5LmMgICAgICB8IDEyICsrKysr KysrLS0tLQogdGVzdHMvbXYvaS0yLnNoIHwgIDIgKy0KIHRlc3RzL212L2ktMy5zaCB8ICAy ICstCiAzIGZpbGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvc3JjL2NvcHkuYyBiL3NyYy9jb3B5LmMKaW5kZXggNDk5ODM4Ni4u YmQ0ZGYwNSAxMDA2NDQKLS0tIGEvc3JjL2NvcHkuYworKysgYi9zcmMvY29weS5jCkBAIC0x NTY2LDcgKzE1NjYsOCBAQCB3cml0YWJsZV9kZXN0aW5hdGlvbiAoY2hhciBjb25zdCAqZmls ZSwgbW9kZV90IG1vZGUpCiB9CiAKIHN0YXRpYyB2b2lkCi1vdmVyd3JpdGVfcHJvbXB0IChj aGFyIGNvbnN0ICpkc3RfbmFtZSwgc3RydWN0IHN0YXQgY29uc3QgKmRzdF9zYikKK292ZXJ3 cml0ZV9wcm9tcHQgKHN0cnVjdCBjcF9vcHRpb25zIGNvbnN0ICp4LCBjaGFyIGNvbnN0ICpk c3RfbmFtZSwKKyAgICAgICAgICAgICAgICAgIHN0cnVjdCBzdGF0IGNvbnN0ICpkc3Rfc2Ip CiB7CiAgIGlmICghIHdyaXRhYmxlX2Rlc3RpbmF0aW9uIChkc3RfbmFtZSwgZHN0X3NiLT5z dF9tb2RlKSkKICAgICB7CkBAIC0xNTc0LDcgKzE1NzUsMTAgQEAgb3ZlcndyaXRlX3Byb21w dCAoY2hhciBjb25zdCAqZHN0X25hbWUsIHN0cnVjdCBzdGF0IGNvbnN0ICpkc3Rfc2IpCiAg ICAgICBzdHJtb2RlIChkc3Rfc2ItPnN0X21vZGUsIHBlcm1zKTsKICAgICAgIHBlcm1zWzEw XSA9ICdcMCc7CiAgICAgICBmcHJpbnRmIChzdGRlcnIsCi0gICAgICAgICAgICAgICBfKCIl czogdHJ5IHRvIG92ZXJ3cml0ZSAlcywgb3ZlcnJpZGluZyBtb2RlICUwNGxvICglcyk/ICIp LAorICAgICAgICAgICAgICAgXygoeC0+dW5saW5rX2Rlc3RfYmVmb3JlX29wZW5pbmcKKyAg ICAgICAgICAgICAgICAgIHx8IHgtPnVubGlua19kZXN0X2FmdGVyX2ZhaWxlZF9vcGVuKQor ICAgICAgICAgICAgICAgICA/ICIlczogcmVwbGFjZSAlcywgb3ZlcnJpZGluZyBtb2RlICUw NGxvICglcyk/ICIKKyAgICAgICAgICAgICAgICAgOiAiJXM6IHVud3JpdGFibGUgJXMgKG1v ZGUgJTA0bG8sICVzKTsgdHJ5IGFueXdheT8gIiksCiAgICAgICAgICAgICAgICBwcm9ncmFt X25hbWUsIHF1b3RlIChkc3RfbmFtZSksCiAgICAgICAgICAgICAgICAodW5zaWduZWQgbG9u ZyBpbnQpIChkc3Rfc2ItPnN0X21vZGUgJiBDSE1PRF9NT0RFX0JJVFMpLAogICAgICAgICAg ICAgICAgJnBlcm1zWzFdKTsKQEAgLTE2MzgsNyArMTY0Miw3IEBAIGFiYW5kb25fbW92ZSAo Y29uc3Qgc3RydWN0IGNwX29wdGlvbnMgKngsCiAgICAgICAgICAgICAgICB8fCAoeC0+aW50 ZXJhY3RpdmUgPT0gSV9VTlNQRUNJRklFRAogICAgICAgICAgICAgICAgICAgICYmIHgtPnN0 ZGluX3R0eQogICAgICAgICAgICAgICAgICAgICYmICEgd3JpdGFibGVfZGVzdGluYXRpb24g KGRzdF9uYW1lLCBkc3Rfc2ItPnN0X21vZGUpKSkKLSAgICAgICAgICAgICAgJiYgKG92ZXJ3 cml0ZV9wcm9tcHQgKGRzdF9uYW1lLCBkc3Rfc2IpLCAxKQorICAgICAgICAgICAgICAmJiAo b3ZlcndyaXRlX3Byb21wdCAoeCwgZHN0X25hbWUsIGRzdF9zYiksIDEpCiAgICAgICAgICAg ICAgICYmICEgeWVzbm8gKCkpKTsKIH0KIApAQCAtMTkxMyw3ICsxOTE3LDcgQEAgY29weV9p bnRlcm5hbCAoY2hhciBjb25zdCAqc3JjX25hbWUsIGNoYXIgY29uc3QgKmRzdF9uYW1lLAog ICAgICAgICAgICAgICBpZiAoISBTX0lTRElSIChzcmNfbW9kZSkKICAgICAgICAgICAgICAg ICAgICYmICh4LT5pbnRlcmFjdGl2ZSA9PSBJX0FMV0FZU19OTwogICAgICAgICAgICAgICAg ICAgICAgIHx8ICh4LT5pbnRlcmFjdGl2ZSA9PSBJX0FTS19VU0VSCi0gICAgICAgICAgICAg ICAgICAgICAgICAgICYmIChvdmVyd3JpdGVfcHJvbXB0IChkc3RfbmFtZSwgJmRzdF9zYiks IDEpCisgICAgICAgICAgICAgICAgICAgICAgICAgICYmIChvdmVyd3JpdGVfcHJvbXB0ICh4 LCBkc3RfbmFtZSwgJmRzdF9zYiksIDEpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICYm ICEgeWVzbm8gKCkpKSkKICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAg ICAgIH0KZGlmZiAtLWdpdCBhL3Rlc3RzL212L2ktMi5zaCBiL3Rlc3RzL212L2ktMi5zaApp bmRleCA2MmQ2M2FmLi40MjAyYjVjIDEwMDc1NQotLS0gYS90ZXN0cy9tdi9pLTIuc2gKKysr IGIvdGVzdHMvbXYvaS0yLnNoCkBAIC0zNiw3ICszNiw3IEBAIGNwIC1pZiBlIGYgPCB5ID4g b3V0IDI+JjEgfHwgZmFpbD0xCiAKICMgTWFrZSBzdXJlIG91dCBjb250YWlucyB0aGUgcHJv bXB0LgogY2FzZSAiJChjYXQgb3V0KSIgaW4KLSAgImNwOiB0cnkgdG8gb3ZlcndyaXRlICdm Jywgb3ZlcnJpZGluZyBtb2RlIDAwMDAgKC0tLS0tLS0tLSk/IiopIDs7CisgICJjcDogcmVw bGFjZSAnZicsIG92ZXJyaWRpbmcgbW9kZSAwMDAwICgtLS0tLS0tLS0pPyIqKSA7OwogICAq KSBmYWlsPTEgOzsKIGVzYWMKIApkaWZmIC0tZ2l0IGEvdGVzdHMvbXYvaS0zLnNoIGIvdGVz dHMvbXYvaS0zLnNoCmluZGV4IGUwM2RjOTkuLjY5MGFmNzMgMTAwNzU1Ci0tLSBhL3Rlc3Rz L212L2ktMy5zaAorKysgYi90ZXN0cy9tdi9pLTMuc2gKQEAgLTQ2LDcgKzQ2LDcgQEAgY2hl Y2tfb3ZlcndyaXRlX3Byb21wdCgpCiB7CiAgIGxvY2FsIGRlbGF5PSIkMSIKICAgY2FzZSAi JChjYXQgb3V0KSIgaW4KLSAgICAibXY6IHRyeSB0byBvdmVyd3JpdGUgJ2cnLCBvdmVycmlk aW5nIG1vZGUgMDAwMCIqKSA7OworICAgICJtdjogcmVwbGFjZSAnZycsIG92ZXJyaWRpbmcg bW9kZSAwMDAwIiopIDs7CiAgICAgKikgc2xlZXAgJGRlbGF5OyByZXR1cm4gMTs7CiAgIGVz YWMKIH0KLS0gCjEuOC41LjMKCg== --------------050806020306020405000303 Content-Type: text/plain; charset=UTF-8; name="0002-cp-simplify-overwrite-logic.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0002-cp-simplify-overwrite-logic.patch" RnJvbSA2ZmJhYzI1YWY5ZDIyMjdhZjI2MTFhYjMzNjc3ZDYxZTQ5YmU0ZDlhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBNb24sIDI0IE1hciAyMDE0IDIzOjE3OjAyIC0wNzAwClN1YmplY3Q6IFtQQVRD SCAyLzJdIGNwOiBzaW1wbGlmeSBvdmVyd3JpdGUgbG9naWMKCiogc3JjL2NvcHkuYyAob3Zl cndyaXRlX29rKTogUmVuYW1lIGZyb20gb3ZlcndyaXRlX3Byb21wdC4gIEludm9rZQp5ZXNu byBpbnN0ZWFkIG9mIGhhdmluZyB0aGUgY2FsbGVyIGRvIGl0OyB0aGF0J3MgY2xlYW5lci4g IFJldHVybgpib29sLCBub3Qgdm9pZC4gIEFsbCBjYWxsZXJzIGNoYW5nZWQuCi0tLQogc3Jj L2NvcHkuYyB8IDE0ICsrKysrKystLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRp b25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9jb3B5LmMgYi9zcmMv Y29weS5jCmluZGV4IGJkNGRmMDUuLjcxODEzZGMgMTAwNjQ0Ci0tLSBhL3NyYy9jb3B5LmMK KysrIGIvc3JjL2NvcHkuYwpAQCAtMTU2NSw5ICsxNTY1LDkgQEAgd3JpdGFibGVfZGVzdGlu YXRpb24gKGNoYXIgY29uc3QgKmZpbGUsIG1vZGVfdCBtb2RlKQogICAgICAgICAgIHx8IGV1 aWRhY2Nlc3MgKGZpbGUsIFdfT0spID09IDApOwogfQogCi1zdGF0aWMgdm9pZAotb3Zlcndy aXRlX3Byb21wdCAoc3RydWN0IGNwX29wdGlvbnMgY29uc3QgKngsIGNoYXIgY29uc3QgKmRz dF9uYW1lLAotICAgICAgICAgICAgICAgICAgc3RydWN0IHN0YXQgY29uc3QgKmRzdF9zYikK K3N0YXRpYyBib29sCitvdmVyd3JpdGVfb2sgKHN0cnVjdCBjcF9vcHRpb25zIGNvbnN0ICp4 LCBjaGFyIGNvbnN0ICpkc3RfbmFtZSwKKyAgICAgICAgICAgICAgc3RydWN0IHN0YXQgY29u c3QgKmRzdF9zYikKIHsKICAgaWYgKCEgd3JpdGFibGVfZGVzdGluYXRpb24gKGRzdF9uYW1l LCBkc3Rfc2ItPnN0X21vZGUpKQogICAgIHsKQEAgLTE1ODgsNiArMTU4OCw4IEBAIG92ZXJ3 cml0ZV9wcm9tcHQgKHN0cnVjdCBjcF9vcHRpb25zIGNvbnN0ICp4LCBjaGFyIGNvbnN0ICpk c3RfbmFtZSwKICAgICAgIGZwcmludGYgKHN0ZGVyciwgXygiJXM6IG92ZXJ3cml0ZSAlcz8g IiksCiAgICAgICAgICAgICAgICBwcm9ncmFtX25hbWUsIHF1b3RlIChkc3RfbmFtZSkpOwog ICAgIH0KKworICByZXR1cm4geWVzbm8gKCk7CiB9CiAKIC8qIEluaXRpYWxpemUgdGhlIGhh c2ggdGFibGUgaW1wbGVtZW50aW5nIGEgc2V0IG9mIEZfdHJpcGxlIGVudHJpZXMKQEAgLTE2 NDIsOCArMTY0NCw3IEBAIGFiYW5kb25fbW92ZSAoY29uc3Qgc3RydWN0IGNwX29wdGlvbnMg KngsCiAgICAgICAgICAgICAgICB8fCAoeC0+aW50ZXJhY3RpdmUgPT0gSV9VTlNQRUNJRklF RAogICAgICAgICAgICAgICAgICAgICYmIHgtPnN0ZGluX3R0eQogICAgICAgICAgICAgICAg ICAgICYmICEgd3JpdGFibGVfZGVzdGluYXRpb24gKGRzdF9uYW1lLCBkc3Rfc2ItPnN0X21v ZGUpKSkKLSAgICAgICAgICAgICAgJiYgKG92ZXJ3cml0ZV9wcm9tcHQgKHgsIGRzdF9uYW1l LCBkc3Rfc2IpLCAxKQotICAgICAgICAgICAgICAmJiAhIHllc25vICgpKSk7CisgICAgICAg ICAgICAgICYmICEgb3ZlcndyaXRlX29rICh4LCBkc3RfbmFtZSwgZHN0X3NiKSkpOwogfQog CiAvKiBQcmludCAtLXZlcmJvc2Ugb3V0cHV0IG9uIHN0YW5kYXJkIG91dHB1dCwgZS5nLiAn bmV3JyAtPiAnb2xkJy4KQEAgLTE5MTcsOCArMTkxOCw3IEBAIGNvcHlfaW50ZXJuYWwgKGNo YXIgY29uc3QgKnNyY19uYW1lLCBjaGFyIGNvbnN0ICpkc3RfbmFtZSwKICAgICAgICAgICAg ICAgaWYgKCEgU19JU0RJUiAoc3JjX21vZGUpCiAgICAgICAgICAgICAgICAgICAmJiAoeC0+ aW50ZXJhY3RpdmUgPT0gSV9BTFdBWVNfTk8KICAgICAgICAgICAgICAgICAgICAgICB8fCAo eC0+aW50ZXJhY3RpdmUgPT0gSV9BU0tfVVNFUgotICAgICAgICAgICAgICAgICAgICAgICAg ICAmJiAob3ZlcndyaXRlX3Byb21wdCAoeCwgZHN0X25hbWUsICZkc3Rfc2IpLCAxKQotICAg ICAgICAgICAgICAgICAgICAgICAgICAmJiAhIHllc25vICgpKSkpCisgICAgICAgICAgICAg ICAgICAgICAgICAgICYmICEgb3ZlcndyaXRlX29rICh4LCBkc3RfbmFtZSwgJmRzdF9zYikp KSkKICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgICAgIH0KIAotLSAK MS44LjUuMwoK --------------050806020306020405000303-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 25 07:11:48 2014 Received: (at 17087-done) by debbugs.gnu.org; 25 Mar 2014 11:11:48 +0000 Received: from localhost ([127.0.0.1]:48523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSPGm-0002Rq-Cn for submit@debbugs.gnu.org; Tue, 25 Mar 2014 07:11:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64087) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSPGj-0002RZ-O4 for 17087-done@debbugs.gnu.org; Tue, 25 Mar 2014 07:11:46 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2PBBVSC019199 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 25 Mar 2014 07:11:36 -0400 Received: from [10.36.116.86] (ovpn-116-86.ams2.redhat.com [10.36.116.86]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s2PBAK77015185 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Tue, 25 Mar 2014 07:10:21 -0400 Message-ID: <5331641B.5080108@draigBrady.com> Date: Tue, 25 Mar 2014 11:10:19 +0000 From: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Paul Eggert Subject: Re: bug#17087: cp -i/yes gets ignored References: <201403241617.s2OGHXDG014380@freefriends.org> <5330C5D5.5080805@draigBrady.com> <5331216C.5090404@cs.ucla.edu> In-Reply-To: <5331216C.5090404@cs.ucla.edu> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 17087-done Cc: 17087-done@debbugs.gnu.org, Karl Berry X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On 03/25/2014 06:25 AM, Paul Eggert wrote: > Pádraig Brady wrote: >> That code has been there "from the beginning" and I'm guessing it's >> to prompt users to allow them to chmod the file in a separate terminal? > > If we go back far enough (i.e., before commit 6bf3479 dated 2000-08-27), this message was output only if -f was also given. Things have flipped around a bit. Originally no prompts were output at all with --force (which was incorrect). > More recently we've seen similar complaints, e.g.: http://lists.gnu.org/archive/html/bug-coreutils/2007-03/msg00130.html Ah thanks for linking that. > At least the diagnostic wording could be improved so that users who are prompted don't get the false impression that the copy will succeed; POSIX clearly allows this. I installed the attached patches (the second is just a code cleanup). Perhaps that's enough. Looks good. It will need adjustment so that the second string is tagged for translation. I'll apply the following: diff --git a/src/copy.c b/src/copy.c index 71813dc..68b4c5e 100644 --- a/src/copy.c +++ b/src/copy.c @@ -1575,10 +1575,10 @@ overwrite_ok (struct cp_options const *x, char const *dst_name, strmode (dst_sb->st_mode, perms); perms[10] = '\0'; fprintf (stderr, - _((x->unlink_dest_before_opening - || x->unlink_dest_after_failed_open) - ? "%s: replace %s, overriding mode %04lo (%s)? " - : "%s: unwritable %s (mode %04lo, %s); try anyway? "), + (x->unlink_dest_before_opening + || x->unlink_dest_after_failed_open) + ? _("%s: replace %s, overriding mode %04lo (%s)? ") + : _("%s: unwritable %s (mode %04lo, %s); try anyway? "), program_name, quote (dst_name), (unsigned long int) (dst_sb->st_mode & CHMOD_MODE_BITS), &perms[1]); Marking this bug as done. thanks, Pádraig. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 25 16:53:33 2014 Received: (at 17087-done) by debbugs.gnu.org; 25 Mar 2014 20:53:33 +0000 Received: from localhost ([127.0.0.1]:49702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSYLk-0006Xz-QM for submit@debbugs.gnu.org; Tue, 25 Mar 2014 16:53:33 -0400 Received: from frenzy.freefriends.org ([66.54.153.139]:59594 helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSYLi-0006Xr-6K for 17087-done@debbugs.gnu.org; Tue, 25 Mar 2014 16:53:30 -0400 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.14.8/8.14.8) with ESMTP id s2PKrM29004350; Tue, 25 Mar 2014 14:53:22 -0600 Received: (from nobody@localhost) by freefriends.org (8.14.8/8.14.8/submit) id s2PKrLmj004349; Tue, 25 Mar 2014 20:53:21 GMT Date: Tue, 25 Mar 2014 20:53:21 GMT Message-Id: <201403252053.s2PKrLmj004349@freefriends.org> X-Authentication-Warning: frenzy.freefriends.org: nobody set sender to karl@freefriends.org using -f From: karl@freefriends.org (Karl Berry) To: P@draigBrady.com Subject: Re: bug#17087: cp -i/yes gets ignored In-Reply-To: <5331641B.5080108@draigBrady.com> X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 17087-done Cc: eggert@cs.ucla.edu, 17087-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) Well, I concur that the new wording is an improvement in that it reduces expectations, but is it really so impractical to get the behavior that is actually to be desired? I expect the sources are much too advanced for it to be something like "force++;" after getting the "y" response :), but maybe ... something ... ? The current behavior is noticeably frustrating, because it seems so unnecessarily stupid. http://lists.gnu.org/archive/html/bug-coreutils/2007-03/msg00130.html Thus, I also agree with that person's frustration in the other direction, although for me it is the situation that I complained about that comes up far more often -- unnecessarily failing to overwrite writable files, rather than unnecessarily asking about unwritable files. But I'm not volunteering to write a patch, and I know the logic in this area is a maze of twisty little passages, some alike and some different, so ... thanks, k From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 26 09:27:01 2014 Received: (at 17087) by debbugs.gnu.org; 26 Mar 2014 13:27:01 +0000 Received: from localhost ([127.0.0.1]:50174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSnrA-0004fc-2r for submit@debbugs.gnu.org; Wed, 26 Mar 2014 09:27:00 -0400 Received: from moutng.kundenserver.de ([212.227.126.131]:58545) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSnr5-0004fS-Vs for 17087@debbugs.gnu.org; Wed, 26 Mar 2014 09:26:57 -0400 Received: from susi.site (gw.camline.com [62.153.148.194]) by mrelayeu.kundenserver.de (node=mreue006) with ESMTP (Nemesis) id 0Lh0JH-1WpVDv40Jz-00oZqq; Wed, 26 Mar 2014 14:26:45 +0100 Message-ID: <5332D593.8050203@bernhard-voelker.de> Date: Wed, 26 Mar 2014 14:26:43 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Paul Eggert , =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= , Karl Berry Subject: Re: bug#17087: cp -i/yes gets ignored References: <201403241617.s2OGHXDG014380@freefriends.org> <5330C5D5.5080805@draigBrady.com> <5331216C.5090404@cs.ucla.edu> In-Reply-To: <5331216C.5090404@cs.ucla.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:NKgg9M31Hl+RC8L0nqEGt1oXpcBASAkXqGSkMYF8BsE NMGbzxPukyJbvjkZuDijPRHljcEnIvo3EQY2lYn6G1MDsNx8Y6 ENcFrrpM6Zpt4v6VC+FNYiQTT8Lm/+8eFrv993VHqicMg8XVXP g5zitu9iKLGfkiKQvHYWyH84FR2ZlzvGesASuvgRuHC8NWdVDg jVqgZgW1uoGhf1IYD7WIUmre3dauzpkGTzasVg+VuUtyn+TuZO kIympt4W5hQLZ0Ivzd632ozgaQ/7XY3uTQmScuftJjPmP4adXF TBT/PmghgICTD9TrZesjOdHJA+z7LGsj3coO75ijjYMKTneVLa CXplUVqGycdDzKv2ULCek6a+AjJDLCrpYRmi/i1Qh X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 17087 Cc: 17087@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On 03/25/2014 07:25 AM, Paul Eggert wrote: > (the second is just a code cleanup). Oops, that 2nd patch http://git.sv.gnu.org/cgit/coreutils.git/commit/?id=7f669b40 now produces the following check failure: FAIL: tests/mv/i-3 ================== ++ initial_cwd_=/home/berny/coreutils ++ fail=0 +++ testdir_prefix_ +++ printf gt ++ pfx_=gt +++ mktempd_ /home/berny/coreutils gt-i-3.sh.XXXX +++ case $# in +++ destdir_=/home/berny/coreutils +++ template_=gt-i-3.sh.XXXX +++ MAX_TRIES_=4 +++ case $destdir_ in +++ case $template_ in ++++ unset TMPDIR +++ d=/home/berny/coreutils/gt-i-3.sh.gj66 +++ case $d in +++ test -d /home/berny/coreutils/gt-i-3.sh.gj66 ++++ ls -dgo /home/berny/coreutils/gt-i-3.sh.gj66 ++++ tr S - +++ perms='drwx------ 2 4096 Mar 26 14:13 /home/berny/coreutils/gt-i-3.sh.gj66' +++ case $perms in +++ test 0 = 0 +++ echo /home/berny/coreutils/gt-i-3.sh.gj66 +++ return ++ test_dir_=/home/berny/coreutils/gt-i-3.sh.gj66 ++ cd /home/berny/coreutils/gt-i-3.sh.gj66 ++ gl_init_sh_nl_=' ' ++ IFS=' ' ++ for sig_ in 1 2 3 13 15 +++ expr 1 + 128 ++ eval 'trap '\''Exit 129'\'' 1' +++ trap 'Exit 129' 1 ++ for sig_ in 1 2 3 13 15 +++ expr 2 + 128 ++ eval 'trap '\''Exit 130'\'' 2' +++ trap 'Exit 130' 2 ++ for sig_ in 1 2 3 13 15 +++ expr 3 + 128 ++ eval 'trap '\''Exit 131'\'' 3' +++ trap 'Exit 131' 3 ++ for sig_ in 1 2 3 13 15 +++ expr 13 + 128 ++ eval 'trap '\''Exit 141'\'' 13' +++ trap 'Exit 141' 13 ++ for sig_ in 1 2 3 13 15 +++ expr 15 + 128 ++ eval 'trap '\''Exit 143'\'' 15' +++ trap 'Exit 143' 15 ++ trap remove_tmp_ 0 + path_prepend_ ./src + test 1 '!=' 0 + path_dir_=./src + case $path_dir_ in + abs_path_dir_=/home/berny/coreutils/./src + case $abs_path_dir_ in + PATH=/home/berny/coreutils/./src:/home/berny/coreutils/src:/home/berny/bin:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/usr/X11R6/bin:/usr/games:/sbin:/usr/sbin + create_exe_shims_ /home/berny/coreutils/./src + case $EXEEXT in + return 0 + shift + test 0 '!=' 0 + export PATH + print_ver_ mv + test yes = yes + local i + for i in '$*' + env mv --version mv (GNU coreutils) 8.22.45-137a42 Copyright (C) 2014 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Mike Parker, David MacKenzie, and Jim Meyering. + require_controlling_input_terminal_ + tty -s + test -t 0 + test '' = no + skip_if_root_ + uid_is_privileged_ ++ id -u + my_uid=717 + case $my_uid in + return 1 + trap '' TTIN ++ uname -s + test Linux = FreeBSD + touch f g h i + chmod 0 g i + ls /dev/stdin ++ readlink -f /dev/stdin + tty=/dev/pts/1 + test -r /dev/pts/1 + pid=18300 + mv f g + retry_delay_ check_overwrite_prompt .1 7 + local test_func=check_overwrite_prompt + local init_delay=.1 + local max_n_tries=7 + shift 3 + local attempt=1 + local num_sleeps=1 + local time_fail + test 1 -le 7 ++ gawk -v n=1 -v s=.1 'BEGIN { print s * n }' + local delay=0.1 + check_overwrite_prompt 0.1 + local delay=0.1 + case "$(cat out)" in ++ cat out + sleep 0.1 + return 1 + time_fail=1 ++ expr 1 + 1 + attempt=2 ++ expr 1 '*' 2 + num_sleeps=2 + test 2 -le 7 ++ gawk -v n=2 -v s=.1 'BEGIN { print s * n }' + local delay=0.2 + check_overwrite_prompt 0.2 + local delay=0.2 + case "$(cat out)" in ++ cat out + sleep 0.2 + return 1 + time_fail=1 ++ expr 2 + 1 + attempt=3 ++ expr 2 '*' 2 + num_sleeps=4 + test 3 -le 7 ++ gawk -v n=4 -v s=.1 'BEGIN { print s * n }' + local delay=0.4 + check_overwrite_prompt 0.4 + local delay=0.4 + case "$(cat out)" in ++ cat out + sleep 0.4 + return 1 + time_fail=1 ++ expr 3 + 1 + attempt=4 ++ expr 4 '*' 2 + num_sleeps=8 + test 4 -le 7 ++ gawk -v n=8 -v s=.1 'BEGIN { print s * n }' + local delay=0.8 + check_overwrite_prompt 0.8 + local delay=0.8 + case "$(cat out)" in ++ cat out + sleep 0.8 + return 1 + time_fail=1 ++ expr 4 + 1 + attempt=5 ++ expr 8 '*' 2 + num_sleeps=16 + test 5 -le 7 ++ gawk -v n=16 -v s=.1 'BEGIN { print s * n }' + local delay=1.6 + check_overwrite_prompt 1.6 + local delay=1.6 + case "$(cat out)" in ++ cat out + sleep 1.6 + return 1 + time_fail=1 ++ expr 5 + 1 + attempt=6 ++ expr 16 '*' 2 + num_sleeps=32 + test 6 -le 7 ++ gawk -v n=32 -v s=.1 'BEGIN { print s * n }' + local delay=3.2 + check_overwrite_prompt 3.2 + local delay=3.2 + case "$(cat out)" in ++ cat out + sleep 3.2 + return 1 + time_fail=1 ++ expr 6 + 1 + attempt=7 ++ expr 32 '*' 2 + num_sleeps=64 + test 7 -le 7 ++ gawk -v n=64 -v s=.1 'BEGIN { print s * n }' + local delay=6.4 + check_overwrite_prompt 6.4 + local delay=6.4 + case "$(cat out)" in ++ cat out + sleep 6.4 + return 1 + time_fail=1 ++ expr 7 + 1 + attempt=8 ++ expr 64 '*' 2 + num_sleeps=128 + test 8 -le 7 + test 1 = 0 + fail=1 + kill 18300 + mv -f h i + test -f i + test -f h + case "$(cat out)" in ++ cat out + Exit 1 + set +e + exit 1 + exit 1 + remove_tmp_ + __st=1 + cleanup_ + : + cd /home/berny/coreutils + chmod -R u+rwx /home/berny/coreutils/gt-i-3.sh.gj66 + rm -rf /home/berny/coreutils/gt-i-3.sh.gj66 + exit 1 BTW: in check_overwrite_prompt, the file 'out' contains "mv: unwritable 'g' (mode 0000, ---------); try anyway?" Have a nice day, Berny From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 26 10:20:40 2014 Received: (at 17087) by debbugs.gnu.org; 26 Mar 2014 14:20:41 +0000 Received: from localhost ([127.0.0.1]:51002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSoh6-0006FE-EC for submit@debbugs.gnu.org; Wed, 26 Mar 2014 10:20:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25164) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSoh2-0006F1-Iu for 17087@debbugs.gnu.org; Wed, 26 Mar 2014 10:20:37 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2QEKGc8011788 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 26 Mar 2014 10:20:19 -0400 Received: from [10.36.116.32] (ovpn-116-32.ams2.redhat.com [10.36.116.32]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s2QEKEqE028756 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 26 Mar 2014 10:20:15 -0400 Message-ID: <5332E21D.1090109@draigBrady.com> Date: Wed, 26 Mar 2014 14:20:13 +0000 From: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Bernhard Voelker Subject: Re: bug#17087: cp -i/yes gets ignored References: <201403241617.s2OGHXDG014380@freefriends.org> <5330C5D5.5080805@draigBrady.com> <5331216C.5090404@cs.ucla.edu> <5332D593.8050203@bernhard-voelker.de> In-Reply-To: <5332D593.8050203@bernhard-voelker.de> X-Enigmail-Version: 1.6 Content-Type: multipart/mixed; boundary="------------020606070705000208080809" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 17087 Cc: Paul Eggert , 17087@debbugs.gnu.org, Karl Berry X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is a multi-part message in MIME format. --------------020606070705000208080809 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 03/26/2014 01:26 PM, Bernhard Voelker wrote: > On 03/25/2014 07:25 AM, Paul Eggert wrote: >> (the second is just a code cleanup). > > Oops, that 2nd patch > http://git.sv.gnu.org/cgit/coreutils.git/commit/?id=7f669b40 > now produces the following check failure: > > FAIL: tests/mv/i-3 > ================== That's an interesting one. I guess our CI didn't flag this as the test is skipped without a controlling tty: http://hydra.nixos.org/jobset/gnu/coreutils-master Also the test is skipped with a parallel make check! I.E. this first command detects the fail, while the second skips the test: $ make -j2 check TESTS="tests/mv/i-3.sh" $ make -j2 check TESTS="tests/mv/i-2.sh tests/mv/i-3.sh" So to handle both cases I'm updating the "release tasks" list to: setsid make check $(($(nproc) * 2)) # tests without controlling tty make check -j1 # tests with controlling tty > BTW: in check_overwrite_prompt, the file 'out' contains > "mv: unwritable 'g' (mode 0000, ---------); try anyway?" That should have been apparent in the test log immediately, without you having to add debug. In general we should allow these patches a little while for review before pushing. Hopefully the attached fixes up these issues. thanks, Pádraig. --------------020606070705000208080809 Content-Type: text/x-patch; name="mv-prompt-fix.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="mv-prompt-fix.patch" >From 8d7e4222e14f3d967c5b0efc10e34a97f32ae320 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1draig=20Brady?= Date: Wed, 26 Mar 2014 13:36:16 +0000 Subject: [PATCH] mv: fix issues with previous prompt adjustments * src/copy.c (overwrite_ok): Fix the gettext calls so that the second string is tagged for translation. Display the correct "replace ..." prompt when in move_mode. * tests/mv/i-3.sh: Display the output on failure to ease debugging. --- src/copy.c | 8 ++++---- tests/mv/i-3.sh | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/copy.c b/src/copy.c index 71813dc..781cc1e 100644 --- a/src/copy.c +++ b/src/copy.c @@ -1575,10 +1575,10 @@ overwrite_ok (struct cp_options const *x, char const *dst_name, strmode (dst_sb->st_mode, perms); perms[10] = '\0'; fprintf (stderr, - _((x->unlink_dest_before_opening - || x->unlink_dest_after_failed_open) - ? "%s: replace %s, overriding mode %04lo (%s)? " - : "%s: unwritable %s (mode %04lo, %s); try anyway? "), + (x->move_mode || x->unlink_dest_before_opening + || x->unlink_dest_after_failed_open) + ? _("%s: replace %s, overriding mode %04lo (%s)? ") + : _("%s: unwritable %s (mode %04lo, %s); try anyway? "), program_name, quote (dst_name), (unsigned long int) (dst_sb->st_mode & CHMOD_MODE_BITS), &perms[1]); diff --git a/tests/mv/i-3.sh b/tests/mv/i-3.sh index 690af73..8c58d5d 100755 --- a/tests/mv/i-3.sh +++ b/tests/mv/i-3.sh @@ -52,7 +52,7 @@ check_overwrite_prompt() } # Wait for up to 12.7 seconds for the expected prompt. -retry_delay_ check_overwrite_prompt .1 7 || fail=1 +retry_delay_ check_overwrite_prompt .1 7 || { fail=1; cat out; } kill $pid -- 1.7.7.6 --------------020606070705000208080809-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 26 11:30:11 2014 Received: (at 17087) by debbugs.gnu.org; 26 Mar 2014 15:30:11 +0000 Received: from localhost ([127.0.0.1]:51069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSpmL-0008FM-23 for submit@debbugs.gnu.org; Wed, 26 Mar 2014 11:30:10 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:44167) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSpmF-0008Ei-S0 for 17087@debbugs.gnu.org; Wed, 26 Mar 2014 11:30:05 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 50061A60002; Wed, 26 Mar 2014 08:30:02 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KH6dxZ2fW1Ml; Wed, 26 Mar 2014 08:30:01 -0700 (PDT) Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 7B2E239E8011; Wed, 26 Mar 2014 08:30:01 -0700 (PDT) Message-ID: <5332F276.3020403@cs.ucla.edu> Date: Wed, 26 Mar 2014 08:29:58 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= , Bernhard Voelker Subject: Re: bug#17087: cp -i/yes gets ignored References: <201403241617.s2OGHXDG014380@freefriends.org> <5330C5D5.5080805@draigBrady.com> <5331216C.5090404@cs.ucla.edu> <5332D593.8050203@bernhard-voelker.de> <5332E21D.1090109@draigBrady.com> In-Reply-To: <5332E21D.1090109@draigBrady.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 17087 Cc: 17087@debbugs.gnu.org, Karl Berry X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) Pádraig Brady wrote: > In general we should allow these patches a little > while for review before pushing. Perhaps I was a bit enthusiastic here, but still, I don't know, when in doubt I prefer an Emacs-like approach (push early and often and fix as soon as you can) to a glibc-like approach (everything needs review and lots of problems just don't get fixed). If coreutils had used the glibc approach, I wouldn't have bothered to improve cp's diagnostics here, as it would have been too much trouble. Even now, the maintenance procedures of coreutils are enough of a pain, and the code is enough of a tangle, that nobody is following up on Karl's eminently reasonable suggestions to improve cp's behavior in this area. > Hopefully the attached fixes up these issues. Thanks, I pushed it for you. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 26 12:45:59 2014 Received: (at 17087) by debbugs.gnu.org; 26 Mar 2014 16:45:59 +0000 Received: from localhost ([127.0.0.1]:51190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSqxj-00037E-66 for submit@debbugs.gnu.org; Wed, 26 Mar 2014 12:45:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10550) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSqxg-000370-Ce for 17087@debbugs.gnu.org; Wed, 26 Mar 2014 12:45:57 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2QGjcB3012000 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 26 Mar 2014 12:45:39 -0400 Received: from [10.36.116.32] (ovpn-116-32.ams2.redhat.com [10.36.116.32]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s2QGjZ7d025620 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Wed, 26 Mar 2014 12:45:37 -0400 Message-ID: <5333042F.3020201@draigBrady.com> Date: Wed, 26 Mar 2014 16:45:35 +0000 From: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Paul Eggert Subject: Re: bug#17087: cp -i/yes gets ignored References: <201403241617.s2OGHXDG014380@freefriends.org> <5330C5D5.5080805@draigBrady.com> <5331216C.5090404@cs.ucla.edu> <5332D593.8050203@bernhard-voelker.de> <5332E21D.1090109@draigBrady.com> <5332F276.3020403@cs.ucla.edu> In-Reply-To: <5332F276.3020403@cs.ucla.edu> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 17087 Cc: Bernhard Voelker , 17087@debbugs.gnu.org, Karl Berry X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On 03/26/2014 03:29 PM, Paul Eggert wrote: > Pádraig Brady wrote: >> In general we should allow these patches a little >> while for review before pushing. > > Perhaps I was a bit enthusiastic here, but still, I don't know, when in doubt I prefer an Emacs-like approach (push early and often and fix as soon as you can) to a glibc-like approach (everything needs review and lots of problems just don't get fixed). I'm not suggesting everything _needs_ review. I'm just suggesting we might take advantage of review. I.E. we're posting the patches to the list anyway, so just hold off on the submission until a review happens or a few hours pass. git branching makes this trivial to manage, and so there should be no extra process. Ideally more than one person should be looking at the code anyway, and if that happens in a timely enough fashion to be in the commit feedback loop that's even better. > the maintenance procedures of coreutils are enough of a pain Are you referring to GNU coding style, commit message summary format or something else? Is there anything we could make more lightweight here? > and the code is enough of a tangle, that nobody is following up on Karl's eminently reasonable suggestions to improve cp's behavior in this area. So I responded with 2 reasons why we might not make 'y' imply '-f' for unwritable files. I'll think some more about what can be done here, but for me at least code complexity it never a reason for not doing something. The code here isn't that complex, it's the external implications that are confusing and hard to consider (and thus best tracked in tests). thanks, Pádraig. p.s. I use this git alias to sort branches by date: brdate = for-each-ref --sort=-committerdate --format='%(committerdate:iso8601) %(refname:short)' refs/heads/ From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 03:13:40 2014 Received: (at 17087) by debbugs.gnu.org; 27 Mar 2014 07:13:40 +0000 Received: from localhost ([127.0.0.1]:51690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WT4VP-00034x-Oe for submit@debbugs.gnu.org; Thu, 27 Mar 2014 03:13:40 -0400 Received: from moutng.kundenserver.de ([212.227.17.13]:54010) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WT4VL-00034l-Gv for 17087@debbugs.gnu.org; Thu, 27 Mar 2014 03:13:36 -0400 Received: from [192.168.1.11] (p548E75EC.dip0.t-ipconnect.de [84.142.117.236]) by mrelayeu.kundenserver.de (node=mreue102) with ESMTP (Nemesis) id 0LnSZS-1X0U2U3fbS-00hfEU; Thu, 27 Mar 2014 08:13:33 +0100 Message-ID: <5333CF9B.5090204@bernhard-voelker.de> Date: Thu, 27 Mar 2014 08:13:31 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= Subject: Re: bug#17087: cp -i/yes gets ignored References: <201403241617.s2OGHXDG014380@freefriends.org> <5330C5D5.5080805@draigBrady.com> <5331216C.5090404@cs.ucla.edu> <5332D593.8050203@bernhard-voelker.de> <5332E21D.1090109@draigBrady.com> In-Reply-To: <5332E21D.1090109@draigBrady.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:Kh30yfXjMLf5mmw+aCOEzeRexyxJgQx/rMPv0bnnugk +hdVCtJQmF+l2J1xm17SFO4lvewyiCgg8h+EX9uzEy2NPPjaHa hkwkCQDzb7u6RU5Vc2kLGQFg5k42BjG6IYG8ybXGKDLfqw0HHI FDZxpxfI7lwTPocE06llOGWSl3Ga0PIRt+glIbxq109Pm8MxyU y6fQSz8uPQOnSKSxn5DFybA2ix6MWTD6veSzlIpb+viBZiCHf6 kTSWYddj8WJ4DRd/br2g6C/V7TpyM6BiwjIzEcu9pHo7en/iOY fdFYO3ZRXWu38DtUxsVeYYRUeFDhfcf3Ea8DlOGyB+H+Tte2Wk xC0j/x8h349dqZGrapP9ThxDHzY710E+F3FsI5PzS X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 17087 Cc: Paul Eggert , 17087@debbugs.gnu.org, Karl Berry X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On 03/26/2014 03:20 PM, Pádraig Brady wrote: > On 03/26/2014 01:26 PM, Bernhard Voelker wrote: >> FAIL: tests/mv/i-3 >> ================== > > That's an interesting one. I guess our CI didn't flag this > as the test is skipped without a controlling tty: > http://hydra.nixos.org/jobset/gnu/coreutils-master > > Also the test is skipped with a parallel make check! > I.E. this first command detects the fail, while the second skips the test: > $ make -j2 check TESTS="tests/mv/i-3.sh" > $ make -j2 check TESTS="tests/mv/i-2.sh tests/mv/i-3.sh" > > So to handle both cases I'm updating the "release tasks" list to: > setsid make check $(($(nproc) * 2)) # tests without controlling tty > make check -j1 # tests with controlling tty Thanks. What about a ---presume-input-tty option for mv(1) like rm(1) has? > Hopefully the attached fixes up these issues. Yes, thanks! Have a nice day, Berny From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 08:46:47 2014 Received: (at 17087) by debbugs.gnu.org; 27 Mar 2014 12:46:47 +0000 Received: from localhost ([127.0.0.1]:51837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WT9hm-00059S-JL for submit@debbugs.gnu.org; Thu, 27 Mar 2014 08:46:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5044) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WT9hh-00059C-2x for 17087@debbugs.gnu.org; Thu, 27 Mar 2014 08:46:42 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2RCkae7006176 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 27 Mar 2014 08:46:37 -0400 Received: from [10.36.116.70] (ovpn-116-70.ams2.redhat.com [10.36.116.70]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s2RCkYsE004874 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 27 Mar 2014 08:46:36 -0400 Message-ID: <53341DAA.4050304@draigBrady.com> Date: Thu, 27 Mar 2014 12:46:34 +0000 From: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Bernhard Voelker Subject: Re: bug#17087: cp -i/yes gets ignored References: <201403241617.s2OGHXDG014380@freefriends.org> <5330C5D5.5080805@draigBrady.com> <5331216C.5090404@cs.ucla.edu> <5332D593.8050203@bernhard-voelker.de> <5332E21D.1090109@draigBrady.com> <5333CF9B.5090204@bernhard-voelker.de> In-Reply-To: <5333CF9B.5090204@bernhard-voelker.de> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 17087 Cc: 17087@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On 03/27/2014 07:13 AM, Bernhard Voelker wrote: > On 03/26/2014 03:20 PM, Pádraig Brady wrote: >> On 03/26/2014 01:26 PM, Bernhard Voelker wrote: >>> FAIL: tests/mv/i-3 >>> ================== >> >> That's an interesting one. I guess our CI didn't flag this >> as the test is skipped without a controlling tty: >> http://hydra.nixos.org/jobset/gnu/coreutils-master >> >> Also the test is skipped with a parallel make check! >> I.E. this first command detects the fail, while the second skips the test: >> $ make -j2 check TESTS="tests/mv/i-3.sh" >> $ make -j2 check TESTS="tests/mv/i-2.sh tests/mv/i-3.sh" >> >> So to handle both cases I'm updating the "release tasks" list to: >> setsid make check $(($(nproc) * 2)) # tests without controlling tty >> make check -j1 # tests with controlling tty > > Thanks. > What about a ---presume-input-tty option for mv(1) like rm(1) has? Good point, though probably not worth it. There is only 1 mv test dependent on tty while there are 5 rm tests dependent on tty. We should add ---presume-input-tty if we add more tests like that though. thanks, Pádraig. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 14:12:57 2014 Received: (at 17087) by debbugs.gnu.org; 27 Mar 2014 18:12:57 +0000 Received: from localhost ([127.0.0.1]:53089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WTEnR-00009h-G4 for submit@debbugs.gnu.org; Thu, 27 Mar 2014 14:12:57 -0400 Received: from frenzy.freefriends.org ([66.54.153.139]:51772 helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WTEnP-00009Z-Rg for 17087@debbugs.gnu.org; Thu, 27 Mar 2014 14:12:56 -0400 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.14.8/8.14.8) with ESMTP id s2RICsXH012944; Thu, 27 Mar 2014 12:12:54 -0600 Received: (from nobody@localhost) by freefriends.org (8.14.8/8.14.8/submit) id s2RICs4g012943; Thu, 27 Mar 2014 18:12:54 GMT Date: Thu, 27 Mar 2014 18:12:54 GMT Message-Id: <201403271812.s2RICs4g012943@freefriends.org> X-Authentication-Warning: frenzy.freefriends.org: nobody set sender to karl@freefriends.org using -f From: karl@freefriends.org (Karl Berry) To: P@draigBrady.com, 17087@debbugs.gnu.org Subject: Re: bug#17087: cp -i/yes gets ignored In-Reply-To: <5333042F.3020201@draigBrady.com> X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 17087 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) So I responded with 2 reasons why we might not make 'y' imply '-f' for unwritable files. P@, I'm afraid those reasons did not make sense to me. Can you restate? Sorry. To restate my own idea: from my "(not so) naive user"'s point of view, going to the trouble of typing "y RET" is the most forceful expression possible of the desired behavior, namely that I want the darn file to get copied. So, if cp -f would work, I would like answering "y" to work. (And, I believe the other user's request amounts to saying "if cp -f would not work, then don't even bother to ask me". I don't feel strongly about that request. :) code complexity it never a reason for not doing something. I suspect we all agree ... in theory :). Thanks, karl From unknown Wed Jun 18 23:11:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 25 Apr 2014 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator