GNU bug report logs - #17072
dfa change apparently needed on Irix

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#17072: closed (dfa change apparently needed on Irix)
Date: Sun, 06 Apr 2014 18:02:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 06 Apr 2014 11:00:58 -0700
with message-id <5341965A.6050400 <at> cs.ucla.edu>
and subject line Re: bug#17072: dfa change apparently needed on Irix
has caused the debbugs.gnu.org bug report #17072,
regarding dfa change apparently needed on Irix
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
17072: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17072
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Aharon Robbins <arnold <at> skeeve.com>
To: bug-grep <at> gnu.org
Subject: dfa change apparently needed on Irix
Date: Sun, 23 Mar 2014 21:32:21 +0200

FYI

Arnold
-------------------
> Date: Tue, 18 Mar 2014 13:44:57 -0600 (MDT)
> From: "Nelson H. F. Beebe" <beebe <at> math.utah.edu>
> To: "Arnold Robbins" <arnold <at> skeeve.com>
> Cc: beebe <at> math.utah.edu
> Subject: gawk-4.1.0f: a patch for a failed build
>
> On SGI IRIX MIPS, gawk-4.1.0a had built and installed without problems
> on 13-Dec-2013.  
>
> For gawk-4.1.0f, however, I had to make one source code patch:
>
> % diff -c dfa.c.org dfa.c
> *** dfa.c.org   Mon Mar 10 14:39:05 2014
> --- dfa.c       Mon Mar 17 18:04:46 2014
> ***************
> *** 43,49 ****
>   #include "missing_d/gawkbool.h"
>   #endif /* HAVE_STDBOOL_H */
>   
> - #include "dfa.h"
>   
>   /* Gawk doesn't use Gnulib, so don't assume static_assert is present.  */
>   #ifndef static_assert
> --- 43,48 ----
> ***************
> *** 89,94 ****
> --- 88,95 ----
>   
>   #include "xalloc.h"
>   
> + #include "dfa.h"
> + 
>   #ifdef GAWK
>   static int
>   is_blank (int c)
>
> The reason for the patch is this error:
>
> 	dfa.c:956: error: conflicting types for 'case_folded_counterparts'
> 	dfa.h:111: error: previous declaration of 'case_folded_counterparts' was here
> 	dfa.c:956: error: conflicting types for 'case_folded_counterparts'
>
> What happens is that the prototype for that function has wchar_t
> arguments, but between the time that prototype is seen, and the first
> reference to the function is seen, wchar_t has been changed to char.
> Moving the inclusion of "dfa.h" later in "dfa.c" solved the problem.
>
> I configured and built like this:
>
> env CC='gcc -std=c99' CFLAGS=-D_SGI_SOURCE LDFLAGS='-L/usr/local/lib -Wl,-rpath,/usr/local/lib' ./configure && $B/make all check

[Message part 3 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: 17072-done <at> debbugs.gnu.org
Cc: 17157 <at> debbugs.gnu.org, bug-gawk <at> gnu.org,
 "Nelson H. F. Beebe" <beebe <at> math.utah.edu>
Subject: Re: bug#17072: dfa change apparently needed on Irix
Date: Sun, 06 Apr 2014 11:00:58 -0700

[Message part 4 (text/plain, inline)]

Thanks to Nelson H.F. Beebe's machines I've reproduced Bug#17072 on IRIX 
and have verified that the attached gawk patch fixes it.  This patch is 
almost identical to the gawk patch I submitted in 
<http://bugs.gnu.org/17157#44>.  It improves on the earlier patch only 
by changing gawk's dfa.c to look more like grep's dfa.c in one more way: 
include "dfa.h" before all other include files (except config.h).

I'll CC: this to Bug#17157 so that the patch is visible there too.  No 
further change should be needed to grep for this.

[0001-awk-simplify-dfa.c-by-having-it-not-include-mbsuppor.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.