GNU bug report logs - #17070
[PATCH] grep: optimization of DFA by reuse of multi-byte buffers in non-UTF8 locales

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#17070: closed ([PATCH] grep: optimization of DFA by reuse of
 multi-byte buffers in non-UTF8 locales)
Date: Sun, 06 Apr 2014 05:14:04 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 05 Apr 2014 22:12:58 -0700
with message-id <5340E25A.9030301 <at> cs.ucla.edu>
and subject line Re: bug#17070: [PATCH] grep: optimization of DFA by reuse of multi-byte buffers in non-UTF8 locales
has caused the debbugs.gnu.org bug report #17070,
regarding [PATCH] grep: optimization of DFA by reuse of multi-byte buffers in non-UTF8 locales
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
17070: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17070
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: submit <at> debbugs.gnu.org
Subject: [PATCH] grep: optimization of DFA by reuse of multi-byte buffers in
 non-UTF8 locales
Date: Sun, 23 Mar 2014 22:19:36 +0900

[Message part 3 (text/plain, inline)]

Package: grep
Tags: patch

dfaexec() allocates and deallocates many buffers in non-UTF8 locales, but
it's very inefficient.

If put them on struct dfa and reuse them, when use not regex but DFA for
ANYCHAR, it will speed up about 20-30% in non-UTF8 locales.

Norihiro

[patch.txt (text/plain, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: Paolo Bonzini <bonzini <at> gnu.org>, 17070-done <at> debbugs.gnu.org,
 17156 <at> debbugs.gnu.org
Subject: Re: bug#17070: [PATCH] grep: optimization of DFA by reuse of
 multi-byte buffers in non-UTF8 locales
Date: Sat, 05 Apr 2014 22:12:58 -0700

[Message part 6 (text/plain, inline)]

Norihiro Tanaka wrote:
> I rebased this patch, and add a bug fix to it.

Thanks.  Paolo wrote it up in <http://bugs.gnu.org/17156#11>, and I just 
now tweaked its ChangeLog and merged the code and installed it (patch 
attached).  I followed up with minor cleanups (2nd patch attached).

[0001-grep-reuse-multibyte-DFA-buffers-in-non-UTF8-locales.patch (text/plain, attachment)]

[0002-grep-minor-improvements-to-previous-patch.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.