From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 21 08:53:48 2014 Received: (at submit) by debbugs.gnu.org; 21 Mar 2014 12:53:48 +0000 Received: from localhost ([127.0.0.1]:43118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQyxH-0007lk-2a for submit@debbugs.gnu.org; Fri, 21 Mar 2014 08:53:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59971) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQyxE-0007lZ-6k for submit@debbugs.gnu.org; Fri, 21 Mar 2014 08:53:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQyx4-0004wb-CC for submit@debbugs.gnu.org; Fri, 21 Mar 2014 08:53:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=AC_HTML_NONSENSE_TAGS, BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51194) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQyx4-0004wV-94 for submit@debbugs.gnu.org; Fri, 21 Mar 2014 08:53:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQyww-0004GB-PY for bug-gnu-emacs@gnu.org; Fri, 21 Mar 2014 08:53:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQywp-0004uM-CH for bug-gnu-emacs@gnu.org; Fri, 21 Mar 2014 08:53:26 -0400 Received: from mail-ee0-f49.google.com ([74.125.83.49]:33566) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQywp-0004uH-3R for bug-gnu-emacs@gnu.org; Fri, 21 Mar 2014 08:53:19 -0400 Received: by mail-ee0-f49.google.com with SMTP id c41so1754369eek.22 for ; Fri, 21 Mar 2014 05:53:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-type; bh=e5DM4/d+l7hwv8HxzaDaHb8YzkEjRaK3evmS7Ptcyqg=; b=FsLKS5dOOmQl+7yb5xGaRuCTXnBjS/Wlg+xBqSJbnHXViDePckwX09CPCBAt+eERE9 20DILA+EtZcYeRVpL4dnxmCOeMgvcTOPL2i/H3xPSGQalB1IdD9SP0eys+fHNmjCPUmH TLKxNuIi5LXrfg/Rn+94yaqfXLfogcWHz8Fk+GVP/0Fxf7I7O8r8przUOH1eOivak37m RWdmZqIbcrcYQpIBvZ51l3PtMOZemM6qV6kaTO7QyfmJXBo2a2/nothHyryQZmWklh/B oPvYi49Y/8nmOPGk1xhdXp8cnFeWu3hspdy4Q6261pHYWWp6rs9J8lDu5t0DWAUSez1R BCJA== X-Gm-Message-State: ALoCoQnxZzTDQgfLlkrO1z48LfL+4lkZaGsmbPBNoD0MSLV5gdgAWcIbFpDBhOGwVbXsIg/4WhAB X-Received: by 10.15.22.201 with SMTP id f49mr48127600eeu.18.1395406397778; Fri, 21 Mar 2014 05:53:17 -0700 (PDT) Received: from Bozhidars-MacBook-Pro.local ([95.87.231.111]) by mx.google.com with ESMTPSA id t4sm11390827eeb.29.2014.03.21.05.53.16 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 21 Mar 2014 05:53:17 -0700 (PDT) Received: by Bozhidars-MacBook-Pro.local (Postfix, from userid 501) id D28E587F4EE7; Fri, 21 Mar 2014 14:53:14 +0200 (EET) From: Bozhidar Batsov To: bug-gnu-emacs@gnu.org Subject: 24.3.50; [ruby-mode] Font-locking of special global variables like $$ is broken(missing) Date: Fri, 21 Mar 2014 14:53:14 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Here's a few examples: "this is #$$" var = $! Things are different for: "this is #$1" var = $1 I think those should be highlighted at least like $1 and friends. There's another thing to consider - do built-in global vars should be font-locked like built-ins or like the other (user-defined) global variables? Personally I'd font-lock them as built-in to underline their significance. In GNU Emacs 24.3.50.1 (x86_64-apple-darwin13.0.0, NS apple-appkit-1265.00) of 2014-03-01 on Bozhidars-MacBook-Pro.local Windowing system distributor `Apple', version 10.3.1265 Configured using: `configure --prefix=/usr/local/Cellar/emacs/HEAD --without-dbus --enable-locallisppath=/usr/local/share/emacs/site-lisp --infodir=/usr/local/Cellar/emacs/HEAD/share/info/emacs --without-gnutls --with-ns --disable-ns-self-contained' Important settings: locale-coding-system: utf-8-unix Major mode: Ruby Minor modes in effect: subword-mode: t ruby-tools-mode: t inf-ruby-minor-mode: t magit-auto-revert-mode: t diff-auto-refine-mode: t guru-mode: t erc-truncate-mode: t erc-spelling-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-match-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-netsplit-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t global-flycheck-mode: t flycheck-mode: t which-function-mode: t flx-ido-mode: t ido-ubiquitous-mode: t winner-mode: t global-undo-tree-mode: t undo-tree-mode: t whitespace-mode: t global-anzu-mode: t anzu-mode: t projectile-global-mode: t projectile-mode: t flyspell-mode: t shell-dirtrack-mode: t volatile-highlights-mode: t global-hl-line-mode: t recentf-mode: t savehist-mode: t show-smartparens-global-mode: t show-smartparens-mode: t smartparens-mode: t global-auto-revert-mode: t delete-selection-mode: t prelude-global-mode: t prelude-mode: t tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t size-indication-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent input: t SPC i s SPC @ # g o o t C-b C-b C-b C-b C-b C-d @ C-f C-f C-f C-f C-d C-x C-s C-e C-x b C-p C-p C-e p SPC n o d e . c h i l d r e n C-x C-s C-x b C-a C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-b C-b C-b { C-d C-f C-f C-f C-f C-f } C-x C-s C-b C-b C-b C-b C-b C-b C-b C-d C-f C-f C-f C-f C-f C-d C-x C-s C-x b C-a C-a C-k C-k C-x b C-b C-b C-b C-b C-b C-d $ C-x C-s C-d C-d C-d C-d $ C-x C-s ! C-x C-s 1 C-x C-s C-x b C-n C-e . l o c . e x p r e s s i o n . s o u r c e C-x C-s C-n C-a C-f C-f C-f C-f C-f C-f C-k C-p C-a C-f C-f C-k C-n C-e C-y C-p C-p C-n C-a C-a C-k C-k C-n C-n C-n C-p C-p C-p C-n C-n C-n C-p C-k C-k C-n C-k C-k C-p C-x C-s C-x b t e s t ! $ 1 $ C-v a v a r r SPC = = SPC $ 1 $ ! t o p SPC = SPC $ t e s t M-x r e b o p o r t Recent messages: Wrote /Users/bozhidar/projects/test.rb Saving file /Users/bozhidar/projects/rubocop/lib/rubocop/cop/style/variable_interpolation.rb... Wrote /Users/bozhidar/projects/rubocop/lib/rubocop/cop/style/variable_interpolation.rb Mark set Indenting region...done Inconsistent indentation detected. Saving file /Users/bozhidar/projects/rubocop/lib/rubocop/cop/style/variable_interpolation.rb... Wrote /Users/bozhidar/projects/rubocop/lib/rubocop/cop/style/variable_interpolation.rb Saving file /Users/bozhidar/projects/test.rb... Wrote /Users/bozhidar/projects/test.rb scroll-up-command: End of buffer Load-path shadows: /Users/bozhidar/.emacs.d/elpa/tabulated-list-20120406.2251/tabulated-list hides /usr/local/Cellar/emacs/HEAD/share/emacs/24.3.50/lisp/emacs-lisp/tabulated-list Features: (rect shadow sort emacsbug make-mode ielm lisp-mnt clojure-test-mode cider-scratch network-stream starttls tls slime-fancy slime-fontifying-fu slime-package-fu slime-references slime-scratch slime-presentations slime-fuzzy slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-parse slime-repl elp slime hyperspec ace-jump-mode hippie-exp browse-url cus-edit cus-start cus-load slim-mode mail-extr eieio-opt speedbar sb-image ezimage dframe rst yaml-mode superword subword ruby-tools inf-ruby ruby-mode-expansions smartparens-ruby ruby-mode smie cider coffee-mode js-mode-expansions js json cc-mode-expansions cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs web-mode-expansions web-mode disp-table nxml-uchnm rng-xsd xsd-regexp rng-cmpct cider-mode cider-repl cider-eldoc cider-interaction arc-mode archive-mode cider-client nrepl-client cider-util ewoc clojure-mode-expansions clojure-mode inf-lisp find-dired vc-annotate vc vc-dispatcher misearch multi-isearch gitignore-mode conf-mode ibuf-ext ibuffer ffap url-parse url-vars mule-util executable magit-key-mode magit view epa derived epg epg-config diff-mode git-rebase-mode git-commit-mode server log-edit message sendmail rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log vc-git markdown-mode noutline outline rainbow-mode color rainbow-delimiters elisp-slime-nav guru-mode prelude-key-chord key-chord prelude-xml nxml-mode-expansions html-mode-expansions sgml-mode smartparens-html rng-nxml rng-valid rng-loc rng-uri rng-parse nxml-parse rng-match rng-dt rng-util rng-pttrn nxml-ns nxml-mode nxml-outln nxml-rap nxml-util nxml-glyph nxml-enc xmltok prelude-web prelude-scss prelude-scheme prelude-ruby prelude-perl prelude-org prelude-js prelude-erc erc-truncate erc-autoaway erc-spelling erc-notify erc-log erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete erc-track erc-match erc-button erc-fill erc-stamp erc-netsplit erc-goodies erc erc-backend erc-compat prelude-emacs-lisp prelude-css prelude-common-lisp slime-autoloads prelude-clojure prelude-lisp prelude-c prelude-programming flycheck help-mode rx f which-func imenu prelude-ido smex flx-ido flx ido-ubiquitous warnings ido prelude-osx exec-path-from-shell prelude-global-keybindings prelude-editor winner undo-tree diff esh-var esh-io esh-cmd esh-opt esh-ext esh-proc esh-arg eldoc esh-groups eshell esh-module esh-mode esh-util re-builder whitespace browse-kill-ring midnight ediff-merg ediff-wind ediff-diff ediff-mult ediff-help ediff-init ediff-util ediff dired-x dired anzu projectile pkg-info find-func grep compile s bookmark pp expand-region text-mode-expansions er-basic-expansions expand-region-core expand-region-custom flyspell ispell tramp tramp-compat auth-source gnus-util mm-util mail-prsvr password-cache tramp-loaddefs trampver shell pcomplete comint ansi-color format-spec etags ring volatile-highlights hl-line windmove recentf tree-widget wid-edit savehist saveplace diminish smartparens-config smartparens autorevert filenotify delsel prelude-mode easy-mmode edmacro kmacro prelude-core epl advice help-fns dash thingatpt prelude-ui zenburn-theme prelude-packages finder-inf ack-and-a-half-autoloads diminish-autoloads erlang-autoloads flx-ido-autoloads eieio byte-opt bytecomp byte-compile cconv eieio-core grizzl-autoloads key-chord-autoloads logito-autoloads info easymenu cl-macs gv pkg-info-autoloads rainbow-delimiters-autoloads rubocop-autoloads volatile-highlights-autoloads yaml-mode-autoloads package cl cl-loaddefs cl-lib time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process cocoa ns multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 21 10:48:12 2014 Received: (at 17057) by debbugs.gnu.org; 21 Mar 2014 14:48:12 +0000 Received: from localhost ([127.0.0.1]:43695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WR0k0-0002Yb-3G for submit@debbugs.gnu.org; Fri, 21 Mar 2014 10:48:12 -0400 Received: from mail-ee0-f49.google.com ([74.125.83.49]:41597) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WR0jv-0002YP-Rg for 17057@debbugs.gnu.org; Fri, 21 Mar 2014 10:48:08 -0400 Received: by mail-ee0-f49.google.com with SMTP id c41so1872353eek.22 for <17057@debbugs.gnu.org>; Fri, 21 Mar 2014 07:48:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=EWUphHBp5i0+RIJ1U7Mxj62lxCi8OKtYlubctcFf8UQ=; b=PiwjpGunONSAWCuPA1C2E9tFzatUlctWhZusHogIv5Nb9satq1E1xiThWV31cGC0vN aNTfALofr0aICokXHGyPoyVesdSJjjIFhXOT7N7Umqf4/8VxrRn+bPIiBelwH4vpp3vx lHi4/Ykk1UeJ1jYw0PDnC6e+CSfuYWalmXM7cGKgfK6Mxy9a0X+oZoX118We9cYZg+Nb 6pl8uxlpj6ZcnNea2spMb1TmyIDRP0qagTOvoLS34vnsXMFFCFTj3m0jcAPll+MdsjUS zHd3qZrleDcZiYdvmnS73jZ589iGONWnwHJv2L2UcJynV/FN5r6548sGuBaUE22Cf4p1 8UcQ== X-Received: by 10.14.204.199 with SMTP id h47mr35353469eeo.48.1395413286927; Fri, 21 Mar 2014 07:48:06 -0700 (PDT) Received: from axl (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by mx.google.com with ESMTPSA id 44sm12007252eek.30.2014.03.21.07.48.05 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 21 Mar 2014 07:48:05 -0700 (PDT) From: Dmitry Gutov To: Bozhidar Batsov Subject: Re: bug#17057: 24.3.50; [ruby-mode] Font-locking of special global variables like $$ is broken(missing) References: Date: Fri, 21 Mar 2014 16:47:59 +0200 In-Reply-To: (Bozhidar Batsov's message of "Fri, 21 Mar 2014 14:53:14 +0200") Message-ID: <87bnwzwqu8.fsf@yandex.ru> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17057 Cc: 17057@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Bozhidar Batsov writes: > Here's a few examples: > > "this is #$$" > > var = $! > > Things are different for: > > "this is #$1" > > var = $1 Have you tried it in the latest Emacs? For me, only one example "this is #$$" is not highlighted (I'll fix that). > There's another thing to consider - do built-in global vars should be > font-locked like built-ins or like the other (user-defined) global > variables? Personally I'd font-lock them as built-in to underline their > significance. Hmmm, maybe. But we also highlight nil, self, true, false, __LINE__, __ENCODING__ and __FILE__ with font-lock-variable-name-face. Should we change these, too? From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 21 10:53:17 2014 Received: (at 17057) by debbugs.gnu.org; 21 Mar 2014 14:53:17 +0000 Received: from localhost ([127.0.0.1]:43699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WR0ou-0002hb-TB for submit@debbugs.gnu.org; Fri, 21 Mar 2014 10:53:17 -0400 Received: from mail-ee0-f42.google.com ([74.125.83.42]:49617) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WR0or-0002hM-Gb for 17057@debbugs.gnu.org; Fri, 21 Mar 2014 10:53:14 -0400 Received: by mail-ee0-f42.google.com with SMTP id d17so1888864eek.15 for <17057@debbugs.gnu.org>; Fri, 21 Mar 2014 07:53:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-type; bh=mkStO/oElJFANT2+FNq0GrpZ/4U191FGSy/aB3V2PcI=; b=mXMu9zTFREVGPLyzPvK7dpFEjVAkK0Jz3jEX8F6I3xgRsCGEh5TqVJBIWUZ4wyxEvy 7ITxymhCImPySyL4ehRaekKH90p/Bv/37xJGZBqBu+fq3tmIddOGxSJZvox52wdKXuwX w7Q5Rk7BfhPnMVc+5AxRHuQprv0fxELNUsy1dzBpH6+s+VCM2Wz5NF7Dduncj3xe4wPU AJcTAHJUs6Y3QPUmV3ONHMKayCU6B72pUPLRhqIZnudJBtWxKyhFy+1rbAOXbiAbjF5E 9BzTSemH81DVM3SlAlHXmqkUv4gp0SolR712wBvmGOllQsbQ2l8QbIB0xOL7Y+QN7Reb tMLQ== X-Received: by 10.15.10.3 with SMTP id f3mr48341585eet.1.1395413592080; Fri, 21 Mar 2014 07:53:12 -0700 (PDT) Received: from [192.168.1.28] ([95.87.231.111]) by mx.google.com with ESMTPSA id e42sm12030029eev.32.2014.03.21.07.53.10 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 21 Mar 2014 07:53:10 -0700 (PDT) Date: Fri, 21 Mar 2014 16:53:08 +0200 From: Bozhidar Batsov To: Dmitry Gutov Message-ID: In-Reply-To: <87bnwzwqu8.fsf@yandex.ru> References: <87bnwzwqu8.fsf@yandex.ru> Subject: Re: bug#17057: 24.3.50; [ruby-mode] Font-locking of special global variables like $$ is broken(missing) X-Mailer: sparrow 1.6.4 (build 1178) MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="532c5254_661e3f1e_fda4" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17057 Cc: 17057@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --532c5254_661e3f1e_fda4 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On =46riday, March 21, 2014 at 4:47 PM, Dmitry Gutov wrote: > Bozhidar Batsov = writes: > =20 > > Here's a few examples: > > =20 > > =22this is =23=24=24=22 > > =20 > > var =3D =24=21 > > =20 > > Things are different for: > > =20 > > =22this is =23=241=22 > > =20 > > var =3D =241 > =20 > Have you tried it in the latest Emacs=3F =46or me, only one example > =20 > =22this is =23=24=24=22 > =20 > is not highlighted (I'll fix that). > =20 > > There's another thing to consider - do built-in global vars should be= > > font-locked like built-ins or like the other (user-defined) global > > variables=3F Personally I'd font-lock them as built-in to underline t= heir > > significance. > > =20 > =20 > =20 > Hmmm, maybe. But we also highlight nil, self, true, false, =5F=5FLINE=5F= =5F, > =5F=5FENCODING=5F=5F and =5F=5F=46ILE=5F=5F with font-lock-variable-nam= e-face. Should we > change these, too=3F > =20 > =20 Technically speaking all of those are keywords, not variables. Somewhat o= dd =5F=5FLINE=5F=5F and friends are =20 treated at string literals by the Ruby parser. As all of those evaluate t= o some value unlike most other keywords I guess it makes some sense to fo= nt-lock them as variables, but I=E2=80=99d prefer if we used font-locking= that makes their special status more apparent. =20 --532c5254_661e3f1e_fda4 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
On =46= riday, March 21, 2014 at 4:47 PM, Dmitry Gutov wrote:
Bozhidar Batsov <bozhidar=40batsov.com> writes:

Here's a few exa= mples:

=22this is =23=24=24=22

var =3D =24=21

Things are different for:=

=22this is =23=241=22

= var =3D =241

Have you tried i= t in the latest Emacs=3F =46or me, only one example

<= div>=22this is =23=24=24=22

is not highlighted (= I'll fix that).

There's another thing to consider - do built-in global vars should be<= /div>
font-locked like built-ins or like the other (user-defined) glo= bal
variables=3F Personally I'd font-lock them as built-in to u= nderline their
significance.

<= /div>
Hmmm, maybe. But we also highlight nil, self, true, false, =5F=5F= LINE=5F=5F,
=5F=5FENCODING=5F=5F and =5F=5F=46ILE=5F=5F with fo= nt-lock-variable-name-face. Should we
change these, too=3F
=20 =20 =20 =20
=20
Technically speaking = all of those are keywords, not variables. Somewhat odd =5F=5FLINE=5F=5F a= nd friends are
treated at str= ing literals by the Ruby parser. As all of those evaluate to some value u= nlike most other keywords I guess it makes some sense to font-lock them a= s variables, but I=E2=80=99d prefer if we used font-locking that makes th= eir special status more apparent. 
--532c5254_661e3f1e_fda4-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 22 06:02:18 2014 Received: (at 17057) by debbugs.gnu.org; 22 Mar 2014 10:02:18 +0000 Received: from localhost ([127.0.0.1]:44191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WRIkr-0006o4-JW for submit@debbugs.gnu.org; Sat, 22 Mar 2014 06:02:18 -0400 Received: from mail-ee0-f51.google.com ([74.125.83.51]:62697) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WRIkp-0006nv-Au for 17057@debbugs.gnu.org; Sat, 22 Mar 2014 06:02:16 -0400 Received: by mail-ee0-f51.google.com with SMTP id c13so2608455eek.24 for <17057@debbugs.gnu.org>; Sat, 22 Mar 2014 03:02:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-type; bh=1GEDBoyzBCWhYEmOm6WMv6ioVVEMmjZ4tXAarF5fQ/I=; b=n5VZTMAAw1l40emQcBMY4V7SOJVJ09sCVhhzw02nEn0gC3DjvA76k91+KAllnxeIAj yUeWDt2jDqOwq/CTr4YKPNUPLjLE+9nYrq3gZkG2uYZma6Q9bMThrPGNZATOIKaIEDHG pQta5DkL3mt0GqL94fWZSXB1vw7ol9HWoALvuszj6CD2m+S7YwBZVUs/5GBPukc7MRYs BLtOlvA4IdOtzCOno5J7+XkgVdJJnuJqxYyFCQmfElzGgcpjyOYEBoD8fuonU4Z65l/p oA0tMc21+NXH4jf4O8S3VIQEqe1a+t8UdOPqd0iXJ2hHzSGOyzCp2qpCRS8V/cpbCCoC 7BWg== X-Received: by 10.14.7.65 with SMTP id 41mr876724eeo.100.1395482534437; Sat, 22 Mar 2014 03:02:14 -0700 (PDT) Received: from [192.168.1.28] ([95.87.231.111]) by mx.google.com with ESMTPSA id 48sm17847749eee.2.2014.03.22.03.02.12 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sat, 22 Mar 2014 03:02:13 -0700 (PDT) Date: Sat, 22 Mar 2014 12:02:10 +0200 From: Bozhidar Batsov To: Dmitry Gutov Message-ID: In-Reply-To: References: <87bnwzwqu8.fsf@yandex.ru> Subject: Re: bug#17057: 24.3.50; [ruby-mode] Font-locking of special global variables like $$ is broken(missing) X-Mailer: sparrow 1.6.4 (build 1178) MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="532d5fa2_94211f2_fda4" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17057 Cc: 17057@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --532d5fa2_94211f2_fda4 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On =46riday, March 21, 2014 at 4:53 PM, Bozhidar Batsov wrote: > On =46riday, March 21, 2014 at 4:47 PM, Dmitry Gutov wrote: > > Bozhidar Batsov writes: > > =20 > > > Here's a few examples: > > > =20 > > > =22this is =23=24=24=22 > > > =20 > > > var =3D =24=21 > > > =20 > > > Things are different for: > > > =20 > > > =22this is =23=241=22 > > > =20 > > > var =3D =241 > > =20 > > Have you tried it in the latest Emacs=3F =46or me, only one example > > =20 > > =22this is =23=24=24=22 > > =20 > > is not highlighted (I'll fix that). > > =20 > > > There's another thing to consider - do built-in global vars should = be > > > font-locked like built-ins or like the other (user-defined) global > > > variables=3F Personally I'd font-lock them as built-in to underline= their > > > significance. > > > =20 > > =20 > > =20 > > Hmmm, maybe. But we also highlight nil, self, true, false, =5F=5FLINE= =5F=5F, > > =5F=5FENCODING=5F=5F and =5F=5F=46ILE=5F=5F with font-lock-variable-n= ame-face. Should we > > change these, too=3F > > =20 > > =20 > > =20 > =20 > Technically speaking all of those are keywords, not variables. Somewhat= odd =5F=5FLINE=5F=5F and friends are =20 > treated at string literals by the Ruby parser. As all of those evaluate= to some value unlike most other keywords I guess it makes some sense to = font-lock them as variables, but I=E2=80=99d prefer if we used font-locki= ng that makes their special status more apparent. =20 > =20 > =20 There=E2=80=99s one more thing to consider - the special variables aliase= s defined in =60English=60. Those are considered de facto built-in (and a= re actually built-in in some implementations like JRuby; will probably be= available out-of-the-box in MRI 3 as well), so I=E2=80=99d suggest treat= ing them the same way as vars like =24=24, etc. =20 --532d5fa2_94211f2_fda4 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
On =46= riday, March 21, 2014 at 4:53 PM, Bozhidar Batsov wrote:
On =46= riday, March 21, 2014 at 4:47 PM, Dmitry Gutov wrote:
Bozhidar Batsov <bozhidar=40batsov.com> writes:

Here's a few exa= mples:

=22this is =23=24=24=22

var =3D =24=21

Things are different for:=

=22this is =23=241=22

= var =3D =241

Have you tried i= t in the latest Emacs=3F =46or me, only one example

<= div>=22this is =23=24=24=22

is not highlighted (= I'll fix that).

There's another thing to consider - do built-in global vars should be<= /div>
font-locked like built-ins or like the other (user-defined) glo= bal
variables=3F Personally I'd font-lock them as built-in to u= nderline their
significance.

<= /div>
Hmmm, maybe. But we also highlight nil, self, true, false, =5F=5F= LINE=5F=5F,
=5F=5FENCODING=5F=5F and =5F=5F=46ILE=5F=5F with fo= nt-lock-variable-name-face. Should we
change these, too=3F
=20 =20 =20 =20
Technically speaking = all of those are keywords, not variables. Somewhat odd =5F=5FLINE=5F=5F a= nd friends are
treated at str= ing literals by the Ruby parser. As all of those evaluate to some value u= nlike most other keywords I guess it makes some sense to font-lock them a= s variables, but I=E2=80=99d prefer if we used font-locking that makes th= eir special status more apparent. 
=20 =20 =20 =20 =20
There=E2=80=99s one = more thing to consider - the special variables aliases defined in =60Engl= ish=60. Those are considered de facto built-in (and are actually built-in= in some implementations like JRuby; will probably be available out-of-th= e-box in MRI 3 as well), so I=E2=80=99d suggest treating them the same wa= y as vars like =24=24, etc. 
--532d5fa2_94211f2_fda4-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 22 06:05:49 2014 Received: (at 17057) by debbugs.gnu.org; 22 Mar 2014 10:05:49 +0000 Received: from localhost ([127.0.0.1]:44195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WRIoG-0006ti-Rk for submit@debbugs.gnu.org; Sat, 22 Mar 2014 06:05:49 -0400 Received: from mail-ee0-f54.google.com ([74.125.83.54]:63497) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WRIoE-0006ta-SO for 17057@debbugs.gnu.org; Sat, 22 Mar 2014 06:05:47 -0400 Received: by mail-ee0-f54.google.com with SMTP id d49so2609150eek.41 for <17057@debbugs.gnu.org>; Sat, 22 Mar 2014 03:05:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-type; bh=umClmIyi2tnv04k3YHdw1iTCxUFRBeeys9c3/a7p0Yc=; b=JY9bAkDX15YuBpTguqjxQMh6FOJfrxFj+z4dro2lCbZkP6+ommRjYKibiTUWsA4XvC PpRo5KdAwlPi2H5hnjpHFr6Am+4xtaDyGkdh5qV7hGwAGqJgZO9fg9BbIq86rQ6D+JE0 l/qO800nx/7jVHw5gzLwOuoofTyKW/ERi9CsgkGS3XMhPmilN+ewilSPkMN2xy4xl5OY tMd19qQLGjIqH3DNWcj6E+7OOkqQSwv7pMCZmDsAAEJ0TQhjwz99kCLMa2ViVVR0j9Wd 9ADZhMDGZHelukQaeE75Qrk5c0ot6G1/ZO0Htu0Fp4KweCcF7LK2Cdm+3tIKFBdAiX0p j5Fw== X-Received: by 10.14.111.66 with SMTP id v42mr17732eeg.107.1395482746016; Sat, 22 Mar 2014 03:05:46 -0700 (PDT) Received: from [192.168.1.28] ([95.87.231.111]) by mx.google.com with ESMTPSA id f45sm17864082eeg.5.2014.03.22.03.05.44 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sat, 22 Mar 2014 03:05:45 -0700 (PDT) Date: Sat, 22 Mar 2014 12:05:42 +0200 From: Bozhidar Batsov To: Dmitry Gutov Message-ID: In-Reply-To: References: <87bnwzwqu8.fsf@yandex.ru> Subject: Re: bug#17057: 24.3.50; [ruby-mode] Font-locking of special global variables like $$ is broken(missing) X-Mailer: sparrow 1.6.4 (build 1178) MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="532d6076_43f18422_fda4" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17057 Cc: 17057@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --532d6076_43f18422_fda4 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Saturday, March 22, 2014 at 12:02 PM, Bozhidar Batsov wrote: > On =46riday, March 21, 2014 at 4:53 PM, Bozhidar Batsov wrote: > > On =46riday, March 21, 2014 at 4:47 PM, Dmitry Gutov wrote: > > > Bozhidar Batsov writes: > > > =20 > > > > Here's a few examples: > > > > =20 > > > > =22this is =23=24=24=22 > > > > =20 > > > > var =3D =24=21 > > > > =20 > > > > Things are different for: > > > > =20 > > > > =22this is =23=241=22 > > > > =20 > > > > var =3D =241 > > > =20 > > > Have you tried it in the latest Emacs=3F =46or me, only one example= > > > =20 > > > =22this is =23=24=24=22 > > > =20 > > > is not highlighted (I'll fix that). > > > =20 =241 gets font-locked immediately, but =24=24 currently gets font-locked = only after some =E2=80=9Cword-boundary=E2=80=9D character gets inserted (= like space, newline, etc). =20 > > > =20 > > > > There's another thing to consider - do built-in global vars shoul= d be > > > > font-locked like built-ins or like the other (user-defined) globa= l > > > > variables=3F Personally I'd font-lock them as built-in to underli= ne their > > > > significance. > > > > =20 > > > =20 > > > =20 > > > Hmmm, maybe. But we also highlight nil, self, true, false, =5F=5FLI= NE=5F=5F, > > > =5F=5FENCODING=5F=5F and =5F=5F=46ILE=5F=5F with font-lock-variable= -name-face. Should we > > > change these, too=3F > > > =20 > > > =20 > > > =20 > > =20 > > Technically speaking all of those are keywords, not variables. Somewh= at odd =5F=5FLINE=5F=5F and friends are =20 > > treated at string literals by the Ruby parser. As all of those evalua= te to some value unlike most other keywords I guess it makes some sense t= o font-lock them as variables, but I=E2=80=99d prefer if we used font-loc= king that makes their special status more apparent. =20 > > =20 > > =20 > > =20 > =20 > There=E2=80=99s one more thing to consider - the special variables alia= ses defined in =60English=60. Those are considered de facto built-in (and= are actually built-in in some implementations like JRuby; will probably = be available out-of-the-box in MRI 3 as well), so I=E2=80=99d suggest tre= ating them the same way as vars like =24=24, etc. =20 > =20 > =20 --532d6076_43f18422_fda4 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
On Sa= turday, March 22, 2014 at 12:02 PM, Bozhidar Batsov wrote:
On =46= riday, March 21, 2014 at 4:53 PM, Bozhidar Batsov wrote:
On =46= riday, March 21, 2014 at 4:47 PM, Dmitry Gutov wrote:
Bozhidar Batsov <bozhidar=40batsov.com> writes:

Here's a few exa= mples:

=22this is =23=24=24=22

var =3D =24=21

Things are different for:=

=22this is =23=241=22

= var =3D =241

Have you tried i= t in the latest Emacs=3F =46or me, only one example

<= div>=22this is =23=24=24=22

is not highlighted (= I'll fix that).

=241 gets font-locked immediately, but= =24=24 currently gets font-locked only after some =E2=80=9Cword-bou= ndary=E2=80=9D character gets inserted (like space, newline, etc).=  
There's another thing to consider - do built-in global vars should= be
font-locked like built-ins or like the other (user-defined)= global
variables=3F Personally I'd font-lock them as built-in = to underline their
significance.
<= br>
Hmmm, maybe. But we also highlight nil, self, true, false, = =5F=5FLINE=5F=5F,
=5F=5FENCODING=5F=5F and =5F=5F=46ILE=5F=5F w= ith font-lock-variable-name-face. Should we
change these, too=3F=
=20 =20 =20 =20
Technically speaking = all of those are keywords, not variables. Somewhat odd =5F=5FLINE=5F=5F a= nd friends are
treated at str= ing literals by the Ruby parser. As all of those evaluate to some value u= nlike most other keywords I guess it makes some sense to font-lock them a= s variables, but I=E2=80=99d prefer if we used font-locking that makes th= eir special status more apparent. 
 =20 =20 =20 =20
T= here=E2=80=99s one more thing to consider - the special variables aliases= defined in =60English=60. Those are considered de facto built-in (and ar= e actually built-in in some implementations like JRuby; will probably be = available out-of-the-box in MRI 3 as well), so I=E2=80=99d suggest treati= ng them the same way as vars like =24=24, etc. 
=20 =20 =20 =20 =20

--532d6076_43f18422_fda4-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 24 03:33:36 2014 Received: (at 17057) by debbugs.gnu.org; 24 Mar 2014 07:33:36 +0000 Received: from localhost ([127.0.0.1]:46674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WRzO2-0006ys-TP for submit@debbugs.gnu.org; Mon, 24 Mar 2014 03:33:35 -0400 Received: from mail-we0-f172.google.com ([74.125.82.172]:35618) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WRzNz-0006yj-UQ for 17057@debbugs.gnu.org; Mon, 24 Mar 2014 03:33:33 -0400 Received: by mail-we0-f172.google.com with SMTP id t61so3188015wes.3 for <17057@debbugs.gnu.org>; Mon, 24 Mar 2014 00:33:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=glHzW32pOmeZnTnWDSRYkLQK2uGZyHFbCussySqa530=; b=zGYAsA+04A7lxyszU7KcaEi6gM7Xcv4+ZertH1dAYP4ab96kF1HUvpdnyx6O+rnc5p asXbttnUnyKnDOuEJjJU/Hb+yXbDz0PbeODNbOIscQa0Ygvf2BN2LjNhNaRuCZPK8aTe Lj5Jryi6me5UQvWqAewT3p++SUpGecD0CWidwlBuL/Cr+nYmuL5iim9N0zXFPg1qZU8k kxgrN97h5JFzxMxCxN/2FSvbUXOO4jA8fgEcXzlvirgxEV9Qru4zoXKo273BlLCWMEMg k2ULRonjc+V5qXdnt8v6yc/aNc1W2QHts0fQm/sJobMLrmEft2Js9vfkSsDu44hzvw1w WdqQ== X-Received: by 10.180.73.1 with SMTP id h1mr13892825wiv.10.1395646410571; Mon, 24 Mar 2014 00:33:30 -0700 (PDT) Received: from [192.168.10.2] ([93.109.138.177]) by mx.google.com with ESMTPSA id f3sm34556480wiv.2.2014.03.24.00.33.28 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 24 Mar 2014 00:33:29 -0700 (PDT) Message-ID: <532FDFC6.2030907@yandex.ru> Date: Mon, 24 Mar 2014 09:33:26 +0200 From: Dmitry Gutov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Bozhidar Batsov Subject: Re: bug#17057: 24.3.50; [ruby-mode] Font-locking of special global variables like $$ is broken(missing) References: <87bnwzwqu8.fsf@yandex.ru> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17057 Cc: 17057@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 22.03.2014 12:05, Bozhidar Batsov wrote: > $1 gets font-locked immediately, but $$ currently gets font-locked only > after some “word-boundary” character gets inserted (like space, newline, > etc). Here's the relevant matcher, it's pretty old: "\\(\\$\\([^a-zA-Z0-9 \n]\\|[0-9]\\)\\)\\W" Apparently, it was meant as a light-weight syntax hint: no highlighting means syntax error. Very ad-hoc, so I'm up for removing it. ($1 also hits another matcher because 1 has the word syntax). From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 24 05:12:46 2014 Received: (at 17057-done) by debbugs.gnu.org; 24 Mar 2014 09:12:46 +0000 Received: from localhost ([127.0.0.1]:46721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WS0w1-0002S2-VB for submit@debbugs.gnu.org; Mon, 24 Mar 2014 05:12:46 -0400 Received: from mail-bk0-f47.google.com ([209.85.214.47]:33872) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WS0vz-0002Rs-Hw for 17057-done@debbugs.gnu.org; Mon, 24 Mar 2014 05:12:44 -0400 Received: by mail-bk0-f47.google.com with SMTP id w10so382253bkz.20 for <17057-done@debbugs.gnu.org>; Mon, 24 Mar 2014 02:12:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=N0RvxWnOEhhqQyuSKOQST73a+q8BVTRNycvxsG1SO+U=; b=CwsbhI3cq5Ta5LeneosqBbaHZZUQza+U8ZDpHDX+l6kk9hck9OwVpc7Q2xn8pc2F7Q IBzPG7a8ITjSOUhoSzik4KLWEUW9AoAENx9jm/JEU/nTluI3UoElK3TF4nlOz/dpxr1/ KzK8SQM5P8hm8rehHyvUK2oBlXSjuzB+Ld8sMYJQNoVWRSdxmgqQmTjbu5iVmYer3CI3 AdsYghMLcEKh1WoG5gS5Dbs8a41/0nkYgjslrj2MG9dJadHHq9IpOr+5VrzZQZWzM17M RJ5UHYLx7Dk8lrpmA0IrAgJEJS4/pFbJ2nkvU6f1+a1aHjbhFccWxsUUifluxNc1rd2y vbsw== X-Received: by 10.205.20.74 with SMTP id qn10mr3439955bkb.11.1395652362332; Mon, 24 Mar 2014 02:12:42 -0700 (PDT) Received: from [192.168.10.2] ([93.109.138.177]) by mx.google.com with ESMTPSA id em17sm3807453bkb.12.2014.03.24.02.12.39 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 24 Mar 2014 02:12:41 -0700 (PDT) Message-ID: <532FF702.7090205@yandex.ru> Date: Mon, 24 Mar 2014 11:12:34 +0200 From: Dmitry Gutov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Bozhidar Batsov Subject: Re: bug#17057: 24.3.50; [ruby-mode] Font-locking of special global variables like $$ is broken(missing) References: <87bnwzwqu8.fsf@yandex.ru> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17057-done Cc: 17057-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Version: 24.4 On 21.03.2014 16:53, Bozhidar Batsov wrote: > Technically speaking all of those are keywords, not variables. Somewhat > odd __LINE__ and friends are > treated at string literals by the Ruby parser. As all of those evaluate > to some value unlike most other keywords I guess it makes some sense to > font-lock them as variables, but I’d prefer if we used font-locking that > makes their special status more apparent. Sounds good to me. Does this list look exhaustive to you? http://www.zenspider.com/Languages/Ruby/QuickRef.html#pre-defined-variables Aside from changing faces, the problems mentioned in this bug should be fixed now, emacs-24 r116850. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 24 05:45:08 2014 Received: (at 17057-done) by debbugs.gnu.org; 24 Mar 2014 09:45:08 +0000 Received: from localhost ([127.0.0.1]:46737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WS1RL-0003M0-V7 for submit@debbugs.gnu.org; Mon, 24 Mar 2014 05:45:08 -0400 Received: from mail-ee0-f43.google.com ([74.125.83.43]:58898) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WS1RJ-0003Lq-H1 for 17057-done@debbugs.gnu.org; Mon, 24 Mar 2014 05:45:06 -0400 Received: by mail-ee0-f43.google.com with SMTP id e53so4178938eek.16 for <17057-done@debbugs.gnu.org>; Mon, 24 Mar 2014 02:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-type; bh=bcgtdBNJS2441gFXB78vUSwORpaFR2//62RzR+lLyAc=; b=MFukNTdUMKpvqenMknI0w21CzuVkRHF7UQkcLGFlkI/7ZKJhPQz/AjhL2gCyCWP5UQ x/T1GhlRwEhj++zFI1qRoVY/iSV/JYUfaeRJ3qUoIdcEMcQFSs0a1Gf9WH9TyHcP/ECd xK1NDz+x8jA9BAFzaZWesT4k78WOT2wTcBA0c/NinftFYXHpJar5LV/tsFPE/HMK5c/u wZe7jTp2cHS2fpEyTkLiktNAC+G2wIO7w2ZRWeoqDh+Dse6Gv7iqDhM1+j+sJIM3mUyV AE9eDyKFWyvLOB1b2y4fk5KKXaQ9SFPGmnIeA0W2ejgmvChN72Jt/9bih1Rj+iYIjJNV t0eQ== X-Received: by 10.14.108.67 with SMTP id p43mr220078eeg.110.1395654304714; Mon, 24 Mar 2014 02:45:04 -0700 (PDT) Received: from [192.168.1.28] ([95.87.231.111]) by mx.google.com with ESMTPSA id t4sm32117651eeb.29.2014.03.24.02.45.02 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 24 Mar 2014 02:45:03 -0700 (PDT) Date: Mon, 24 Mar 2014 11:45:01 +0200 From: Bozhidar Batsov To: Dmitry Gutov Message-ID: <2EF5A812FAC74FBBBB465952FCFFC2D6@gmail.com> In-Reply-To: <532FF702.7090205@yandex.ru> References: <87bnwzwqu8.fsf@yandex.ru> <532FF702.7090205@yandex.ru> Subject: Re: bug#17057: 24.3.50; [ruby-mode] Font-locking of special global variables like $$ is broken(missing) X-Mailer: sparrow 1.6.4 (build 1178) MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="532ffe9d_2a155dbc_fda4" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17057-done Cc: 17057-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --532ffe9d_2a155dbc_fda4 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Monday, March 24, 2014 at 11:12 AM, Dmitry Gutov wrote: > Version: 24.4 > =20 > On 21.03.2014 16:53, Bozhidar Batsov wrote: > =20 > > Technically speaking all of those are keywords, not variables. Somewh= at > > odd =5F=5FLINE=5F=5F and friends are > > treated at string literals by the Ruby parser. As all of those evalua= te > > to some value unlike most other keywords I guess it makes some sense = to > > font-lock them as variables, but I=E2=80=99d prefer if we used font-l= ocking that > > makes their special status more apparent. > > =20 > =20 > =20 > Sounds good to me. Does this list look exhaustive to you=3F > =20 > http://www.zenspider.com/Languages/Ruby/QuickRef.html=23pre-defined-var= iables > =20 Yeah, seems that everything important is listed there. Here=E2=80=99s one= a bit more extensive list, though: https://github.com/bbatsov/rubocop/blob/master/lib/rubocop/cop/style/glob= al=5Fvars.rb It features the JRuby-specific global vars in addition to the standard on= es. =20 > =20 > Aside from changing faces, the problems mentioned in this bug should be= =20 > fixed now, emacs-24 r116850. > =20 > =20 Thanks=21 =20 --532ffe9d_2a155dbc_fda4 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
On Mo= nday, March 24, 2014 at 11:12 AM, Dmitry Gutov wrote:
Version: 24.4

On 21.03.2014 16:53, Bozhidar Batsov wrote:

Technically speaking all of those a= re keywords, not variables. Somewhat
odd =5F=5FLINE=5F=5F and f= riends are
treated at string literals by the Ruby parser. As al= l of those evaluate
to some value unlike most other keywords I = guess it makes some sense to
font-lock them as variables, but I= =E2=80=99d prefer if we used font-locking that
makes their spec= ial status more apparent.

Sou= nds good to me. Does this list look exhaustive to you=3F
Yeah, seems that e= verything important is listed there. Here=E2=80=99s one a bit more extens= ive list, though:

<= font face=3D=22Trebuchet MS=22>
It features the JRuby-specific global vars in addition to the= standard ones.  
Aside from changing faces, = the problems mentioned in this bug should be
fixed now, emacs-= 24 r116850.

Thanks=21 
=20

--532ffe9d_2a155dbc_fda4-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 26 08:36:25 2014 Received: (at 17057-done) by debbugs.gnu.org; 26 Mar 2014 12:36:25 +0000 Received: from localhost ([127.0.0.1]:50139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSn4C-0003FK-EJ for submit@debbugs.gnu.org; Wed, 26 Mar 2014 08:36:24 -0400 Received: from mail-bk0-f51.google.com ([209.85.214.51]:47375) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSn4A-0003FB-2A for 17057-done@debbugs.gnu.org; Wed, 26 Mar 2014 08:36:23 -0400 Received: by mail-bk0-f51.google.com with SMTP id 6so527586bkj.10 for <17057-done@debbugs.gnu.org>; Wed, 26 Mar 2014 05:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=NiKU9rNDPn9Z0Vbm9QSHosj3zCo3b4Vht5N4tOgoxl0=; b=SVa6EJN9XZXG0Uhh0mWrT664ugX2FjjXJ9/pAbas6zwBiy+/bu4j9ScmhSC6Eey60M v+84jPyrf+nkGAa/80c65AXh/5l9p3AYu+fKeJ2QOfO03Suz/2rycHznjFzq+3vtLw4v HZEZy4cFzdo/TQ1ytT3ARkiSWMJ2Idfj24hvqk8jyQVBurAzGZcvuGX1itoFH0gd93Fj T7jliAMr6Ujip1s/MceIxwRrGtQoWLgj19imj/puKDuwubvJ0lHWzYlYUR5Ms6Pg/lmq bH276SiPR8hFl4nRvXdSyJzcfc238ErF8FGEVHeLQSssNnce4qKbyKxnUAhIjypljh+V oQfw== X-Received: by 10.205.100.200 with SMTP id cx8mr427282bkc.68.1395837380761; Wed, 26 Mar 2014 05:36:20 -0700 (PDT) Received: from [192.168.0.94] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by mx.google.com with ESMTPSA id es17sm15432422bkb.7.2014.03.26.05.36.03 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 26 Mar 2014 05:36:19 -0700 (PDT) Message-ID: <5332C981.9030805@yandex.ru> Date: Wed, 26 Mar 2014 14:35:13 +0200 From: Dmitry Gutov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Bozhidar Batsov Subject: Re: bug#17057: 24.3.50; [ruby-mode] Font-locking of special global variables like $$ is broken(missing) References: <87bnwzwqu8.fsf@yandex.ru> <532FF702.7090205@yandex.ru> <2EF5A812FAC74FBBBB465952FCFFC2D6@gmail.com> In-Reply-To: <2EF5A812FAC74FBBBB465952FCFFC2D6@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17057-done Cc: 17057-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 24.03.2014 11:45, Bozhidar Batsov wrote: > Yeah, seems that everything important is listed there. Here’s one a bit > more extensive list, though: > > https://github.com/bbatsov/rubocop/blob/master/lib/rubocop/cop/style/global_vars.rb > > It features the JRuby-specific global vars in addition to the standard > ones. I see that you don't include the $(digit) globals, which reference the last regexp-matched groups. The patch below does. Not sure if it's okay to install in 24.4, though: on the one hand it's low-risk, on the other hand it's not a bugfix. === modified file 'lisp/progmodes/ruby-mode.el' --- lisp/progmodes/ruby-mode.el 2014-03-24 08:53:56 +0000 +++ lisp/progmodes/ruby-mode.el 2014-03-26 11:33:42 +0000 @@ -2108,13 +2108,28 @@ 1 font-lock-variable-name-face) ;; Keywords that evaluate to certain values. ("\\_<__\\(?:LINE\\|ENCODING\\|FILE\\)__\\_>" - (0 font-lock-variable-name-face)) + (0 font-lock-builtin-face)) ;; Symbols. ("\\(^\\|[^:]\\)\\(:\\([-+~]@?\\|[/%&|^`]\\|\\*\\*?\\|<\\(<\\|=>?\\)?\\|>[>=]?\\|===?\\|=~\\|![~=]?\\|\\[\\]=?\\|@?\\(\\w\\|_\\)+\\([!?=]\\|\\b_*\\)\\|#{[^}\n\\\\]*\\(\\\\.[^}\n\\\\]*\\)*}\\)\\)" 2 font-lock-constant-face) - ;; Variables. - ("\\$[^a-zA-Z \n]" - 0 font-lock-variable-name-face) + ;; Special variables. + (,(concat "\\$\\(?:[:\"!@;,/\\._><\\$?~=*&`'+0-9]\\|-[0adFiIlpvw]\\|" + (regexp-opt '("LOAD_PATH" "LOADED_FEATURES" "PROGRAM_NAME" + "ERROR_INFO" "ERROR_POSITION" + "FS" "FIELD_SEPARATOR" + "OFS" "OUTPUT_FIELD_SEPARATOR" + "RS" "INPUT_RECORD_SEPARATOR" + "ORS" "OUTPUT_RECORD_SEPARATOR" + "NR" "INPUT_LINE_NUMBER" + "LAST_READ_LINE" "DEFAULT_OUTPUT" "DEFAULT_INPUT" + "PID" "PROCESS_ID" "CHILD_STATUS" + "LAST_MATCH_INFO" "IGNORECASE" + "ARGV" "MATCH" "PREMATCH" "POSTMATCH" + "LAST_PAREN_MATCH" "stdin" "stdout" "stderr" + "DEBUG" "FILENAME" "VERBOSE" "SAFE" "CLASSPATH" + "JRUBY_VERSION" "JRUBY_REVISION" "ENV_JAVA")) + "\\_>\\)") + 0 font-lock-builtin-face) ("\\(\\$\\|@\\|@@\\)\\(\\w\\|_\\)+" 0 font-lock-variable-name-face) ;; Constants. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 26 08:42:59 2014 Received: (at 17057-done) by debbugs.gnu.org; 26 Mar 2014 12:42:59 +0000 Received: from localhost ([127.0.0.1]:50147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSnAY-0003Sg-F8 for submit@debbugs.gnu.org; Wed, 26 Mar 2014 08:42:59 -0400 Received: from mail-ee0-f53.google.com ([74.125.83.53]:48418) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSnAV-0003SV-FK for 17057-done@debbugs.gnu.org; Wed, 26 Mar 2014 08:42:56 -0400 Received: by mail-ee0-f53.google.com with SMTP id b57so1592621eek.26 for <17057-done@debbugs.gnu.org>; Wed, 26 Mar 2014 05:42:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-type; bh=amx6yzY9pdGk5C+vTtlR40nKFbMkCJWxFL8RNKp/oHc=; b=vApoBjqBEDL7Do7Em7P4yvXrTKpIdGckLbfLNFM3NH9UCR28TvEXcGabBZqQ8G3ngH EtnZKYJsGSt1FQsupUM1H0xH3jmcsgzKmjEugyIqIhHkcK2EYdSS4U9FDCYXJKH4SRr6 0kH4bNYbhw7H2S3hPD23VUNtP9a3Q9aPrY0hnN1APiOl5Z2SUaJ++Cab1o1f7ZL+G3cq 3jdPyRTc4mElEajjTrp8XJXYIqjNnuJqbXaMzsouUJKLrdBcKSagvbSr1lUj7PB0KsRx n9jCmUFFvoRyxMKM5Len/3z94feueuPqg9Lq9zZpejMWja0tZLd4HTZbAv8u1d0DoNb/ 4x6g== X-Received: by 10.15.68.136 with SMTP id w8mr22856590eex.5.1395837774452; Wed, 26 Mar 2014 05:42:54 -0700 (PDT) Received: from [192.168.1.28] ([95.87.231.111]) by mx.google.com with ESMTPSA id q41sm5111012eez.7.2014.03.26.05.42.52 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 26 Mar 2014 05:42:53 -0700 (PDT) Date: Wed, 26 Mar 2014 14:42:51 +0200 From: Bozhidar Batsov To: Dmitry Gutov Message-ID: <0875C1E7651142E5A1CB22EDBF5ACB64@gmail.com> In-Reply-To: <5332C981.9030805@yandex.ru> References: <87bnwzwqu8.fsf@yandex.ru> <532FF702.7090205@yandex.ru> <2EF5A812FAC74FBBBB465952FCFFC2D6@gmail.com> <5332C981.9030805@yandex.ru> Subject: Re: bug#17057: 24.3.50; [ruby-mode] Font-locking of special global variables like $$ is broken(missing) X-Mailer: sparrow 1.6.4 (build 1178) MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="5332cb4b_3f07acc3_fda4" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17057-done Cc: 17057-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --5332cb4b_3f07acc3_fda4 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline I didn=E2=80=99t include them in RuboCop=E2=80=99s code since they actual= ly constitute a different syntactic category according to the parser - a = =E2=80=9Cnth-reference=E2=80=9D. I don=E2=80=99t think we should care abo= ut this in ruby-mode, though. The patch looks great. Given the fact that = Emacs releases are pretty far apart (usually more than 1 year) I think we= should include this given that=E2=80=99s if virtually impossible to intr= oduce a regression. -- =20 Cheers, Bozhidar On Wednesday, March 26, 2014 at 2:35 PM, Dmitry Gutov wrote: > On 24.03.2014 11:45, Bozhidar Batsov wrote: > =20 > > Yeah, seems that everything important is listed there. Here=E2=80=99s= one a bit > > more extensive list, though: > > =20 > > https://github.com/bbatsov/rubocop/blob/master/lib/rubocop/cop/style/= global=5Fvars.rb > > =20 > > It features the JRuby-specific global vars in addition to the standar= d > > ones. > > =20 > =20 > =20 > I see that you don't include the =24(digit) globals, which reference th= e =20 > last regexp-matched groups. The patch below does. > =20 > Not sure if it's okay to install in 24.4, though: on the one hand it's = =20 > low-risk, on the other hand it's not a bugfix. > =20 > =20 > =3D=3D=3D modified file 'lisp/progmodes/ruby-mode.el' > --- lisp/progmodes/ruby-mode.el 2014-03-24 08:53:56 +0000 > +++ lisp/progmodes/ruby-mode.el 2014-03-26 11:33:42 +0000 > =40=40 -2108,13 +2108,28 =40=40 > 1 font-lock-variable-name-face) > ;; Keywords that evaluate to certain values. > (=22=5C=5C=5F<=5F=5F=5C=5C(=3F:LINE=5C=5C=7CENCODING=5C=5C=7C=46ILE=5C=5C= )=5F=5F=5C=5C=5F>=22 > - (0 font-lock-variable-name-face)) > + (0 font-lock-builtin-face)) > ;; Symbols. > =20 > (=22=5C=5C(=5E=5C=5C=7C=5B=5E:=5D=5C=5C)=5C=5C(:=5C=5C(=5B-+=7E=5D=40=3F= =5C=5C=7C=5B/%&=7C=5E=60=5D=5C=5C=7C=5C=5C*=5C=5C*=3F=5C=5C=7C<=5C=5C(<=5C= =5C=7C=3D>=3F=5C=5C)=3F=5C=5C=7C>=5B>=3D=5D=3F=5C=5C=7C=3D=3D=3D=3F=5C=5C= =7C=3D=7E=5C=5C=7C=21=5B=7E=3D=5D=3F=5C=5C=7C=5C=5C=5B=5C=5C=5D=3D=3F=5C=5C= =7C=40=3F=5C=5C(=5C=5Cw=5C=5C=7C=5F=5C=5C)+=5C=5C(=5B=21=3F=3D=5D=5C=5C=7C= =5C=5Cb=5F*=5C=5C)=5C=5C=7C=23=7B=5B=5E=7D=5Cn=5C=5C=5C=5C=5D*=5C=5C(=5C=5C= =5C=5C.=5B=5E=7D=5Cn=5C=5C=5C=5C=5D*=5C=5C)*=7D=5C=5C)=5C=5C)=22 > 2 font-lock-constant-face) > - ;; Variables. > - (=22=5C=5C=24=5B=5Ea-zA-Z =5Cn=5D=22 > - 0 font-lock-variable-name-face) > + ;; Special variables. > + (,(concat =22=5C=5C=24=5C=5C(=3F:=5B:=5C=22=21=40;,/=5C=5C.=5F><=5C=5C= =24=3F=7E=3D*&=60'+0-9=5D=5C=5C=7C-=5B0ad=46iIlpvw=5D=5C=5C=7C=22 > + (regexp-opt '(=22LOAD=5FPATH=22 =22LOADED=5F=46EATURES=22 =22PROGRAM=5F= NAME=22 > + =22ERROR=5FIN=46O=22 =22ERROR=5FPOSITION=22 > + =22=46S=22 =22=46IELD=5FSEPARATOR=22 > + =22O=46S=22 =22OUTPUT=5F=46IELD=5FSEPARATOR=22 > + =22RS=22 =22INPUT=5FRECORD=5FSEPARATOR=22 > + =22ORS=22 =22OUTPUT=5FRECORD=5FSEPARATOR=22 > + =22NR=22 =22INPUT=5FLINE=5FNUMBER=22 > + =22LAST=5FREAD=5FLINE=22 =22DE=46AULT=5FOUTPUT=22 =20 > =22DE=46AULT=5FINPUT=22 > + =22PID=22 =22PROCESS=5FID=22 =22CHILD=5FSTATUS=22 > + =22LAST=5FMATCH=5FIN=46O=22 =22IGNORECASE=22 > + =22ARGV=22 =22MATCH=22 =22PREMATCH=22 =22POSTMATCH=22 > + =22LAST=5FPAREN=5FMATCH=22 =22stdin=22 =22stdout=22 =22stderr=22 > + =22DEBUG=22 =22=46ILENAME=22 =22VERBOSE=22 =22SA=46E=22 =22CLASSPATH=22= > + =22JRUBY=5FVERSION=22 =22JRUBY=5FREVISION=22 =22ENV=5FJAVA=22)) > + =22=5C=5C=5F>=5C=5C)=22) > + 0 font-lock-builtin-face) > (=22=5C=5C(=5C=5C=24=5C=5C=7C=40=5C=5C=7C=40=40=5C=5C)=5C=5C(=5C=5Cw=5C= =5C=7C=5F=5C=5C)+=22 > 0 font-lock-variable-name-face) > ;; Constants. > =20 > =20 --5332cb4b_3f07acc3_fda4 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
I didn=E2=80=99t include them in RuboCop=E2=80=99s code since the= y actually constitute a different syntactic category according to the par= ser - a =E2=80=9Cnth-reference=E2=80=9D. I don=E2=80=99t think we should = care about this in ruby-mode, though. The patch looks great. Given the fa= ct that Emacs releases are pretty far apart (usually more than 1 year) I = think we should include this given that=E2=80=99s if virtually impossible= to introduce a regression.

-- 
Cheers,
=
Bozhidar

=20

On Wednesday, March 26= , 2014 at 2:35 PM, Dmitry Gutov wrote:

On 24.03.2014 11:45, Bozhidar Ba= tsov wrote:

Y= eah, seems that everything important is listed there. Here=E2=80=99s one = a bit
more extensive list, though:


It fe= atures the JRuby-specific global vars in addition to the standard
ones.

I see that you don't= include the =24(digit) globals, which reference the
last rege= xp-matched groups. The patch below does.

Not sur= e if it's okay to install in 24.4, though: on the one hand it's
low-risk, on the other hand it's not a bugfix.


=3D=3D=3D modified file 'lisp/progmodes/ruby-mode.el'
--- lisp/progmodes/ruby-mode.el 2014-03-24 08:53:56 +0000
+++ lisp/progmodes/ruby-mode.el 2014-03-26 11:33:42 +0000
=40= =40 -2108,13 +2108,28 =40=40
1 font-lock-variable-name-f= ace)
;; Keywords that evaluate to certain values.
(=22=5C=5C=5F<=5F=5F=5C=5C(=3F:LINE=5C=5C=7CENCODING=5C=5C=7C= =46ILE=5C=5C)=5F=5F=5C=5C=5F>=22
- (0 font-lock-variable= -name-face))
+ (0 font-lock-builtin-face))
= ;; Symbols.
(=22=5C=5C(=5E=5C=5C=7C=5B=5E:=5D=5C=5C= )=5C=5C(:=5C=5C(=5B-+=7E=5D=40=3F=5C=5C=7C=5B/%&=7C=5E=60=5D=5C=5C=7C= =5C=5C*=5C=5C*=3F=5C=5C=7C<=5C=5C(<=5C=5C=7C=3D>=3F=5C=5C)=3F=5C= =5C=7C>=5B>=3D=5D=3F=5C=5C=7C=3D=3D=3D=3F=5C=5C=7C=3D=7E=5C=5C=7C=21= =5B=7E=3D=5D=3F=5C=5C=7C=5C=5C=5B=5C=5C=5D=3D=3F=5C=5C=7C=40=3F=5C=5C(=5C= =5Cw=5C=5C=7C=5F=5C=5C)+=5C=5C(=5B=21=3F=3D=5D=5C=5C=7C=5C=5Cb=5F*=5C=5C)= =5C=5C=7C=23=7B=5B=5E=7D=5Cn=5C=5C=5C=5C=5D*=5C=5C(=5C=5C=5C=5C.=5B=5E=7D= =5Cn=5C=5C=5C=5C=5D*=5C=5C)*=7D=5C=5C)=5C=5C)=22
2 font-= lock-constant-face)
- ;; Variables.
- (=22=5C=5C= =24=5B=5Ea-zA-Z =5Cn=5D=22
- 0 font-lock-variable-name-face= )
+ ;; Special variables.
+ (,(concat =22=5C=5C= =24=5C=5C(=3F:=5B:=5C=22=21=40;,/=5C=5C.=5F><=5C=5C=24=3F=7E=3D*&am= p;=60'+0-9=5D=5C=5C=7C-=5B0ad=46iIlpvw=5D=5C=5C=7C=22
+ = (regexp-opt '(=22LOAD=5FPATH=22 =22LOADED=5F=46EATURES=22 =22PROGRA= M=5FNAME=22
+ =22ERROR=5FIN=46O=22 =22= ERROR=5FPOSITION=22
+ =22=46S=22 =22= =46IELD=5FSEPARATOR=22
+ =22O=46S=22= =22OUTPUT=5F=46IELD=5FSEPARATOR=22
+ = =22RS=22 =22INPUT=5FRECORD=5FSEPARATOR=22
+ = =22ORS=22 =22OUTPUT=5FRECORD=5FSEPARATOR=22
+ = =22NR=22 =22INPUT=5FLINE=5FNUMBER=22
+ = =22LAST=5FREAD=5FLINE=22 =22DE=46AULT=5FOUTPUT=22 =
=22DE=46AULT=5FINPUT=22
+ = =22PID=22 =22PROCESS=5FID=22 =22CHILD=5FSTATUS=22
+ = =22LAST=5FMATCH=5FIN=46O=22 =22IGNORECASE=22
+= =22ARGV=22 =22MATCH=22 =22PREMATCH=22 =22POST= MATCH=22
+ =22LAST=5FPAREN=5FMATCH=22= =22stdin=22 =22stdout=22 =22stderr=22
+ = =22DEBUG=22 =22=46ILENAME=22 =22VERBOSE=22 =22SA=46E=22 =22CLASSPATH= =22
+ =22JRUBY=5FVERSION=22 =22JRUBY= =5FREVISION=22 =22ENV=5FJAVA=22))
+ =22=5C=5C=5F&g= t;=5C=5C)=22)
+ 0 font-lock-builtin-face)
(= =22=5C=5C(=5C=5C=24=5C=5C=7C=40=5C=5C=7C=40=40=5C=5C)=5C=5C(=5C=5Cw=5C=5C= =7C=5F=5C=5C)+=22
0 font-lock-variable-name-face)
<= div> ;; Constants. =20 =20 =20 =20 =20

--5332cb4b_3f07acc3_fda4-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 04:26:31 2014 Received: (at 17057-done) by debbugs.gnu.org; 27 Mar 2014 08:26:31 +0000 Received: from localhost ([127.0.0.1]:51747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WT5du-00051o-Qc for submit@debbugs.gnu.org; Thu, 27 Mar 2014 04:26:30 -0400 Received: from mail-ee0-f44.google.com ([74.125.83.44]:45916) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WT5ds-00051e-83 for 17057-done@debbugs.gnu.org; Thu, 27 Mar 2014 04:26:28 -0400 Received: by mail-ee0-f44.google.com with SMTP id e49so2517927eek.17 for <17057-done@debbugs.gnu.org>; Thu, 27 Mar 2014 01:26:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=VZ6xJK6WR0LHuOi9ihFkdxQHRbqm4WiThnxCXma/EA8=; b=X8FEos1KAy/D8wwgOcwHtXwvFKelyjMSMRB57xlKxkgb54EMR7GT/6Taakhr0YCPNR Mw6lxWyu82o+R+dHq44GJ101bPvAn44hBQNKlMSOsjJLEVvDa9NoPcFOVUfPGh9UeJxo GpJwMbHSNil7jPtc8EnPXZKmA7ZwrFxdPO2heeu/AstkYyUlRa6CoPsn42nruyu+poTG jnrkbrCd/L80UqSy0+rqDU6cLDmVue0749qZtSzeBVQjApfROx4xA1ISLO3i/WzOgPeX LTHBgPJIrOgZzUQ6rwzPCADOMklsmVXuJsI8HT5PH83WHJDwWPfZMBFXJ6q9xvchCtPH V5ng== X-Received: by 10.15.22.69 with SMTP id e45mr405351eeu.11.1395908787342; Thu, 27 Mar 2014 01:26:27 -0700 (PDT) Received: from [192.168.10.2] (6-67.adsl.cytanet.com.cy. [83.168.6.67]) by mx.google.com with ESMTPSA id h47sm2779418eey.13.2014.03.27.01.26.25 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 27 Mar 2014 01:26:26 -0700 (PDT) Message-ID: <5333E0AF.7040602@yandex.ru> Date: Thu, 27 Mar 2014 10:26:23 +0200 From: Dmitry Gutov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Bozhidar Batsov Subject: Re: bug#17057: 24.3.50; [ruby-mode] Font-locking of special global variables like $$ is broken(missing) References: <87bnwzwqu8.fsf@yandex.ru> <532FF702.7090205@yandex.ru> <2EF5A812FAC74FBBBB465952FCFFC2D6@gmail.com> <5332C981.9030805@yandex.ru> <0875C1E7651142E5A1CB22EDBF5ACB64@gmail.com> In-Reply-To: <0875C1E7651142E5A1CB22EDBF5ACB64@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17057-done Cc: 17057-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 26.03.2014 14:42, Bozhidar Batsov wrote: > Given the fact that Emacs releases are > pretty far apart (usually more than 1 year) I think we should include > this given that’s if virtually impossible to introduce a regression. Okay, this was probably enough time for someone else to weigh in. Guess I'll keep installing small tweaks in ruby-mode until an explicit slap on the wrist. :) emacs-24, r116870. From unknown Sat Aug 16 13:45:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 24 Apr 2014 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator