From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 20 12:23:00 2014 Received: (at submit) by debbugs.gnu.org; 20 Mar 2014 16:23:00 +0000 Received: from localhost ([127.0.0.1]:42497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQfkC-0002XS-7q for submit@debbugs.gnu.org; Thu, 20 Mar 2014 12:23:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41343) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQfkB-0002XI-5N for submit@debbugs.gnu.org; Thu, 20 Mar 2014 12:22:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQfkA-0005pd-9l for submit@debbugs.gnu.org; Thu, 20 Mar 2014 12:22:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:33546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQfkA-0005pS-70 for submit@debbugs.gnu.org; Thu, 20 Mar 2014 12:22:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQfk9-0001Ab-B1 for bug-gnu-emacs@gnu.org; Thu, 20 Mar 2014 12:22:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQfk8-0005nb-Al for bug-gnu-emacs@gnu.org; Thu, 20 Mar 2014 12:22:57 -0400 Received: from mail-yh0-x234.google.com ([2607:f8b0:4002:c01::234]:56240) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQfk8-0005nC-5I for bug-gnu-emacs@gnu.org; Thu, 20 Mar 2014 12:22:56 -0400 Received: by mail-yh0-f52.google.com with SMTP id c41so1074709yho.11 for ; Thu, 20 Mar 2014 09:22:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=vcaaM/eScTzfmhvMgKeI/TZWIgSO9TsTU1kFFViho78=; b=O0zG1wASa0anqA3Mls82WKvSoAKZDGEKz5CxnM9jGSKijLW1JO25dcNFbaPvNfwUD6 j5tpZWfnAgQXvg6Qk6XZ72F8yRp+0ZzHUkdtfZcNBxaQaK8SEvpECNzqwWOIr2dhLWVq krT6AthgXnP6KbqOvuPfPHzgsH/cG7yLqMX7/CqirmYx8A3M97VlZKSttz56fwpHmCMb 74WtWaZBKFY1Kqfwv/hGWR8nrjPrqOjb6jZdb9dgJaBLDq7GcNu3qUS1wZc+6JUqETnE +K157OWoQ9jJ2LWjKPw58g690mmMkPXqfJkMqAy/z8nFimFePpX8451B5P04UNE+Rc7l wZBg== X-Received: by 10.236.91.67 with SMTP id g43mr3365999yhf.146.1395332575661; Thu, 20 Mar 2014 09:22:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.170.163.3 with HTTP; Thu, 20 Mar 2014 09:22:15 -0700 (PDT) From: Juanma Barranquero Date: Thu, 20 Mar 2014 17:22:15 +0100 Message-ID: Subject: substitute-command-keys strips text properties To: Bug-Gnu-Emacs Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Package: emacs Severity: wishlist Currently, substitute-command-keys returns a string with text properties stripped. This should be fixed. One specific case where it matters is in docstrings of advised functions, as discussed in the thread for bug#16993. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 14 20:55:38 2019 Received: (at 17052) by debbugs.gnu.org; 15 Aug 2019 00:55:38 +0000 Received: from localhost ([127.0.0.1]:49971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hy43G-0007ts-9x for submit@debbugs.gnu.org; Wed, 14 Aug 2019 20:55:38 -0400 Received: from quimby.gnus.org ([80.91.231.51]:58994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hy43E-0007tg-9H for 17052@debbugs.gnu.org; Wed, 14 Aug 2019 20:55:36 -0400 Received: from 24-104-73-23-ip-static.hfc.comcastbusiness.net ([24.104.73.23] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hy438-0005xJ-OB; Thu, 15 Aug 2019 02:55:33 +0200 From: Lars Ingebrigtsen To: Juanma Barranquero Subject: Re: bug#17052: substitute-command-keys strips text properties References: Date: Wed, 14 Aug 2019 17:55:28 -0700 In-Reply-To: (Juanma Barranquero's message of "Thu, 20 Mar 2014 17:22:15 +0100") Message-ID: <871rxns0vz.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juanma Barranquero writes: > Currently, substitute-command-keys returns a string with text > properties stripped. This should be fixed. > > One specific case where it matters is in docstrings of advised > functions, as discusse [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17052 Cc: 17052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juanma Barranquero writes: > Currently, substitute-command-keys returns a string with text > properties stripped. This should be fixed. > > One specific case where it matters is in docstrings of advised > functions, as discussed in the thread for bug#16993. (I'm going through old bug reports that have unfortunately gotten no responses yet.) Looks like this has been fixed sometime in the intervening years? (substitute-command-keys (propertize "foo" 'face 'bold)) => #("foo" 0 3 (face bold)) So I'm closing this bug report. If this is still a problem, please reopen. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 14 20:55:45 2019 Received: (at control) by debbugs.gnu.org; 15 Aug 2019 00:55:46 +0000 Received: from localhost ([127.0.0.1]:49974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hy43N-0007uF-K9 for submit@debbugs.gnu.org; Wed, 14 Aug 2019 20:55:45 -0400 Received: from quimby.gnus.org ([80.91.231.51]:59008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hy43M-0007u8-3Z for control@debbugs.gnu.org; Wed, 14 Aug 2019 20:55:44 -0400 Received: from 24-104-73-23-ip-static.hfc.comcastbusiness.net ([24.104.73.23] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hy43J-0005xQ-2t for control@debbugs.gnu.org; Thu, 15 Aug 2019 02:55:43 +0200 Date: Wed, 14 Aug 2019 17:55:39 -0700 Message-Id: <87zhkbqmb8.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #17052 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 17052 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 17052 quit From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 14 21:35:01 2019 Received: (at 17052) by debbugs.gnu.org; 15 Aug 2019 01:35:01 +0000 Received: from localhost ([127.0.0.1]:50052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hy4fN-0006td-0c for submit@debbugs.gnu.org; Wed, 14 Aug 2019 21:35:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hy4fK-0006tO-Rv for 17052@debbugs.gnu.org; Wed, 14 Aug 2019 21:34:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hy4fE-000892-CB; Wed, 14 Aug 2019 21:34:53 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1hy4f9-0001dD-HS; Wed, 14 Aug 2019 21:34:47 -0400 From: Glenn Morris To: Lars Ingebrigtsen Subject: Re: bug#17052: substitute-command-keys strips text properties References: <871rxns0vz.fsf@mouse.gnus.org> X-Spook: IRA [Hello to all my friends and fans in domestic X-Ran: aoa[]U4WLBdv+)|dvt?.: X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 14 Aug 2019 21:34:47 -0400 In-Reply-To: <871rxns0vz.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Wed, 14 Aug 2019 17:55:28 -0700") Message-ID: <1xh86jb494.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 17052 Cc: Juanma Barranquero , 17052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen wrote: > Looks like this has been fixed sometime in the intervening years? > > (substitute-command-keys (propertize "foo" 'face 'bold)) > => #("foo" 0 3 (face bold)) Nope, you need to use an example which does a substitution, eg (substitute-command-keys (propertize "foo \\[find-file]" 'face 'bold)) The doc of substitute-command-keys used to mention this, but it was somewhat prematurely removed in 049fac7. From unknown Wed Jun 25 02:10:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Thu, 15 Aug 2019 01:36:01 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 14 21:59:05 2019 Received: (at 17052) by debbugs.gnu.org; 15 Aug 2019 01:59:05 +0000 Received: from localhost ([127.0.0.1]:50096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hy52f-0001By-E4 for submit@debbugs.gnu.org; Wed, 14 Aug 2019 21:59:05 -0400 Received: from quimby.gnus.org ([80.91.231.51]:60624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hy52d-0001Bo-Hd for 17052@debbugs.gnu.org; Wed, 14 Aug 2019 21:59:03 -0400 Received: from 24-104-73-23-ip-static.hfc.comcastbusiness.net ([24.104.73.23] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hy52Z-0006Vt-Jw; Thu, 15 Aug 2019 03:59:02 +0200 From: Lars Ingebrigtsen To: Glenn Morris Subject: Re: bug#17052: substitute-command-keys strips text properties References: <871rxns0vz.fsf@mouse.gnus.org> <1xh86jb494.fsf@fencepost.gnu.org> Date: Wed, 14 Aug 2019 18:58:57 -0700 In-Reply-To: <1xh86jb494.fsf@fencepost.gnu.org> (Glenn Morris's message of "Wed, 14 Aug 2019 21:34:47 -0400") Message-ID: <87tvaj6vfi.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Glenn Morris writes: > Lars Ingebrigtsen wrote: > >> Looks like this has been fixed sometime in the intervening years? >> >> (substitute-command-keys (propertize "foo" 'face 'bold)) >> => #("foo" 0 3 (face bold)) > > Nope [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17052 Cc: Juanma Barranquero , 17052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Glenn Morris writes: > Lars Ingebrigtsen wrote: > >> Looks like this has been fixed sometime in the intervening years? >> >> (substitute-command-keys (propertize "foo" 'face 'bold)) >> => #("foo" 0 3 (face bold)) > > Nope, you need to use an example which does a substitution, eg > > (substitute-command-keys (propertize "foo \\[find-file]" 'face 'bold)) Ah, I see. I've now reopened the bug report again. > The doc of substitute-command-keys used to mention this, but it was > somewhat prematurely removed in 049fac7. Heh, heh: (Fsubstitute_command_keys): Don't advertise the fact that text-properties are dropped, since we think it's a bug that we'll fix in 24.5. Should I just put it back in the doc string, or do we still think that we'll fix it? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 15 12:46:26 2019 Received: (at 17052) by debbugs.gnu.org; 15 Aug 2019 16:46:26 +0000 Received: from localhost ([127.0.0.1]:52377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyItN-0000Us-1B for submit@debbugs.gnu.org; Thu, 15 Aug 2019 12:46:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyItL-0000P5-BK for 17052@debbugs.gnu.org; Thu, 15 Aug 2019 12:46:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hyItG-00005v-4k; Thu, 15 Aug 2019 12:46:18 -0400 Received: from [176.228.60.248] (port=2122 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hyItC-0007az-KV; Thu, 15 Aug 2019 12:46:14 -0400 Date: Thu, 15 Aug 2019 19:46:06 +0300 Message-Id: <83sgq2peb5.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87tvaj6vfi.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Wed, 14 Aug 2019 18:58:57 -0700) Subject: Re: bug#17052: substitute-command-keys strips text properties References: <871rxns0vz.fsf@mouse.gnus.org> <1xh86jb494.fsf@fencepost.gnu.org> <87tvaj6vfi.fsf@mouse.gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 17052 Cc: rgm@gnu.org, 17052@debbugs.gnu.org, lekktu@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Date: Wed, 14 Aug 2019 18:58:57 -0700 > Cc: Juanma Barranquero , 17052@debbugs.gnu.org > > > The doc of substitute-command-keys used to mention this, but it was > > somewhat prematurely removed in 049fac7. > > Heh, heh: > > (Fsubstitute_command_keys): Don't advertise the fact that > text-properties are dropped, since we think it's a bug that we'll fix > in 24.5. > > Should I just put it back in the doc string, or do we still think that > we'll fix it? I don't think it matters (unless you want to fix this right now ;-). We should document the situation and leave the bug open for the possibility that someone would like to work on this. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 15 18:42:29 2019 Received: (at 17052) by debbugs.gnu.org; 15 Aug 2019 22:42:29 +0000 Received: from localhost ([127.0.0.1]:52603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyORx-0002xX-FZ for submit@debbugs.gnu.org; Thu, 15 Aug 2019 18:42:29 -0400 Received: from quimby.gnus.org ([80.91.231.51]:48542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyORv-0002xO-91 for 17052@debbugs.gnu.org; Thu, 15 Aug 2019 18:42:27 -0400 Received: from [50.225.213.182] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hyORq-0007jK-7T; Fri, 16 Aug 2019 00:42:25 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#17052: substitute-command-keys strips text properties References: <871rxns0vz.fsf@mouse.gnus.org> <1xh86jb494.fsf@fencepost.gnu.org> <87tvaj6vfi.fsf@mouse.gnus.org> <83sgq2peb5.fsf@gnu.org> Date: Thu, 15 Aug 2019 15:42:18 -0700 In-Reply-To: <83sgq2peb5.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 15 Aug 2019 19:46:06 +0300") Message-ID: <87h86iuk39.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: >> Heh, heh: >> >> (Fsubstitute_command_keys): Don't advertise the fact that >> text-properties are dropped, since we think it's a bug that we'll fix >> in 24.5. >> >> Should I just put it back in the [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17052 Cc: rgm@gnu.org, 17052@debbugs.gnu.org, lekktu@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Heh, heh: >> >> (Fsubstitute_command_keys): Don't advertise the fact that >> text-properties are dropped, since we think it's a bug that we'll fix >> in 24.5. >> >> Should I just put it back in the doc string, or do we still think that >> we'll fix it? > > I don't think it matters (unless you want to fix this right now ;-). I had a look at that function now and, er, no. :-) Perhaps it should be rewritten in Emacs Lisp? Then it'd be pretty trivial to fix this stuff. > We should document the situation and leave the bug open for the > possibility that someone would like to work on this. Document the situation by just putting back into the doc string that it doesn't copy text properties in some situations? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 16 02:48:13 2019 Received: (at 17052) by debbugs.gnu.org; 16 Aug 2019 06:48:13 +0000 Received: from localhost ([127.0.0.1]:52963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyW1z-0006Q6-Oz for submit@debbugs.gnu.org; Fri, 16 Aug 2019 02:48:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyW1y-0006Pu-KS for 17052@debbugs.gnu.org; Fri, 16 Aug 2019 02:48:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33532) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hyW1r-0005RP-Qp; Fri, 16 Aug 2019 02:48:04 -0400 Received: from [176.228.60.248] (port=1538 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hyW1q-0008Dd-2M; Fri, 16 Aug 2019 02:48:03 -0400 Date: Fri, 16 Aug 2019 09:47:56 +0300 Message-Id: <83ftm1ppwj.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87h86iuk39.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Thu, 15 Aug 2019 15:42:18 -0700) Subject: Re: bug#17052: substitute-command-keys strips text properties References: <871rxns0vz.fsf@mouse.gnus.org> <1xh86jb494.fsf@fencepost.gnu.org> <87tvaj6vfi.fsf@mouse.gnus.org> <83sgq2peb5.fsf@gnu.org> <87h86iuk39.fsf@mouse.gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 17052 Cc: rgm@gnu.org, 17052@debbugs.gnu.org, lekktu@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: rgm@gnu.org, 17052@debbugs.gnu.org, lekktu@gmail.com > Date: Thu, 15 Aug 2019 15:42:18 -0700 > > > We should document the situation and leave the bug open for the > > possibility that someone would like to work on this. > > Document the situation by just putting back into the doc string that it > doesn't copy text properties in some situations? That's what I meant, yes. Is there a problem with that which I missed? From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 16 03:04:30 2019 Received: (at 17052) by debbugs.gnu.org; 16 Aug 2019 07:04:30 +0000 Received: from localhost ([127.0.0.1]:52987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyWHm-0000Ug-3A for submit@debbugs.gnu.org; Fri, 16 Aug 2019 03:04:30 -0400 Received: from quimby.gnus.org ([80.91.231.51]:55216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyWHj-0000UY-Dh for 17052@debbugs.gnu.org; Fri, 16 Aug 2019 03:04:28 -0400 Received: from [50.225.213.182] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hyWHe-0003EW-1N; Fri, 16 Aug 2019 09:04:26 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#17052: substitute-command-keys strips text properties References: <871rxns0vz.fsf@mouse.gnus.org> <1xh86jb494.fsf@fencepost.gnu.org> <87tvaj6vfi.fsf@mouse.gnus.org> <83sgq2peb5.fsf@gnu.org> <87h86iuk39.fsf@mouse.gnus.org> <83ftm1ppwj.fsf@gnu.org> Date: Fri, 16 Aug 2019 00:04:19 -0700 In-Reply-To: <83ftm1ppwj.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 16 Aug 2019 09:47:56 +0300") Message-ID: <878srtr3po.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: >> From: Lars Ingebrigtsen >> Cc: rgm@gnu.org, 17052@debbugs.gnu.org, lekktu@gmail.com >> Date: Thu, 15 Aug 2019 15:42:18 -0700 >> >> > We should document the situation and leave the [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17052 Cc: rgm@gnu.org, 17052@debbugs.gnu.org, lekktu@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Lars Ingebrigtsen >> Cc: rgm@gnu.org, 17052@debbugs.gnu.org, lekktu@gmail.com >> Date: Thu, 15 Aug 2019 15:42:18 -0700 >> >> > We should document the situation and leave the bug open for the >> > possibility that someone would like to work on this. >> >> Document the situation by just putting back into the doc string that it >> doesn't copy text properties in some situations? > > That's what I meant, yes. Is there a problem with that which I > missed? No, I was just wondering whether you meant documenting it in some other way since my question was >>> Should I just put it back in the doc string, or do we still think that >>> we'll fix it? and your answer wasn't "just put it back in the doc string". :-) Which I'll now do, but leave the bug report open. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 18 13:08:37 2019 Received: (at 17052) by debbugs.gnu.org; 18 Aug 2019 17:08:37 +0000 Received: from localhost ([127.0.0.1]:58474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzOfV-0001Co-2v for submit@debbugs.gnu.org; Sun, 18 Aug 2019 13:08:37 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:35596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzOfT-0001CY-NG; Sun, 18 Aug 2019 13:08:36 -0400 Received: by mail-pf1-f194.google.com with SMTP id d85so5749031pfd.2; Sun, 18 Aug 2019 10:08:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JMFcqfbFuqHfFnXTrc3nd1wja1ihRkoSAwWLaMWR0BE=; b=Ut12Uf9JcQqrOip48Uz6t3p07TwkxGrzPxdiZHyVZ5tItQr1lbeN/YF3ZhRYzbiESB 5OMivx3JCI/IZv97wIAxVzsPpki8kqlabPbDpQazh0WPjIIp84LA9KGnepe1wIMdbOUr DGUutEmcz+qZnNYqrrc6FGQRIG09Sf0WFDr0Gtlwe7WVCOJ+SSIvs3NBo65hOF01wjik kDfSr2SdZXxB/ZIcxCp1l2lUrr6JVbITgaHiRfHVN1EEfA9y1cU++iCeED9fyq4CHMLR NVcS+0gLxdZdNc6F/Ps3+huTNDGXcrfbTvlDv16PyEhKkP6swqikAhMfMReUakuxav5T GUMg== X-Gm-Message-State: APjAAAU+yQbLP+lvI5zvT2AMVJVeqWCBB08gs8pzHco7mvo0KiOy53TV WYqZwz7j3bp0nojKgQO7+Ugm1j3vDntZFuy+dfc= X-Google-Smtp-Source: APXvYqyAY3glRKkL3hM+U9V+WjNIECBi8VmLyCAkGPYFl4lnxSIR/Zc2aIw7hu69R8UJJNkpBRvCDHQchzr7k6XBjUc= X-Received: by 2002:a62:7789:: with SMTP id s131mr20360678pfc.50.1566148110116; Sun, 18 Aug 2019 10:08:30 -0700 (PDT) MIME-Version: 1.0 References: <871rxns0vz.fsf@mouse.gnus.org> <1xh86jb494.fsf@fencepost.gnu.org> <87tvaj6vfi.fsf@mouse.gnus.org> <83sgq2peb5.fsf@gnu.org> <87h86iuk39.fsf@mouse.gnus.org> In-Reply-To: <87h86iuk39.fsf@mouse.gnus.org> From: Stefan Kangas Date: Sun, 18 Aug 2019 19:08:18 +0200 Message-ID: Subject: Re: bug#17052: substitute-command-keys strips text properties To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 17052 Cc: lekktu@gmail.com, Eli Zaretskii , 8951@debbugs.gnu.org, 17052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) [In reply to Bug#17052 and cross-posting to Bug#8951.] Lars Ingebrigtsen writes: > I had a look at that function now and, er, no. :-) Perhaps it should > be rewritten in Emacs Lisp? Then it'd be pretty trivial to fix this > stuff. The Fsubstitute_command_keys function is indeed a bit hairy, and I agree that a conversion to Lisp is the most reasonable next step. I've actually been working a patch to convert it to Lisp for Bug#8951, but it's not finished yet. The difficulty is that it has a couple of helper functions that also needs to be lifted, which makes the job bigger than just the function Fsubstitute_command_keys. My goal is to get the Lisp version to produce the same output as the C version, which currently seems to be a feasible goal. Once it's in Lisp it should be easier to make further improvements, fix bugs, etc. Thanks, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 18 13:19:36 2019 Received: (at 17052) by debbugs.gnu.org; 18 Aug 2019 17:19:36 +0000 Received: from localhost ([127.0.0.1]:58491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzOq8-0001Tx-Gs for submit@debbugs.gnu.org; Sun, 18 Aug 2019 13:19:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzOq5-0001Te-LI; Sun, 18 Aug 2019 13:19:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34063) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hzOq0-0000dH-3H; Sun, 18 Aug 2019 13:19:28 -0400 Received: from [176.228.60.248] (port=2509 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hzOpz-0008S2-J8; Sun, 18 Aug 2019 13:19:27 -0400 Date: Sun, 18 Aug 2019 20:19:26 +0300 Message-Id: <83d0h2mlwh.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: (message from Stefan Kangas on Sun, 18 Aug 2019 19:08:18 +0200) Subject: Re: bug#17052: substitute-command-keys strips text properties References: <871rxns0vz.fsf@mouse.gnus.org> <1xh86jb494.fsf@fencepost.gnu.org> <87tvaj6vfi.fsf@mouse.gnus.org> <83sgq2peb5.fsf@gnu.org> <87h86iuk39.fsf@mouse.gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 17052 Cc: lekktu@gmail.com, larsi@gnus.org, 8951@debbugs.gnu.org, 17052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Sun, 18 Aug 2019 19:08:18 +0200 > Cc: Eli Zaretskii , 17052@debbugs.gnu.org, lekktu@gmail.com, > 8951@debbugs.gnu.org > > > I had a look at that function now and, er, no. :-) Perhaps it should > > be rewritten in Emacs Lisp? Then it'd be pretty trivial to fix this > > stuff. > > The Fsubstitute_command_keys function is indeed a bit hairy, and I > agree that a conversion to Lisp is the most reasonable next step. > > I've actually been working a patch to convert it to Lisp for Bug#8951, > but it's not finished yet. The difficulty is that it has a couple of > helper functions that also needs to be lifted, which makes the job > bigger than just the function Fsubstitute_command_keys. > > My goal is to get the Lisp version to produce the same output as the C > version, which currently seems to be a feasible goal. Once it's in > Lisp it should be easier to make further improvements, fix bugs, etc. Maybe we should first talk a bit about why Lars you think it would be "pretty trivial" to keep properties in Lisp, but not in C. I'm probably missing something very basic here, because I don't see why it would be easier in Lisp. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 18 13:19:58 2019 Received: (at 17052) by debbugs.gnu.org; 18 Aug 2019 17:19:58 +0000 Received: from localhost ([127.0.0.1]:58496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzOqU-0001Ue-58 for submit@debbugs.gnu.org; Sun, 18 Aug 2019 13:19:58 -0400 Received: from quimby.gnus.org ([80.91.231.51]:42126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzOqR-0001UQ-Vu; Sun, 18 Aug 2019 13:19:56 -0400 Received: from [50.225.213.182] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hzOqN-0000x2-AA; Sun, 18 Aug 2019 19:19:54 +0200 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#17052: substitute-command-keys strips text properties References: <871rxns0vz.fsf@mouse.gnus.org> <1xh86jb494.fsf@fencepost.gnu.org> <87tvaj6vfi.fsf@mouse.gnus.org> <83sgq2peb5.fsf@gnu.org> <87h86iuk39.fsf@mouse.gnus.org> Date: Sun, 18 Aug 2019 10:19:48 -0700 In-Reply-To: (Stefan Kangas's message of "Sun, 18 Aug 2019 19:08:18 +0200") Message-ID: <87k1ba5r2j.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > I've actually been working a patch to convert it to Lisp for Bug#8951, > but it's not finished yet. The difficulty is that it has a couple of > helper functions that also needs to be lifted, which m [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17052 Cc: lekktu@gmail.com, Eli Zaretskii , 8951@debbugs.gnu.org, 17052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > I've actually been working a patch to convert it to Lisp for Bug#8951, > but it's not finished yet. The difficulty is that it has a couple of > helper functions that also needs to be lifted, which makes the job > bigger than just the function Fsubstitute_command_keys. > > My goal is to get the Lisp version to produce the same output as the C > version, which currently seems to be a feasible goal. Once it's in > Lisp it should be easier to make further improvements, fix bugs, etc. Sounds great! -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 18 18:43:49 2019 Received: (at 17052) by debbugs.gnu.org; 18 Aug 2019 22:43:49 +0000 Received: from localhost ([127.0.0.1]:58889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzTts-00063D-S2 for submit@debbugs.gnu.org; Sun, 18 Aug 2019 18:43:49 -0400 Received: from quimby.gnus.org ([80.91.231.51]:46530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzTto-00062r-3x; Sun, 18 Aug 2019 18:43:44 -0400 Received: from [12.144.191.101] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hzTti-0003B2-I4; Mon, 19 Aug 2019 00:43:41 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#17052: substitute-command-keys strips text properties References: <871rxns0vz.fsf@mouse.gnus.org> <1xh86jb494.fsf@fencepost.gnu.org> <87tvaj6vfi.fsf@mouse.gnus.org> <83sgq2peb5.fsf@gnu.org> <87h86iuk39.fsf@mouse.gnus.org> <83d0h2mlwh.fsf@gnu.org> Date: Sun, 18 Aug 2019 15:43:35 -0700 In-Reply-To: <83d0h2mlwh.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 18 Aug 2019 20:19:26 +0300") Message-ID: <87zhk63xig.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > Maybe we should first talk a bit about why Lars you think it would be > "pretty trivial" to keep properties in Lisp, but not in C. I'm > probably missing something very basic here, because I don't s [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17052 Cc: lekktu@gmail.com, Stefan Kangas , 8951@debbugs.gnu.org, 17052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Maybe we should first talk a bit about why Lars you think it would be > "pretty trivial" to keep properties in Lisp, but not in C. I'm > probably missing something very basic here, because I don't see why > it would be easier in Lisp. Anything is easier in Lisp, surely. But if you look at that function in particular, it's written in a very C-ey fashion, what with copying over characters one by one etc. It could be rewritten (in C) to use the proper primitives we have that preserve text properties (Fsubstring etc), but then you'd just end up with a more long-winded version that would be Lisp-in-C, so we might as well just rewrite it in Lisp. It'll probably be a fraction of the code length. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 19 11:27:47 2019 Received: (at 17052) by debbugs.gnu.org; 19 Aug 2019 15:27:47 +0000 Received: from localhost ([127.0.0.1]:60432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzjZS-0001nT-Sn for submit@debbugs.gnu.org; Mon, 19 Aug 2019 11:27:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzjZN-0001n2-0m; Mon, 19 Aug 2019 11:27:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55118) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hzjZH-0000f6-Jc; Mon, 19 Aug 2019 11:27:35 -0400 Received: from [176.228.60.248] (port=4300 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hzjZC-0003E3-0L; Mon, 19 Aug 2019 11:27:33 -0400 Date: Mon, 19 Aug 2019 18:27:32 +0300 Message-Id: <83tvadkwez.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87zhk63xig.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Sun, 18 Aug 2019 15:43:35 -0700) Subject: Re: bug#17052: substitute-command-keys strips text properties References: <871rxns0vz.fsf@mouse.gnus.org> <1xh86jb494.fsf@fencepost.gnu.org> <87tvaj6vfi.fsf@mouse.gnus.org> <83sgq2peb5.fsf@gnu.org> <87h86iuk39.fsf@mouse.gnus.org> <83d0h2mlwh.fsf@gnu.org> <87zhk63xig.fsf@mouse.gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 17052 Cc: lekktu@gmail.com, stefan@marxist.se, 8951@debbugs.gnu.org, 17052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: Stefan Kangas , 17052@debbugs.gnu.org, > lekktu@gmail.com, 8951@debbugs.gnu.org > Date: Sun, 18 Aug 2019 15:43:35 -0700 > > But if you look at that function in particular, it's written in a very > C-ey fashion, what with copying over characters one by one etc. It > could be rewritten (in C) to use the proper primitives we have that > preserve text properties (Fsubstring etc), but then you'd just end up > with a more long-winded version that would be Lisp-in-C, so we might as > well just rewrite it in Lisp. AFAIU, the problematic parts are not those which copy characters one by one, the problematic parts are those which _substitute_ one text with another. In that case, you need to adjust the text properties or cons them out of thin air. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 20:24:12 2020 Received: (at 17052) by debbugs.gnu.org; 17 Nov 2020 01:24:12 +0000 Received: from localhost ([127.0.0.1]:57868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kepjA-0001nx-1T for submit@debbugs.gnu.org; Mon, 16 Nov 2020 20:24:12 -0500 Received: from mail-ej1-f53.google.com ([209.85.218.53]:35270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kepj7-0001nc-SE for 17052@debbugs.gnu.org; Mon, 16 Nov 2020 20:24:10 -0500 Received: by mail-ej1-f53.google.com with SMTP id f23so27201464ejk.2 for <17052@debbugs.gnu.org>; Mon, 16 Nov 2020 17:24:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=iw3CZpwJLbiWqnJCjgfGWi3Vff9ilcyo4yETYT80ARE=; b=coDwbsNS1pDiyhSSUXlHiGWlfqZULEZU4ozeAW/I8l3ADwCeevKSTcDtucHAZ48Aiu UARtglgDaYETa2iQSW0oei9tewV1ndG/pWTLrrvSwsZfQ+uWphM43gsy3RJWJq0wo1y0 HOnV1A8h15LvZ46iUthK6TrH53HFWPorLC7IesAyLyHFeiW1dNgsENl6Hlv6iCrlngJ5 fM1ZpjbRAeZ9+ycPvSMmNeQKd10khICscbOHZt2FMNfxc8qqop447/o5KTcfGJExyeGV 3HHgpfHF16X/u+MJbgHTSf9wwQ0AGT+XC+ohCroF9jWRwcc8UThd5Z0ueSh00vuEDgTI HE5A== X-Gm-Message-State: AOAM530JI7lMkttzs+0Womh9QKActSyoBE5LXgOmuFB3cQdp6ucce3iw EvFW5TdOrGvPzMNxuIVf3H//Ofbys810p8eQKD0= X-Google-Smtp-Source: ABdhPJw2LfX9CSEVHwYUbgz2FrQ7r0dHzNKDPeasS1nrVrepGUXwO0X/11aqw0NlYxMc0M031vMinwZ1oincguOwsp4= X-Received: by 2002:a17:906:519b:: with SMTP id y27mr16713374ejk.25.1605576244007; Mon, 16 Nov 2020 17:24:04 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 16 Nov 2020 17:24:03 -0800 From: Stefan Kangas In-Reply-To: <1xh86jb494.fsf@fencepost.gnu.org> (Glenn Morris's message of "Wed, 14 Aug 2019 21:34:47 -0400") References: <871rxns0vz.fsf@mouse.gnus.org> <1xh86jb494.fsf@fencepost.gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Mon, 16 Nov 2020 17:24:03 -0800 Message-ID: Subject: Re: bug#17052: substitute-command-keys strips text properties To: Glenn Morris Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 17052 Cc: Juanma Barranquero , Lars Ingebrigtsen , 17052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) close 17052 28.1 thanks Glenn Morris writes: >> Looks like this has been fixed sometime in the intervening years? >> >> (substitute-command-keys (propertize "foo" 'face 'bold)) >> => #("foo" 0 3 (face bold)) > > Nope, you need to use an example which does a substitution, eg > > (substitute-command-keys (propertize "foo \\[find-file]" 'face 'bold)) This was fixed by the recent rewrite of substitute-command-keys in Lisp. I've added a test for this in commit 27655f9f38, and am therefore closing this bug. (For posterity, the root cause for this was that `princ' does not preserve text properties. The code now uses `insert' instead.) From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 20:37:41 2020 Received: (at 17052) by debbugs.gnu.org; 17 Nov 2020 01:37:41 +0000 Received: from localhost ([127.0.0.1]:57877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kepwD-0004Db-94 for submit@debbugs.gnu.org; Mon, 16 Nov 2020 20:37:41 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:57198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kepw7-0004DI-GW for 17052@debbugs.gnu.org; Mon, 16 Nov 2020 20:37:39 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AH1YVYp095070; Tue, 17 Nov 2020 01:37:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=39V+4b/2kQy+lk2/ozYdwBob5bVgbk7G2U+4I4S83Ec=; b=ePnTu4n7RnRirMAGFytbrrp9gwa5u1JBJNE92LpFlhAFz9L8pzh+caT+Mjh5YmH6YSdS XS+WMYYdWNDktK/KOkiNLRLf6AOh14+PmNi1h1G01SUJAdHd4fyX6yln8muSEwC6w+8W W1UgL2DPwZdbpQR6F2ZGLMLNky7bHHGDqc9tvYdNYKVtCwFcORYzCT5FqH0lXNqkK0iB XYSndNtu7xwzMCTTLl4xenYmmEpIbX7T35Ap9wCcJFSis6QlY4amqI1xTrCKgVg2DdK0 A2T4CbOEwNDJ68imI+Ngycytqeu4F3h79uxvgaS4d9uYQ8H+R/7TqBtxpZjKL2fa314H +g== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2130.oracle.com with ESMTP id 34t4rar8cs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 17 Nov 2020 01:37:29 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AH1ZEx5098392; Tue, 17 Nov 2020 01:37:29 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 34umcxhj2y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Nov 2020 01:37:29 +0000 Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0AH1bRl2030947; Tue, 17 Nov 2020 01:37:27 GMT MIME-Version: 1.0 Message-ID: Date: Mon, 16 Nov 2020 17:37:26 -0800 (PST) From: Drew Adams To: Stefan Kangas , Glenn Morris Subject: RE: bug#17052: substitute-command-keys strips text properties, bug#8911: huh? X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5071.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9807 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 phishscore=0 spamscore=0 bulkscore=0 mlxlogscore=897 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011170011 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9807 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 clxscore=1011 malwarescore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=909 adultscore=0 phishscore=0 suspectscore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011170011 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 17052 Cc: Juanma Barranquero , Lars Ingebrigtsen , 17052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > close 17052 28.1 > thanks I don't understand the relation between this bug, #17052, and bug #8911. Half of the messages in the 8911 thread are about 17052, and the subjects seem quite different. But it looks like 8911 is still open (wishlist). Is that correct? Why/how did these two bugs get overlapped or combined? From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 21:35:04 2020 Received: (at 17052) by debbugs.gnu.org; 17 Nov 2020 02:35:04 +0000 Received: from localhost ([127.0.0.1]:57913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keqpk-0007iM-7i for submit@debbugs.gnu.org; Mon, 16 Nov 2020 21:35:04 -0500 Received: from mail-ej1-f41.google.com ([209.85.218.41]:34052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keqpi-0007ho-Fw for 17052@debbugs.gnu.org; Mon, 16 Nov 2020 21:35:03 -0500 Received: by mail-ej1-f41.google.com with SMTP id o9so27325890ejg.1 for <17052@debbugs.gnu.org>; Mon, 16 Nov 2020 18:35:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=dlgFntn0Ft06indLiWLNkQza/HUr69Yoy1i1WSbjk0g=; b=O4P6fT5lG/sdVW/TFpLosnpw82CHggOSrh2uSknCOf0b8m1qVgQGVP2Pz+fGL0OgcE u6FD1oVBWRExRtuXjn0FGjHXqekMsWd8HSnf9bpl/Z7uHtB/DgYwsR4IJoOB9n6gUvs+ d4DBjcSQGnaXP6CSjHfpNseTZjLAufcaa5ROoovFU1kABjSufVxpRX3xt+MGHfoi9vPw tlxgID5aUu4SI5cumZi9GIUWx7qUVE0FB4NWuS80TI7AlahCsHxwO04npC2ohTRcMpxU 4HdT7hKq9GEL8opFLUaF/0JUIVZLcGJHh57G1G8mb+kQ5DrH0bGhZ/TswrsdBMHc7fLz 5uMA== X-Gm-Message-State: AOAM531KnncshgHvaxUe6haGIyj+JWAzMaI96sWbLoJimjxR6v3lQUXF RgElny12+1OlidP3E3wsjcpR8R9NXh12C4C6ISw= X-Google-Smtp-Source: ABdhPJxQd1/lEY0gDAZYbX50EM+J6jivfxtmOldCtI5goeijAwDO/0AF/G1Z+oR7BOK+Iwq84YS1NKGn7QVhe1qCW3o= X-Received: by 2002:a17:906:ce24:: with SMTP id sd4mr16983513ejb.432.1605580496687; Mon, 16 Nov 2020 18:34:56 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 16 Nov 2020 18:34:56 -0800 From: Stefan Kangas In-Reply-To: References: MIME-Version: 1.0 Date: Mon, 16 Nov 2020 18:34:56 -0800 Message-ID: Subject: RE: bug#17052: substitute-command-keys strips text properties, bug#8911: huh? To: Drew Adams , Glenn Morris Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 17052 Cc: Juanma Barranquero , Lars Ingebrigtsen , 17052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Drew Adams writes: > I don't understand the relation between this bug, #17052, > and bug #8911. Half of the messages in the 8911 thread > are about 17052, and the subjects seem quite different. > > But it looks like 8911 is still open (wishlist). Is that ^^^^ you probably mean 8951 > correct? Why/how did these two bugs get overlapped or > combined? It was my perhaps ill-advised attempt to combine the discussions about the Lisp conversion of `substitute-command-keys'. (FWIW, I intend to look into Bug#8951 soon-ish.) From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 22:02:21 2020 Received: (at 17052) by debbugs.gnu.org; 17 Nov 2020 03:02:21 +0000 Received: from localhost ([127.0.0.1]:57939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kerG9-0008NY-It for submit@debbugs.gnu.org; Mon, 16 Nov 2020 22:02:21 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:51314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kerG6-0008NJ-Vh for 17052@debbugs.gnu.org; Mon, 16 Nov 2020 22:02:20 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AH2sDSB023211; Tue, 17 Nov 2020 03:02:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=A4jW/SlazBrBfKSxmf5w+4d2w5RbIL1FVlcq9/NcO4I=; b=aF9Zhj3ncs3KlGKwvJHwTlpls/PZW3Tits434uJpTQsrCIL2Jut+WaV4wNsHE87R1jY+ S35wbJjKkZ8KFE5d3d+w/1CbEmeRtByVuw0XV7XssOUJBkCCZM5ZCTtwh0M2I84CRTp/ inUso4+2No1SUtG+fbzo7HbmRmYjXr2uUY3Qyffykm1EIddQuQs8y6CFyN4zNTElAWmV H7mBa73Wc8YnbOiIj0qntpR+er9aKuqTu4UXDreUYk6DlDSrTLLFMsBhgB/vanyR56kG 03ZEbeVmxD6bWL7eU3rUQcOguId4iccUbMDnW6Dz828halwlkbsEUL6xxDh9nuS2uLXd jw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2130.oracle.com with ESMTP id 34t4rarej6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 17 Nov 2020 03:02:12 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AH2tRGj012775; Tue, 17 Nov 2020 03:00:11 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 34ts0q9k17-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Nov 2020 03:00:11 +0000 Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0AH30AxN030494; Tue, 17 Nov 2020 03:00:10 GMT MIME-Version: 1.0 Message-ID: <73ce5055-2cc4-4908-acf7-cee037012864@default> Date: Mon, 16 Nov 2020 19:00:09 -0800 (PST) From: Drew Adams To: Stefan Kangas , Glenn Morris Subject: RE: bug#17052: substitute-command-keys strips text properties, bug#8911: huh? References: In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5071.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9807 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 bulkscore=0 suspectscore=0 spamscore=0 malwarescore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011170023 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9807 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 clxscore=1015 malwarescore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=999 adultscore=0 phishscore=0 suspectscore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011170023 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 17052 Cc: Juanma Barranquero , Lars Ingebrigtsen , 17052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > I don't understand the relation between this bug, #17052, > > and bug #8911. Half of the messages in the 8911 thread > > are about 17052, and the subjects seem quite different. > > > > But it looks like 8911 is still open (wishlist). Is that correct? > ^^^^ you probably mean 8951 Yes, sorry; I meant 8951. > > Why/how did these two bugs get overlapped or combined? >=20 > It was my perhaps ill-advised attempt to combine the discussions about > the Lisp conversion of `substitute-command-keys'. >=20 > (FWIW, I intend to look into Bug#8951 soon-ish.) From unknown Wed Jun 25 02:10:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 15 Dec 2020 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator