GNU bug report logs - #17049
[PATCH] Make reverse! forego the cost of SCM_VALIDATE_LIST

Previous Next

Package: guile;

Reported by: David Kastrup <dak <at> gnu.org>

Date: Thu, 20 Mar 2014 11:24:01 UTC

Severity: wishlist

Tags: notabug, patch

Done: Mark H Weaver <mhw <at> netris.org>

Bug is archived. No further changes may be made.

Full log

Message #38 received at 17049 <at> debbugs.gnu.org (full text, mbox):

From: David Kastrup <dak <at> gnu.org>
To: 17049 <at> debbugs.gnu.org
Cc: Mark H Weaver <mhw <at> netris.org>
Subject: Re: [PATCH v2] Make reverse! forego the cost of SCM_VALIDATE_LIST
Date: Tue, 01 Apr 2014 12:40:53 +0200

Sigh.  In case you are committing this, there might be one minor change
worth doing to match the coding style:

> +  scm_wrong_type_arg (FUNC_NAME, 1, lst);

This should likely be

     SCM_WRONG_TYPE_ARG (1, lst);

for consistency with other usage in list.c.  I can reroll if you prefer
this over fixing it yourself.

-- 
David Kastrup
This bug report was last modified 11 years and 57 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.