GNU bug report logs - #17035
[PATCH] chmod -c -R produces errors with special permissions

Previous Next

Package: coreutils;

Reported by: Dylan Alex Simon <dylan <at> dylex.net>

Date: Tue, 18 Mar 2014 16:54:02 UTC

Severity: normal

Tags: patch

Done: Pádraig Brady <P <at> draigBrady.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Pádraig Brady <P <at> draigBrady.com>
To: Bernhard Voelker <mail <at> bernhard-voelker.de>
Cc: dylan <at> dylex.net, 17035 <at> debbugs.gnu.org
Subject: bug#17035: [PATCH] chmod -c -R produces errors with special permissions
Date: Wed, 19 Mar 2014 02:38:54 +0000
On 03/18/2014 11:41 PM, Pádraig Brady wrote:
> On 03/18/2014 10:18 PM, Bernhard Voelker wrote:
>> On 03/18/2014 07:45 PM, Pádraig Brady wrote:
>>> The fix looks good.  It seems this bug was introduced
>>> with the change to FTS in 5.1.0 (released Dec 2003)
>>
>> Wasn't it commit v5.2.1-690-gbc580f6?
> 
> I think that restricted the issue to if (new_mode & (S_ISUID | S_ISGID | S_ISVTX))
> but the stat on the relative name was there previously?

But if that was the case then previous to v5.2.1 release
would have gotten the diagnostic without special mode bits,
which is unlikely as the issue would then very likely have been noticed.
So I dug a little further and the issue seems to be with where fts
was improved to not change directory when traversing in coreutils 6.0 in:
http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commit;h=c1994c16

Change is now pushed:
http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commit;h=09eda9ed

thanks,
Pádraig.




This bug report was last modified 11 years and 71 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.