GNU bug report logs - #17035
[PATCH] chmod -c -R produces errors with special permissions

Previous Next

Full log

Message #16 received at 17035 <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: 17035 <at> debbugs.gnu.org, P <at> draigBrady.com, dylan <at> dylex.net
Subject: Re: bug#17035: [PATCH] chmod -c -R produces errors with special
 permissions
Date: Tue, 18 Mar 2014 23:33:39 +0100

On 03/18/2014 07:45 PM, Pádraig Brady wrote:
> @@ -121,7 +121,7 @@ mode_changed (int dirfd, char const *file, char const *file_full_name,
> 
>        struct stat new_stats;
> 
> -      if (fstatat (dirfd, file, &new_stats, 0) != 0)
> +      if (fstatat (dir_fd, file, &new_stats, 0) != 0)
>          {
>            if (! force_silent)
>              error (0, errno, _("getting new attributes of %s"), quote (file_full_name));

Another minor nit: the last line doesn't pass sc_long_lines:

  $ make syntax-check
  ...
  src/chmod.c:127:            error (0, errno, _("getting new attributes of %s"), quote (file_full_name));
  maint.mk: line(s) with more than 80 characters; reindent

Thanks & have a nice day,
Berny

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.