From xah@xahlee.org Thu Dec 25 10:30:44 2008 Received: (at submit) by emacsbugs.donarmstrong.com; 25 Dec 2008 18:30:44 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBPIUf14004581 for ; Thu, 25 Dec 2008 10:30:42 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LFuyn-0000m7-5m for bug-gnu-emacs@gnu.org; Thu, 25 Dec 2008 13:30:41 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LFuyl-0000lv-R9 for bug-gnu-emacs@gnu.org; Thu, 25 Dec 2008 13:30:39 -0500 Received: from [199.232.76.173] (port=32772 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LFuyl-0000ls-LU for bug-gnu-emacs@gnu.org; Thu, 25 Dec 2008 13:30:39 -0500 Received: from mout.perfora.net ([74.208.4.194]:60670) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LFuyl-0001Cx-Cu for bug-gnu-emacs@gnu.org; Thu, 25 Dec 2008 13:30:39 -0500 Received: from [192.168.1.2] (c-76-102-50-240.hsd1.ca.comcast.net [76.102.50.240]) by mrelay.perfora.net (node=mrus1) with ESMTP (Nemesis) id 0MKpCa-1LFuyj2fnU-0007UP; Thu, 25 Dec 2008 13:30:39 -0500 Mime-Version: 1.0 (Apple Message framework v753.1) Content-Transfer-Encoding: quoted-printable Message-Id: Content-Type: text/plain; charset=UTF-8; delsp=yes; format=flowed To: bug-gnu-emacs@gnu.org From: xah lee Subject: feature request: correctly display single file zip archive Date: Thu, 25 Dec 2008 10:30:32 -0800 X-Mailer: Apple Mail (2.753.1) X-Provags-ID: V01U2FsdGVkX18oka0+bNfa6MGOdwVFwo0duU2eXFWcAgtFyRE eNt3F6CjuKUePICWk+jPMQscCtYHFPxaeKMoKBra3+n/A0qX9L bgaRg9PbHQ8PqviUpEAjg== X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. this might be considered as a feature request or a bug. Problem: When opening a zip archive that is just a single file, emacs displays =20= gibberish, as opposed to decompressed file content. (Note: when the zip archive is a directory of files, Emacs behaves =20 correctly by showing its file index) Thanks. GNU Emacs 22.2.1 (powerpc-apple-darwin8.11.0, Carbon Version 1.6.0) =20 of 2008-04-05 on g5.tokyo.stp.isas.jaxa.jp Xah =E2=88=91 http://xahlee.org/ =E2=98=84= From cyd@stupidchicken.com Sat Dec 27 18:47:33 2008 Received: (at 1702) by emacsbugs.donarmstrong.com; 28 Dec 2008 02:47:33 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBS2lQIY021295 for <1702@emacsbugs.donarmstrong.com>; Sat, 27 Dec 2008 18:47:27 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id 28A5F57E217; Sat, 27 Dec 2008 21:47:36 -0500 (EST) From: Chong Yidong To: xah lee Cc: 1702@debbugs.gnu.org Subject: Re: feature request: correctly display single file zip archive Date: Sat, 27 Dec 2008 21:47:36 -0500 Message-ID: <87lju1hv7b.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > When opening a zip archive that is just a single file, emacs displays > gibberish, as opposed to decompressed file content. I can't reproduce this. Do you have an example of a zip file that shows this problem? From rgm@gnu.org Sat Jan 3 18:08:04 2009 Received: (at control) by emacsbugs.donarmstrong.com; 4 Jan 2009 02:08:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.7 required=4.0 tests=MISSING_SUBJECT,NOSUBJECT, VALID_BTS_CONTROL,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n04281Al027408 for ; Sat, 3 Jan 2009 18:08:02 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LJIOD-0008IO-Nf; Sat, 03 Jan 2009 21:06:53 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18784.6589.638899.56291@fencepost.gnu.org> Date: Sat, 3 Jan 2009 21:06:53 -0500 From: Glenn Morris To: control X-Debbugs-No-Ack: yes reassign 1778 spam reassign 1777 spam reassign 1774 spam reassign 1773 spam reassign 1772 spam severity 1771 wishlist reassign 1769 spam reassign 1760 spam reassign 1759 spam reassign 1758 spam reassign 1663 emacs,ns reassign 1677 emacs,gnus reassign 1687 emacs,ns reassign 1693 emacs,gnus close 1698 tags 1702 moreinfo reassign 1729 emacs,cc-mode tags 1731 notabug severity 1750 wishlist reassign 1756 emacs,cc-mode From xah@xahlee.org Fri Jan 16 12:09:39 2009 Received: (at 1702) by emacsbugs.donarmstrong.com; 16 Jan 2009 20:09:39 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mout.perfora.net (mout.perfora.net [74.208.4.194]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0GK9a0p026941 for <1702@emacsbugs.donarmstrong.com>; Fri, 16 Jan 2009 12:09:37 -0800 Received: from [192.168.1.2] (c-24-6-175-142.hsd1.ca.comcast.net [24.6.175.142]) by mrelay.perfora.net (node=mrus0) with ESMTP (Nemesis) id 0MKp8S-1LNv0W0kgI-000T2v; Fri, 16 Jan 2009 15:09:35 -0500 In-Reply-To: <87lju1hv7b.fsf@cyd.mit.edu> References: <87lju1hv7b.fsf@cyd.mit.edu> Mime-Version: 1.0 (Apple Message framework v753.1) Content-Type: text/plain; charset=UTF-8; delsp=yes; format=flowed Message-Id: <13EFAAB6-C6B3-4F67-A39A-5266E91A0CD5@xahlee.org> Cc: 1702@debbugs.gnu.org Content-Transfer-Encoding: quoted-printable From: xah lee Subject: Re: feature request: correctly display single file zip archive Date: Fri, 16 Jan 2009 12:09:30 -0800 To: Chong Yidong X-Mailer: Apple Mail (2.753.1) X-Provags-ID: V01U2FsdGVkX18OSeuYn6emyhvqs+c2QUfNfaZ4DWV7NvuyGgH FoKN91HWCEGqgNxLcwJXylRFVyRqbnK1CwduO47gsy8N0F4HDc +bDvzPAT6IClx8ON6mPeQ== On Dec 27, 2008, at 6:47 PM, Chong Yidong wrote: > When opening a zip archive that is just a single file, emacs displays > gibberish, as opposed to decompressed file content. I can't reproduce this. Do you have an example of a zip file that shows this problem? --------------------- Sorry, i can't reproduced what i wrote. I think rather that i wrote =20 wrong. Here's a correct report: When opening a zip archive of a single file, emacs displays the zip =20 archive's index (which is just a single file), as opposed to the =20 decompressed file content. I think when the zip file is a single file, it is more useful to =20 display file content and allow transparent editing. For what's worth, Thanks. Xah =E2=88=91 http://xahlee.org/ =E2=98=84 From cyd@stupidchicken.com Fri Jan 16 12:25:51 2009 Received: (at control) by emacsbugs.donarmstrong.com; 16 Jan 2009 20:25:51 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.0 required=4.0 tests=VALID_BTS_CONTROL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0GKPmL7031949 for ; Fri, 16 Jan 2009 12:25:49 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id 7823B57E205; Fri, 16 Jan 2009 15:26:07 -0500 (EST) From: Chong Yidong To: control@debbugs.gnu.org Subject: severity 1702 wishlist Date: Fri, 16 Jan 2009 15:26:07 -0500 Message-ID: <87ab9rt2u8.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii severity 1702 wishlist thanks From rgm@gnu.org Sun Jan 18 12:22:50 2009 Received: (at control) by emacsbugs.donarmstrong.com; 18 Jan 2009 20:22:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: ** X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=2.3 required=4.0 tests=MISSING_SUBJECT,NOSUBJECT, VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0IKMlnA002448 for ; Sun, 18 Jan 2009 12:22:48 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LOe92-0007Kz-TZ; Sun, 18 Jan 2009 15:21:20 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18803.36672.857032.427796@fencepost.gnu.org> Date: Sun, 18 Jan 2009 15:21:20 -0500 From: Glenn Morris To: control tags 1702 - moreinfo severity 1933 wishlist severity 1939 wishlist From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 13 13:39:51 2014 Received: (at 1702) by debbugs.gnu.org; 13 Nov 2014 18:39:51 +0000 Received: from localhost ([127.0.0.1]:59671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XozJ8-0005zE-R4 for submit@debbugs.gnu.org; Thu, 13 Nov 2014 13:39:51 -0500 Received: from mx0.mattleach.net ([176.58.118.143]:47513) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XozJ5-0005z5-E3 for 1702@debbugs.gnu.org; Thu, 13 Nov 2014 13:39:49 -0500 Received: by mx0.mattleach.net (Postfix, from userid 99) id AE39861AC1; Thu, 13 Nov 2014 18:39:46 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx0.mattleach.net X-Spam-Level: X-Spam-Status: No, score=-1.0 required=4.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from loki.home.mattleach.net (host86-180-142-129.range86-180.btcentralplus.com [86.180.142.129]) by mx0.mattleach.net (Postfix) with ESMTPSA id 0B38661ABA; Thu, 13 Nov 2014 18:39:44 +0000 (GMT) From: Matthew Leach To: xah lee Subject: Re: bug#1702: [PATCH]: feature request: correctly display single file zip archive In-Reply-To: <13EFAAB6-C6B3-4F67-A39A-5266E91A0CD5@xahlee.org> (xah lee's message of "Fri, 16 Jan 2009 12:09:30 -0800") References: <87lju1hv7b.fsf@cyd.mit.edu> <13EFAAB6-C6B3-4F67-A39A-5266E91A0CD5@xahlee.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Date: Thu, 13 Nov 2014 18:39:43 +0000 Message-ID: <87wq6zj66o.fsf_-_@loki.home> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 1702 Cc: 1702@debbugs.gnu.org, Chong Yidong X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi all, xah lee writes: > When opening a zip archive of a single file, emacs displays the zip > archive's index (which is just a single file), as opposed to the > decompressed file content. > > I think when the zip file is a single file, it is more useful to > display file content and allow transparent editing. Please see the attached patch to implement this. Any comments welcome! Thanks, -- Matt ChangeLog entry: 2014-11-13 Matthew Leach * arc-mode.el (singular-file-archive-action): New. (archive-mode): Visit file if archive contains a single file. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Don-t-show-summary-for-single-file-archives.patch >From 1c84ec04f024f9de44b0bb57d60d009b9738c899 Mon Sep 17 00:00:00 2001 From: Matthew Leach Date: Thu, 13 Nov 2014 18:30:24 +0000 Subject: [PATCH] Don't show summary for single-file archives. * arc-mode.el (singular-file-archive-action): New. (archive-mode): Visit file if archive contains a single file. --- lisp/arc-mode.el | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/lisp/arc-mode.el b/lisp/arc-mode.el index ef155ee..279b9a1 100644 --- a/lisp/arc-mode.el +++ b/lisp/arc-mode.el @@ -147,6 +147,13 @@ A local copy of the archive will be used when updating." "Hook run when an archive member has been extracted." :type 'hook :group 'archive) + +(defcustom singular-file-archive-action 'visit-file + "When opening an archive that contains a single file choose +whether to open the file or display the archive summary." + :type '(choice (const :tag "Show archive summary" show-summary) + (const :tag "Visit the single file" visit-file)) + :group 'archive) ;; ------------------------------ ;; Arc archive configuration @@ -742,7 +749,12 @@ archive. (if (default-value 'enable-multibyte-characters) (set-buffer-multibyte 'to)) (archive-summarize nil) - (setq buffer-read-only t)))) + (setq buffer-read-only t) + (when (and (= (length archive-files) 1) + (eq singular-file-archive-action 'visit-file)) + (let ((archive-buffer (current-buffer))) + (archive-extract) + (kill-buffer archive-buffer)))))) ;; Archive mode is suitable only for specially formatted data. (put 'archive-mode 'mode-class 'special) -- 2.1.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 13 13:50:32 2014 Received: (at 1702) by debbugs.gnu.org; 13 Nov 2014 18:50:32 +0000 Received: from localhost ([127.0.0.1]:59699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XozTT-0007bi-E0 for submit@debbugs.gnu.org; Thu, 13 Nov 2014 13:50:31 -0500 Received: from mtaout25.012.net.il ([80.179.55.181]:48566) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XozTQ-0007bY-Sd for 1702@debbugs.gnu.org; Thu, 13 Nov 2014 13:50:30 -0500 Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NEZ00F00QKNO500@mtaout25.012.net.il> for 1702@debbugs.gnu.org; Thu, 13 Nov 2014 20:46:03 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NEZ007GPQSQL280@mtaout25.012.net.il>; Thu, 13 Nov 2014 20:46:03 +0200 (IST) Date: Thu, 13 Nov 2014 20:50:26 +0200 From: Eli Zaretskii Subject: Re: bug#1702: [PATCH]: feature request: correctly display single file zip archive In-reply-to: <87wq6zj66o.fsf_-_@loki.home> X-012-Sender: halo1@inter.net.il To: Matthew Leach Message-id: <83ppcrj5ot.fsf@gnu.org> References: <87lju1hv7b.fsf@cyd.mit.edu> <13EFAAB6-C6B3-4F67-A39A-5266E91A0CD5@xahlee.org> <87wq6zj66o.fsf_-_@loki.home> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 1702 Cc: xah@xahlee.org, 1702@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Matthew Leach > Date: Thu, 13 Nov 2014 18:39:43 +0000 > Cc: 1702@debbugs.gnu.org, Chong Yidong > > xah lee writes: > > > When opening a zip archive of a single file, emacs displays the zip > > archive's index (which is just a single file), as opposed to the > > decompressed file content. > > > > I think when the zip file is a single file, it is more useful to > > display file content and allow transparent editing. > > Please see the attached patch to implement this. Thanks. > Any comments welcome! A comment: if the default is indeed going to be to automatically visit such a compressed file (and I personally am not convinced it should), then this is a user-visible change in behavior, so it should be mentioned in NEWS, and the entry should describe how to get the old behavior back. > +(defcustom singular-file-archive-action 'visit-file > + "When opening an archive that contains a single file choose > +whether to open the file or display the archive summary." We use a certain style in doc strings of options: the first line should be a complete sentence. In addition, option names should begin with the name of the package. Also, this is just a boolean yes/no option, so no need to use a symbol as its value. Therefor, I suggest: (defcustom archive-visit-single-files t "If non-nil, opening an archive with a single file visits that file. If this option's value is nil, visiting such archives will display the archive summary." (and the corresponding change in the code). From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 13 14:26:20 2014 Received: (at 1702) by debbugs.gnu.org; 13 Nov 2014 19:26:20 +0000 Received: from localhost ([127.0.0.1]:59725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xp027-00007L-TT for submit@debbugs.gnu.org; Thu, 13 Nov 2014 14:26:20 -0500 Received: from mx0.mattleach.net ([176.58.118.143]:47603) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xp025-000077-2b for 1702@debbugs.gnu.org; Thu, 13 Nov 2014 14:26:17 -0500 Received: by mx0.mattleach.net (Postfix, from userid 99) id 4B90E61AC1; Thu, 13 Nov 2014 19:26:16 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx0.mattleach.net X-Spam-Level: X-Spam-Status: No, score=-1.0 required=4.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from loki.home.mattleach.net (host86-180-142-129.range86-180.btcentralplus.com [86.180.142.129]) by mx0.mattleach.net (Postfix) with ESMTPSA id 2816961ABA; Thu, 13 Nov 2014 19:26:15 +0000 (GMT) From: Matthew Leach To: Eli Zaretskii Subject: Re: bug#1702: [PATCH]: feature request: correctly display single file zip archive In-Reply-To: <83ppcrj5ot.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 13 Nov 2014 20:50:26 +0200") References: <87lju1hv7b.fsf@cyd.mit.edu> <13EFAAB6-C6B3-4F67-A39A-5266E91A0CD5@xahlee.org> <87wq6zj66o.fsf_-_@loki.home> <83ppcrj5ot.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Date: Thu, 13 Nov 2014 19:26:13 +0000 Message-ID: <87r3x6kilm.fsf@loki.home> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 1702 Cc: xah@xahlee.org, 1702@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Eli, Eli Zaretskii writes: [...] > A comment: if the default is indeed going to be to automatically visit > such a compressed file (and I personally am not convinced it should), > then this is a user-visible change in behavior, so it should be > mentioned in NEWS, and the entry should describe how to get the old > behavior back. I think the advantage gained here is transparent editing of compressed files, like how Emacs can read .el.gz files without having to manually decompress them first. Of course, if you think the user-visible change is too substantial without much benefit, I shall make the current behaviour default. Thoughts? -- Matt From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 13 14:40:05 2014 Received: (at 1702) by debbugs.gnu.org; 13 Nov 2014 19:40:05 +0000 Received: from localhost ([127.0.0.1]:59751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xp0FQ-0000YU-Sw for submit@debbugs.gnu.org; Thu, 13 Nov 2014 14:40:05 -0500 Received: from mtaout28.012.net.il ([80.179.55.184]:51654) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xp0FN-0000Xy-EQ for 1702@debbugs.gnu.org; Thu, 13 Nov 2014 14:40:03 -0500 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NEZ00O00T0BPP00@mtaout28.012.net.il> for 1702@debbugs.gnu.org; Thu, 13 Nov 2014 21:37:14 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NEZ00M7JT62XH20@mtaout28.012.net.il>; Thu, 13 Nov 2014 21:37:14 +0200 (IST) Date: Thu, 13 Nov 2014 21:39:58 +0200 From: Eli Zaretskii Subject: Re: bug#1702: [PATCH]: feature request: correctly display single file zip archive In-reply-to: <87r3x6kilm.fsf@loki.home> X-012-Sender: halo1@inter.net.il To: Matthew Leach Message-id: <83lhnekhyp.fsf@gnu.org> References: <87lju1hv7b.fsf@cyd.mit.edu> <13EFAAB6-C6B3-4F67-A39A-5266E91A0CD5@xahlee.org> <87wq6zj66o.fsf_-_@loki.home> <83ppcrj5ot.fsf@gnu.org> <87r3x6kilm.fsf@loki.home> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 1702 Cc: xah@xahlee.org, 1702@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Matthew Leach > Cc: xah@xahlee.org, 1702@debbugs.gnu.org, cyd@stupidchicken.com > Date: Thu, 13 Nov 2014 19:26:13 +0000 > > I think the advantage gained here is transparent editing of compressed > files, like how Emacs can read .el.gz files without having to manually > decompress them first. This won't work without a suitable change to jka-compr.el. > Of course, if you think the user-visible change is too substantial > without much benefit, I shall make the current behaviour default. > Thoughts? I already expressed my doubts, so let's wait for others to chime in, if they care. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 13 14:51:58 2014 Received: (at 1702) by debbugs.gnu.org; 13 Nov 2014 19:51:58 +0000 Received: from localhost ([127.0.0.1]:59767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xp0Qw-0000rW-J6 for submit@debbugs.gnu.org; Thu, 13 Nov 2014 14:51:58 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:45522) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xp0Qu-0000rK-AS for 1702@debbugs.gnu.org; Thu, 13 Nov 2014 14:51:57 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Xp0Qa-0007HW-Hl; Thu, 13 Nov 2014 20:51:36 +0100 From: Lars Magne Ingebrigtsen To: Matthew Leach Subject: Re: bug#1702: [PATCH]: feature request: correctly display single file zip archive References: <87lju1hv7b.fsf@cyd.mit.edu> <13EFAAB6-C6B3-4F67-A39A-5266E91A0CD5@xahlee.org> <87wq6zj66o.fsf_-_@loki.home> <83ppcrj5ot.fsf@gnu.org> <87r3x6kilm.fsf@loki.home> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAD1BMVEXw38Deyqp5ZFT9+N/4 6sxd//jbAAACQklEQVQ4jVWUi5GrMAxF5eACLJMCsLIFwMgFiLX6r+ldGZLNYyYE69j6XAmIuRSm xEwFN6yI4g+m4jCURHlaimc8JKyNLNZ4SjjZ+LpygOtkTuGq3MATwUEVadjCAAIGXwnAjWur8uwI VVlq0aF6BnBLTUS04yDQonqDbgT7pjscNqaw66E3aEfTU+J69gl6IsWvNlrVJDwuDvvonUgtlaF9 KMrBhny5QgwAVoUDX/bKKeFBdTcjP5nnLsehSmHFCSMKpcLeDQ6hpIbbg2aBaQQgVJC4jVgcmUMS FNWR3Ioa2zbdntATItZFRzF4sRt0J44YgtOeGjsKassbINs6Zlb2kwA4FnCDPvAl3OiWam1zsZd3 8GiJR2sarzM4UfRsDcllo4iRAjjAnI/YgvlIsqU8wiuMIGVTDwGpSov+dd8DuNXnQE7YgkCDRneD flBtr89ZFUUgzhBhjs3Qk/tVB5bSFh9vEOpZdirwwikv0YgAZ6je1XGhPj/tmZAE015/dHYt7rVh vMojyqVTXpHgJerZ1B4xmSLUBScMAA0snNZI+gJVIN+cM25128sbGMurWySQpNbl+IC9IojHBLXt Icvh9nHV8gR7zRaNpRtkluxOAdxeX+CE1pRjzjgfkTn9BW94SaKd+Xf8D4Q8Rzv9N+bgnRVaJAU6 4m1ACpD0AyAZAzhnj7fmC4gUzAli24om0eMLYE7USrZozOzjBGeAJwBRHr3cSQHYBNAR0zcwHm9w TjC/NNf970SV+2PUiuOzcYN/fCyWMBfyPWUAAAAASUVORK5CYII= X-Now-Playing: Eurythmics's _Savage_: "Shame" X-Hashcash: 1:23:141113:cyd@stupidchicken.com::5YsMehJaAu5jxTLg:0000000000000000000000000000000000000000FElC X-Hashcash: 1:23:141113:1702@debbugs.gnu.org::LsU8NbAdSjGbU5Ga:00000000000000000000000000000000000000000I0H1 X-Hashcash: 1:23:141113:xah@xahlee.org::wkU8kBl6issJ4MWw:000Tjd4 X-Hashcash: 1:23:141113:matthew@mattleach.net::Pz/F4D8wS8wxiYHp:0000000000000000000000000000000000000000STpq X-Hashcash: 1:23:141113:eliz@gnu.org::eN5lAUVBfLVJDuA+:00000VfXn Date: Thu, 13 Nov 2014 20:51:36 +0100 In-Reply-To: <87r3x6kilm.fsf@loki.home> (Matthew Leach's message of "Thu, 13 Nov 2014 19:26:13 +0000") Message-ID: User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1Xp0Qa-0007HW-Hl X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1416513096.77194@ongIQmbLsL9KEZqJPchUFQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 1702 Cc: xah@xahlee.org, 1702@debbugs.gnu.org, Eli Zaretskii , cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Matthew Leach writes: > I think the advantage gained here is transparent editing of compressed > files, like how Emacs can read .el.gz files without having to manually > decompress them first. If it were possible to edit files inside archives, that would be great. But that's a pretty major undertaking, I think. > Of course, if you think the user-visible change is too substantial > without much benefit, I shall make the current behaviour default. > Thoughts? I think it would be nice to go directly to the single file in these archives, but, on the other hand, it might be kinda surprising. If you're visiting an archive, you expect to see the list of files in the archive. For one type of archives (ones with a single file in them) to work differently may be too inconsistent. So I dunno... others who want to chime in? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 13 14:58:28 2014 Received: (at 1702) by debbugs.gnu.org; 13 Nov 2014 19:58:29 +0000 Received: from localhost ([127.0.0.1]:59771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xp0XB-00012U-Aq for submit@debbugs.gnu.org; Thu, 13 Nov 2014 14:58:28 -0500 Received: from mtaout27.012.net.il ([80.179.55.183]:45456) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xp0X5-00012H-RV for 1702@debbugs.gnu.org; Thu, 13 Nov 2014 14:58:24 -0500 Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NEZ00A00TUQSO00@mtaout27.012.net.il> for 1702@debbugs.gnu.org; Thu, 13 Nov 2014 21:53:32 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NEZ00589TX8AO50@mtaout27.012.net.il>; Thu, 13 Nov 2014 21:53:32 +0200 (IST) Date: Thu, 13 Nov 2014 21:58:17 +0200 From: Eli Zaretskii Subject: Re: bug#1702: [PATCH]: feature request: correctly display single file zip archive In-reply-to: X-012-Sender: halo1@inter.net.il To: Lars Magne Ingebrigtsen Message-id: <83k32ykh46.fsf@gnu.org> References: <87lju1hv7b.fsf@cyd.mit.edu> <13EFAAB6-C6B3-4F67-A39A-5266E91A0CD5@xahlee.org> <87wq6zj66o.fsf_-_@loki.home> <83ppcrj5ot.fsf@gnu.org> <87r3x6kilm.fsf@loki.home> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 1702 Cc: xah@xahlee.org, matthew@mattleach.net, cyd@stupidchicken.com, 1702@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Lars Magne Ingebrigtsen > Cc: Eli Zaretskii , xah@xahlee.org, 1702@debbugs.gnu.org, cyd@stupidchicken.com > Date: Thu, 13 Nov 2014 20:51:36 +0100 > > Matthew Leach writes: > > > I think the advantage gained here is transparent editing of compressed > > files, like how Emacs can read .el.gz files without having to manually > > decompress them first. > > If it were possible to edit files inside archives, that would be great. > But that's a pretty major undertaking, I think. Maybe so, but that undertaking was already made many years ago: arc-mode.el does support editing files in archives. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 13 15:03:38 2014 Received: (at 1702) by debbugs.gnu.org; 13 Nov 2014 20:03:38 +0000 Received: from localhost ([127.0.0.1]:59775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xp0cE-0001CR-Dl for submit@debbugs.gnu.org; Thu, 13 Nov 2014 15:03:38 -0500 Received: from mx0.mattleach.net ([176.58.118.143]:47672) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xp0cB-0001CD-Km for 1702@debbugs.gnu.org; Thu, 13 Nov 2014 15:03:36 -0500 Received: by mx0.mattleach.net (Postfix, from userid 99) id E1DD161AC1; Thu, 13 Nov 2014 20:03:33 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx0.mattleach.net X-Spam-Level: X-Spam-Status: No, score=-1.0 required=4.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from loki.home.mattleach.net (host86-180-142-129.range86-180.btcentralplus.com [86.180.142.129]) by mx0.mattleach.net (Postfix) with ESMTPSA id 51EDB61ABA; Thu, 13 Nov 2014 20:03:33 +0000 (GMT) From: Matthew Leach To: Eli Zaretskii Subject: Re: bug#1702: [PATCH]: feature request: correctly display single file zip archive In-Reply-To: <83lhnekhyp.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 13 Nov 2014 21:39:58 +0200") References: <87lju1hv7b.fsf@cyd.mit.edu> <13EFAAB6-C6B3-4F67-A39A-5266E91A0CD5@xahlee.org> <87wq6zj66o.fsf_-_@loki.home> <83ppcrj5ot.fsf@gnu.org> <87r3x6kilm.fsf@loki.home> <83lhnekhyp.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Date: Thu, 13 Nov 2014 20:03:32 +0000 Message-ID: <87mw7ukgvf.fsf@loki.home> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 1702 Cc: xah@xahlee.org, 1702@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Matthew Leach >> Cc: xah@xahlee.org, 1702@debbugs.gnu.org, cyd@stupidchicken.com >> Date: Thu, 13 Nov 2014 19:26:13 +0000 >> >> I think the advantage gained here is transparent editing of compressed >> files, like how Emacs can read .el.gz files without having to manually >> decompress them first. > > This won't work without a suitable change to jka-compr.el. Could you please elaborate on what kind of change would be needed? From the small amount of testing I've done so far, it seems to `just work (TM)'. -- Matt From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 13 15:25:20 2014 Received: (at 1702) by debbugs.gnu.org; 13 Nov 2014 20:25:20 +0000 Received: from localhost ([127.0.0.1]:59788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xp0xC-0001nJ-QO for submit@debbugs.gnu.org; Thu, 13 Nov 2014 15:25:19 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:34464) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xp0xA-0001n6-4x for 1702@debbugs.gnu.org; Thu, 13 Nov 2014 15:25:17 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NEZ00700V74R400@a-mtaout22.012.net.il> for 1702@debbugs.gnu.org; Thu, 13 Nov 2014 22:25:14 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NEZ007KTVE2ID50@a-mtaout22.012.net.il>; Thu, 13 Nov 2014 22:25:14 +0200 (IST) Date: Thu, 13 Nov 2014 22:25:13 +0200 From: Eli Zaretskii Subject: Re: bug#1702: [PATCH]: feature request: correctly display single file zip archive In-reply-to: <87mw7ukgvf.fsf@loki.home> X-012-Sender: halo1@inter.net.il To: Matthew Leach Message-id: <83h9y2kfva.fsf@gnu.org> References: <87lju1hv7b.fsf@cyd.mit.edu> <13EFAAB6-C6B3-4F67-A39A-5266E91A0CD5@xahlee.org> <87wq6zj66o.fsf_-_@loki.home> <83ppcrj5ot.fsf@gnu.org> <87r3x6kilm.fsf@loki.home> <83lhnekhyp.fsf@gnu.org> <87mw7ukgvf.fsf@loki.home> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 1702 Cc: xah@xahlee.org, 1702@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Matthew Leach > Cc: xah@xahlee.org, 1702@debbugs.gnu.org, cyd@stupidchicken.com > Date: Thu, 13 Nov 2014 20:03:32 +0000 > > Eli Zaretskii writes: > > >> From: Matthew Leach > >> Cc: xah@xahlee.org, 1702@debbugs.gnu.org, cyd@stupidchicken.com > >> Date: Thu, 13 Nov 2014 19:26:13 +0000 > >> > >> I think the advantage gained here is transparent editing of compressed > >> files, like how Emacs can read .el.gz files without having to manually > >> decompress them first. > > > > This won't work without a suitable change to jka-compr.el. > > Could you please elaborate on what kind of change would be needed? Do we want to disable decompression when auto-compression-mode is off, for example? (I was mistaken: the change to do that needs to be done in arc-mode.el itself, because it bypasses jka-compr.) From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 13 15:50:26 2014 Received: (at 1702) by debbugs.gnu.org; 13 Nov 2014 20:50:26 +0000 Received: from localhost ([127.0.0.1]:59807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xp1LV-0002Tx-SK for submit@debbugs.gnu.org; Thu, 13 Nov 2014 15:50:26 -0500 Received: from mx0.mattleach.net ([176.58.118.143]:47704) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xp1LT-0002Tm-JK for 1702@debbugs.gnu.org; Thu, 13 Nov 2014 15:50:24 -0500 Received: by mx0.mattleach.net (Postfix, from userid 99) id A6B1561AC1; Thu, 13 Nov 2014 20:50:22 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx0.mattleach.net X-Spam-Level: X-Spam-Status: No, score=-1.0 required=4.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from loki.home.mattleach.net (host86-180-142-129.range86-180.btcentralplus.com [86.180.142.129]) by mx0.mattleach.net (Postfix) with ESMTPSA id 9633B61ABA; Thu, 13 Nov 2014 20:50:21 +0000 (GMT) From: Matthew Leach To: Eli Zaretskii Subject: Re: bug#1702: [PATCH]: feature request: correctly display single file zip archive In-Reply-To: <83h9y2kfva.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 13 Nov 2014 22:25:13 +0200") References: <87lju1hv7b.fsf@cyd.mit.edu> <13EFAAB6-C6B3-4F67-A39A-5266E91A0CD5@xahlee.org> <87wq6zj66o.fsf_-_@loki.home> <83ppcrj5ot.fsf@gnu.org> <87r3x6kilm.fsf@loki.home> <83lhnekhyp.fsf@gnu.org> <87mw7ukgvf.fsf@loki.home> <83h9y2kfva.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Date: Thu, 13 Nov 2014 20:50:21 +0000 Message-ID: <87a93ukepe.fsf@loki.home> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 1702 Cc: xah@xahlee.org, 1702@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Matthew Leach >> Cc: xah@xahlee.org, 1702@debbugs.gnu.org, cyd@stupidchicken.com >> Date: Thu, 13 Nov 2014 20:03:32 +0000 >> >> Eli Zaretskii writes: >> >> >> From: Matthew Leach >> >> Cc: xah@xahlee.org, 1702@debbugs.gnu.org, cyd@stupidchicken.com >> >> Date: Thu, 13 Nov 2014 19:26:13 +0000 >> >> >> >> I think the advantage gained here is transparent editing of compressed >> >> files, like how Emacs can read .el.gz files without having to manually >> >> decompress them first. >> > >> > This won't work without a suitable change to jka-compr.el. >> >> Could you please elaborate on what kind of change would be needed? > > Do we want to disable decompression when auto-compression-mode is off, > for example? I think in the case that the user has auto-compression-mode off, the archive summary should be shown instead. -- Matt From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 14 00:27:15 2014 Received: (at 1702) by debbugs.gnu.org; 14 Nov 2014 05:27:15 +0000 Received: from localhost ([127.0.0.1]:60026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xp9Pe-0004QQ-Kv for submit@debbugs.gnu.org; Fri, 14 Nov 2014 00:27:14 -0500 Received: from mtaout25.012.net.il ([80.179.55.181]:33656) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xp9Pb-0004QD-CO for 1702@debbugs.gnu.org; Fri, 14 Nov 2014 00:27:13 -0500 Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NF000L00JIHMQ00@mtaout25.012.net.il> for 1702@debbugs.gnu.org; Fri, 14 Nov 2014 07:22:46 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NF000JG8K9XCE40@mtaout25.012.net.il>; Fri, 14 Nov 2014 07:22:46 +0200 (IST) Date: Fri, 14 Nov 2014 07:27:09 +0200 From: Eli Zaretskii Subject: Re: bug#1702: [PATCH]: feature request: correctly display single file zip archive In-reply-to: <87a93ukepe.fsf@loki.home> X-012-Sender: halo1@inter.net.il To: Matthew Leach Message-id: <83d28qjqs2.fsf@gnu.org> References: <87lju1hv7b.fsf@cyd.mit.edu> <13EFAAB6-C6B3-4F67-A39A-5266E91A0CD5@xahlee.org> <87wq6zj66o.fsf_-_@loki.home> <83ppcrj5ot.fsf@gnu.org> <87r3x6kilm.fsf@loki.home> <83lhnekhyp.fsf@gnu.org> <87mw7ukgvf.fsf@loki.home> <83h9y2kfva.fsf@gnu.org> <87a93ukepe.fsf@loki.home> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 1702 Cc: xah@xahlee.org, 1702@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Matthew Leach > Cc: xah@xahlee.org, 1702@debbugs.gnu.org, cyd@stupidchicken.com > Date: Thu, 13 Nov 2014 20:50:21 +0000 > > > Do we want to disable decompression when auto-compression-mode is off, > > for example? > > I think in the case that the user has auto-compression-mode off, the > archive summary should be shown instead. I agree. So this needs to be part of the patch, if the rationale is what you proposed. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 14 06:06:56 2014 Received: (at 1702) by debbugs.gnu.org; 14 Nov 2014 11:06:56 +0000 Received: from localhost ([127.0.0.1]:60223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpEiO-00067h-4c for submit@debbugs.gnu.org; Fri, 14 Nov 2014 06:06:56 -0500 Received: from mx0.mattleach.net ([176.58.118.143]:56738) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpEiM-00067Z-HM for 1702@debbugs.gnu.org; Fri, 14 Nov 2014 06:06:55 -0500 Received: by mx0.mattleach.net (Postfix, from userid 99) id AB46C61AC8; Fri, 14 Nov 2014 11:06:53 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx0.mattleach.net X-Spam-Level: X-Spam-Status: No, score=-1.0 required=4.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from loki.mattleach.net (host86-180-142-129.range86-180.btcentralplus.com [86.180.142.129]) by mx0.mattleach.net (Postfix) with ESMTPSA id 97A2961ABC; Fri, 14 Nov 2014 11:06:46 +0000 (GMT) From: Matthew Leach To: Eli Zaretskii Subject: Re: bug#1702: [PATCH]: feature request: correctly display single file zip archive In-Reply-To: <83d28qjqs2.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 14 Nov 2014 07:27:09 +0200") References: <87lju1hv7b.fsf@cyd.mit.edu> <13EFAAB6-C6B3-4F67-A39A-5266E91A0CD5@xahlee.org> <87wq6zj66o.fsf_-_@loki.home> <83ppcrj5ot.fsf@gnu.org> <87r3x6kilm.fsf@loki.home> <83lhnekhyp.fsf@gnu.org> <87mw7ukgvf.fsf@loki.home> <83h9y2kfva.fsf@gnu.org> <87a93ukepe.fsf@loki.home> <83d28qjqs2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Date: Fri, 14 Nov 2014 11:06:45 +0000 Message-ID: <87sihmjb22.fsf@mattleach.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 1702 Cc: xah@xahlee.org, 1702@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi Eli, Eli Zaretskii writes: >> From: Matthew Leach >> Cc: xah@xahlee.org, 1702@debbugs.gnu.org, cyd@stupidchicken.com >> Date: Thu, 13 Nov 2014 20:50:21 +0000 >> >> > Do we want to disable decompression when auto-compression-mode is off, >> > for example? >> >> I think in the case that the user has auto-compression-mode off, the >> archive summary should be shown instead. > > I agree. So this needs to be part of the patch, if the rationale is > what you proposed. Thank you for the review. The attached patch should take care of everything mentioned. -- Matt lisp/ChangeLog: 2014-11-14 Matthew Leach * arc-mode.el (archive-visit-single-files): New. (archive-mode): Visit file if archive contains a single file. etc/ChangeLog: 2014-11-14 Matthew Leach * NEWS: Mention archive will now visit the file in singular-file archives. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Don-t-show-summary-for-single-file-archives.patch >From fb5402f8fe3e5bdd7e6994cc7fc744d75b0da1da Mon Sep 17 00:00:00 2001 From: Matthew Leach Date: Thu, 13 Nov 2014 18:30:24 +0000 Subject: [PATCH] Don't show summary for single-file archives. * arc-mode.el (archive-visit-single-files): New. (archive-mode): Visit file if archive contains a single file. * etc/NEWS: Mention archive will now visit the file in singular-file archives. --- etc/NEWS | 6 ++++++ lisp/arc-mode.el | 17 ++++++++++++++++- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/etc/NEWS b/etc/NEWS index 05210df..2083127 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -184,6 +184,12 @@ appending FUN to `minibuffer-setup-hook'. ** cl-lib *** New functions cl-fresh-line, cl-digit-char-p and cl-parse-integer. +** Archive +*** When visiting an archive that contains a single file automatically +visit that file, rather than displaying the archive summary. To +revert to the original behaviour, set `archive-visit-single-files' to +nil. + ** Calendar and diary +++ diff --git a/lisp/arc-mode.el b/lisp/arc-mode.el index ef155ee..80f6564 100644 --- a/lisp/arc-mode.el +++ b/lisp/arc-mode.el @@ -147,6 +147,15 @@ A local copy of the archive will be used when updating." "Hook run when an archive member has been extracted." :type 'hook :group 'archive) + +(defcustom archive-visit-single-files t + "If non-nil, opening an archive with a single file visits that file. + + If this option's value is nil, visiting such archives will + display the archive summary." + :type '(choice (const :tag "Visit the single file" t) + (const :tag "Show the archive summary" nil)) + :group 'archive) ;; ------------------------------ ;; Arc archive configuration @@ -742,7 +751,13 @@ archive. (if (default-value 'enable-multibyte-characters) (set-buffer-multibyte 'to)) (archive-summarize nil) - (setq buffer-read-only t)))) + (setq buffer-read-only t) + (when (and archive-visit-single-files + auto-compression-mode + (= (length archive-files) 1)) + (let ((archive-buffer (current-buffer))) + (rename-buffer (concat " " (buffer-name))) + (archive-extract)))))) ;; Archive mode is suitable only for specially formatted data. (put 'archive-mode 'mode-class 'special) -- 2.1.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 14 06:31:36 2014 Received: (at 1702) by debbugs.gnu.org; 14 Nov 2014 11:31:36 +0000 Received: from localhost ([127.0.0.1]:60231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpF6F-0006la-SY for submit@debbugs.gnu.org; Fri, 14 Nov 2014 06:31:36 -0500 Received: from mx0.mattleach.net ([176.58.118.143]:56760) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpF6D-0006lQ-6d for 1702@debbugs.gnu.org; Fri, 14 Nov 2014 06:31:34 -0500 Received: by mx0.mattleach.net (Postfix, from userid 99) id C3C0261AC8; Fri, 14 Nov 2014 11:31:32 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx0.mattleach.net X-Spam-Level: X-Spam-Status: No, score=-1.0 required=4.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from loki.mattleach.net (host86-180-142-129.range86-180.btcentralplus.com [86.180.142.129]) by mx0.mattleach.net (Postfix) with ESMTPSA id E4C8361ABC; Fri, 14 Nov 2014 11:31:30 +0000 (GMT) From: Matthew Leach To: Eli Zaretskii Subject: Re: bug#1702: [PATCH]: feature request: correctly display single file zip archive In-Reply-To: <87sihmjb22.fsf@mattleach.net> (Matthew Leach's message of "Fri, 14 Nov 2014 11:06:45 +0000") References: <87lju1hv7b.fsf@cyd.mit.edu> <13EFAAB6-C6B3-4F67-A39A-5266E91A0CD5@xahlee.org> <87wq6zj66o.fsf_-_@loki.home> <83ppcrj5ot.fsf@gnu.org> <87r3x6kilm.fsf@loki.home> <83lhnekhyp.fsf@gnu.org> <87mw7ukgvf.fsf@loki.home> <83h9y2kfva.fsf@gnu.org> <87a93ukepe.fsf@loki.home> <83d28qjqs2.fsf@gnu.org> <87sihmjb22.fsf@mattleach.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Date: Fri, 14 Nov 2014 11:31:29 +0000 Message-ID: <87lhnej9wu.fsf@mattleach.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 1702 Cc: xah@xahlee.org, 1702@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Matthew Leach writes: [...] > @@ -742,7 +751,13 @@ archive. > (if (default-value 'enable-multibyte-characters) > (set-buffer-multibyte 'to)) > (archive-summarize nil) > - (setq buffer-read-only t)))) > + (setq buffer-read-only t) > + (when (and archive-visit-single-files > + auto-compression-mode > + (= (length archive-files) 1)) > + (let ((archive-buffer (current-buffer))) Oops, the `let' isn't needed anymore. Sorry for the noise. -- Matt --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Don-t-show-summary-for-single-file-archives.patch >From a6ec5479a42c130c36d7d628fa976630b19d741c Mon Sep 17 00:00:00 2001 From: Matthew Leach Date: Thu, 13 Nov 2014 18:30:24 +0000 Subject: [PATCH] Don't show summary for single-file archives. * arc-mode.el (archive-visit-single-files): New. (archive-mode): Visit file if archive contains a single file. * etc/NEWS: Mention archive will now visit the file in singular-file archives. --- etc/NEWS | 6 ++++++ lisp/arc-mode.el | 16 +++++++++++++++- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/etc/NEWS b/etc/NEWS index 05210df..2083127 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -184,6 +184,12 @@ appending FUN to `minibuffer-setup-hook'. ** cl-lib *** New functions cl-fresh-line, cl-digit-char-p and cl-parse-integer. +** Archive +*** When visiting an archive that contains a single file automatically +visit that file, rather than displaying the archive summary. To +revert to the original behaviour, set `archive-visit-single-files' to +nil. + ** Calendar and diary +++ diff --git a/lisp/arc-mode.el b/lisp/arc-mode.el index ef155ee..3026a6a 100644 --- a/lisp/arc-mode.el +++ b/lisp/arc-mode.el @@ -147,6 +147,15 @@ A local copy of the archive will be used when updating." "Hook run when an archive member has been extracted." :type 'hook :group 'archive) + +(defcustom archive-visit-single-files t + "If non-nil, opening an archive with a single file visits that file. + + If this option's value is nil, visiting such archives will + display the archive summary." + :type '(choice (const :tag "Visit the single file" t) + (const :tag "Show the archive summary" nil)) + :group 'archive) ;; ------------------------------ ;; Arc archive configuration @@ -742,7 +751,12 @@ archive. (if (default-value 'enable-multibyte-characters) (set-buffer-multibyte 'to)) (archive-summarize nil) - (setq buffer-read-only t)))) + (setq buffer-read-only t) + (when (and archive-visit-single-files + auto-compression-mode + (= (length archive-files) 1)) + (rename-buffer (concat " " (buffer-name))) + (archive-extract))))) ;; Archive mode is suitable only for specially formatted data. (put 'archive-mode 'mode-class 'special) -- 2.1.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 18 08:05:06 2014 Received: (at 1702) by debbugs.gnu.org; 18 Nov 2014 13:05:06 +0000 Received: from localhost ([127.0.0.1]:36907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XqiSv-00049F-Lz for submit@debbugs.gnu.org; Tue, 18 Nov 2014 08:05:06 -0500 Received: from dancol.org ([96.126.100.184]:50401) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XqiSt-000495-8k for 1702@debbugs.gnu.org; Tue, 18 Nov 2014 08:05:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=S00v9tR5PHm6I0D3fnpcR0fHlCu0A52kIEeqJtojiE8=; b=aD2cmPgvfDtBRojkela6rKmVqmsybtHguNARdZtnDZYmIAgplP+kFMLrAErWYfi0hGyglvLddPvhNRi3pgbixfVS7jJts8iHut2rkAkPb1mgm+x21Pr+WVRcVhkLr1JgNv/8mfYq+oyYHysnZQreYZcxTNuNS4f8yG0FhcUtMCUPE43WGcrnM8EOLBZoE9cPc2S1OtukETn285q0s9ILrBhG82TwJXuulIM7KEWvpVNE5dSzwx15XeA4nDd8HEtcKGOau11/2U2Dx2RB3fWMmaTXAw+45bulOe9yVGLi5ZmL2Q5198OVhT6lR8/uu30NqhYjhP/SmPArowbKEAPEDA==; Received: from [2620:0:1cfe:9a:2ab2:bdff:fe1c:db58] by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84) (envelope-from ) id 1XqiSq-0004Xt-IZ; Tue, 18 Nov 2014 05:05:00 -0800 Message-ID: <546B43F6.8040207@dancol.org> Date: Tue, 18 Nov 2014 05:04:54 -0800 From: Daniel Colascione User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Matthew Leach , Eli Zaretskii Subject: Re: bug#1702: [PATCH]: feature request: correctly display single file zip archive References: <87lju1hv7b.fsf@cyd.mit.edu> <13EFAAB6-C6B3-4F67-A39A-5266E91A0CD5@xahlee.org> <87wq6zj66o.fsf_-_@loki.home> <83ppcrj5ot.fsf@gnu.org> <87r3x6kilm.fsf@loki.home> <83lhnekhyp.fsf@gnu.org> <87mw7ukgvf.fsf@loki.home> <83h9y2kfva.fsf@gnu.org> <87a93ukepe.fsf@loki.home> <83d28qjqs2.fsf@gnu.org> <87sihmjb22.fsf@mattleach.net> <87lhnej9wu.fsf@mattleach.net> In-Reply-To: <87lhnej9wu.fsf@mattleach.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bWpMmcW2ci7xxVxbFT4IOa1FEPJDoJjER" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 1702 Cc: xah@xahlee.org, 1702@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bWpMmcW2ci7xxVxbFT4IOa1FEPJDoJjER Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 11/14/2014 03:31 AM, Matthew Leach wrote: > Matthew Leach writes: >=20 I don't think the new behavior should be the default. I'd prefer to avoid= making a special case for singleton zip files and let users opt into the= special case when it's convenient for their workflow. Special cases make= programs hard to learn. --bWpMmcW2ci7xxVxbFT4IOa1FEPJDoJjER Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJUa0P2AAoJEN4WImmbpWBl9ZkP/2PAYVIbrOObbgZQHZQq8qCX 3TyggHRnSUYzW+lLl8iLp46spY6copFNSFREARrb//oeMgN5ft1ouE24b0v2ln+G 2p3Ha+YXDjF2uMM3Odk+dueTOGAj5CKR9IIHss6nyoE+CQt4OUzq0VeKA7AD5sPT GujtOoKe12zxDd6iV33Oy9KHrF0qn0bU5BGvU7srgisAXBPp0wh296P0HFOxZc9W OE5ootuCDLwgXRoCevJ6yHssWrXZCr4vD574LpBht+VeCv2FK9x4TBInlvRwIDAP 14UWwliHkvr37Iqd8SwA4uwbvsFFvj8JrJgDLN27jOqt4San0o33qumPBPqbg3Xz cSwAKyp2nPl3D9VRFS1WcCO/xwo+UMHJY/hh+a9icFHs8lV+AkHT8czr8CefK5CV gKhkE/RlQMsC5v5WeHFbEk2JEv4ey65ga66wyyTMBariSeOln7rXc6qAmM3d2f5H XMMnD+bXUHAl8ajGgusZdx5i12cCyJ4IVOrMK9WVUjjfZQgJFgejNiqdAkEe37wl KzRBNtPmSCpQCtx3RSUV5H3cqnwqqKHJdCrJDYSI0+CbHzwxtuJ63J0Ji9YV8Jjv lq7cMEnqJfViRgxUxzcz/dE4ZFFHmgzk6Il4QZrIOph4z5E7d3ao/MUMUKL7dKL8 HCUelz4wRj8XLabqzZfw =KITk -----END PGP SIGNATURE----- --bWpMmcW2ci7xxVxbFT4IOa1FEPJDoJjER-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 18 08:23:24 2014 Received: (at submit) by debbugs.gnu.org; 18 Nov 2014 13:23:24 +0000 Received: from localhost ([127.0.0.1]:36912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XqikZ-0004cd-Rx for submit@debbugs.gnu.org; Tue, 18 Nov 2014 08:23:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47925) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XqikU-0004cR-Bv for submit@debbugs.gnu.org; Tue, 18 Nov 2014 08:23:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqikM-00054M-63 for submit@debbugs.gnu.org; Tue, 18 Nov 2014 08:23:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: *** X-Spam-Status: No, score=4.0 required=5.0 tests=BAYES_50,FREEMAIL_FROM, FSL_HELO_BARE_IP_2,RCVD_NUMERIC_HELO autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45785) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqikM-00054I-3u for submit@debbugs.gnu.org; Tue, 18 Nov 2014 08:23:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqikF-0007wr-8E for bug-gnu-emacs@gnu.org; Tue, 18 Nov 2014 08:23:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xqik8-00052F-6v for bug-gnu-emacs@gnu.org; Tue, 18 Nov 2014 08:22:59 -0500 Received: from plane.gmane.org ([80.91.229.3]:53740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xqik8-00051p-0g for bug-gnu-emacs@gnu.org; Tue, 18 Nov 2014 08:22:52 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Xqik5-0006bH-Iu for bug-gnu-emacs@gnu.org; Tue, 18 Nov 2014 14:22:49 +0100 Received: from 109.201.154.199 ([109.201.154.199]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 18 Nov 2014 14:22:49 +0100 Received: from rasmus by 109.201.154.199 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 18 Nov 2014 14:22:49 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Rasmus Subject: Re: bug#1702: [PATCH]: feature request: correctly display single file zip archive Date: Tue, 18 Nov 2014 14:22:36 +0100 Lines: 26 Message-ID: <87tx1wwsmb.fsf@gmx.us> References: <87lju1hv7b.fsf@cyd.mit.edu> <13EFAAB6-C6B3-4F67-A39A-5266E91A0CD5@xahlee.org> <87wq6zj66o.fsf_-_@loki.home> <83ppcrj5ot.fsf@gnu.org> <87r3x6kilm.fsf@loki.home> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 109.201.154.199 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAAAAAByaaZbAAAAAnRSTlMA/iyWEiMAAAACYktH RAD/h4/MvwAAAAlwSFlzAAAASAAAAEgARslrPgAAAjNJREFUSMe1lsGNIzsMRH15+VQmlUqFwlAY CiMS9qDucdtuD7D78QX4YFtPJFVUSY/1l+Pxj0AbqOO36ZrfgTFytfa0EaD+DRBxTR0h4ukS+Q6Y UC2AJBZOJl+Ix1qNyYCrAhIg8xPwE4jE2DGqTqoNgjFfAEtUzDnUJRvPbYjHWhJvo6YMI+Y+JfxO yMAKN8Qu+oMA3ESfWT1WgGp4wzSCCL2p/iglZUC1Qm2ZUcY7N4Gvqj/iOoue3h88U89y9KL6Y1As CfWysvbMdHVftsCXGhqc1K5hWmABR057XPrksdYqwVWLqaqjt54x5uU8DBf1NJ97HPn1APkCdN2o EvoVeOaU5k5G6UuErcRHryiH6D9AfpuPZO2kThM4GlD388EEzcVmjhruCwCsgzgB0wYtU/c5mU2c QBOrssTMXbOrD8F/nK+gJiPKee7+GDA7NoR5WmVR+8io8FRSPV05FnfPDnHx1khENIWrusqCPlpF 8QjbVzOeUKI4z6xiyngCFJlq68W9d0oUCjWz1shF3EABNdQbUFAE5TAxKTQpKGzkdQOoUI7+l61i r1Nr5u1CqQ3kBxis/ZU6+vsFCIXq8ndTeAN9Aww2qp1D7xKMQ3Qfodj7d2S8VhNwKNAdIBuUnVLO U6Ic63wCREBZUMpayy5wrC+APFHXoetaq+iZ5XwDGveUirOGZSTIVLoPZd6E2xabPjexk3jffrl9 CUy3SD19a53OWN+fDgHydvXMf35r/I/AH5DaBVjP2kHeAAAAAElFTkSuQmCC User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.4.51 (gnu/linux) Cancel-Lock: sha1:+DvSg2HpUaWCgS50G/E+C+F875M= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) Lars Magne Ingebrigtsen writes: > I think it would be nice to go directly to the single file in these > archives, but, on the other hand, it might be kinda surprising. If > you're visiting an archive, you expect to see the list of files in the > archive. For one type of archives (ones with a single file in them) to > work differently may be too inconsistent. > > So I dunno... others who want to chime in? If I get the zip from somewhere I probably don't know it's a single-file zip beforehand. . . So maybe displaying it in tar-mode (or whatever it's called) and requiring one more RET is better. How about a zip file that contains only one folder and one file, like folder/ folder/txt I don't necessarily agree that the proposed behavior is the logically correct thing to do in the case of an archive that is not "obviously"(?) a file (like foo.el.gz). —Rasmus -- However beautiful the theory, you should occasionally look at the evidence From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 18 15:12:29 2014 Received: (at 1702) by debbugs.gnu.org; 18 Nov 2014 20:12:29 +0000 Received: from localhost ([127.0.0.1]:37575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xqp8X-0006Tl-58 for submit@debbugs.gnu.org; Tue, 18 Nov 2014 15:12:29 -0500 Received: from mx0.mattleach.net ([176.58.118.143]:60146) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xqp8V-0006Td-7H for 1702@debbugs.gnu.org; Tue, 18 Nov 2014 15:12:27 -0500 Received: by mx0.mattleach.net (Postfix, from userid 99) id E18E061ACC; Tue, 18 Nov 2014 20:12:26 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx0.mattleach.net X-Spam-Level: X-Spam-Status: No, score=-1.0 required=4.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from loki.home.mattleach.net (host86-157-143-67.range86-157.btcentralplus.com [86.157.143.67]) by mx0.mattleach.net (Postfix) with ESMTPSA id 2907161ABC; Tue, 18 Nov 2014 20:12:26 +0000 (GMT) From: Matthew Leach To: Daniel Colascione Subject: Re: bug#1702: [PATCH]: feature request: correctly display single file zip archive In-Reply-To: <546B43F6.8040207@dancol.org> (Daniel Colascione's message of "Tue, 18 Nov 2014 05:04:54 -0800") References: <87lju1hv7b.fsf@cyd.mit.edu> <13EFAAB6-C6B3-4F67-A39A-5266E91A0CD5@xahlee.org> <87wq6zj66o.fsf_-_@loki.home> <83ppcrj5ot.fsf@gnu.org> <87r3x6kilm.fsf@loki.home> <83lhnekhyp.fsf@gnu.org> <87mw7ukgvf.fsf@loki.home> <83h9y2kfva.fsf@gnu.org> <87a93ukepe.fsf@loki.home> <83d28qjqs2.fsf@gnu.org> <87sihmjb22.fsf@mattleach.net> <87lhnej9wu.fsf@mattleach.net> <546B43F6.8040207@dancol.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Date: Tue, 18 Nov 2014 20:12:25 +0000 Message-ID: <87y4r8i7yu.fsf@loki.home> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 1702 Cc: xah@xahlee.org, 1702@debbugs.gnu.org, Eli Zaretskii , cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Daniel Colascione writes: > On 11/14/2014 03:31 AM, Matthew Leach wrote: >> Matthew Leach writes: >> > > I don't think the new behavior should be the default. It seems as though that is the consensus. Revised patch included that turns off the feature by default. Thanks, Matt lisp/ChangeLog: 2014-11-13 Matthew Leach * arc-mode.el (archive-visit-single-files): New. (archive-mode): Visit file if archive contains a single file. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=arc-single-file-mode.patch diff --git a/lisp/arc-mode.el b/lisp/arc-mode.el index ef155ee..9833c90 100644 --- a/lisp/arc-mode.el +++ b/lisp/arc-mode.el @@ -147,6 +147,15 @@ A local copy of the archive will be used when updating." "Hook run when an archive member has been extracted." :type 'hook :group 'archive) + +(defcustom archive-visit-single-files nil + "If non-nil, opening an archive with a single file visits that file. + + If this option's value is nil, visiting such archives will + display the archive summary." + :type '(choice (const :tag "Visit the single file" t) + (const :tag "Show the archive summary" nil)) + :group 'archive) ;; ------------------------------ ;; Arc archive configuration @@ -742,7 +751,12 @@ archive. (if (default-value 'enable-multibyte-characters) (set-buffer-multibyte 'to)) (archive-summarize nil) - (setq buffer-read-only t)))) + (setq buffer-read-only t) + (when (and archive-visit-single-files + auto-compression-mode + (= (length archive-files) 1)) + (rename-buffer (concat " " (buffer-name))) + (archive-extract))))) ;; Archive mode is suitable only for specially formatted data. (put 'archive-mode 'mode-class 'special) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 21 05:10:07 2014 Received: (at 1702-done) by debbugs.gnu.org; 21 Nov 2014 10:10:08 +0000 Received: from localhost ([127.0.0.1]:40276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrlAF-000452-3x for submit@debbugs.gnu.org; Fri, 21 Nov 2014 05:10:07 -0500 Received: from mtaout24.012.net.il ([80.179.55.180]:58644) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrlAB-00044l-Lz for 1702-done@debbugs.gnu.org; Fri, 21 Nov 2014 05:10:04 -0500 Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NFD00800VNCSN00@mtaout24.012.net.il> for 1702-done@debbugs.gnu.org; Fri, 21 Nov 2014 12:02:24 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NFD006FTVW0BJ30@mtaout24.012.net.il>; Fri, 21 Nov 2014 12:02:24 +0200 (IST) Date: Fri, 21 Nov 2014 12:10:00 +0200 From: Eli Zaretskii Subject: Re: bug#1702: [PATCH]: feature request: correctly display single file zip archive In-reply-to: <87y4r8i7yu.fsf@loki.home> X-012-Sender: halo1@inter.net.il To: Matthew Leach Message-id: <83d28g50g7.fsf@gnu.org> References: <87lju1hv7b.fsf@cyd.mit.edu> <13EFAAB6-C6B3-4F67-A39A-5266E91A0CD5@xahlee.org> <87wq6zj66o.fsf_-_@loki.home> <83ppcrj5ot.fsf@gnu.org> <87r3x6kilm.fsf@loki.home> <83lhnekhyp.fsf@gnu.org> <87mw7ukgvf.fsf@loki.home> <83h9y2kfva.fsf@gnu.org> <87a93ukepe.fsf@loki.home> <83d28qjqs2.fsf@gnu.org> <87sihmjb22.fsf@mattleach.net> <87lhnej9wu.fsf@mattleach.net> <546B43F6.8040207@dancol.org> <87y4r8i7yu.fsf@loki.home> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 1702-done Cc: xah@xahlee.org, 1702-done@debbugs.gnu.org, cyd@stupidchicken.com, dancol@dancol.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Matthew Leach > Cc: Eli Zaretskii , xah@xahlee.org, 1702@debbugs.gnu.org, cyd@stupidchicken.com > Date: Tue, 18 Nov 2014 20:12:25 +0000 > > Daniel Colascione writes: > > > On 11/14/2014 03:31 AM, Matthew Leach wrote: > >> Matthew Leach writes: > >> > > > > I don't think the new behavior should be the default. > > It seems as though that is the consensus. Revised patch included that > turns off the feature by default. Thanks, I pushed this in your name, and I'm closing the bug. From unknown Sat Sep 06 05:55:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 19 Dec 2014 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator