GNU bug report logs - #17000
setup ido keymaps only once

Previous Next

Full log

Message #8 received at 17000 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Jonas Bernoulli <jonas <at> bernoul.li>
Cc: 17000 <at> debbugs.gnu.org
Subject: Re: bug#17000: setup ido keymaps only once
Date: Wed, 12 Mar 2014 19:36:06 -0400

> Currently the ido keymaps are hard to modify because they are recreated
> every time `ido-completing-read' is used.

Indeed, this is wrong.

> I believe it is safe for the "base" ido keymaps to set the value when
> the variable is defined, instead of delaying this until ido is actually
> used, and then redoing that work whenever `ido-completing-read' is
> called.

Agreed.

> -(defvar ido-common-completion-map nil
> +(defvar ido-common-completion-map
> +  (let ((map (make-sparse-keymap)))
[...]
> +    (set-keymap-parent map minibuffer-local-map)
> +    (setq ido-common-completion-map map))

This last line should just be "map)".  Same for the other maps.

Looks good.  Please apply after the trunk re-opens.


        Stefan "Beware: I don't use IDO and don't know its code"

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.