From unknown Sat Jun 14 19:11:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16993: advice-add hides docstring Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Mar 2014 04:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 16993@debbugs.gnu.org X-Debbugs-Original-To: Bug-Gnu-Emacs Received: via spool by submit@debbugs.gnu.org id=B.139459913016588 (code B ref -1); Wed, 12 Mar 2014 04:39:01 +0000 Received: (at submit) by debbugs.gnu.org; 12 Mar 2014 04:38:50 +0000 Received: from localhost ([127.0.0.1]:33780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNawL-0004JU-NY for submit@debbugs.gnu.org; Wed, 12 Mar 2014 00:38:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52992) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNawJ-0004JK-O8 for submit@debbugs.gnu.org; Wed, 12 Mar 2014 00:38:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNawI-0000r7-Kt for submit@debbugs.gnu.org; Wed, 12 Mar 2014 00:38:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40028) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNawI-0000r3-IO for submit@debbugs.gnu.org; Wed, 12 Mar 2014 00:38:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNawH-0006XM-Nf for bug-gnu-emacs@gnu.org; Wed, 12 Mar 2014 00:38:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNawH-0000ql-07 for bug-gnu-emacs@gnu.org; Wed, 12 Mar 2014 00:38:45 -0400 Received: from mail-yk0-x22f.google.com ([2607:f8b0:4002:c07::22f]:39068) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNawG-0000qZ-Qf for bug-gnu-emacs@gnu.org; Wed, 12 Mar 2014 00:38:44 -0400 Received: by mail-yk0-f175.google.com with SMTP id 131so25813839ykp.6 for ; Tue, 11 Mar 2014 21:38:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=Mp5upOwyDc3SHG7PddlhnsL1OBisU/KDHcEHZTHuWYI=; b=n+68iZ5385UE4b5oYfbRUQ3qDp1C0hhKnrmqq5LtlLrmUJWB2wPZERVf8jvl4stziB b0uYceMUY5wFsobvTnWAOXJXHRA15hg7Dtoda9k2d0v2UT4FTZHZdgVT85Mf9QeyI/E0 HZvTLP5JpflXZkTJ29LU1t3MT9kGkN0eoziqObSi6wN2szDOPcKmN6iAdMuA2ND5Tv0G PmnjzPkdz8m19beOrJ0D2lhjao60MP53+ijHKI+o8fLzzJ6ZD3LD92f8pemvoVNKcFUP M3prvV35PFAfiC0hMc97Lth2cNhoA3iLGoKrgXC/AOjGNj2x5TMtLwjqHOCtySS1cnUG wwUw== X-Received: by 10.236.92.115 with SMTP id i79mr56547838yhf.62.1394599124051; Tue, 11 Mar 2014 21:38:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.170.163.3 with HTTP; Tue, 11 Mar 2014 21:38:03 -0700 (PDT) From: Juanma Barranquero Date: Wed, 12 Mar 2014 05:38:03 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Package: emacs Version: 24.3.50 ISTR this was discussed before, but I cannot find a bug report about it... Some advice-add'ed functions lose their docstring. Current examples from "emacs -Q" include `insert-directory', `rename-buffer' and `create-file-buffer'. Others do no. After (require 'cl), `dolist', `dotimes' and `declare' still have their docstrings. After loading ses.el, both `yank' and `copy-region-as-kill' still have their docstrings. However, in C-h f yank the around advice info :around advice: `ses--advice-yank' isn't font-locked as it is in other cases. From unknown Sat Jun 14 19:11:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16993: advice-add hides docstring Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Mar 2014 19:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juanma Barranquero Cc: 16993@debbugs.gnu.org Received: via spool by 16993-submit@debbugs.gnu.org id=B16993.13946528506589 (code B ref 16993); Wed, 12 Mar 2014 19:35:01 +0000 Received: (at 16993) by debbugs.gnu.org; 12 Mar 2014 19:34:10 +0000 Received: from localhost ([127.0.0.1]:34939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNoun-0001iC-D4 for submit@debbugs.gnu.org; Wed, 12 Mar 2014 15:34:09 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:59450) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNouk-0001i2-JC for 16993@debbugs.gnu.org; Wed, 12 Mar 2014 15:34:07 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WNouj-0002gT-Kp; Wed, 12 Mar 2014 15:34:05 -0400 From: Glenn Morris References: X-Spook: quarter Freeh Janet Reno pre-emptive supercomputer X-Ran: mmR*6JT4)(Y[{dvityXjRY$9"*pvRF]/hy.1ygX,B6z"ivWy0bY}^Rgqs=6>dH<\7i3DN* X-Hue: green X-Attribution: GM Date: Wed, 12 Mar 2014 15:34:05 -0400 In-Reply-To: (Juanma Barranquero's message of "Wed, 12 Mar 2014 05:38:03 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Juanma Barranquero wrote: > C-h f yank > > the around advice info > > :around advice: `ses--advice-yank' > > isn't font-locked as it is in other cases. I think this is because substitute-command-keys (in describe-function-1) removes text properties (per its documentation). From unknown Sat Jun 14 19:11:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16993: advice-add hides docstring Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Mar 2014 19:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 16993@debbugs.gnu.org Received: via spool by 16993-submit@debbugs.gnu.org id=B16993.13946538378593 (code B ref 16993); Wed, 12 Mar 2014 19:51:02 +0000 Received: (at 16993) by debbugs.gnu.org; 12 Mar 2014 19:50:37 +0000 Received: from localhost ([127.0.0.1]:34946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNpAi-0002ET-5U for submit@debbugs.gnu.org; Wed, 12 Mar 2014 15:50:36 -0400 Received: from mail-yh0-f43.google.com ([209.85.213.43]:61645) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNpAf-0002ED-EW for 16993@debbugs.gnu.org; Wed, 12 Mar 2014 15:50:34 -0400 Received: by mail-yh0-f43.google.com with SMTP id b6so10745240yha.30 for <16993@debbugs.gnu.org>; Wed, 12 Mar 2014 12:50:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=tPAAUpClPpPhmaKiuTeYtDeTgcdbqJoZSknkn5+2ubA=; b=FxF3aREt8/Stnu3EpyKsT7Ibm7cx1/014nWlR4HbbUslpvKhXueEMfSvhZpf0GSM1i DBgpiv1eM8PSNyeJHiR6xpy/Z2ls9rFI8YDEY1LlIFNlRtyTffh0rmQHu9HEuNz90Pw7 +eRZKotwfPNasjBghfGDya/wFCgpuHjMMErMVBRpBlxpZup1fpKZ/gtbaVeRU4BzKcql wiWGUpqfCuXE6dAD6olSkZdHwowpvOBw3sy+oEWLJO/Sz6+bE2hRBQufiMEmaXA+uTeN +hLgrk+kESlKU1prd+Rf2uFF4rxObtyysRPMgyMJNa9nS89+KpGRSaluldaXQOj6B5Fk XqZA== X-Received: by 10.236.62.232 with SMTP id y68mr63911005yhc.12.1394653832527; Wed, 12 Mar 2014 12:50:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.170.163.3 with HTTP; Wed, 12 Mar 2014 12:49:52 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Wed, 12 Mar 2014 20:49:52 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, Mar 12, 2014 at 8:34 PM, Glenn Morris wrote: > I think this is because substitute-command-keys (in describe-function-1) > removes text properties (per its documentation). Aha, I tried with two test functions, one with a key binding in its doc (\\[universal-argument]) and the other without, and indeed, the first one gets its advice info's font-locking removed and the other doesn't. I'll try to come with an easy fix, if at all possible, unless you beat me to it (feel free to ;-) Still, the other problem (docstrings missing) is much more serious. Thanks, J From unknown Sat Jun 14 19:11:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16993: advice-add hides docstring Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Mar 2014 19:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juanma Barranquero Cc: 16993@debbugs.gnu.org Received: via spool by 16993-submit@debbugs.gnu.org id=B16993.13946541619296 (code B ref 16993); Wed, 12 Mar 2014 19:57:01 +0000 Received: (at 16993) by debbugs.gnu.org; 12 Mar 2014 19:56:01 +0000 Received: from localhost ([127.0.0.1]:34955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNpFx-0002Po-EK for submit@debbugs.gnu.org; Wed, 12 Mar 2014 15:56:01 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:59760) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNpFu-0002Pf-MU for 16993@debbugs.gnu.org; Wed, 12 Mar 2014 15:55:59 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WNpFt-0007Hs-Qu; Wed, 12 Mar 2014 15:55:57 -0400 From: Glenn Morris References: X-Spook: Craig Livingstone INS Adriatic ammunition e-cash CDMA X-Ran: I)j[x|MboFk8w[Eu5S+z\0KnhW>\K&da&=9H^/&E4Cmh8+iv"!N0"7=uZ# X-Hue: cyan X-Attribution: GM Date: Wed, 12 Mar 2014 15:55:57 -0400 In-Reply-To: (Juanma Barranquero's message of "Wed, 12 Mar 2014 20:49:52 +0100") Message-ID: <3uzjkvxkc2.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Juanma Barranquero wrote: > Aha, I tried with two test functions, one with a key binding in its > doc (\\[universal-argument]) and the other without, and indeed, the > first one gets its advice info's font-locking removed and the other > doesn't. > > I'll try to come with an easy fix, if at all possible, unless you beat > me to it (feel free to ;-) I don't intend to work on it, but IMO substitute-command-keys should preserve text properties. AFAIK, there's no particular reason why it removes them; see e.g. http://lists.gnu.org/archive/html/emacs-pretest-bug/2005-11/msg00094.html > Still, the other problem (docstrings missing) is much more serious. I guess that's something to do with built-in functions. (I don't see an issue with insert-directory.) From unknown Sat Jun 14 19:11:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16993: advice-add hides docstring Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Mar 2014 20:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 16993@debbugs.gnu.org Received: via spool by 16993-submit@debbugs.gnu.org id=B16993.139465538611799 (code B ref 16993); Wed, 12 Mar 2014 20:17:01 +0000 Received: (at 16993) by debbugs.gnu.org; 12 Mar 2014 20:16:26 +0000 Received: from localhost ([127.0.0.1]:34965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNpZh-00034E-JT for submit@debbugs.gnu.org; Wed, 12 Mar 2014 16:16:25 -0400 Received: from mail-yk0-f172.google.com ([209.85.160.172]:58475) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNpZf-000341-4Z for 16993@debbugs.gnu.org; Wed, 12 Mar 2014 16:16:23 -0400 Received: by mail-yk0-f172.google.com with SMTP id 200so77051ykr.3 for <16993@debbugs.gnu.org>; Wed, 12 Mar 2014 13:16:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=u1koAsKKF2T0kIwnZuL/K3Pv+AknOulB0TE1/ZQvjrw=; b=OKcBLpWWwdi1mNJvZjXoxry/aMoi/MhHPX46ybvmDFRBGx9d3ZYhMqtzxMfC4WsPD9 YW/QQ48KHbv4JtW3RnhrNvfZ9Sa2uzyqxMI7euDgJoXkw7yc2RUv/38xLkEN7bXiGnBu ojJo9dpF96+1MIm41zuBRQnuI0v7U0YVuosoJ8mdvvxihca7GPueCnL7nCrF9AClI/f5 WyXlEZ0usNK7ooiGLZiWz6NeYn5LCiYwclx10ioT7fmxgwFngcJyowP/pHs3X7CIyMnJ 3gG/AtF2wVnOfivfJxBy5Q7aYXMMlOOGD2FkPgiw1ztW6nFzt3L3o5IBAy7HVf63cEw3 JG9Q== X-Received: by 10.236.149.2 with SMTP id w2mr5319198yhj.114.1394655381665; Wed, 12 Mar 2014 13:16:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.170.163.3 with HTTP; Wed, 12 Mar 2014 13:15:41 -0700 (PDT) In-Reply-To: <3uzjkvxkc2.fsf@fencepost.gnu.org> References: <3uzjkvxkc2.fsf@fencepost.gnu.org> From: Juanma Barranquero Date: Wed, 12 Mar 2014 21:15:41 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, Mar 12, 2014 at 8:55 PM, Glenn Morris wrote: > I don't intend to work on it, but IMO substitute-command-keys should > preserve text properties. > AFAIK, there's no particular reason why it removes them; see e.g. > > http://lists.gnu.org/archive/html/emacs-pretest-bug/2005-11/msg00094.html I'll look into it. Thanks. > I guess that's something to do with built-in functions. > (I don't see an issue with insert-directory.) Because your Emacs doesn't use ls-lisp, I guess. Do you see the problem if you load eshell? J From unknown Sat Jun 14 19:11:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16993: advice-add hides docstring Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Mar 2014 20:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juanma Barranquero Cc: 16993@debbugs.gnu.org Received: via spool by 16993-submit@debbugs.gnu.org id=B16993.139465631313756 (code B ref 16993); Wed, 12 Mar 2014 20:32:02 +0000 Received: (at 16993) by debbugs.gnu.org; 12 Mar 2014 20:31:53 +0000 Received: from localhost ([127.0.0.1]:34980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNpoe-0003Zo-ST for submit@debbugs.gnu.org; Wed, 12 Mar 2014 16:31:53 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:60553) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNpob-0003Ze-Nj for 16993@debbugs.gnu.org; Wed, 12 Mar 2014 16:31:50 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WNpoa-0004iN-Mx; Wed, 12 Mar 2014 16:31:48 -0400 From: Glenn Morris References: <3uzjkvxkc2.fsf@fencepost.gnu.org> X-Spook: bemd USCODE BCCI kilo class quarter Ortega sweep beanpole X-Ran: p*:5Gp$o%xB}-6fzU=ql3QS34Bi|C%{b%BQ1my#w9k[z{*~Kkz{#l++'>G[xBPoFiyLPx* X-Hue: blue X-Attribution: GM Date: Wed, 12 Mar 2014 16:31:48 -0400 In-Reply-To: (Juanma Barranquero's message of "Wed, 12 Mar 2014 21:15:41 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Juanma Barranquero wrote: >> (I don't see an issue with insert-directory.) > > Because your Emacs doesn't use ls-lisp, I guess. Do you see the > problem if you load eshell? No. Nor if I load ls-lisp. Perhaps it has to loaded before dumping. From unknown Sat Jun 14 19:11:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16993: advice-add hides docstring Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Mar 2014 20:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 16993@debbugs.gnu.org Received: via spool by 16993-submit@debbugs.gnu.org id=B16993.139465648014083 (code B ref 16993); Wed, 12 Mar 2014 20:35:01 +0000 Received: (at 16993) by debbugs.gnu.org; 12 Mar 2014 20:34:40 +0000 Received: from localhost ([127.0.0.1]:34984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNprL-0003f4-Lk for submit@debbugs.gnu.org; Wed, 12 Mar 2014 16:34:40 -0400 Received: from mail-yk0-f169.google.com ([209.85.160.169]:62239) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNprJ-0003ew-9Y for 16993@debbugs.gnu.org; Wed, 12 Mar 2014 16:34:37 -0400 Received: by mail-yk0-f169.google.com with SMTP id 142so144231ykq.0 for <16993@debbugs.gnu.org>; Wed, 12 Mar 2014 13:34:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=BNXvpzQYlROgBHm4k2wI0fJW75T/SloCw24i0LO0YuM=; b=ecQkFDHZUkNweaBt1ZDEADrUr9q/ksuif8vMapZfkGf4/KCGW9XJ/nR5SUXWkjRwJX T5lQiCBl+ZexvCG8Wgb8t9R96Y1Hsttibnn+ULNGDEObsRS6P814W5wc4z/eI8yT8jqu EGRNITxNBk6pdKucK7i3Z0PUXlyWNRiswXY8vfszYhz4qumkRdybEuTQaWVnyUiDVwrn ZZCgZKQag+2UAuSh5PMuMC/I+HZfc4Mu/zsgljZKkS3wDfG9Lu2akoRcIFlP4WRUPZyk ejcAqK9LBtjWMcRNzK6quIREA7Uo8qaht/qYVpIfKWMUAoxIJpghpbTNV06xJsgb2iwa loHQ== X-Received: by 10.236.137.8 with SMTP id x8mr32996639yhi.4.1394656476500; Wed, 12 Mar 2014 13:34:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.170.163.3 with HTTP; Wed, 12 Mar 2014 13:33:56 -0700 (PDT) In-Reply-To: References: <3uzjkvxkc2.fsf@fencepost.gnu.org> From: Juanma Barranquero Date: Wed, 12 Mar 2014 21:33:56 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, Mar 12, 2014 at 9:31 PM, Glenn Morris wrote: > No. Nor if I load ls-lisp. Perhaps it has to loaded before dumping. Worth checking, I suppose. From unknown Sat Jun 14 19:11:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16993: advice-add hides docstring Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Mar 2014 16:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 16993@debbugs.gnu.org Received: via spool by 16993-submit@debbugs.gnu.org id=B16993.13952480726463 (code B ref 16993); Wed, 19 Mar 2014 16:55:01 +0000 Received: (at 16993) by debbugs.gnu.org; 19 Mar 2014 16:54:32 +0000 Received: from localhost ([127.0.0.1]:41411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQJl9-0001gA-6E for submit@debbugs.gnu.org; Wed, 19 Mar 2014 12:54:31 -0400 Received: from mail-yk0-f171.google.com ([209.85.160.171]:46561) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQJl6-0001g1-L3 for 16993@debbugs.gnu.org; Wed, 19 Mar 2014 12:54:29 -0400 Received: by mail-yk0-f171.google.com with SMTP id q9so23899507ykb.2 for <16993@debbugs.gnu.org>; Wed, 19 Mar 2014 09:54:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=OFPYVUb/9G2Nj/8yQquw2lgxd+OLWl2O/BmiylzFQik=; b=xlQLscSt/0KXoKoPPanzvyfCk7BQpt/a2H8BrNG41SPRncKqiIvxrHYOIXNwUqst6S Iiv+QkXj5gYMaoBqbXq3MOYKm7T44TTunKEbk9qQ/4Ul0l1+sC82g1tJ/MIcdprFl9RH EPGDKhYJ3bqFrek45TOd213GHjIHzlZF2DWFZPUEAnxvCOJ11waPVTlhz6ym5N51Mwh6 ChpxIDqysiJWmA6h2h2QTgRHQBwpHezxhmfFaUWlXZAIIz7uNN0BiZ3C1rDxMnfjvmtJ Hkjsw4lI/4QBraYoY+SjTnK+O6t0yQmrJAPpWjru1gBDNp7oSm3s01FrqczBIJfYUUbh RECg== X-Received: by 10.236.61.45 with SMTP id v33mr28156320yhc.20.1395248068024; Wed, 19 Mar 2014 09:54:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.170.163.3 with HTTP; Wed, 19 Mar 2014 09:53:47 -0700 (PDT) In-Reply-To: <3uzjkvxkc2.fsf@fencepost.gnu.org> References: <3uzjkvxkc2.fsf@fencepost.gnu.org> From: Juanma Barranquero Date: Wed, 19 Mar 2014 17:53:47 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, Mar 12, 2014 at 8:55 PM, Glenn Morris wrote: > I don't intend to work on it, but IMO substitute-command-keys should > preserve text properties. > AFAIK, there's no particular reason why it removes them; see e.g. > > http://lists.gnu.org/archive/html/emacs-pretest-bug/2005-11/msg00094.html I'll raise the issue on emacs-devel after the freeze. From unknown Sat Jun 14 19:11:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16993: advice-add hides docstring Resent-From: Stefan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Mar 2014 18:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juanma Barranquero Cc: 16993@debbugs.gnu.org Received: via spool by 16993-submit@debbugs.gnu.org id=B16993.139525376317186 (code B ref 16993); Wed, 19 Mar 2014 18:30:03 +0000 Received: (at 16993) by debbugs.gnu.org; 19 Mar 2014 18:29:23 +0000 Received: from localhost ([127.0.0.1]:41529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQLEx-0004T8-4C for submit@debbugs.gnu.org; Wed, 19 Mar 2014 14:29:23 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:9620) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQLEu-0004Sz-Om for 16993@debbugs.gnu.org; Wed, 19 Mar 2014 14:29:21 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFHO+KKg/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDjhiWYoFegxM X-IPAS-Result: Av4EABK/CFHO+KKg/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDjhiWYoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="52636318" Received: from 206-248-162-160.dsl.teksavvy.com (HELO pastel.home) ([206.248.162.160]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 19 Mar 2014 14:29:20 -0400 Received: by pastel.home (Postfix, from userid 20848) id C5A3C60123; Wed, 19 Mar 2014 14:29:19 -0400 (EDT) From: Stefan Message-ID: References: Date: Wed, 19 Mar 2014 14:29:19 -0400 In-Reply-To: (Juanma Barranquero's message of "Wed, 12 Mar 2014 05:38:03 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Some advice-add'ed functions lose their docstring. Current examples > from "emacs -Q" include `insert-directory', `rename-buffer' and > `create-file-buffer'. That's an incompatibility with Snarf-documentation: Snarf-documentation scans the DOC file, finds the doc of rename-buffer, and tries to stick the corresponding DOC offset in rename-buffer's "docstring slot". This should set the "docstring slot" of the #, but instead (symbol-function 'rename-buffer) returns an `advice--p' object, so Snarf-documentation tries to set the docstring slot of that object (which fails because the vector doesn't have a slot for it, but even if it succeeded it wouldn't be what we want). We can either fix it by teaching Snarf-documentation about advised function (yuck!) or by not advising functions that are documented in DOC. IOW the right fix is to get rid of those advices in uniquify.el. Stefan From unknown Sat Jun 14 19:11:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16993: advice-add hides docstring Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Mar 2014 05:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Cc: 16993@debbugs.gnu.org Received: via spool by 16993-submit@debbugs.gnu.org id=B16993.139529272426328 (code B ref 16993); Thu, 20 Mar 2014 05:19:02 +0000 Received: (at 16993) by debbugs.gnu.org; 20 Mar 2014 05:18:44 +0000 Received: from localhost ([127.0.0.1]:41801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQVNM-0006qa-4I for submit@debbugs.gnu.org; Thu, 20 Mar 2014 01:18:44 -0400 Received: from mail-yk0-f170.google.com ([209.85.160.170]:53304) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQVNK-0006qQ-HT for 16993@debbugs.gnu.org; Thu, 20 Mar 2014 01:18:43 -0400 Received: by mail-yk0-f170.google.com with SMTP id 9so1004333ykp.1 for <16993@debbugs.gnu.org>; Wed, 19 Mar 2014 22:18:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=kNeKPWfJSLtGu/77yqoSenKdCUf8VCpJMYBz1pgbKlw=; b=qC059x1TTSi3GvO5rs11QlZzfPUOjjtIYIxMw3Tndb9aL0kpVsao5J41G7oh8Ss2mh 3cmKr8lD5Kyey+dcLTMFJcSZC+8FyC69Y3BpRiy337V+XSXnRSpQ/1Tvol1SyOZfR8kt KkU9lTWgXNENWUGSrv7FM2cLFre85QcFi1GEZ1VcWwYkrmvAT8E7dQxghPvEn9pmqQsN /a2cncQzvdW8nSy57x82YV76XACzz0m2c5Nrskwh9xDuZCLafGVYI0rHWQ4BYZYBrHax 8EIt10O91iBSdbMh2ZJho5dIAUefxDt0F3Y57IbY2/VCmealtTfSP+Jfi5UxXhyuwzfP /Eqw== X-Received: by 10.236.163.73 with SMTP id z49mr24013893yhk.43.1395292721993; Wed, 19 Mar 2014 22:18:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.170.163.3 with HTTP; Wed, 19 Mar 2014 22:18:01 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Thu, 20 Mar 2014 06:18:01 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, Mar 19, 2014 at 7:29 PM, Stefan wrote: > We can either fix it by teaching Snarf-documentation about advised > function (yuck!) or by not advising functions that are documented in > DOC. IOW the right fix is to get rid of those advices in uniquify.el. IIUC, you're not proposing to delay the advice-add calls, but remove them altogether. How would you re-implement the current functionality so rename-buffer and create-file-buffer still respect uniquify? Some kind of hook in these functions? From unknown Sat Jun 14 19:11:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16993: advice-add hides docstring Resent-From: Stefan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Mar 2014 12:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juanma Barranquero Cc: 16993@debbugs.gnu.org Received: via spool by 16993-submit@debbugs.gnu.org id=B16993.139532018414991 (code B ref 16993); Thu, 20 Mar 2014 12:57:02 +0000 Received: (at 16993) by debbugs.gnu.org; 20 Mar 2014 12:56:24 +0000 Received: from localhost ([127.0.0.1]:41938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQcWF-0003ti-SV for submit@debbugs.gnu.org; Thu, 20 Mar 2014 08:56:24 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:19575) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQcW9-0003tV-Gc for 16993@debbugs.gnu.org; Thu, 20 Mar 2014 08:56:18 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFHO+KKg/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDjhiWYoFegxM X-IPAS-Result: Av4EABK/CFHO+KKg/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDjhiWYoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="52745276" Received: from 206-248-162-160.dsl.teksavvy.com (HELO pastel.home) ([206.248.162.160]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 20 Mar 2014 08:56:16 -0400 Received: by pastel.home (Postfix, from userid 20848) id 652E86012B; Thu, 20 Mar 2014 08:56:16 -0400 (EDT) From: Stefan Message-ID: References: Date: Thu, 20 Mar 2014 08:56:16 -0400 In-Reply-To: (Juanma Barranquero's message of "Thu, 20 Mar 2014 06:18:01 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> We can either fix it by teaching Snarf-documentation about advised >> function (yuck!) or by not advising functions that are documented in >> DOC. IOW the right fix is to get rid of those advices in uniquify.el. > IIUC, you're not proposing to delay the advice-add calls, but remove > them altogether. Right. > How would you re-implement the current functionality so rename-buffer > and create-file-buffer still respect uniquify? Some kind of hook in > these functions? I haven't looked at it yet, but last time I looked at removing uniquify's advices (that was many years ago), I couldn't come up with a good hook, so I expect that we'll "simply" change the current code of those 2 functions by adding explicit calls to uniquify. Stefan From unknown Sat Jun 14 19:11:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16993: advice-add hides docstring Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Mar 2014 13:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Cc: 16993@debbugs.gnu.org Received: via spool by 16993-submit@debbugs.gnu.org id=B16993.139532381521412 (code B ref 16993); Thu, 20 Mar 2014 13:57:02 +0000 Received: (at 16993) by debbugs.gnu.org; 20 Mar 2014 13:56:55 +0000 Received: from localhost ([127.0.0.1]:42349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQdSp-0005ZI-3k for submit@debbugs.gnu.org; Thu, 20 Mar 2014 09:56:55 -0400 Received: from mail-yh0-f51.google.com ([209.85.213.51]:64303) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQdSj-0005ZC-JR for 16993@debbugs.gnu.org; Thu, 20 Mar 2014 09:56:50 -0400 Received: by mail-yh0-f51.google.com with SMTP id f10so829661yha.10 for <16993@debbugs.gnu.org>; Thu, 20 Mar 2014 06:56:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=2/eC3WXv+XJAz5prICMxb7RTs2spYteM37no5TEnfB8=; b=Jjrujvx3FzFFyPjLjr4RexwXu8y0keTiN4FKwp2nwjpypPqT/nDNa3vDsH/WElec2a NkdFhhrauBQaih2/c8RcqokCAAzo4FUaL3YlMY1UDZKRcgmE0fjvncjZsz+/EY6OOUCc HfW4H4IXF6Jor9MeTkqFZsSG9BNTansmI+lnnHEWY7j/fJme8eAmQA/nCilr4011DTDO RDV0ZxjiefsrGMm0gToOoo06ygVphuDS8jZIB8achncmdggSjdOSIQYGmZje/geUV0du 3geftOkIEiowkCVlIM/bccg19O5p8GQNdYxfhCv5wBj2eR+MH/hYoYMHT+WJQasKzDXF RxTA== X-Received: by 10.236.23.71 with SMTP id u47mr2367160yhu.143.1395323808978; Thu, 20 Mar 2014 06:56:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.170.163.3 with HTTP; Thu, 20 Mar 2014 06:56:08 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Thu, 20 Mar 2014 14:56:08 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Thu, Mar 20, 2014 at 1:56 PM, Stefan wrote: > I haven't looked at it yet, but last time I looked at removing > uniquify's advices (that was many years ago), I couldn't come up with > a good hook, so I expect that we'll "simply" change the current > code of those 2 functions by adding explicit calls to uniquify. OK. I'll raise this issue too After the Freeze (tm). From unknown Sat Jun 14 19:11:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16993: advice-add hides docstring Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Mar 2014 15:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juanma Barranquero Cc: Stefan , 16993@debbugs.gnu.org Received: via spool by 16993-submit@debbugs.gnu.org id=B16993.13953310476504 (code B ref 16993); Thu, 20 Mar 2014 15:58:02 +0000 Received: (at 16993) by debbugs.gnu.org; 20 Mar 2014 15:57:27 +0000 Received: from localhost ([127.0.0.1]:42453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQfLS-0001gp-KJ for submit@debbugs.gnu.org; Thu, 20 Mar 2014 11:57:26 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:45189) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQfLQ-0001gd-OJ for 16993@debbugs.gnu.org; Thu, 20 Mar 2014 11:57:25 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WQfLO-0000xZ-IY; Thu, 20 Mar 2014 11:57:22 -0400 From: Glenn Morris References: X-Spook: Treasury Afghanistan DRM Uzbekistan Rule Psix Crowell X-Ran: ()a2$\|&AN[A1@2Oo(t0W+`pLe8-i'm6.2Wz.d6qth^VBE4nyEBaF?z>h}|o3Oqh?>O1ER X-Hue: black X-Attribution: GM Date: Thu, 20 Mar 2014 11:57:21 -0400 In-Reply-To: (Juanma Barranquero's message of "Thu, 20 Mar 2014 14:56:08 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is http://debbugs.gnu.org/1338, BTW. From unknown Sat Jun 14 19:11:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16993: advice-add hides docstring Resent-From: Stefan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Mar 2014 16:03:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juanma Barranquero Cc: 16993@debbugs.gnu.org Received: via spool by 16993-submit@debbugs.gnu.org id=B16993.13953313517217 (code B ref 16993); Thu, 20 Mar 2014 16:03:03 +0000 Received: (at 16993) by debbugs.gnu.org; 20 Mar 2014 16:02:31 +0000 Received: from localhost ([127.0.0.1]:42459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQfQL-0001sH-VY for submit@debbugs.gnu.org; Thu, 20 Mar 2014 12:02:30 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:11850) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQfQI-0001rt-84 for 16993@debbugs.gnu.org; Thu, 20 Mar 2014 12:02:27 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFHO+KKg/2dsb2JhbAA8CL8OF3OCHgEBBAFWIwULCw4mEhQYDSSIHgbBLY0bg28DjhiWYoFegxM X-IPAS-Result: Av4EABK/CFHO+KKg/2dsb2JhbAA8CL8OF3OCHgEBBAFWIwULCw4mEhQYDSSIHgbBLY0bg28DjhiWYoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="52771109" Received: from 206-248-162-160.dsl.teksavvy.com (HELO pastel.home) ([206.248.162.160]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 20 Mar 2014 12:02:25 -0400 Received: by pastel.home (Postfix, from userid 20848) id 165866012B; Thu, 20 Mar 2014 12:02:25 -0400 (EDT) From: Stefan Message-ID: References: Date: Thu, 20 Mar 2014 12:02:25 -0400 In-Reply-To: (Juanma Barranquero's message of "Wed, 12 Mar 2014 05:38:03 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Some advice-add'ed functions lose their docstring. Current examples > from "emacs -Q" include `insert-directory', `rename-buffer' and > `create-file-buffer'. I installed a workaround for these. > the around advice info > :around advice: `ses--advice-yank' > isn't font-locked as it is in other cases. I think this will have to wait for 24.5 to be fixed :-( Stefan From unknown Sat Jun 14 19:11:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16993: advice-add hides docstring Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Mar 2014 16:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Cc: 16993@debbugs.gnu.org Received: via spool by 16993-submit@debbugs.gnu.org id=B16993.13953323769288 (code B ref 16993); Thu, 20 Mar 2014 16:20:01 +0000 Received: (at 16993) by debbugs.gnu.org; 20 Mar 2014 16:19:36 +0000 Received: from localhost ([127.0.0.1]:42485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQfgs-0002Ph-Rk for submit@debbugs.gnu.org; Thu, 20 Mar 2014 12:19:35 -0400 Received: from mail-yh0-f41.google.com ([209.85.213.41]:42548) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQfgk-0002P9-Ju for 16993@debbugs.gnu.org; Thu, 20 Mar 2014 12:19:32 -0400 Received: by mail-yh0-f41.google.com with SMTP id v1so1094589yhn.0 for <16993@debbugs.gnu.org>; Thu, 20 Mar 2014 09:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=Y9DW03TxTS4jvBUvX+81aYHTV890mW2YP8W/cvIjRNo=; b=dgD5xEzqBB6BwWaMFto13QcwsmlX2AEUppW9FT38ssTky1wa5wBoA0yO8IOhY/Nquq 1D+m4IwaA7Bko/qCmptk251s991ZcAUIzWhkc0GMyuPq4ov5cLED5dNDNq7yvfiW1gh/ JpznygMuTPZCq9CMGwdPMA+NUXF0gOffNQhXPqO9VTpqJns1zVM5qIsB8lWyHPnPzexg rpvpYqiquHmwtifr7j47vuPl77+6N2OE7xicip3kdQYx9HN4Igxr1fkTb72HzQQ19ZS5 RwzHhbFryImCTQO8aKeAsGHjhEX152LKAUjkkVRTD4FiM8DltX0K5hdi0q53NzRN/mW7 Z0Sw== X-Received: by 10.236.147.10 with SMTP id s10mr20991965yhj.88.1395332365831; Thu, 20 Mar 2014 09:19:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.170.163.3 with HTTP; Thu, 20 Mar 2014 09:18:45 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Thu, 20 Mar 2014 17:18:45 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) forcemerge 16993 1338 close 16993 quit On Thu, Mar 20, 2014 at 5:02 PM, Stefan wrote: > I installed a workaround for these. Thanks. I'm closing this one and #1338, and will file a separate bug for substitute-command-keys. > I think this will have to wait for 24.5 to be fixed :-( Of course. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 20 12:35:18 2014 Received: (at control) by debbugs.gnu.org; 20 Mar 2014 16:35:19 +0000 Received: from localhost ([127.0.0.1]:42525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQfw5-00042f-Ct for submit@debbugs.gnu.org; Thu, 20 Mar 2014 12:35:17 -0400 Received: from mail-yh0-f49.google.com ([209.85.213.49]:64500) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQfw1-00042O-Kt for control@debbugs.gnu.org; Thu, 20 Mar 2014 12:35:14 -0400 Received: by mail-yh0-f49.google.com with SMTP id z6so1097536yhz.22 for ; Thu, 20 Mar 2014 09:35:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=pT+lPnwBaZw73Q6U7Z115hTxbRJUGLVbAThM+XL7Vbg=; b=nO5HrZ++uVS1UgiEvwtMvNkc70kLhyGkhMJKs0FdcUC/DslkNAnFwTJTj3nk+5FSep hZkZaj/wrCcg2jt4f4G6q1Y02iRUtZzEeVWFR2hraj47g74Jl5jOL2RWecC2XhcJ1IrW yxf6ti6dOQjA1oLsCcYGgXgJBb1d7n+TCT17d/Yjjuew1Kr3m17RCoHdMwgEQ09PBrFf s9bAML/4JQhr3LW3Rea2bZx6VxXBTAMkrjhMMq8aKGAKNMPZQnU7zrfKDUS35IH0oUK4 ddEo5Ku2OJSFdV6qVIK/4IaJvioxwr7Jwco64fJu4U6FRvVy2R3cX6VrMJy3ZxqZnAdp 8LBw== X-Received: by 10.236.23.71 with SMTP id u47mr3477981yhu.143.1395333313229; Thu, 20 Mar 2014 09:35:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.170.163.3 with HTTP; Thu, 20 Mar 2014 09:34:33 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Thu, 20 Mar 2014 17:34:33 +0100 Message-ID: Subject: Re: bug#1338: uniquify uses advice To: Glenn Morris Content-Type: text/plain; charset=UTF-8 Bcc: control@debbugs.gnu.org X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control Cc: 1338@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) unmerge 1338 reopen 1338 quit Sorry, my mistake. From unknown Sat Jun 14 19:11:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16993: advice-add hides docstring Resent-From: Stefan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Mar 2014 17:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juanma Barranquero Cc: 16993@debbugs.gnu.org Received: via spool by 16993-submit@debbugs.gnu.org id=B16993.139533815228983 (code B ref 16993); Thu, 20 Mar 2014 17:56:01 +0000 Received: (at 16993) by debbugs.gnu.org; 20 Mar 2014 17:55:52 +0000 Received: from localhost ([127.0.0.1]:42613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQhC1-0007XN-Vt for submit@debbugs.gnu.org; Thu, 20 Mar 2014 13:55:50 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:2006) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQhBz-0007XD-4h for 16993@debbugs.gnu.org; Thu, 20 Mar 2014 13:55:47 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Al8FABK/CFHO+KKg/2dsb2JhbABEj0SvShdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOOGJZigV6DEw X-IPAS-Result: Al8FABK/CFHO+KKg/2dsb2JhbABEj0SvShdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOOGJZigV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="52782266" Received: from 206-248-162-160.dsl.teksavvy.com (HELO pastel.home) ([206.248.162.160]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 20 Mar 2014 13:55:46 -0400 Received: by pastel.home (Postfix, from userid 20848) id 0AB296012B; Thu, 20 Mar 2014 13:55:46 -0400 (EDT) From: Stefan Message-ID: References: Date: Thu, 20 Mar 2014 13:55:45 -0400 In-Reply-To: (Juanma Barranquero's message of "Thu, 20 Mar 2014 17:18:45 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Thanks. I'm closing this one and #1338, No, my patch doesn't eliminate the advice on rename-buffer, it just makes C-h f rename-buffer find the right docstring (even tho it was put at the wrong place). > and will file a separate bug > for substitute-command-keys. Please do, thanks, Stefan From unknown Sat Jun 14 19:11:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16993: advice-add hides docstring Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Mar 2014 18:00:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Cc: 16993@debbugs.gnu.org Received: via spool by 16993-submit@debbugs.gnu.org id=B16993.139533839629410 (code B ref 16993); Thu, 20 Mar 2014 18:00:04 +0000 Received: (at 16993) by debbugs.gnu.org; 20 Mar 2014 17:59:56 +0000 Received: from localhost ([127.0.0.1]:42617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQhG0-0007eH-BH for submit@debbugs.gnu.org; Thu, 20 Mar 2014 13:59:56 -0400 Received: from mail-yh0-f42.google.com ([209.85.213.42]:57487) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQhFy-0007e7-8e for 16993@debbugs.gnu.org; Thu, 20 Mar 2014 13:59:54 -0400 Received: by mail-yh0-f42.google.com with SMTP id t59so1257116yho.1 for <16993@debbugs.gnu.org>; Thu, 20 Mar 2014 10:59:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=QGEGwZSkZHi32wOJMs2EQRnmsMT8IDFLjko0z8S6jO4=; b=ZbyLImmarXJm2SyRGaj9qzRfIAaJseypGmNz5WB3TYbdiM9fCigWHTQVxVxYulR/eP PEhA/6GxSVWP0ICnQ2+dikGvFC0jQIMX/45OMPtRIQjMsFe9nzni5y12a8Hg70kvDK6N u4NdDg0WLG/6vXtxo9TVuoYs2iddBzQQdKceWttgFYM2mdiYg/0LSFgIPODIOxMWCJcK piCqSADXgMATXPj9hIaqDOmCNFjix9ctssyAGvfb4Z7Zk9L1E6IL78dgpbOIsn/XEZWA N2KxNsqkpg/OaDQfFh0hEEksWLC4w3KnhSzdWT7gO0591QDum7o/+cAGnJT36f2p2mP0 PJGw== X-Received: by 10.236.61.45 with SMTP id v33mr36635464yhc.20.1395338393503; Thu, 20 Mar 2014 10:59:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.170.163.3 with HTTP; Thu, 20 Mar 2014 10:59:13 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Thu, 20 Mar 2014 18:59:13 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > No, my patch doesn't eliminate the advice on rename-buffer, it just > makes C-h f rename-buffer find the right docstring (even tho it was put > at the wrong place). Yes, my mistake, I already re-opened bug#1338. > Please do, thanks, Done as bug#17052.