GNU bug report logs - #16984
dired-do-rename susceptible to .../~/... hijack

Previous Next

Full log

Message #37 received at 16984 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 16984 <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: Re: bug#16984: dired-do-rename susceptible to .../~/... hijack
Date: Mon, 31 Oct 2016 20:42:22 -0400

[Message part 1 (text/plain, inline)]

Michael Albinus <michael.albinus <at> gmx.de> writes:
>>  
>> +           (not (let ((handler (find-file-name-handler
>> +                                filename 'substitute-in-file-name)))
>> +                  (and handler
>> +                       (funcall handler 'substitute-in-file-name filename)))))
>
> I would rather use (not (file-remote-p file-name))

Okay.

[v3-0001-Quote-filenames-containing-in-prompts.patch (text/plain, attachment)]

[Message part 3 (text/plain, inline)]

>
> This fixes the problem for local file names, but not for remote
> ones. "/ssh:user <at> host:/path/~/file" would still be expanded to something
> like "/ssh:user <at> host:/home/user/file". Well, better than nothing.
>
> What do people think to use the "/:" prefix also for the local part of
> remote file names? Then one could use "/ssh:user <at> host:/:/path/~/file",
> making substitute-in-file-name a noop.

Makes sense to me.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.