GNU bug report logs - #16972
Incorrect check for library target directory when relinking

Previous Next

Full log

View this message in rfc822 format

From: Peter Rosin <peda <at> lysator.liu.se>
To: Thilo Schulz <thilo <at> tjps.eu>, 16972 <at> debbugs.gnu.org
Subject: bug#16972: [PATCH] Fix for this bug
Date: Tue, 11 Mar 2014 08:37:47 +0100

On 2014-03-11 02:03, Thilo Schulz wrote:
> --- libtool.orig        2014-03-11 00:59:52.821999549 +0000
> +++ libtool     2014-03-11 01:00:21.197220463 +0000
> @@ -3402,7 +3402,7 @@
>           # At present, this check doesn't affect windows .dll's that
>           # are installed into $libdir/../bin (currently, that works fine)
>           # but it's something to keep an eye on.
> -         test "$inst_prefix_dir" = "$destdir" && \
> +         test "$inst_prefix_dir" = "$destdir" || \
>             func_fatal_error "error: cannot install \`$file' to a directory not 
> ending in $libdir"
>  
>           if test -n "$inst_prefix_dir"; then
> 

Hi Thilo,

I seriously doubt that this change is correct. The code has been the way
it is since it was added 10+ years ago (commit d2c4f8f8fc). Well, the test
was written as

	if test "$inst_prefix_dir" = "$destdir"; then
	  $echo ...
	  exit
	fi

way back when, but that's equivalent to the current code.

Cheers,
Peter

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.