From unknown Sun Jun 15 08:53:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16959: 24.3.50; defadvice docstring out of date Resent-From: Florian Beck Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Mar 2014 15:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16959 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 16959@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13942055224754 (code B ref -1); Fri, 07 Mar 2014 15:19:01 +0000 Received: (at submit) by debbugs.gnu.org; 7 Mar 2014 15:18:42 +0000 Received: from localhost ([127.0.0.1]:55020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WLwXp-0001Eb-8M for submit@debbugs.gnu.org; Fri, 07 Mar 2014 10:18:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46206) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WLwXm-0001ES-LV for submit@debbugs.gnu.org; Fri, 07 Mar 2014 10:18:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLwXg-0005eK-E6 for submit@debbugs.gnu.org; Fri, 07 Mar 2014 10:18:38 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50065) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLwXg-0005eG-BX for submit@debbugs.gnu.org; Fri, 07 Mar 2014 10:18:32 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47680) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLwXX-0007cf-AK for bug-gnu-emacs@gnu.org; Fri, 07 Mar 2014 10:18:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLwXR-0005WU-5Q for bug-gnu-emacs@gnu.org; Fri, 07 Mar 2014 10:18:23 -0500 Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::5]:23142) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLwXQ-0005V7-Jc for bug-gnu-emacs@gnu.org; Fri, 07 Mar 2014 10:18:17 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1394205493; l=407; s=domk; d=streitblatt.de; h=Content-Transfer-Encoding:Content-Type:Subject:To:MIME-Version:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=jU5aqmfnqkCLSB/nPxwY9lR7Qrs=; b=DTQmxX0w+ZLDYjNiUlcCCpjVPsaQMGdcD5hak+VLFKCBnBz5v3Vpy3pIF3cCsllNvtB p0h6k8yGdA4zuTxyUREBJ8VuU09KLwpH+JhoEPI+xTRH0Ap+J0rC8w5G67NlvWMVXFwFg P/P9DKVxs8feVNPFAFUpSdESj0NuRzqkipk= X-RZG-AUTH: :KmALZ0mpdbGonPxw7gDkop508XQjelhLxGYn4B74/iddlkME3ssvHN/NWXydtg+1ZjaAx5x+ X-RZG-CLASS-ID: mo00 Received: from [77.24.0.191] (ip-77-24-0-191.web.vodafone.de [77.24.0.191]) by smtp.strato.de (RZmta 32.27 DYNA|AUTH) with ESMTPSA id j0479eq27F0B2Tq (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) for ; Fri, 7 Mar 2014 16:00:11 +0100 (CET) Message-ID: <5319DEF8.3050809@miszellen.de> Date: Fri, 07 Mar 2014 16:00:08 +0100 From: Florian Beck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) The docstring of defadvice says See Info node `(elisp)Advising Functions' for comprehensive documentation. This is no longer true. Also, while the old advice mechanism seems to have been be obsoleted, the help doesn't say so. BTW, the nadvice info could use some more examples and a note on how to transition from defadvice. Kind of obvious, I know, but only in hindsight. -- Florian Beck From unknown Sun Jun 15 08:53:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16959: 24.3.50; defadvice docstring out of date Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Mar 2014 18:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16959 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Florian Beck Cc: 16959@debbugs.gnu.org Received: via spool by 16959-submit@debbugs.gnu.org id=B16959.139447537922240 (code B ref 16959); Mon, 10 Mar 2014 18:17:01 +0000 Received: (at 16959) by debbugs.gnu.org; 10 Mar 2014 18:16:19 +0000 Received: from localhost ([127.0.0.1]:60543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WN4kM-0005me-Gy for submit@debbugs.gnu.org; Mon, 10 Mar 2014 14:16:18 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:36315) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WN4kK-0005mU-AS for 16959@debbugs.gnu.org; Mon, 10 Mar 2014 14:16:16 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WN4kJ-0007gX-5F; Mon, 10 Mar 2014 14:16:15 -0400 From: Glenn Morris References: <5319DEF8.3050809@miszellen.de> X-Spook: warfare AMW Hugo Chavez South Africa Ermes AMEMB KGB CBNRC X-Ran: jHxY-Ox!!1C1YO}[):,rVwp.A@3FL(c4gnA,&H|gt$Yu>P`n2=AJL>Ih.G6l;V!E%d+k#" X-Hue: green X-Attribution: GM Date: Mon, 10 Mar 2014 14:16:14 -0400 In-Reply-To: <5319DEF8.3050809@miszellen.de> (Florian Beck's message of "Fri, 07 Mar 2014 16:00:08 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Florian Beck wrote: > The docstring of defadvice says > > See Info node `(elisp)Advising Functions' for comprehensive documentation. > > This is no longer true. OK; removed. > Also, while the old advice mechanism seems to have been be obsoleted, > the help doesn't say so. Why do you think it is obsolete? > BTW, the nadvice info could use some more examples and a note on how > to transition from defadvice. I'll leave this report open till someone does that. From unknown Sun Jun 15 08:53:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16959: 24.3.50; defadvice docstring out of date Resent-From: Florian Beck Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Mar 2014 05:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16959 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 16959@debbugs.gnu.org Received: via spool by 16959-submit@debbugs.gnu.org id=B16959.13945162487253 (code B ref 16959); Tue, 11 Mar 2014 05:38:02 +0000 Received: (at 16959) by debbugs.gnu.org; 11 Mar 2014 05:37:28 +0000 Received: from localhost ([127.0.0.1]:60774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNFNX-0001st-Ji for submit@debbugs.gnu.org; Tue, 11 Mar 2014 01:37:28 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.163]:45689) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNFNT-0001sj-SZ for 16959@debbugs.gnu.org; Tue, 11 Mar 2014 01:37:25 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1394516242; l=2146; s=domk; d=streitblatt.de; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References: Subject:CC:To:MIME-Version:From:Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=Lp8WccPigA/xskgzrFlv1JnukqM=; b=eJgg3yeJ16kV1vTsPfU9nEbFgBj6mbKgNWfV8xJLuD67F4+IwmxZ0Y2oVB25cYtvB6g /w/2J5/2TpjMZK+YC+LigMSWmkjfI8fZQocQLeKMLTEI0ODif/lmuP/zAFYiWruDqjxQ8 8LBhb9R/Tnio0f8cytkWVQbd0g7S8Py/MVU= X-RZG-AUTH: :KmALZ0mpdbGonPxw7gDkop508XQjelhLxGYn4B74/iddlkME3ssvHN/NWXydtg+1ZC2E0JwaLg== X-RZG-CLASS-ID: mo00 Received: from [77.24.255.19] (ip-77-24-255-19.web.vodafone.de [77.24.255.19]) by smtp.strato.de (RZmta 32.27 DYNA|AUTH) with ESMTPSA id j01fb8q2B5bLaJC (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate); Tue, 11 Mar 2014 06:37:21 +0100 (CET) Message-ID: <531EA10D.20507@miszellen.de> Date: Tue, 11 Mar 2014 06:37:17 +0100 From: Florian Beck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 References: <5319DEF8.3050809@miszellen.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 10.03.2014 19:16, Glenn Morris wrote: > Why do you think it is obsolete? Because every hint of its existence has been expunged from the documentation and the new advice seems to offer the same functionality. >> BTW, the nadvice info could use some more examples and a note on how >> to transition from defadvice. > > I'll leave this report open till someone does that. Some specifics: - See the documentation of the old advice: it starts with "altering the behavior of an existing function" (yeah! that's what I'm here for), then gives a simple example, a use case ("Suppose you wanted ..."). - In contrast, the beginning of the new "Advising Functions" is a bit confusing: appropriate setter function? set-process-filter? What are "such hooks"? - The difference between add-function and advice-add is not entirely clear to me: the latter is for the "function cell of a symbol", a "named function and macros", "macros and autoloaded functions". Which is it? I can write (add-function :after (symbol-function 'somefun) 'someadvice) but should I? I have the feeling I should stick with advice-add unless dealing with process filters. - Indeed, it seems the documentation is in the wrong order: from a user's perspective, advice-add is what she usually wants and add-function is a special case. - The docstring of advice-add is useless: it should give me the info I need when writing an advice, which is in add-function. IMO is should be the other way around: the fact that you need advice-add for macros, etc should be mentioned in the docstring of add-function. - The page title "Advising Primitives" is misleading in the context of "Advising Functions" and "Advising Named Functions". - Interactive functions are only discussed in the docstring of add-function. - Add some examples that show how arguments work for someone who is not familiar with &rest and apply. - How about reimplementing the two examples from the old docu ("A Simple Advice Example" and "Around Advice")? That would also demonstrate how to transition to the new mechanism. -- Florian Beck From unknown Sun Jun 15 08:53:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16959: 24.3.50; defadvice docstring out of date Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Mar 2014 13:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16959 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Florian Beck Cc: Glenn Morris , 16959@debbugs.gnu.org Received: via spool by 16959-submit@debbugs.gnu.org id=B16959.139463219828863 (code B ref 16959); Wed, 12 Mar 2014 13:50:01 +0000 Received: (at 16959) by debbugs.gnu.org; 12 Mar 2014 13:49:58 +0000 Received: from localhost ([127.0.0.1]:33983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNjXi-0007VT-Gz for submit@debbugs.gnu.org; Wed, 12 Mar 2014 09:49:58 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:21417) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNjXg-0007VL-Gk for 16959@debbugs.gnu.org; Wed, 12 Mar 2014 09:49:56 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFMCppy/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOSWpIggV6DEw X-IPAS-Result: Av8EABK/CFFMCppy/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOSWpIggV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="51454182" Received: from 76-10-154-114.dsl.teksavvy.com (HELO pastel.home) ([76.10.154.114]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 12 Mar 2014 09:49:55 -0400 Received: by pastel.home (Postfix, from userid 20848) id A26B96057F; Wed, 12 Mar 2014 09:49:50 -0400 (EDT) From: Stefan Monnier Message-ID: References: <5319DEF8.3050809@miszellen.de> <531EA10D.20507@miszellen.de> Date: Wed, 12 Mar 2014 09:49:50 -0400 In-Reply-To: <531EA10D.20507@miszellen.de> (Florian Beck's message of "Tue, 11 Mar 2014 06:37:17 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Some specifics: Thanks Florian, this list is very helpful. Just one comment: > - Indeed, it seems the documentation is in the wrong order: from a user's > perspective, advice-add is what she usually wants and add-function > is a special case. Actually, add-function is likely to become more common with new hooks using a `*-function' variable modified via add-function rather than a `*-functions' modified via add-hook. Stefan From unknown Sun Jun 15 08:53:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16959: 24.3.50; defadvice docstring out of date Resent-From: Josh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Mar 2014 16:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16959 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Florian Beck , 16959@debbugs.gnu.org Received: via spool by 16959-submit@debbugs.gnu.org id=B16959.139464184515901 (code B ref 16959); Wed, 12 Mar 2014 16:31:01 +0000 Received: (at 16959) by debbugs.gnu.org; 12 Mar 2014 16:30:45 +0000 Received: from localhost ([127.0.0.1]:34840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNm3H-00048I-EP for submit@debbugs.gnu.org; Wed, 12 Mar 2014 12:30:44 -0400 Received: from mail-yk0-f175.google.com ([209.85.160.175]:53474) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNm3D-000487-0E for 16959@debbugs.gnu.org; Wed, 12 Mar 2014 12:30:40 -0400 Received: by mail-yk0-f175.google.com with SMTP id 131so27714642ykp.6 for <16959@debbugs.gnu.org>; Wed, 12 Mar 2014 09:30:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=jmn4xgVfpgVxsmkFi72V5hQ3FI/BwFwkgaS0LVhwcvs=; b=A8DzEPRRzKX+HYPYiCT0QJx7qYoWIhv3a9WPn+e12WRkV8uWsSa5KFeTdmSU9JiVco ugzkZGVug1HmBcYA6QX/DgGAtNnl2CH+LpMqckZ4RHcea45eXNUMZv0iAoE5gR250WmP 3cM8H96Y/4J8VHHVqenjrzwuMnhFH5ne2XM9CvkMTGBuSAk5OoUdT1HybRg1yInHiTcn UatMJvnqwnTOBXJtP0bFizaBkUUq+zz+SAvNwD5lGiFyjWxf+OlXzAUfYvtiXIatT4A1 G9VqqnoG7yzhnICFEU/r6FTC9oDc8JWhS3Q1NFvlf8GNHkw8onAUJcJt3qOA1GP44Bkz w3TA== X-Gm-Message-State: ALoCoQmdZkKQf3DyV06R3JqVkYBX5hgVuul491eaeJ8BwuJgz7GKlsPcZGLqY7LPabgc0ukfc/Fl X-Received: by 10.236.182.229 with SMTP id o65mr31681215yhm.86.1394641838483; Wed, 12 Mar 2014 09:30:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.170.156.136 with HTTP; Wed, 12 Mar 2014 09:30:08 -0700 (PDT) In-Reply-To: References: <5319DEF8.3050809@miszellen.de> <531EA10D.20507@miszellen.de> From: Josh Date: Wed, 12 Mar 2014 09:30:08 -0700 X-Google-Sender-Auth: DhqjqOguaTLNFc-h6RfAwBWPld8 Message-ID: Content-Type: multipart/alternative; boundary=20cf30563ed35f41cc04f46b5bed X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --20cf30563ed35f41cc04f46b5bed Content-Type: text/plain; charset=ISO-8859-1 On Wed, Mar 12, 2014 at 6:49 AM, Stefan Monnier wrote: > > Some specifics: > > Thanks Florian, this list is very helpful. Just one comment: > > > - Indeed, it seems the documentation is in the wrong order: from a > user's > > perspective, advice-add is what she usually wants and add-function > > is a special case. > > Actually, add-function is likely to become more common with new hooks > using a `*-function' variable modified via add-function rather than > a `*-functions' modified via add-hook. Somewhat relatedly, would you consider renaming advice-add to add-advice (naturally with an alias for backward compatibility)? It's easier to discover related functionality through tab completion, apropos, etc. when its names share a common structure. For example if I was looking for basename functionality and I knew about file-name-directory, `C-h f file-name- TAB' would lead me to `file-name-nondirectory' straightaway. --20cf30563ed35f41cc04f46b5bed Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On Wed, Mar 12, 2014 at 6:4= 9 AM, Stefan Monnier <monnier@iro.umontreal.ca> wrote= :
> Some specifics:

Thanks Florian, this list is very helpful. =A0Just one comment:

> =A0- Indeed, it seems the documentation is in the wrong order: from a = user's
> perspective, advice-add is what she usually wants and add-function
> is a special case.

Actually, add-function is likely to become more common with new hooks=
using a `*-function' variable modified via add-function rather than
a `*-functions' modified via add-hook.

= Somewhat relatedly, would you consider renaming advice-add to
add-advice= (naturally with an alias for backward compatibility)?
It's easier t= o discover related functionality through tab
completion, apropos, etc. when its names share a common structure.
For e= xample if I was looking for basename functionality and I knew
about file= -name-directory, `C-h f file-name- TAB' would lead me to
`file-name-= nondirectory' straightaway.

--20cf30563ed35f41cc04f46b5bed-- From unknown Sun Jun 15 08:53:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16959: 24.3.50; defadvice docstring out of date Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Mar 2014 18:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16959 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Josh Cc: Florian Beck , 16959@debbugs.gnu.org Received: via spool by 16959-submit@debbugs.gnu.org id=B16959.139464971732374 (code B ref 16959); Wed, 12 Mar 2014 18:42:01 +0000 Received: (at 16959) by debbugs.gnu.org; 12 Mar 2014 18:41:57 +0000 Received: from localhost ([127.0.0.1]:34918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNo6G-0008Q6-NG for submit@debbugs.gnu.org; Wed, 12 Mar 2014 14:41:57 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:62916) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNo6D-0008Pw-Cx for 16959@debbugs.gnu.org; Wed, 12 Mar 2014 14:41:53 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFMCppy/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IPAS-Result: Av8EABK/CFFMCppy/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="51492503" Received: from 76-10-154-114.dsl.teksavvy.com (HELO pastel.home) ([76.10.154.114]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 12 Mar 2014 14:41:52 -0400 Received: by pastel.home (Postfix, from userid 20848) id 4140760110; Wed, 12 Mar 2014 14:41:52 -0400 (EDT) From: Stefan Monnier Message-ID: References: <5319DEF8.3050809@miszellen.de> <531EA10D.20507@miszellen.de> Date: Wed, 12 Mar 2014 14:41:52 -0400 In-Reply-To: (josh@foxtail.org's message of "Wed, 12 Mar 2014 09:30:08 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Somewhat relatedly, would you consider renaming advice-add to > add-advice (naturally with an alias for backward compatibility)? No, that's not an option. I could consider getting rid of the add-function and remove-function exceptions (i.e. renaming them to something that starts with "advice-" like everything else in nadvice.el), but then their "natural" name would probably be advice-function-add and advice-function-remove, neither of which please me very much. Especially given the intention to see `add-function' as a brother to `add-hook'. Stefan From unknown Sun Jun 15 08:53:48 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Florian Beck Subject: bug#16959: closed (Re: bug#16981: 24.3.50; electric-pair-delete-adjacent-pairs broken in c-mode, python-mode, maybe-others) Message-ID: References: <5319DEF8.3050809@miszellen.de> X-Gnu-PR-Message: they-closed 16959 X-Gnu-PR-Package: emacs Reply-To: 16959@debbugs.gnu.org Date: Tue, 18 Mar 2014 01:57:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1395107823-16015-1" This is a multi-part message in MIME format... ------------=_1395107823-16015-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #16959: 24.3.50; defadvice docstring out of date which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 16959@debbugs.gnu.org. --=20 16959: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D16959 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1395107823-16015-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 16959-done) by debbugs.gnu.org; 18 Mar 2014 01:56:28 +0000 Received: from localhost ([127.0.0.1]:39378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WPjGW-00049R-FX for submit@debbugs.gnu.org; Mon, 17 Mar 2014 21:56:28 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:56817) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WPjGU-00049J-8o for 16959-done@debbugs.gnu.org; Mon, 17 Mar 2014 21:56:26 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFHO+KKg/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCw4mBwsUGA0kiB4GwS2NGYNxA44YlmKBXoMTgUo X-IPAS-Result: Av8EABK/CFHO+KKg/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCw4mBwsUGA0kiB4GwS2NGYNxA44YlmKBXoMTgUo X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="52421903" Received: from 206-248-162-160.dsl.teksavvy.com (HELO pastel.home) ([206.248.162.160]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 17 Mar 2014 21:56:25 -0400 Received: by pastel.home (Postfix, from userid 20848) id 142D96028B; Mon, 17 Mar 2014 21:56:25 -0400 (EDT) From: Stefan To: Florian Beck Subject: Re: bug#16981: 24.3.50; electric-pair-delete-adjacent-pairs broken in c-mode, python-mode, maybe-others Message-ID: References: Date: Mon, 17 Mar 2014 21:56:25 -0400 In-Reply-To: (Alan Mackenzie's message of "Thu, 13 Mar 2014 22:04:33 +0000 (UTC)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 16959-done Cc: 16959-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> Why do you think it is obsolete? > Because every hint of its existence has been expunged from the documentation > and the new advice seems to offer the same functionality. Indeed, it's technically obsolete, but it's not declared officially obsolete yet. It will come, tho. But it'll be with us for many years to come. OTOH its support is limited to keeping things working. >>> BTW, the nadvice info could use some more examples and a note on how >>> to transition from defadvice. >> I'll leave this report open till someone does that. > Some specifics: I've installed some changes to try and address them. Stefan ------------=_1395107823-16015-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 Mar 2014 15:18:42 +0000 Received: from localhost ([127.0.0.1]:55020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WLwXp-0001Eb-8M for submit@debbugs.gnu.org; Fri, 07 Mar 2014 10:18:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46206) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WLwXm-0001ES-LV for submit@debbugs.gnu.org; Fri, 07 Mar 2014 10:18:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLwXg-0005eK-E6 for submit@debbugs.gnu.org; Fri, 07 Mar 2014 10:18:38 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50065) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLwXg-0005eG-BX for submit@debbugs.gnu.org; Fri, 07 Mar 2014 10:18:32 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47680) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLwXX-0007cf-AK for bug-gnu-emacs@gnu.org; Fri, 07 Mar 2014 10:18:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLwXR-0005WU-5Q for bug-gnu-emacs@gnu.org; Fri, 07 Mar 2014 10:18:23 -0500 Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::5]:23142) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLwXQ-0005V7-Jc for bug-gnu-emacs@gnu.org; Fri, 07 Mar 2014 10:18:17 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1394205493; l=407; s=domk; d=streitblatt.de; h=Content-Transfer-Encoding:Content-Type:Subject:To:MIME-Version:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=jU5aqmfnqkCLSB/nPxwY9lR7Qrs=; b=DTQmxX0w+ZLDYjNiUlcCCpjVPsaQMGdcD5hak+VLFKCBnBz5v3Vpy3pIF3cCsllNvtB p0h6k8yGdA4zuTxyUREBJ8VuU09KLwpH+JhoEPI+xTRH0Ap+J0rC8w5G67NlvWMVXFwFg P/P9DKVxs8feVNPFAFUpSdESj0NuRzqkipk= X-RZG-AUTH: :KmALZ0mpdbGonPxw7gDkop508XQjelhLxGYn4B74/iddlkME3ssvHN/NWXydtg+1ZjaAx5x+ X-RZG-CLASS-ID: mo00 Received: from [77.24.0.191] (ip-77-24-0-191.web.vodafone.de [77.24.0.191]) by smtp.strato.de (RZmta 32.27 DYNA|AUTH) with ESMTPSA id j0479eq27F0B2Tq (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) for ; Fri, 7 Mar 2014 16:00:11 +0100 (CET) Message-ID: <5319DEF8.3050809@miszellen.de> Date: Fri, 07 Mar 2014 16:00:08 +0100 From: Florian Beck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: 24.3.50; defadvice docstring out of date Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) The docstring of defadvice says See Info node `(elisp)Advising Functions' for comprehensive documentation. This is no longer true. Also, while the old advice mechanism seems to have been be obsoleted, the help doesn't say so. BTW, the nadvice info could use some more examples and a note on how to transition from defadvice. Kind of obvious, I know, but only in hindsight. -- Florian Beck ------------=_1395107823-16015-1-- From unknown Sun Jun 15 08:53:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16959: bug#16981: 24.3.50; electric-pair-delete-adjacent-pairs broken in c-mode, python-mode, maybe-others Resent-From: Florian Beck Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Mar 2014 00:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16959 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 16959@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 16959-submit@debbugs.gnu.org id=B16959.139527559323880 (code B ref 16959); Thu, 20 Mar 2014 00:34:01 +0000 Received: (at 16959) by debbugs.gnu.org; 20 Mar 2014 00:33:13 +0000 Received: from localhost ([127.0.0.1]:41659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQQv2-0006D5-10 for submit@debbugs.gnu.org; Wed, 19 Mar 2014 20:33:12 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.163]:54468) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQQuy-0006Cs-30 for 16959@debbugs.gnu.org; Wed, 19 Mar 2014 20:33:09 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1395275586; l=1435; s=domk; d=streitblatt.de; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References: Subject:To:MIME-Version:From:Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=5Nt41BdJOjXsVCeslOO+IAXmazU=; b=Rdk5nSX2xv3v78vtRtCEhSwnCanJ4xGiWi5jH3bEjUisZrru31bnR8N8PIgE0Pre7r/ T5PtpaizWKCYh3AlkA4HXSegsxMykG2G1FeiOaI0CCyJij7oYF/Nu5K1haw2iMdrPEXyd kStwmB6/kKm8v2IAVlheDlnYidA4t/U3Qow= X-RZG-AUTH: :KmALZ0mpdbGonPxw7gDkop508XQjelhLxGYn4B74/iddlkME3ssvHN/NX3uKqg+oBr7QKL7Wha8O X-RZG-CLASS-ID: mo00 Received: from [109.43.245.179] (ip-109-43-245-179.web.vodafone.de [109.43.245.179]) by smtp.strato.de (RZmta 32.29 DYNA|AUTH) with ESMTPSA id U057f5q2K0X3IaC (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate); Thu, 20 Mar 2014 01:33:03 +0100 (CET) Message-ID: <532A373C.2050502@miszellen.de> Date: Thu, 20 Mar 2014 01:33:00 +0100 From: Florian Beck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > I've installed some changes to try and address them. Very nice. Some comments: Advising Emacs Lisp Functions: - The third paragraph could link to "What Is a Function?" - also link "in order to trace the calls to the process filter of a process" to "Filter Functions" - in the last paragraph ":above" should be ":around"; the formatting "_advice_" is strange - mention that in the first example the advising function takes the same arguments as the original, and in the second the original function as an additional argument (this is the most important info, IMO) Core Advising Primitives: - Should the WHERE specifications have their own node or section? In any case, I would move the second example (his-tracing-function) to the end of the list and explain it a little bit. Like "In this case a call to `display-buffer' works like calling (lambda (BUFFER-OR-NAME &optional ACTION FRAME) (apply 'his-tracing-fun 'display-buffer BUFFER-OR-NAME ACTION FRAME)) That is, instead of `display-buffer', the new function `his tracing-fun' is called with display-buffer as its first argument." - depth: clarify what happens when you have several pieces of ":override" or ":around" advice that doesn't call the original function at the depth 0. Advising named functions: - "Macros can also be advised": this doesn't work when the macro is used in a compiled function. -- Florian Beck From unknown Sun Jun 15 08:53:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16959: bug#16981: 24.3.50; electric-pair-delete-adjacent-pairs broken in c-mode, python-mode, maybe-others Resent-From: Stefan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Mar 2014 21:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16959 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Florian Beck Cc: 16959@debbugs.gnu.org Received: via spool by 16959-submit@debbugs.gnu.org id=B16959.13954384807898 (code B ref 16959); Fri, 21 Mar 2014 21:48:01 +0000 Received: (at 16959) by debbugs.gnu.org; 21 Mar 2014 21:48:00 +0000 Received: from localhost ([127.0.0.1]:43965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WR7IG-00023J-1P for submit@debbugs.gnu.org; Fri, 21 Mar 2014 17:48:00 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:40845) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WR7ID-000239-3h for 16959@debbugs.gnu.org; Fri, 21 Mar 2014 17:47:58 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFHO+KKg/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJgcLFBgNJIgeBsEtkQoDjhiEQpIggV6DEw X-IPAS-Result: Av8EABK/CFHO+KKg/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJgcLFBgNJIgeBsEtkQoDjhiEQpIggV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="52912337" Received: from 206-248-162-160.dsl.teksavvy.com (HELO pastel.home) ([206.248.162.160]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 21 Mar 2014 17:47:55 -0400 Received: by pastel.home (Postfix, from userid 20848) id 99374600C3; Fri, 21 Mar 2014 17:47:55 -0400 (EDT) From: Stefan Message-ID: References: <532A373C.2050502@miszellen.de> Date: Fri, 21 Mar 2014 17:47:55 -0400 In-Reply-To: <532A373C.2050502@miszellen.de> (Florian Beck's message of "Thu, 20 Mar 2014 01:33:00 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > - also link "in order to trace the calls to the process filter of a > process" to "Filter Functions" I find Texinfo links to be a bit heavy, so I prefer not to put too many of them, so the reader can concentrate on the subject. Process filters are not really relevant. > - in the last paragraph ":above" should be ":around"; Fixed. > the formatting "_advice_" is strange That's how Texinfo renders @emph in Info. > Core Advising Primitives: > - Should the WHERE specifications have their own node or section? Sizewise, I fully agree, so I moved it to its own node/section. I'm not completely happy with the result, but I think it's better. > In any case, I would move the second example (his-tracing-function) to > the end of the list and explain it a little bit. I'd rather keep the advice-add in the first node alongside the add-function example, since as you say in many cases advice-add is what the reader is really after. > - depth: clarify what happens when you have several pieces of ":override" > or ":around" advice that doesn't call the original function at the depth 0. I tried to clarify the notion of depth by spelling out what it means for :after, :before and :override. > Advising named functions: > - "Macros can also be advised": this doesn't work when the macro is used > in a compiled function. Of course it works. The restriction is that the macro needs to be advised before it is expanded. I spelled it out now. Stefan From unknown Sun Jun 15 08:53:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16959: bug#16981: 24.3.50; electric-pair-delete-adjacent-pairs broken in c-mode, python-mode, maybe-others Resent-From: Florian Beck Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Mar 2014 17:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16959 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Cc: 16959@debbugs.gnu.org Received: via spool by 16959-submit@debbugs.gnu.org id=B16959.139576912330788 (code B ref 16959); Tue, 25 Mar 2014 17:39:02 +0000 Received: (at 16959) by debbugs.gnu.org; 25 Mar 2014 17:38:43 +0000 Received: from localhost ([127.0.0.1]:49563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSVJD-00080V-FC for submit@debbugs.gnu.org; Tue, 25 Mar 2014 13:38:43 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.161]:50679) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSVJA-00080J-9w for 16959@debbugs.gnu.org; Tue, 25 Mar 2014 13:38:41 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1395769118; l=1148; s=domk; d=streitblatt.de; h=Content-Type:MIME-Version:In-Reply-To:Date:References:Subject:Cc:To: From:X-RZG-CLASS-ID:X-RZG-AUTH; bh=7BxViKrDNaab1PUuKBnMENqlkQw=; b=G7fo03UT1TJk/tKpdsVzc8XefxoHuCpSPA0lgaV6FALl3t2c2IHk39y1FhkusBILV6K AY9u8ucBL7RKKWeQgeT38iPqQavLDyfqrB0J60EMvMKRusZ6s6l73ay/nLPakt8W1qXWJ +/RddpmvlXG27LZ3gTfWBr0aDTVkrKbLl6A= X-RZG-AUTH: :KmALZ0mpdbGonPxw7gDkop508XQjelhLxGYn4B74/iddlkME3ssvHN/NWXydtg+1YCmfzJ0VLg== X-RZG-CLASS-ID: mo00 Received: from sophokles (ip-77-24-61-206.web.vodafone.de [77.24.61.206]) by smtp.strato.de (RZmta 32.31 DYNA|AUTH) with ESMTPSA id k056c4q2PHcY498 (using TLSv1.2 with cipher DHE-RSA-AES256-SHA256 (256/256 bits)) (Client did not present a certificate); Tue, 25 Mar 2014 18:38:34 +0100 (CET) From: Florian Beck References: <532A373C.2050502@miszellen.de> Date: Tue, 25 Mar 2014 18:38:30 +0100 In-Reply-To: (Stefan's message of "Fri, 21 Mar 2014 17:47:55 -0400") Message-ID: <87siq62n6x.fsf@sophokles.streitblatt.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Looks very nice now. Thank you. >> - depth: clarify what happens when you have several pieces of ":override" >> or ":around" advice that doesn't call the original function at the depth 0. > > I tried to clarify the notion of depth by spelling out what it means > for :after, :before and :override. The depth metaphor actually works pretty well. The use case I had in mind was this: (1) Someone defines a :override advice. (2) There already is an :override advice. (3) Neither advice specifies depth, so it defaults to 0. The result is that the advice SEEMS to work (the user put it in her .emacs and presses C-x C-e), but on restarting emacs it depends on the order advice defintions. > >> Advising named functions: >> - "Macros can also be advised": this doesn't work when the macro is used >> in a compiled function. > > Of course it works. The restriction is that the macro needs to be > advised before it is expanded. I spelled it out now. Of course, from a user's point of view, macros usually are already expanded. How would a user go about advising, say, byte-compile-log in her .emacs? -- Florian Beck From unknown Sun Jun 15 08:53:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16959: bug#16981: 24.3.50; electric-pair-delete-adjacent-pairs broken in c-mode, python-mode, maybe-others Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Mar 2014 00:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16959 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Florian Beck Cc: 16959@debbugs.gnu.org Received: via spool by 16959-submit@debbugs.gnu.org id=B16959.139579408217977 (code B ref 16959); Wed, 26 Mar 2014 00:35:02 +0000 Received: (at 16959) by debbugs.gnu.org; 26 Mar 2014 00:34:42 +0000 Received: from localhost ([127.0.0.1]:49822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSbnm-0004fs-2h for submit@debbugs.gnu.org; Tue, 25 Mar 2014 20:34:42 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:39331) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSbnj-0004fi-MR for 16959@debbugs.gnu.org; Tue, 25 Mar 2014 20:34:40 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s2Q0YbdW027801; Tue, 25 Mar 2014 20:34:37 -0400 Received: by pastel.home (Postfix, from userid 20848) id E65D56013D; Tue, 25 Mar 2014 20:34:36 -0400 (EDT) From: Stefan Monnier Message-ID: References: <532A373C.2050502@miszellen.de> <87siq62n6x.fsf@sophokles.streitblatt.de> Date: Tue, 25 Mar 2014 20:34:36 -0400 In-Reply-To: <87siq62n6x.fsf@sophokles.streitblatt.de> (Florian Beck's message of "Tue, 25 Mar 2014 18:38:30 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4892=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4892> : inlines <646> : streams <1144646> : uri <1709955> X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > The result is that the advice SEEMS to work (the user put it in her > .emacs and presses C-x C-e), but on restarting emacs it depends on the > order advice defintions. That's why the doc says: [..] should stay as the outermost advice. When two advices specify the same depth, the most recently added advice will be outermost. [..] > Of course, from a user's point of view, macros usually are already expanded. > How would a user go about advising, say, byte-compile-log in her .emacs? She can't do it and hope for it to affect already compiled code, indeed. But we use advice-add in cl.el on the `declare', `dolist', and `dotimes' macros and it works very well. Obviously code that uses those needs to have a (require 'cl) somewhere to make sure the advice is installed before macro-expansion. Stefan