GNU bug report logs - #16943
24.3.50; [PATCH] `icomplete-exhibit' needs `with-current-buffer' for minibuffer

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Wed, 5 Mar 2014 18:51:02 UTC

Severity: normal

Tags: moreinfo

Found in version 24.3.50

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 16943 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 16943 <at> debbugs.gnu.org
Subject: Re: bug#16943: 24.3.50;
 [PATCH] `icomplete-exhibit' needs `with-current-buffer' for minibuffer
Date: Fri, 07 Mar 2014 19:17:32 -0500

>  (with-current-buffer (window-buffer (active-minibuffer-window))

I think this would only paper over an underlying problem: icomplete uses
a buffer-local post-command-hook, so it makes no sense that it would be
run in another buffer.
A few possibilities:
- the hook is placed in the wrong buffer, in which case it would only be
  run in the wrong buffer.
- an earlier post-command-hook function changed current-buffer.
- an earlier minibuffer-setup-hook function changed current-buffer
  (which would cause the hook to be placed in the wrong buffer).


        Stefan
This bug report was last modified 9 years and 84 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.