GNU bug report logs - #16941
[PATCH] tests/mb-non-UTF8-performance: increase timeout

Previous Next

Package: grep;

Reported by: Andreas Schwab <schwab <at> suse.de>

Date: Wed, 5 Mar 2014 16:10:02 UTC

Severity: normal

Tags: patch

Done: Jim Meyering <jim <at> meyering.net>

Bug is archived. No further changes may be made.

Full log


Message #14 received at 16941 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Andreas Schwab <schwab <at> suse.de>
Cc: 16941 <at> debbugs.gnu.org
Subject: Re: bug#16941: [PATCH] tests/mb-non-UTF8-performance: increase timeout
Date: Sun, 9 Mar 2014 22:12:01 -0700
[Message part 1 (text/plain, inline)]
On Thu, Mar 6, 2014 at 12:15 AM, Andreas Schwab <schwab <at> suse.de> wrote:
> Jim Meyering <jim <at> meyering.net> writes:
>
>> On Wed, Mar 5, 2014 at 8:09 AM, Andreas Schwab <schwab <at> suse.de> wrote:
>>> ---
>>>  tests/mb-non-UTF8-performance | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tests/mb-non-UTF8-performance b/tests/mb-non-UTF8-performance
>>> index 282f0c4..9b581a3 100755
>>> --- a/tests/mb-non-UTF8-performance
>>> +++ b/tests/mb-non-UTF8-performance
>>> @@ -26,7 +26,7 @@ require_JP_EUC_locale_
>>>  yes $(printf '%078d' 0) | head -50000 > in || framework_failure_
>>>
>>>  # Expect no match, i.e., exit status of 1.  Anything else is an error.
>>> -timeout 4 grep -i foobar in; st=$?
>>> +timeout 50 grep -i foobar in; st=$?
>>>  test $st = 1 || fail=1
>>
>> Thanks.  For what environment is that useful?
>
> For m68k-suse-linux.

Thanks again for the patch, but if I were to use it, the timeout
would be so long that the test would mistakenly pass
(the timeout would not trigger) even if the bug were reintroduced.
Instead, I've rewritten the test to make it less sensitive to the
actual hardware used to run it.  Please let me know if this works
for you:
[k.txt (text/plain, attachment)]

This bug report was last modified 11 years and 60 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.