GNU bug report logs - #16940
[PATCH] tests: Do not access /dev/tty if it does not exist

Previous Next

Package: coreutils;

Reported by: Cyril Roelandt <tipecaml <at> gmail.com>

Date: Wed, 5 Mar 2014 03:42:01 UTC

Severity: normal

Tags: fixed, patch

Done: Assaf Gordon <assafgordon <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: Pádraig Brady <P <at> draigBrady.com>
Cc: 16940 <at> debbugs.gnu.org
Subject: bug#16940: [PATCH] tests: Do not access /dev/tty if it does not exist
Date: Wed, 05 Mar 2014 23:02:04 +0100

On 03/05/2014 08:05 PM, Pádraig Brady wrote:
> On 03/05/2014 04:46 PM, Pádraig Brady wrote:
>> Note the ':>' is problematic though as the : always returns true.
>> Well it does for solaris, freebsd, dash, bash-4.3 at least.
>> In ksh and bash<=4.2 it does return an error as you assumed.
>> The ':>' construct is only needed for csh anyway I think
>> which we don't support.
>>
>> I notice a few more cases: git grep ": *>.*"
>> which I'll fix in a follow up patch with maybe a syntax check.
> 
> Attached.

Great, looks good.

Thanks & have a nice day,
Berny
This bug report was last modified 6 years and 227 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.