GNU bug report logs - #16929
[PATCH] ui: switch to new-style readline typedef

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16929 in the body.
You can then email your comments to 16929 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gustavo Zacarias <gustavo <at> zacarias.com.ar>
To: bug-parted <at> gnu.org
Cc: Gustavo Zacarias <gustavo <at> zacarias.com.ar>
Subject: [PATCH] ui: switch to new-style readline typedef
Date: Mon,  3 Mar 2014 10:40:08 -0300

The CPPFunction typedef (among others) have been deprecated in favour of
specific prototyped typedefs since readline 4.2 (circa 2001).
It's been working since because compatibility typedefs have been in
place until they where removed in the recent readline 6.3 release.
Switch to the new style to avoid build breakage.

Signed-off-by: Gustavo Zacarias <gustavo <at> zacarias.com.ar>
---
 parted/ui.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/parted/ui.c b/parted/ui.c
index 786deed..b33f6fc 100644
--- a/parted/ui.c
+++ b/parted/ui.c
@@ -1470,7 +1470,7 @@ init_readline (void)
 #ifdef HAVE_LIBREADLINE
   if (!opt_script_mode) {
     rl_initialize ();
-    rl_attempted_completion_function = (CPPFunction*) complete_function;
+    rl_attempted_completion_function = (rl_completion_func_t *) complete_function;
     readline_state.in_readline = 0;
   }
 #endif
-- 
1.8.3.2

Message #10 received at 16929-done <at> debbugs.gnu.org (full text, mbox):

From: Phillip Susi <psusi <at> ubuntu.com>
To: Gustavo Zacarias <gustavo <at> zacarias.com.ar>, 
 16929-done <at> debbugs.gnu.org
Subject: Re: bug#16929: [PATCH] ui: switch to new-style readline typedef
Date: Wed, 05 Mar 2014 20:47:00 -0500

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 03/03/2014 08:40 AM, Gustavo Zacarias wrote:
> The CPPFunction typedef (among others) have been deprecated in
> favour of specific prototyped typedefs since readline 4.2 (circa
> 2001). It's been working since because compatibility typedefs have
> been in place until they where removed in the recent readline 6.3
> release. Switch to the new style to avoid build breakage.

Thanks, pushed.



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCgAGBQJTF9OUAAoJEI5FoCIzSKrw4u8IAIfntCZtuME3YS2gNqMZ2m/A
Jan9XFWYKftUAmL8GPH7DKdTt8/KXx1oFA29XifR6Oo1vnI1Zt6/nr+Dwbia0TpN
UdcUwet35i0/EbirnNFF9N55gc23JI9JUfT5M7LyOqRRsikUiJhC5Oj5dHdso978
SwMCja95VcpMdKx0nlESQzIQqjNsnyEuJwNNvVLaNWecOnMFTqnL7cpmlhHNnPi5
zXj3Qyi2fJ1VreGYIEquAjMS7623H3sa79WeMkLTiatY3krG5DbuNHK5qTpvP29y
UImWQzCYPCjY9DL35COfA8TQ2TzP+B/UsKEET0FbagiNOwmSvURqs3k6V5gAgbM=
=PMvM
-----END PGP SIGNATURE-----

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.