Subject: Re: bug#16922: df --si -h should emit a warning

From: Pádraig Brady <[email-masked]>
Date: Mon, 03 Mar 2014 16:41:10 +0000

On 03/03/2014 03:19 PM, Mateusz Jończyk wrote:
> W dniu 03.03.2014 04:02, Pádraig Brady pisze:
>> On 03/02/2014 05:38 PM, Bernhard Voelker wrote: Very few read info pages, and
>> anyway in this case we should be clear at the man page level.
> 
>> Mateusz stated the issue was that on a quick glance, the --si option wasn't
>> described well enough in isolation. Likewise, the description of -h requires
>> reading that of -H to know the power used. So hopefully the attached patch fixes
>> this and more.
> 
> This patch fixes only the --help output, not the man page (which should be done
> separately).

The man pages are generated from --help

> Seriously, wouldn't it be better to hardcode 1023M and 1.1G(B) into the code then
> calculate them every time?

Yes we've already switched to hardcoded values
with associated translator notes.

> W dniu 03.03.2014 11:06, Bernhard Voelker pisze:
>> On 03/03/2014 10:35 AM, Pádraig Brady wrote:
>>> So SIZE here refers to the _input_ argument mentioned previously in the
>>> --help. We might make this a bit more clear with BSIZE, but this same note is
>>> refactored for use by df, du, ls, split, truncate. truncate(1) for example
>>> uses it to refer to both a threshold and block size. Perhaps we should clarify
>>> like:
>>>
>>> The SIZE argument is an integer and optional unit (example: 10K is 10*1024).
>>> Units are K,M,G,T,P,E,Z,Y (powers of 1024) or KB,MB, ... (powers of 1000).
> 
>> Good idea. Thanks.
> 
> Maybe:
> "The SIZE argument consists of an integer and an optional unit."

Sometimes these are worded slightly awkwardly to be more
concise and fit available space.

thanks,
Pádraig.